MediaWiki r114047 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r114046‎ | r114047 (on ViewVC)‎ | r114048 >
Date:02:23, 17 March 2012
Author:bsitu
Status:reverted (Comments)
Tags:gerritmigration 
Comment:
fix for bug33214 - catch all exceptions in api execute and provides necessary parameters required by the custom printer
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r114335Revert r107309, r113601, r113704, r113742, r113792, r113838, r113859, r113893......catrope00:16, 21 March 2012

Comments

#Comment by Bawolff (talk | contribs)   02:42, 17 March 2012

To be honest, it kind of seems odd to return an RSS feed in case of an error, since errors can't really be expressed in that format. At the very least if an rss feed is returned in error conditions it should be a non-200 status code imho.

#Comment by Bsitu (talk | contribs)   00:36, 24 March 2012

Thank you for the comment, I agree with what you said, that means the custom printer needs to be altered to some other printers on error since the custom printer requires some additional parameters which exception does not provide, that doesn't seem to be an easy fix to me as the API can be executed in a mode with exception not being caught and there looks quite a lot of dependencies in ApiMain.php, However, there may be an easy fix to this which I don't see so I am open to any feedbacks, :)

#Comment by Hashar (talk | contribs)   12:48, 22 March 2012

Change was copied to Gerrit as https://gerrit.wikimedia.org/r/3328

Follow up there :)

Status & tagging log

  • 00:17, 21 March 2012 Catrope (talk | contribs) changed the status of r114047 [removed: new added: reverted]
  • 21:13, 20 March 2012 Catrope (talk | contribs) changed the tags for r114047 [added: gerritmigration]