MediaWiki r113740 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r113739‎ | r113740 (on ViewVC)‎ | r113741 >
Date:18:15, 13 March 2012
Author:saper
Status:reverted (Comments)
Tags:gerritmigration 
Comment:
(bug 33536) Make a list of print on demand publishers configurable for Extension:Collection

Improve inteface to list print on demand providers including better
fallback for browsers without JavaScript.

Quell PHP warning:

PHP Notice: Undefined index: writer in extensions/Collection/Collection.body.php on line 1214

Bump extension version to 1.6

New global variable:

$wgCollectionPODPartners - Array of parameters needed to define print on
demand providers.

CSS ID converted into a class: collection-order-button classes added:
CSS collection-partner coll-partnerlink collapsed classes moved:
CSS coll-more_info classes removed: coll-hide_info

i18n messages removed: coll-more_info coll-hide_info
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r113785Followup-To: r113740 $wgScriptPath/extensions/ => $wgExtensionAssetsPath...saper23:20, 13 March 2012
r113985Followup r113740...reedy01:07, 16 March 2012
r114399Revert r113740 and its followups r113785, r113985, r113986, r113988, r113991,...catrope19:56, 21 March 2012

Comments

#Comment by Brion VIBBER (talk | contribs)   21:08, 13 March 2012
+var media_path = wgScriptPath + '/extensions/Collection/images/';

use wgExtensionAssetsPath instead here; in a multi-version wiki farm like Wikimedia's we may have different versions of MediaWiki (and thus the extension) in different places.

Status & tagging log

  • 19:59, 21 March 2012 Aaron Schulz (talk | contribs) changed the status of r113740 [removed: new added: reverted]
  • 01:03, 21 March 2012 Catrope (talk | contribs) changed the tags for r113740 [added: gerritmigration]