MediaWiki r112591 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r112590‎ | r112591 (on ViewVC)‎ | r112592 >
Date:12:41, 28 February 2012
Author:siebrand
Status:resolved (Comments)
Tags:i18nreview 
Comment:
(bug 34702) More localised parentheses.
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r112630fix r112591: re-add whitespace between message name and (talk)robin20:14, 28 February 2012
r113121No point doing it the hard way, ping r112591nikerabbit07:20, 6 March 2012

Past revisions this follows-up on

Rev.Commit summaryAuthorDate
r112410(bug 34702) Use localised parentheses in Special:Contributions.siebrand20:42, 25 February 2012
r112412Follow-up r112410: (bug 34702) Use localised parentheses for comment, too.siebrand20:53, 25 February 2012
r112433(bug 34702) Localised parentheses are now used in more special pages.siebrand13:08, 26 February 2012
r112589(bug 34702) More localised parentheses. Patch contributed by Yusuke Matsubara.siebrand11:56, 28 February 2012

Comments

#Comment by SPQRobin (talk | contribs)   20:17, 28 February 2012
- return $title . ' (' . $talk . ')';
+ return $title . $this->msg( 'parentheses' )->rawParams( $talk )->escaped();

Whitespace re-added in r112630

Status & tagging log

  • 07:20, 6 March 2012 Nikerabbit (talk | contribs) changed the status of r112591 [removed: new added: resolved]
  • 12:42, 28 February 2012 Siebrand (talk | contribs) changed the tags for r112591 [added: i18nreview]