MediaWiki r111953 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r111952‎ | r111953 (on ViewVC)‎ | r111954 >
Date:18:48, 20 February 2012
Author:jeroendedauw
Status:deferred (Comments)
Tags:
Comment:
applied patch by James Hong Kong
Modified paths:

Diff [purge]

Loading diff…

Image changes

Index: /trunk/extensions/SemanticResultFormats/Gallery/resources/images/next-horizontal.png
added
Index: /trunk/extensions/SemanticResultFormats/Gallery/resources/images/next-vertical.png
added
Index: /trunk/extensions/SemanticResultFormats/Gallery/resources/images/prev-horizontal.png
added
Index: /trunk/extensions/SemanticResultFormats/Gallery/resources/images/prev-vertical.png
added

Follow-up revisions

Rev.Commit summaryAuthorDate
r111954follow up to r111953jeroendedauw19:00, 20 February 2012
r112069Follow up to r111953; fix indent and some js fixesjeroendedauw00:10, 22 February 2012

Comments

#Comment by Nikerabbit (talk | contribs)   07:54, 21 February 2012
+jQuery(function($) {
 	12	+ $(window).load(function() {

jQuery( function () {} ) already executes on document ready.

Bad indentation in i18n file.

#Comment by SPQRobin (talk | contribs)   17:00, 23 February 2012

Please add message documentation for the newly added messages. Thanks.

Status & tagging log

  • 22:23, 23 February 2012 Reedy (talk | contribs) changed the status of r111953 [removed: new added: deferred]
  • 00:10, 22 February 2012 Jeroen De Dauw (talk | contribs) changed the status of r111953 [removed: fixme added: new]
  • 07:54, 21 February 2012 Nikerabbit (talk | contribs) changed the status of r111953 [removed: deferred added: fixme]