MediaWiki r111647 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r111646‎ | r111647 (on ViewVC)‎ | r111648 >
Date:16:05, 16 February 2012
Author:robin
Status:ok (Comments)
Tags:
Comment:
(Bug 31417) Content-holding div needs an ID.
Since the introduction of the class mw-content-ltr/rtl, it has been used to get the page text which is very bad because there are two class names and it is not always on the same place (if at all). This ID will always hold the bodytext (excluding categories, ArticleFeedback, ...).
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r113932MFT r111647reedy17:10, 15 March 2012
r113933MFT r111647reedy17:12, 15 March 2012
r113934Move RELEASE-NOTES after merging r111647 into 1.19 in r113933reedy17:14, 15 March 2012

Comments

#Comment by SPQRobin (talk | contribs)   16:08, 16 February 2012

I hope the ID name doesn't collide with other IDs. Google search didn't give me any exact matches.

Also, to my surprise, mw-content-ltr shows up as a google search suggestion, which means a lot of people wondered what it is :-S

#Comment by George Orwell III (talk | contribs)   22:08, 8 March 2012

A lot of people on en.wikisource were wondering how to use the ms-content-ltr container to replace an interim container scheme used for dynamic layouts of transcluded content once it went through the ProofReading process. This additional ID generated skin-wide would greatly help cut down on the amount of local .js currently needed (not to mention help stop abusing #contentSub where the interim container is being dynamically moved to).

Any chance this revision slated for 1.20wmf with the new ID attribute generation could be hurried along? Patching the current wikisource deployed version sooner rather than later sure could go a long way in undoing our dynamic layout mess moving forward. TIA - GOIII

#Comment by SPQRobin (talk | contribs)   22:59, 10 March 2012

I'm tagging this with 1.19wmf1 so if possible/allowed it will be deployed to WMF wikis.

Btw, I made the page Manual:Interface/IDs and classes which hopefully clears up usage of a few common IDs/classes (it's still a rather short list). Maybe it could become as helpful as Manual:Interface/JavaScript :)

#Comment by Reedy (talk | contribs)   16:49, 15 March 2012

Should this go into 1.19 aswell?

#Comment by SPQRobin (talk | contribs)   22:14, 15 March 2012

I see you did so already.. that's even better I suppose :)

Status & tagging log

  • 17:15, 15 March 2012 Reedy (talk | contribs) changed the tags for r111647 [removed: 1.19wmf1]
  • 22:59, 10 March 2012 SPQRobin (talk | contribs) changed the tags for r111647 [added: 1.19wmf1]
  • 00:18, 25 February 2012 Aaron Schulz (talk | contribs) changed the status of r111647 [removed: new added: ok]