MediaWiki r110640 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r110639‎ | r110640 (on ViewVC)‎ | r110641 >
Date:02:18, 3 February 2012
Author:robin
Status:ok (Comments)
Tags:
Comment:
Add @noflip to arrow directions like "southwest", as that is the same location regardless of language directionality. The arrow was displayed at the wrong side. Also removing text-align:left; for the tooltip as the text direction should be set in html if needed, and shouldn't be overridden by (flipped) css.
Modified paths:

Diff [purge]

Loading diff…

Comments

#Comment by SPQRobin (talk | contribs)   02:25, 3 February 2012

Ow, fixes bug 34175.

#Comment by Siebrand (talk | contribs)   10:39, 3 February 2012

This is an external library. How are we ensuring that our local fixes are included upstream?

#Comment by Siebrand (talk | contribs)   10:43, 3 February 2012

By the way, it looks pretty unmaintained, as there are 28 open pull requests and 0 closed pull requests on https://github.com/jaz303/tipsy/pulls.

#Comment by SPQRobin (talk | contribs)   13:27, 3 February 2012

The original code is designed for LTR and doesn't take into account that it can be flipped, so @noflip is a MediaWiki-specific addition (although CSSJanus is also external). Plus, looking at the file history, we have made some local changes before.

#Comment by Kaldari (talk | contribs)   21:35, 3 February 2012

It looks like our local version is substantially different than the upstream version (in both JS and CSS). I've added a note to this effect in r110686.

Status & tagging log