MediaWiki r108938 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r108937‎ | r108938 (on ViewVC)‎ | r108939 >
Date:19:35, 14 January 2012
Author:robin
Status:resolved (Comments)
Tags:
Comment:
(Bug 33553) Babel AutoCreate should not be able to create categories it is not allowed to create (protected titles)
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r109205Followup r108938, don't create an article object to just get the title out again...reedy20:07, 17 January 2012

Comments

#Comment by Nikerabbit (talk | contribs)   09:22, 15 January 2012

Why are you asking the title from Article when you just used $title to create Article object?

#Comment by SPQRobin (talk | contribs)   17:57, 15 January 2012

No special reason.. it doesn't make any difference I suppose

#Comment by Krinkle (talk | contribs)   02:19, 27 February 2012

This wasn't merged yet (I see no follow-ups). If that is the case, do we still need it? 1.19 was branched after this so it'll be in 1.19.0 and already is in 1.19wmf1. Untagging for now, feel free to re-tag.

#Comment by SPQRobin (talk | contribs)   13:13, 27 February 2012

Now that it's in 1.19wmf1 (and actually deployed on most wikis), it doesn't need to be in 1.18wmf1 anymore, so it's okay.

Status & tagging log

  • 02:19, 27 February 2012 Krinkle (talk | contribs) changed the tags for r108938 [removed: 1.18wmf1]
  • 20:06, 17 January 2012 Reedy (talk | contribs) changed the status of r108938 [removed: new added: resolved]
  • 19:39, 14 January 2012 SPQRobin (talk | contribs) changed the tags for r108938 [added: 1.18wmf1]