MediaWiki r108034 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r108033‎ | r108034 (on ViewVC)‎ | r108035 >
Date:15:13, 4 January 2012
Author:nikerabbit
Status:resolved (Comments)
Tags:
Comment:
* Refactored TranslationHelpers to have MessageHandle as store variable, instead of separate title, language and message key
* Refactored TranslationHelpers to throw exceptions, which are converted to html comments to aid debugging
* Refactored TranslationHelpers to not rely on $wgRequest
* Added getMessageContent to RecentMessageGroup to allow passing the message handle, getMessage only takes message key which does not include names, and thus was unable to know which message to load
* Added getGroupIds and getPrimaryGroupId to MessageIndex which accept MessageHandles, equivalents in TranslationUtils::messageKeyToGroup(s) should be phased out
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r108038Missed one instance were constructor changed, ping r108034nikerabbit15:23, 4 January 2012
r108046It's useful to catch the errors we might throw, ping r108034nikerabbit16:15, 4 January 2012
r110265follow-up r108034: actually return the value of $code in getTargetLanguage (t...robin03:46, 30 January 2012

Comments

#Comment by Siebrand (talk | contribs)   15:38, 4 January 2012
  • @since 2012-01-14

What was it like over there?

#Comment by Nikerabbit (talk | contribs)   15:53, 4 January 2012

There was snow everywhere. I had to type with my mittens on.

Status & tagging log

  • 22:57, 13 January 2012 Siebrand (talk | contribs) changed the tags for r108034 [removed: i18n]
  • 22:57, 13 January 2012 Siebrand (talk | contribs) changed the status of r108034 [removed: new added: resolved]
  • 21:10, 4 January 2012 RobLa-WMF (talk | contribs) changed the tags for r108034 [added: i18n]