MediaWiki r106782 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r106781‎ | r106782 (on ViewVC)‎ | r106783 >
Date:12:01, 20 December 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Resourceloader-ify CSS/JS from CentralAuth

Kill $wgCentralAuthStyleVersion as now un-needed
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r107123Fixup CA js/css per Roan on r106782...reedy23:24, 22 December 2011
r114151* (bug 34980) [Regression] IRC action text should never contain HTML for title...ialex16:40, 19 March 2012

Comments

#Comment by Catrope (talk | contribs)   18:45, 21 December 2011
-		$wgOut->addExtensionStyle( "{$wgExtensionAssetsPath}/CentralAuth/centralauth.css?" .
-			$wgCentralAuthStyleVersion );
-		$wgOut->addScriptFile( "{$wgExtensionAssetsPath}/CentralAuth/centralauth.js?" .
-			$wgCentralAuthStyleVersion );
+		$wgOut->addModules( 'ext.centralauth' );

This will cause a flash of unstyled content for the +.merge-method-help rule.

#Comment by Reedy (talk | contribs)   01:03, 22 December 2011

If can someone can either advise how to best fix this, else, fix it for me, it'd be appreciated

#Comment by Catrope (talk | contribs)   20:45, 22 December 2011

Sorry :)

You need to put the CSS file in a separate module and load that module with addModuleStyles().

#Comment by Reedy (talk | contribs)   22:03, 22 December 2011

Cheers!

Roan, do you realise you're using HTTP? ;)

#Comment by Catrope (talk | contribs)   22:04, 22 December 2011

Huh? What do you mean? Posting over HTTP? That sounds unlikely, I have HTTPSEverywhere enabled.

#Comment by Reedy (talk | contribs)   22:06, 22 December 2011
"Catrope" posted a comment on MediaWiki.[[Special:Code/MediaWiki/106782|r106782]].
URL: [http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106782#c28363 http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106782#c28363]

Commit summary for MediaWiki.[[Special:Code/MediaWiki/106782|r106782]]:

Resourceloader-ify CSS/JS from CentralAuth

Kill $wgCentralAuthStyleVersion as now un-needed

Catrope's comment:

Huh? What do you mean? Posting over HTTP? That sounds unlikely, I have HTTPSEverywhere enabled.

Ok, so CR is giving non https links again? :/

#Comment by Catrope (talk | contribs)   22:07, 22 December 2011

Yeah, I guess CR is probably just using getCanonicalUrl() now? I don't know.

Status & tagging log

  • 01:42, 1 March 2012 Krinkle (talk | contribs) changed the tags for r106782 [removed: frontend]
  • 16:19, 9 January 2012 Catrope (talk | contribs) changed the status of r106782 [removed: new added: ok]
  • 17:40, 5 January 2012 MarkAHershberger (talk | contribs) changed the tags for r106782 [added: frontend]
  • 23:25, 22 December 2011 Reedy (talk | contribs) changed the status of r106782 [removed: fixme added: new]
  • 18:45, 21 December 2011 Catrope (talk | contribs) changed the status of r106782 [removed: new added: fixme]