MediaWiki r106724 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r106723‎ | r106724 (on ViewVC)‎ | r106725 >
Date:23:35, 19 December 2011
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
Reduce more indenting
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r106891Fix boolean fail due to tiredness from r106721 and r106724reedy23:23, 20 December 2011

Comments

#Comment by Preilly (talk | contribs)   23:19, 20 December 2011

This logic is wrong:

if ( self::$useFormat === 'mobile' || self::$useFormat === 'mobile-wap' || - $xDevice ) {...

#Comment by Preilly (talk | contribs)   23:19, 20 December 2011

Sorry, I meant: if ( self::$useFormat !== 'mobile' || self::$useFormat !== 'mobile-wap' || !$xDevice ) {

Status & tagging log

  • 19:27, 21 December 2011 Catrope (talk | contribs) changed the status of r106724 [removed: fixme added: resolved]
  • 23:19, 20 December 2011 Preilly (talk | contribs) changed the status of r106724 [removed: new added: fixme]