Skin talk:Poncho

Jump to navigation Jump to search

About this board

Skin fails to load on MW 1.32

4
Noloader (talkcontribs)

I'm testing Poncho on the Crypto++ wiki. The skin fails to load with the message:

 Warning:  getimagesize(//www.cryptopp.com/w/images/logo/Logo-Steel.png): failed to open stream: No such file or directory in /var/www/html/w/skins/Poncho/Poncho.php on line 38
 title="Visit the main page" href="/wiki/Main_Page" style="background-image: url("/w/images/logo/Logo-Steel.png");">Crypto++ Wiki
 Fatal error:  OOUI\Exception: OOUI\Theme::singleton was called with no singleton theme set. in /var/www/html/w/vendor/oojs/oojs-ui/php/Theme.php:31 Stack trace: #0 /var/www/html/w/vendor/oojs/oojs-ui/php/Element.php(242): OOUI\Theme::singleton() #1 /var/www/html/w/vendor/oojs/oojs-ui/php/Tag.php(462): OOUI\Element->toString() #2 /var/www/html/w/skins/Poncho/Poncho.php(29): OOUI\Tag->__toString() #3 /var/www/html/w/skins/Poncho/Poncho.phtml(12): PonchoTemplate->searchInput() #4 /var/www/html/w/skins/Poncho/Poncho.php(138): include('/var/www/html/w...') #5 /var/www/html/w/includes/skins/SkinTemplate.php(227): PonchoTemplate->execute() #6 /var/www/html/w/includes/OutputPage.php(2706): SkinTemplate->outputPage() #7 /var/www/html/w/includes/MediaWiki.php(867): OutputPage->output(true) #8 /var/www/html/w/includes/MediaWiki.php(879): MediaWiki->{closure}() #9 /var/www/html/w/includes/MediaWiki.php(517): MediaWiki->main() #10 /var/www/html/w/index.php(42): MediaWiki->run() #11 {main} in /var/www/html/w/vendor/oojs/oojs-ui/php/Tag.php on line 464
Sophivorus (talkcontribs)

Thanks for the report. I just submitted a patch that should fix this. Please download the latest version (1.8) and reopen this topic if the issue persists. Cheers!

Noloader (talkcontribs)

Thanks @Sophivorus.

I'm still seeing the issue with Poncho's GitHub master.

This may have something to do with it:

#grep cryptopp.com LocalSettings.php

$wgServer           = '//www.cryptopp.com';
$wgEmergencyContact = "noreply@cryptopp.com";
$wgPasswordSender   = "noreply@cryptopp.com";

The $wgServer and forward slashes of '//www.cryptopp.com' means it is protocol agnostic (iirc). Mediawiki serves from HTTP or HTTPS, depending on how the client connects.

I tried to drop an image of the browser window !here!, but Mediawiki ignores my drop/upload. Sorry about that.

This also may have something to do with it: OOUI\Exception occurs when try to insert "https://w" to page.

Sorry I cannot help more. I'm a C/C++ guy. I know little to nothing about web programming. All I am is an administrator who tries to ensure users have good quality documentation.

Our VM is CentOS 7. Cent provides antique software so we have Software Collections (SCL) enabled. That gets us PHP 7.1 and Apache 2.4. We run Mediawiki 1.32.4 from the mw tarball.

And sorry about reopening the report. I could not comment otherwise. My email is noloader, gmail if you would like to have sidebar conversation.

Sophivorus (talkcontribs)

Hi! I just made a fresh MediaWiki 1.32.4 install with Poncho 1.8 and had no trouble. I made $wgServer protocol agnostic and still had no trouble.

GitHub is a mirror of the official Gerrit repo. Are you sure GitHub had already updated to Poncho 1.8 when you cloned it? Can you double-check your Poncho version from Special:Version and let me know?

Reply to "Skin fails to load on MW 1.32"

$wgSitename problematic

3
Summary by Sophivorus

Fixed in 1.6, see the $wgPonchoSitename config option.

Kghbln (talkcontribs)

The value of $wgSitename can only be about 20 chars before things start to be ugly. On mobile devices only 10 chars are allowed for the same reason. You can see the issue here. The Foreground skin solves this issue by providing a configuration prameter "wikiName" allowing to override the site name just for the display in the top bar of the skin. Perhaps this is something to considered here too.

Kghbln (talkcontribs)

This is still an open feature request for version 1.5.0

Sophivorus (talkcontribs)

Thanks for the reminder. This week I've been actively working on the Poncho skin and will release a new version in a couple days, including a fix for this. I created a Phabricator project for Poncho and a task for this, see https://phabricator.wikimedia.org/T226717 Let's continue there, cheers!

Drop-down of personal toolbar hides

5
Summary by Sophivorus

Fixed in 1.6.

Kghbln (talkcontribs)

When editing a page and hovering over the drop-down toolbar (the one with talk, preferences, beta ...) it hides behind the edit bar provided by the WikiEditor extension at the top of the page edit field. This is not an issue with the edit bar provided by the VisualEdior extension.

Sophivorus (talkcontribs)

Hi, thanks for the report, but I couldn't reproduce the issue. Could you download the latest version of the skin and let me know if the issue persists? If so, please attach a screenshot!

Kghbln (talkcontribs)

Hi, I just updated to latest master and the issue can still be reproduced. See the respective screen shot.

Kghbln (talkcontribs)

This is still an open issue for version 1.5.0

Sophivorus (talkcontribs)

Thanks for the reminder. This week I've been actively working on the Poncho skin and will release a new version in a couple days, including a fix for this. I created a Phabricator project for Poncho and a task for this, see https://phabricator.wikimedia.org/T226716 Let's continue there, cheers!

Summary by Kghbln

Will be fixed with version 1.5.x

Kghbln (talkcontribs)

Hi, currently the skin's name does not link to Skin:Poncho from special page "Version". To have this link will be nice for easier access to the docu.

Kghbln (talkcontribs)

This is still an open issue for version 1.5.0

Kghbln (talkcontribs)

Fixed with this commit. Will be part of the next release once it was merged.

Summary by Kghbln

Issues and improvement requests are in their own threads.

Kghbln (talkcontribs)

I just discovered and installed this skin. It is really nice. @Sophivorus: Thank you for creating and working on it.

Sophivorus (talkcontribs)

Thanks! I'll try to tackle the issues you mention throughout the week, cheers!

Kghbln (talkcontribs)

A pleasure and thanks for looking at these. Cheers

Action labels are always in small letters

2
Summary by Kghbln

Fixed in version 1.5.0

Kghbln (talkcontribs)

This skin assumes that the labels for the page actions like, e.g. edit, delete, version history are always in small letters. This is an issue for languages excessively liking capital letters to start words. I think MonoBook once had the same issue for the portlet labels in the sidebar.

Kghbln (talkcontribs)

This is no longer the case with version 1.5.0 though it could probably have been fixed with version 1.4.0 already. Anyways, thanks a lot.

There are no older topics