Reading/Multimedia/Team Norms

From MediaWiki.org
Jump to navigation Jump to search

Code review[edit]

  • Code without approval from jenkins will not be reviewed
  • Code with approval from jenkins will be reviewed within 1-2 business days (depending on timezone quirks)
  • '-1' means 'I do not think this patch should be merged without improvements', but another reviewer is free to disagree and approve for merging
  • '-2' means 'This patch must not be approved without improvements', and no other reviewer should override the decision
  • 'Abandon' means this patch will never be merged. Reasons include work on the patch being stalled for too long, or the original issue having been fixed or made irrelevant by something else. Another developer may reclaim the patch to improve it, but this is very unusual.