Manual talk:Article.php

From mediawiki.org
Latest comment: 9 years ago by Leucosticte in topic The purpose of pages like this

Note that Article::doEdit accepts parameters as flags. However, the combination of EDIT_MINOR | EDIT_SUPPRESS_RC makes the article show in the history, as the flags are mutually exclusive.

Discrepancy between code and documentation (HOOKS)[edit]

I have the FlaggedRevs extension installed (MW 1.15.3) and it uses the ArticleUpdateBeforeRedirect hook provided by Article.php, the documentation from hooks.txt (and the website) says:

'ArticleUpdateBeforeRedirect': After a page is updated (usually on save), before the user is redirected back to the page
&$article: the article
&$sectionanchor: The section anchor link (e.g. "#overview" )
&$extraq: Extra query parameters which can be added via hooked functions

But the code in Article.php:

includes/Article.php:		wfRunHooks( 'ArticleUpdateBeforeRedirect', array( $this, &$sectionanchor, &$extraQuery ) );

I changed the code in FlaggedRevs.hooks.php to match the code above, and it works. I am by no means a PHP expert, so I may be completely off, in that case I am sure somebody will correct me...

The purpose of pages like this[edit]

[09:36] <leucosticte> I was wondering, what's the main advantage of having pages like https://www.mediawiki.org/wiki/Manual:Article.php ? Are those mostly left over from before we had stuff like Doxygen as documentation for classes, methods, etc.? Or are they intended to make it easier to document stuff, since you can just make a wiki edit rather than having to get a patch approved?
[09:37] <marktraceur> leucosticte: The latter, I think.
Leucosticte (talk) 13:39, 29 September 2014 (UTC)Reply