Extension talk:LegalLogin
Add topic| This page used the Structured Discussions extension to give structured discussions. It has since been converted to wikitext, so the content and history here are only an approximation of what was actually displayed at the time these comments were made. |
Bug: not possible to click when the policy contains a table of contents
[edit]The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.
(I’m not sure it is the right place to declare a bug.)
When one of the policy contains a table of contents, the button to confirm that all policies are accepted never becomes clickable.
The cause is in modules/policyField.js where the number of policies is determined by $policyCheckboxes = $( '.legal-login-field input[type=checkbox]' ) and the TOC contains an input of type checkbox since MediaWiki 1.32 (commit).
This can be solved by changing the jQuery expression by a stricter one $policyCheckboxes = $( '.legal-login-field > div.mw-ui-checkbox input[type=checkbox]' ). ~ Seb35 [^_^] 12:47, 20 January 2022 (UTC)
- @Pastakhov: : I proposed this change on Gerrit. ~ Seb35 [^_^] 12:55, 20 January 2022 (UTC)
- @Seb35, I've +2'd the change. Thanks! I'll go ahead and resolve this now. X-Savitar (talk) 04:55, 23 February 2022 (UTC)
Notice: Undefined index: fieldname in /home2/wwiiarch/public_html/includes/htmlform/HTMLFormField.php on line 520
[edit]The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.
Whenever I try to sign into an account with LegalLogin set up, it repeats the following error message four times:
Notice: Undefined index: fieldname in /home2/wwiiarch/public_html/includes/htmlform/HTMLFormField.php on line 520
And it also just shows a blue hyperlink to the page that I am referencing. Also there are no errors for when I'm creating an account, it shows the scrollable page perfectly fine. Here is my code:
wfLoadExtension( 'LegalLogin' );
$wgLegalLoginPolicies = [
'WAMoS' => [ // text from MediaWiki:Terms and Conditions of Use, title is the same
'require scrolling' => true, // user must scroll it to down or open in popup windows before accept
],
]; Guillaume Taillefer (talk) 03:34, 10 November 2022 (UTC)
- We'll check this. Is there a URL where we can see the wiki? Which versions of MediaWiki and the extension are you using? Ike Hecht 00:58, 11 November 2022 (UTC)
- Thanks, its wwii-archives.org Guillaume Taillefer (talk) 01:41, 11 November 2022 (UTC)
- It is already fixed in the master branch, you can use it on your wiki. Also I created patch to merge changes from master branch to 1_38 branch, it should be merged soon. Pastakhov (talk) 16:38, 18 November 2022 (UTC)
- Ok thanks I'll try it out and see if it works Guillaume Taillefer (talk) 05:05, 20 November 2022 (UTC)
- Patch merged on REL1_38. Please note that there is no official support for non-LTS branches. Ike Hecht 16:25, 28 November 2022 (UTC)