Extension talk:IncludeBikemap
Add topicLatest comment: 14 years ago by Singlespeedfahrer in topic Code review
| This page used the LiquidThreads extension to give structured discussions. It has since been converted to wikitext, so the content and history here are only an approximation of what was actually displayed at the time these comments were made. |
Code review
[edit]The following discussion is closed. Please do not modify it. Subsequent comments should be made on the appropriate discussion page. No further edits should be made to this discussion.
Hi, just noticed this extension and I see some issues with code:
- First of all, great to see that this extension is XSS-safe, however you don't need to apply escaping to
$wgIBMsize- it is not outputted to pages directly. - We use prefix
wgfor global configuration variables (wg stands for "wiki global"), you don't need to use it for internal variables. wfMsg*()functions are used to retrieve messages from message files and optionally transform them (by parsing wikitext, substituting parameters like $1 with provided values and so on). They can't be used with random input likewfMsgForContent('uncorrect id: '). See Localisation for details. Max Semenik 11:56, 5 March 2011 (UTC)
- Hi, many thanks for your code review! I have to learn a lot about writing those extensions. So I'm pleased of your fast response. I fixed the code now as you have suggested. Best wishes. Singlespeedfahrer 14:03, 5 March 2011 (UTC)
The discussion above is closed. Please do not modify it. No further edits should be made to this discussion.