Extension talk:CloseWikis

From MediaWiki.org
Jump to navigation Jump to search

Some review notes[edit]

consider renaming tables.sql to closewiki.sql (naming conventions)

Consider adding a timestamp and 'by' field to the closed table.

Credits info references http://www.mediawiki.org/wiki/Extension:CloseWikis which is blank

CloseWikis::getList() cache seems like it should be unnecessary.

Instead of trawling through a list of every closed wiki ever, consider checking just the state of the current wiki individually in the permission checks.

Secondly, it just looks very weird to me -- first, the userCan hook looks like it'll apply to *any* action, but we close wikis only by locking them to read-only. What's the actual affect here?

Why not plug into the read-only hooks? What's intended?

       $wgOut->addHTML( '<form method="post" action="' . $wgTitle->getLocalURL() . '">' );

^^ URL needs escaping

   public function doClose( $wiki, $dispreason ) {

^^ consider encapsulating all DB access into a single class here; let the special page and the hooks be clients of that class.


-- brion 18:29, 23 October 2008 (UTC)

Review for deployment[edit]

Hi! I am not sure whether you are interested in getting this extension deployed on WMF wikis -- it was in Review queue but there was no Bugzilla bug associated with it. If you are, please respond to Brion's criticisms on this talk page, follow Writing an extension for deployment and add it back to Review queue with a bug number. Thanks! Sumana Harihareswara, Wikimedia Foundation Volunteer Development Coordinator (talk) 14:43, 4 April 2012 (UTC)

Being converted to extension registration[edit]

Hello maintainers and interested users. I've uploaded a patch at gerrit:391877 proposing to migrate this extension to extension registration. Please kindly review it if you have time. Thanks. —MarcoAurelio (talk) 18:52, 22 December 2017 (UTC)