Extension:MobileFrontend/Deployments/2013-09-24
Stories[edit]
Story 1163: Mobile Captcha support for editing
Story 475: UserProfile special page (first pass)
Bugs[edit]
Bug: 54238 - Ajax page loading: Page refreshes on a hash change
Bug: 52047 - Mobile editor doesn't support captcha
Bug: 52857 - Formatter: Cannot edit lead section of articles containing h1's
Bug: 49440 - MobileFrontend images shown double-sized in Retina desktop, iOS 7 beta
Bug: 53342 - Improve Error handling of GeoLocation api
Bug: 51586 - Liquid threads and mobile talk dislike each other
Bug: 54386 - Uploads tutorial doesn't show on first visit to uploads page
Bug: 54066 - Translate links to Wikipedia:General disclaimer and Wikipedia:About on fr.m.wikipedia.org
Bug: 53179 - Clicking "edit this page" doesn't work in mobile site
Bug: 48718 - (Tracking) Use mw.loader.using for non essential modules
Bug: 53782 - Logged out users on mobile should not load JS for editing
Bug: 53595 - License shouldn't be hardcoded in MobileFrontend
Bug 54282 - homepage styles leak into ajax loaded page
Bug: 48730 - Formatter: Sections on Commons are not collapsed
Bug: 53802 - Enable toggled sections always
Hygiene[edit]
Hygiene: Refactor page.js
Hygiene: Simplify formatter HTML Hygiene: Refactor page.js
QA[edit]
QA#1214 content license changes mean I need to change the tests to look at a different license as part of the footer tests
Uncategorized[edit]
Update cookie name in QA tests
Generate links for about and disclaimer correctly.
Use shorter text for some common licensing strings in the footer
Debug logging for latest PoolCounter weirdness
Alpha: Update title of page on a lazy load
Clean up login/create account form and captcha CSS
Update templates to contain new mobile edit links
Localisation updates from http://translatewiki.net.
Show proper button bar in editor on errors
Prevent overlay header from covering button bars
More HtmlFormatter removal fixes
Hide toasts and drawers when tapping in overlays
Fixes for moving HtmlFormatter class to core
Remove b/c cookie code
Using our own copyright i18n message for mobile
Cleanup after cookie name change
These headers are now set by Zero.
Re-adding mobile-frontend-footer-license i18n message
Update coding conventions in README
split MobileTemplateWML into its own class
Un-hardcode footer license message
Ensure sections in stubs really look like open sections
Git Logs[edit]
commit f76b384b6f7e66de26b32c7a0df7903dec1508b9 Author: kaldari <rkaldari@wikimedia.org> Date: Mon Sep 23 17:42:09 2013 -0700
Generate links for about and disclaimer correctly. Otherwise htmlvalidation will complain. Change-Id: I10c8adc0bf0f2e7eb7ce3ee405e7242f52adab22
commit dfefa8fc6d96c2fba850bfecf4a30f9ee0248587 Author: kaldari <rkaldari@wikimedia.org> Date: Mon Sep 23 16:17:04 2013 -0700
Use shorter text for some common licensing strings in the footer Unfortunately, this is a bit hacky since the installer only stores the license as a string. Change-Id: I1aed744919f55134456a09b6c9c9d2e627b75c0e
commit c1668a96cba128fdd725371b90ea3ab3c3446d0c Author: Max Semenik <maxsem.wiki@gmail.com> Date: Tue Sep 24 03:47:37 2013 +0400
Debug logging for latest PoolCounter weirdness Change-Id: I2f86bf9c80d1dc8edde08982216c6583a20ca82c
commit eb7d182a81e07e497813c8bf59c18ba3eae9c058 Author: jrobson <jrobson@wikimedia.org> Date: Mon Sep 23 16:30:38 2013 -0700
Alpha: Update title of page on a lazy load Change-Id: I104a718017bcbe17ff8f44ba2f843b0b61c5b428
commit 80d2596c007fe2012fd8a3f58da7346bba00e29b Author: jrobson <jrobson@wikimedia.org> Date: Mon Sep 16 13:39:30 2013 -0700
Stop refreshing page on a hash change Keep tabs on the current url and only do so when the url changes Bug: 54238 Change-Id: I819600b87c63fa5aef10039f73808e3e225aa982
commit 15689acf09e03cea3b7d0eb0c953dd6227254688 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Thu Sep 19 17:46:35 2013 -0700
Clean up login/create account form and captcha CSS Now that it is reused in the editor too, CSS can be shared. Change-Id: I6f909baaf2fc764484a009d7be2e32dbee78d8d2
commit 357be27901c06f6db18c9293e882a42fd389e127 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Thu Sep 19 17:12:24 2013 -0700
Story 1163: Mobile Captcha support for editing Add support for FancyCaptcha from ConfirmEdit extension. Reuses captcha styling from account creation (CSS cleanup in the following commit). Bug: 52047 Change-Id: I4850ed8eade5e76d141155d40f7ccd83d9cdfa57
commit eaef5a57dc545c0bbcce3886756bc838ad1b5cde Author: jrobson <jrobson@wikimedia.org> Date: Tue Sep 17 14:34:51 2013 -0700
Collapse on h1s when present * When h1s are present collapse on these rather than h2s Bug: 52857 Change-Id: I5e8d723d061f7003599b2a7f639bbe1301ba92e0
commit c2a9e0531fc65d91718d10ce1a76997feb6bac5d Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri Sep 20 12:31:27 2013 -0700
Update templates to contain new mobile edit links They should reflect server generated markup. Also, without this change section editing links would stop working after removing obsolete code from editor.js (FIXME on L89). Change-Id: I160a7d5ff7d6fc025cbd518b9f37d3caa54965b4
commit fd45ff3c0c145c2e3642adab0b63cc364a55a8cb Author: jrobson <jrobson@wikimedia.org> Date: Tue Sep 17 10:29:04 2013 -0700
Leave width of image rendering of infoboxes up to the template However make sure it doesn't exceed the size of the viewport * Disclaimer: This will break rendering of image on phones that do not support max-width and have resolutions smaller than the image - but this should be left to the template to take care of Bug: 49440 Change-Id: Iec09df6c8a513287d24f29dba1700c58a155a5ae
commit 1df7a5c888d3b9c359f75c4c2654a73866df662b Author: jrobson <jrobson@wikimedia.org> Date: Mon Sep 16 15:57:56 2013 -0700
Improve nearby error handling Bug: 53342 Change-Id: I7686553a66021ce8e63437521a1b6bdddcc28024
commit 74156462ee0b4a7eb9cbf02b90a159fa70f07a7c Author: jrobson <jrobson@wikimedia.org> Date: Fri Jul 26 17:24:43 2013 -0700
Story 475: UserProfile special page (first pass) Change-Id: I59ed57fcd2c75788f42d6d306cba81719c964204
commit 8f1565405ed541adbc3b525477cc5dc11e9d3b6a Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Mon Sep 23 19:41:56 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: Ib331b6ba26693eaadf189445ed99d161beafe796
commit 0c6161ab46e9357d4e143891651c65e749958b30 Author: jrobson <jrobson@wikimedia.org> Date: Mon Sep 16 16:52:09 2013 -0700
Redirect to talk page when liquid threads enabled Bug: 51586 Change-Id: Ie1bb49e3395a7286d7fa84f41b39a83624bff9f4
commit 923b6ea10069e947b228fb5eee30205f436eeecb Author: jrobson <jrobson@wikimedia.org> Date: Fri Sep 20 14:07:10 2013 -0700
Regression:Restore the First time user uploads tutorial * Restore the styling of this page Bug: 54386 Change-Id: I3f49cd50ed0c1778f8914b45cbc492fcc1775ca6
commit 2be64cb80321eb5339cd63cf250e2eebfdbb4af7 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri Sep 20 12:41:18 2013 -0700
Show proper button bar in editor on errors Errors happen when the preview is visible, not the textarea, so if an error occurs when saving, we should show preview's button bar. Change-Id: I1d1222770fa5b498877ba5b917bee7e013a2e780
commit 37ba24c34fa099f5e288cf9a984eb80f8cc97804 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri Sep 20 15:14:14 2013 -0700
Prevent overlay header from covering button bars When the keyboard was opened and a button bar had position fixed (e.g. summary in editor), it would get partially covered by overlay header in some cases. Change-Id: I542641ed29d873f6b065193f8c0ada4b3335df4c
commit 3dc3ea2e5bf40b99f8718e8b43ba9801f2c7ebaf Author: Max Semenik <maxsem.wiki@gmail.com> Date: Mon Sep 23 22:49:12 2013 +0400
More HtmlFormatter removal fixes Change-Id: Idc0d3e7a345b339845a9b4ee3f2a91ef7e9dead1
commit 0956dd1b25e4d6eb4a2e186d0cb958e84a5e1e7d Author: jrobson <jrobson@wikimedia.org> Date: Mon Sep 23 11:37:24 2013 -0700
Regression: Fix extraction of section heading in preview Update hacky code in preview that extracts the section heading Change-Id: Ic3f8a222983989c8949a863d96e7952f16f99c13
commit d0b58c33e0b76d578b664166c56700d3cc59767f Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Fri Sep 20 12:36:14 2013 -0700
Hide toasts and drawers when tapping in overlays Currently when a toast is showed in an overlay that is not scrollable (e.g. editor with a short section), there's no way of getting rid of the error toast that covers the "Keep editing" link. Change-Id: I1188f29a98b22b8e3ab84ea5ed9d40b7572c7afa
commit 3d385a460df44f34d1840ccee62a92cd12de858a Author: jrobson <jrobson@wikimedia.org> Date: Mon Sep 23 11:31:25 2013 -0700
Regression: Ensure clicking main edit button opens lead section Some old code was left lying around (I guess due to the dynamic edit refactor) Change-Id: I29f7b98380e3b6cd140d37318ae4548985a63d05
commit b3a8fc8c829738db86d16ec13c5329964fcba047 Author: jrobson <jrobson@wikimedia.org> Date: Thu Sep 19 14:08:19 2013 -0700
Hygiene: Refactor page.js * Rename page module to Page * Allow multiple page views to be rendered by separating the page-loaded event * Update body classes on a dynamic page load (fixes bug 54282) Change-Id: I3fea375f4583e877937b0face46289807e561e00
commit d91d2ddd1090785dff3b95b6ef5b59182bb7a33e Author: Brion Vibber <brion@pobox.com> Date: Mon Sep 23 10:10:27 2013 -0700
Fixes for moving HtmlFormatter class to core Updates from core change Ic276e1604c5718e8568e120ddfb9a8fc13a682fc Change-Id: Ie0e05a4c45181e608f5143dd1f9370fcc45fff06
commit 917c50011fca3a6126096a5a935b3f38c098a7a0 Author: kaldari <rkaldari@wikimedia.org> Date: Mon Sep 16 17:36:13 2013 -0700
Un-hardcoding About and Disclaimer links Making them work the same (roughly) as desktop site. Also removing unused i18n messages. Bug: 54066 Change-Id: Id53fcb7dbce85caa555466042cb1148c8aebf88a
commit 5a793a567e1bff563246839e12961d193e92cbf6 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Sun Sep 22 20:15:18 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: Ib3bfa11cf7818192321bf791f65183cfbe76f0c9
commit 37ffeafd50cd4cef0adc020ae1a8b33b7a9f9111 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Sat Sep 21 19:39:16 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I4480310bb852e9b8769c01141ea9643de4838475
commit b7f42563e98eb764ec65ee1241b4e6933cd6f777 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Fri Sep 20 17:53:36 2013 -0700
Remove b/c cookie code The old cookies should've expired since July 30 by now Change-Id: Idcea645c7d3e0eafb33947ad64b2785e23735064
commit 61365d734d273aa535edb606abdae6006f1433cf Author: kaldari <rkaldari@wikimedia.org> Date: Tue Sep 17 11:25:47 2013 -0700
Using our own copyright i18n message for mobile The copyright i18n message in core is commonly overriden on-wiki with paragraph-long licensing information. Having a licensing message that long is not suitable for mobile display. This allows us to have a separate version for mobile views. Also making it so that if no licensing info is present in the config, it doesn't display a broken message. Change-Id: Id082230532b3857cfb015939c98a62eda4c3c59f
commit aca95790b9a5c377543e9f8b8a0d0b2196a6a55d Author: jrobson <jrobson@wikimedia.org> Date: Wed Sep 11 11:30:05 2013 -0700
Hygiene: Simplify formatter HTML * Simplifies HTML output to simply wrap content between h2s * Fixes bug: 48730 and bug: 53802 * No cache flush required Change-Id: Iafc288e284b07061aba5fcb53bd80cc6e57a6c86
commit 1680db57af25837e3fc6ecf49bbc449ea3ff06fa Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Fri Sep 20 19:37:57 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I708c0b37f1916d975a28ab782df20dc5c02d6bba
commit a03dc708dea31ae2b9c8058ac2b7ae65e70af1ac Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Wed Sep 18 17:27:43 2013 -0700
Redirect &action=edit§ion=X to mobile editor When on mobile, redirect desktop edit links to the mobile ones. Bug: 53179 Change-Id: Ica7836528c2e93140908cdf0a4322072dd6d3896
commit f7dfde20231fa040b90b824c6449182afeb58cce Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Thu Sep 19 14:54:16 2013 -0700
Cleanup after cookie name change mf_mobileFormat changed to mf_useformat in 1fb258a0df8e9bb7cbbee57c3ecb7f0ea81914f0 Change-Id: I6da48c68ef536e8105970dc4db10101ece8c9156
commit c09f6fdc58f3989f136cf74c9ddb185b595fba18 Author: jrobson <jrobson@wikimedia.org> Date: Fri Sep 20 09:01:50 2013 -0700
Remove tables from alpha They have been there since December 2012 with no movement so let's just remove them. We can always reconsider this code at a later time but in the mean time it is something else to maintain Change-Id: I2d62a8d296354c85ed938ab0b2f0003ab4d5920f
commit 9c427517d15317710c3cc28e6f7c037d0dc1d815 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Thu Sep 12 12:22:31 2013 -0700
Load photo uploader dynamically Refactor the code in the process (split the button and "controller" code) and rename/move some of the templates so that it's clear where they belong. Initial page load (stable, desktop Chrome) before: 320KB, after: 303KB. Bug: 48718 Change-Id: I1b167dd27ba0488f99cbd3a29287d8af95011647
commit c17d846da21bf8f2811553a852e8d1cf1241f305 Author: Yuki Shira <shirayuking@gmail.com> Date: Fri Sep 20 12:16:54 2013 +0900
Fix the license URL Change-Id: I0440ecd33e253fdaf77179b855db6cdd4f355935
commit 2a113698e00d6ae231025d23958a5a7b1cb5f066 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Wed Sep 11 16:12:48 2013 -0700
Load talk overlay dynamically Only when talk icon is clicked. Initial page load (beta, desktop Chrome) before: 339KB, after: 332KB. Bug: 48718 Change-Id: I4aa7976e88dbb214e37c7c6aae082a82623d3a3d
commit 17a3f909e85dce63673ce899a8c65d23d4c68c4f Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Wed Sep 11 14:54:26 2013 -0700
Load editor dynamically Don't load it on every page load, only when the edit icon is clicked. Non-existent page data transferred (stable, desktop Chrome) before: 328KB, after: 319KB Reuse LoadingOverlay from Nearby previews to show a spinner when loading JS dynamically. Remove the message from the LoadingOverlay (we use spinners without messages everywhere to indicate that something is loading, it's a standard pattern that everyone understands). Bug: 53782 Tracking bug: 48718 Change-Id: I315f8d0404a7b2edaa0579dd747f9143aa5d3c38
commit 4f0dfed6f18ef01c1205b222b3aed4e8cd260a89 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Thu Sep 19 14:47:16 2013 -0700
Update cookie name in QA tests The name of the cookie used to trigger the mobile mode changed in 1fb258a0df8e9bb7cbbee57c3ecb7f0ea81914f0 to mf_useformat. Change-Id: Iaf1df35c4bbcfa90cb32d2c67ae633b398cc86d6
commit 7c0980ea284b50edff9742591113211f306895e5 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Thu Sep 19 19:30:33 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: I64da2c6058ce7811190f9713b92b45abb7f56733
commit 054dd7e0390ca0203328eecba1d9afff31892bd2 Author: Max Semenik <maxsem.wiki@gmail.com> Date: Wed Sep 18 17:35:59 2013 -0700
These headers are now set by Zero. The corresponding change has already been deployed. Change-Id: Ib9873ffd22a3cedbfbecacf977ccb4af89a64987
commit f0b74d25740d7980c3f5c68e8d381dc862cc1e40 Author: kaldari <rkaldari@wikimedia.org> Date: Wed Sep 18 17:11:18 2013 -0700
Re-adding mobile-frontend-footer-license i18n message Still needed by Zero Change-Id: I3381c3ef4c0bab79bf7bc357dcc8ca4b83e7d8c6
commit 83ead254bbd835bae04fee27e16531494dc0b39c Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Wed Sep 18 19:09:34 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: Idd4b7577ebaf3c86508fdbb12fb30f6ccd2f0181
commit 2b0ebb534fed784d6653c99df9709d2d44e57935 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Tue Sep 17 16:36:24 2013 -0700
Update coding conventions in README Remove obsolete text and replace it with a link to the new wiki page with all the coding conventions. Change-Id: Ida2bc9e46d91043229644da391ca0dc9e0b34ec8
commit 5c6f9c28964cd315713f68009d64a37b61f48fc5 Author: Michelle Grover <jcmish1@gmail.com> Date: Tue Sep 17 16:22:43 2013 -0700
QA#1214 content license changes mean I need to change the tests to look at a different license as part of the footer tests Change-Id: Ib644094a9abe978bc93c67568099c2ea774b618b
commit bc22d8349c3f2232dde000ffa05d07ac1d4a1c57 Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Mon Sep 16 13:39:37 2013 -0700
Wrap README at 72 characters That's what git does in commit messages. It improves readability in code editors which usually are not configured to wrap lines by default. Also, replace tabs with spaces in command examples so that they're styled properly. Change-Id: I7ee5aaf65f2f8f9a66a3802be06956d6c3005384
commit fe18d673f400da90bba7326ad2ca7db1cdfe05e7 Author: Translation updater bot <l10n-bot@translatewiki.net> Date: Tue Sep 17 19:45:30 2013 +0000
Localisation updates from http://translatewiki.net. Change-Id: Iaef798713e1b94622d43031c986b97931ded4331
commit dcbc74568558895d3632fb7f87650289e0d97a4d Author: addshore <addshorewiki@gmail.com> Date: Mon Sep 16 19:06:07 2013 +0200
split MobileTemplateWML into its own class The autoloader expects this as it is specified in the classes array which looks for classes in individual files. You can see this if running the autoloader tests in core. So this is probably what should be done. Change-Id: Ia5ef4b267542bfa7491f0141b6ed6a46f7a00fef
commit 67e345602aad9b93bd9bb1573d13f5e79067eee5 Author: kaldari <rkaldari@wikimedia.org> Date: Mon Sep 16 16:48:34 2013 -0700
Un-hardcode footer license message Make license message in footer work the same way (roughly) as it does on the desktop site. Also removing i18n message no longer needed. Bug: 53595 Change-Id: I867dddc3fde389db44b8a2966a29afebb6ec5d22
commit affb3e6916627d5ceb713a5bf4011f70dd4668fa Author: Juliusz Gonera <jgonera@wikimedia.org> Date: Mon Sep 16 15:48:37 2013 -0700
Ensure sections in stubs really look like open sections Change-Id: I2e57665ac486be15edb6e8cc7fdde1ef0f63492f