Gerrit/Project ownership

__NEWSECTIONLINK__ This page queues individuals' requests to be added to the Gerrit project owner groups for specific Gerrit projects (each of which corresponds to a Git repository). A Gerrit project owner has the power to approve changes for merger into that Gerrit project's master branch, and to veto changes.

"When/how we'll add, remove people from Gerrit project owner groups" has procedural details. Sumana Harihareswara will regularly look at new requests for project owner membership and contact the existing project owners. If the candidate gets zero vetoes and at least one yes from the existing project owners, then we'll approve the candidate. For each new candidate the process shouldn't take more than two weeks, and usually much less.

If your codebase/extension/tool isn't in Gerrit yet, use this form: Git/New repositories

To see the current list of Gerrit project owners for a specific Gerrit project, visit https://gerrit.wikimedia.org/r/#/admin/groups/.

Ownership structure
Example: an extension is named foo.
 * The Gerrit group "foo" should usually be an owner of the Gerrit project "foo."
 * Sometimes, meta-groups will be included in the group. This is for people have ownership over multiple extensions, so you can add/remove members in one place.
 * Rights to the group may be inherited from other groups (Look for a "Rights Inherit From:" in the project access.)

Specific example: the project "mediawiki/extensions/DonationInterface" is owned by group "extension-DonationInterface." This group includes the meta-group "fundraising." Also members of the group "mediawiki" has ownership via "Rights Inherit From: "mediawiki/extensions access"

By keeping the naming convention ("extensions/foo" is owned by group "extension-foo"), it'll make the "automatically setup a repo" process much more scriptable when we hit that bridge.

(Note to Gerrit group creators: remember to check the "Make group visible to all registered users." checkbox and leave the group type as "Internal group" and not LDAP.)

= Requests =

[ Add a request]

Editor engagement owns MoodBar
I'd like to assign the developers of MoodBar to be able to +2 the MoodBar backlog. So that's a number of small changes (all related).


 * creation of the extension-MoodBar group
 * group membership of "editor-engagement" to MoodBar extension
 * me added explicitly to extesnion-Moodbar group
 * me added "editor-engagement" extensions groups (me added to the extension-$extension groups below)
 * Article Creation Workflow
 * ArticleFeedbackv5
 * ClickTracking
 * E3Experiments
 * Echo
 * PageTriage
 * UploadWizard
 * TimedMediaHandler

BTW, I already can empower individuals to the extension via "editor-engagement", but I need finer-grained control for some extensions so I can add people outside the WMF to some editor engagement extensions, but not all..

Comments

 * I am the requestor -Tychay (talk) 17:59, 5 October 2012 (UTC)
 * Fabrice Florin (WMF) (talk) 21:47, 5 October 2012 (UTC)
 * Tfinc (talk) 23:03, 5 October 2012 (UTC)

A bunch of new groups
I'd like to have an $extension-trusted group (initially empty and with no rights assigned) for the following extensions: Validator, Maps, SemanticMaps, Push, LiveTranslate, SubPageList, Spark, IncludeWP, Survey, DidYouKnow, Gitweb (once created), DataValues (once created), Diff, SemanticWatchlist, SemanticImageInput and SemanticBundle.

These groups would be owned by their respective $extension-owner group.

This will allow me to manage my extension myself without posting a request here each time someone should get access :) --Jeroen De Dauw (talk) 19:25, 17 August 2012 (UTC)

Comments

 * Support. --siebrand (talk) 16:06, 21 August 2012 (UTC)
 * Since these are non-deployed extensions, I think this is fine. But I'd like to get input from Chad before we start introducing new group structures. --Catrope (talk) 18:02, 21 August 2012 (UTC)
 * I don't *like* it as proposed since this is very quickly going to explode the number of groups we have. Ideally all extension-$name groups should be owned by an extension-$name-owner (other than deployed exts, perhaps). The reason it's all currently owned by the "Project & Group Creators" was so people could process this page and add new users to their respective groups. What I'd like is either A) A way to manage all groups without giving out admin privs, or B) Multiple owners of groups. The former is probably easier. This all being said, perhaps we can go ahead with this structure for a few non-deployed extensions anyway and see if we really need this page at all for granting access to those. ^demon (talk) 14:05, 22 August 2012 (UTC)
 * Well then I suppose we'd be supportive of adding Jeroen as the owner of all those groups? Also, it seems to me that there are a number of them should be in some metagroup fro SMW. Tychay (talk) 20:56, 5 October 2012 (UTC)

Jeroen De Dauw for MediaWiki core ownership
And yes, I will only approve stuff of others that I'm qualified to review :) -- Jeroen De Dauw (talk) 18:14, 3 August 2012 (UTC)


 * -- Daniel Kinzler (WMDE) (talk) 16:15, 21 August 2012 (UTC)
 * We went over this in April, and the consensus was to grant +2 for certain extensions but not for core. I still have the same opinion. --Catrope (talk) 23:40, 21 August 2012 (UTC)
 * I love Jeroen changes, but I would prefer having a safeguard before landing them in production :-) Antoine &#34;hashar&#34; Musso (talk) 19:53, 23 August 2012 (UTC)
 * ❌ Sumana Harihareswara, Engineering Community Manager (talk) 15:09, 24 August 2012 (UTC)

As I understand it, the reason for not giving me merge rights is because I would supposedly go and merge my own stuff without discussion and break core. I understand that I should not merge my own code very well, and think I am quite responsible enough not to break things by being sloppy. I have merge rights to quite a few extensions, including WMF deployed ones, and AFAIK I have not merged in a single change that needed to be reverted since the git migration. So the argumentation against granting merge rights here seem invalid to me. At the very least, I'd like to ask for giving me a chance and revoking the right as soon as I merge in any of my own commits (which I guarantee you I will not do). --Jeroen De Dauw (talk) 20:07, 27 August 2012 (UTC)
 * It's not about merging your own changes, it's about about trust in general. We only give +2 access to people if the other reviewers trust their judgment. Once we actually have a process for revoking +2 access, I guess we could be more liberal about giving people access and taking it away from them if they break certain yet-to-be-determined rules, but right now we don't have such a process and we don't have those rules spelled out very well. So currently we can't really say "here's your access, but don't do X or we'll take it away", we can only say "here's your access, we're confident you'll use it well" or "sorry, you don't get merge access". I think that middle ground option should exist, and if and when it does that's what I'd vote to give you, but since it doesn't exist right now I'm voting conservatively. --Catrope (talk) 18:33, 31 August 2012 (UTC)
 * Sure. I'm absolutely fine with you not doing a +1 on this, as we don't know each other very well and have never worked together, hence it seems rather hard for you to properly judge my sense of responsibility. However, you are giving a -1, which I'm rather curious to hear what it is based upon. When I joined the community 3 years ago I was very novice, had no clue how stuff worked, and thus messed things up. I'm getting the impression this is being held against me here. --Jeroen De Dauw (talk) 12:43, 10 September 2012 (UTC)

User:Jan Luca for mediawiki/extensions/CentralAuth

 * LDAP user name : jan

I would like to join the CentralAuth-project because I think this is a very important extension for the community of Wikimedia and currently there is only one other project owner for this project (beside the MW core-owner). --Jan Luca (talk) 14:33, 21 September 2012 (UTC)

Comments

 * Jan, thanks. Since Victor Vasiliev is the existing Gerrit project owner here (other than the MediaWiki core team of course) I'm pinging him to ask for comment.  Owners commenting: see Jan's reviews and Jan's changesets. Sumana Harihareswara, Engineering Community Manager (talk) 18:02, 21 September 2012 (UTC)
 * I'm sorry, but I am not much familiar with your MediaWiki work (that's my fault). Could you please link to some of your Gerrit reviews (+1 or -1)? Preferrably in CentralAuth. vvvt 05:00, 22 September 2012 (UTC)
 * My reviews and changesets. Jan Luca (talk) 10:51, 22 September 2012 (UTC)
 * Two changes for CentralAuth as example:
 * 
 * 
 * --Jan Luca (talk) 22:09, 22 September 2012 (UTC)
 * To be honest, I expect to see more thorough testing for the deployment-level code. vvvt 04:06, 26 September 2012 (UTC)

Nischyan branch owner in SemanticMaps
I tried making Nischyan owner of the nischyan branch of SemanticMaps by adding a group he's member of as owner of this branch. I want him to be able to happily merge in stuff without needing approval of someone else. Since this did not work, I tried giving him pretty much all other rights on the branch, but he says he's still not able to approve his own commits. Am I doing something wrong? https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/SemanticMaps,access
 * -- Jeroen De Dauw (talk) 15:04, 24 September 2012 (UTC)


 * Reviewing commits (Verified+1, CodeReview+2, Submit) needs to be assigned to the appropriate refs/for/* refspace, not the destination ref. Compare and . ^demon (talk) 19:23, 24 September 2012 (UTC)


 * So it should be refs/for/refs/heads/nischyan? --Jeroen De Dauw (talk) 18:26, 28 September 2012 (UTC)

dsc to integration group
Just so anyone know, I am adding David "dsc" Schoonover to the integration group so he can merge things in integration/jenkins.git. Antoine &#34;hashar&#34; Musso (talk) 19:21, 24 September 2012 (UTC)

Comments

 * Sounds fine to me. ^demon (talk) 19:23, 24 September 2012 (UTC)
 * ✅ Antoine &#34;hashar&#34; Musso (talk) 19:23, 24 September 2012 (UTC)

Mathias Lidal for extension SmoothGallery
LDAP username: MathiasLidal I would like to take over maintainership of the SmoothGallery extension. As far as I can see this is no longer actively maintained. I have deployed this extension for a client and will continue to develop it (already have some bugfixes I would like to merge in)
 * Asking the author (Ryan Lane). Sharihareswara (WMF) (talk) 15:47, 27 September 2012 (UTC)
 * I'm fine with it. I don't have time to maintain it. I'm glad someone else wants to.--Ryan lane (talk) 19:55, 29 September 2012 (UTC)
 * ✅ Congrats, Mathias! Please change the Extension:SmoothGallery page to note that you are now the maintainer. Sharihareswara (WMF) (talk) 01:05, 30 September 2012 (UTC)

Add Jon Robeson and Rob Moen as owners of vector
Two things:


 * Create a extension-Vector group that owns the vector extension
 * Add the following to the group
 * Trevor Parscal
 * Jon Robeson
 * Rob Moen

Comments

 * I'm requesting on OK from Trevor, who doubles as the mediawiki ok ;-) -Tychay (talk) 21:02, 5 October 2012 (UTC)

Add Ori to MediaWiki group
It's mostly a formality, but it is highly weird we have a features engineer with +2 in core, but not the extensions. Besides, all the other project teams but E3 have a mediawiki group member (some like Mobile and VisualEditor have multiple)… I suppose this is an artifact of me collecting all the core mediawiki contributors in VE.

Comments

 * I am the requestor -Tychay (talk) 21:30, 5 October 2012 (UTC)
 * --Eloquence (talk) 21:33, 5 October 2012 (UTC)
 * -- Gabriel Wicke (GWicke) (talk) 22:40, 5 October 2012 (UTC)