Talk:Requests for comment/Typesafe enums

Looking forward to using it!
That's a really solid proposal and code. The only suggestions I have are:
 * Don't worry about the "final" class tags, it doesn't really belong in the reference implementation. Developers know they can use final if they really want, and it's a bit distracting from your point.
 * Maybe add more basic language constructs to the unit tests to dispel any potential anxiety. For example, in_array, array_search, and switch.

Can I also say, that is some really clean code? Adamw (talk) 21:26, 16 May 2014 (UTC)