Extension talk:BibleRef

Just what I needed! Thanks for your hard work. --Kf4bdy 20:27, 2 January 2007 (UTC)

Thanks
Thanks for this extension, I just add the French versions, and a parameter $wgBibleRefDefaultVersion the use the French version on a French site ;-)

CU Stéphane 13:11, 22 March 2007 (UTC)

Suggestion: NET Bible
Thanks Matt for the extension. I use the NET translation a lot and was wondering if it could be included in a future update of the code. Net Bible's universal search facility is very similar, using the same inputs as Bible Gateway. Ironblood 21:52, 3 May 2007 (UTC)


 * Hi Matt. With the help of a friend, I submit the following lines of code.
 * We added this line to the list of versions (bibleref.php)
 * 'net'          => 999, // NET Bible (net.bible.org)
 * We replaced the $output line with the following
 * if ($version == 999)
 * $output = "<a href='http://net.bible.org/passage.php?passage=".urlencode($input)."'";
 * else
 * $output = "<a href='http://www.biblegateway.com/passage/?search=".urlencode($input).";&version=".$version.";'";
 * We had to reset the cache for it to work, and are really pleased with the results. The only problem I can see is that it doesn't open up the passage in a new window. Perhaps you can see where we went wrong and correct it. With you, soli deo gloria Ironblood 00:24, 4 May 2007 (UTC)

New Version 1.1
Thanks for those updates/suggestions. I've modified the code to include the suggested Net Bible functionality, using a slightly different method than that suggested so other Bible sites could easily be incorporated later. - Matt.dolan 08:12, 7 May 2007 (UTC)


 * There was no need to explain why you didn't use our code - ours was clunky, you were always going to do a better job than us. Thank you for even considering it. Many thanks. Ironblood 00:16, 8 May 2007 (UTC)

Security fix
The 1.1 version of the code contained an XSS error, i.e. input was not properly escaped. This made it possible to include arbitrary HTML in the site. Anyone using this extension should update to version 1.2. -- Tbleher 16:13, 28 January 2008 (UTC)

Using http://www.bibleserver.com
Just as an info for anyone wishing to use http://www.bibleserver.com: You don't need an extension for that, just use a template like ; example code:

Adjust lang and bible type accordingly. -- Tbleher 16:17, 28 January 2008 (UTC)

include statement should be include_once
I recently installed BibleRef extension and am delighted. However, many of my Special: pages were broken after I installed it. I kept getting a message indicating that wfBibleRef could not be declared, having already been declared.

The fix is very simple and standard. Change:

include('extensions/BibleRef.php');

to

include_once('extensions/BibleRef.php');

Thanks for the excellent work on this. I enjoy being able to quickly and easily put in my Bible references.

--rowenrye 01:48, 8 February 2008 (UTC)

Version 1.2?
I see reference to version 1.2 in the discussion. I see it in the sidebar. However, the code on the extension page is version 1.1, as far as I can tell. I see that the code does include the NET Bible functionality. Is the current numbering in the code simply an oversight or is 1.1 still the one showing on the front page?

--rowenrye 01:51, 8 February 2008 (UTC)


 * I updated the version number to 1.2, as the old code had a security issue (possibility to include arbitrary HTML in the page). I just forgot to update the version in the code itself (which I now did). So the code on the page should be up-to-date. You can look at the [ page history] to see my changes.
 * -- Tbleher 08:14, 8 February 2008 (UTC)