Thread:Extension talk:FancyBoxThumbs/ Bug Hardcoded URL

Hi,

thanks for the nice extension, I was very relieved to get rid of the RegEx crap that I was fighting with before.

However, there is one severe bug in FancyBox:

There's a hardcoded URL in FancyBoxThumbs.php, line 71:

"http://www.frikipedia.es/friki/Archivo:" should not be hardcoded and must be replaced with the current URL and "/File:"

and "Origen" seems to be some other language than english, so I suppose it should be "Origin:" or "Source:"

Additionally I have two proposals:

1. The loading of jQueryMin from Google is a question of preference, but I prefer to keep it local. So I changed line 54

src="http://ajax.googleapis.com/ajax/libs/jquery/1.4/jquery.min.js" 

into

src="'.$wgScriptPath.$FBT_Dir.'/jquery.min.js"

(of course after putting jquery.min.js in the extension directory.

2. I added this to my css to make it clearer where the extension will load; it'll add a magnifier cursor:

Hope this feedback is useful, Cheers,