Extension talk:Approved Revs

Not working correctly with MW 1.13.4
Approved Revs is not working correctly with MW 1.13.4. Althought the (approve) link displays on the history page, when clicked it does not actually approve the page revision.

I made sure that this was on a revision after Approved Revs was installed.

Thanks for the help in advance. --Dgennaro 16:47, 25 August 2010 (UTC)


 * Hi - that's too bad; sorry about that. I'm never sure about the MediaWiki version compatibility for different extensions. I just changed the requirement to 1.14 - I'm on firmer ground with that one, I think. Yaron Koren 18:13, 25 August 2010 (UTC)


 * I can confirm it works with 1.15.4. --Dgennaro 19:52, 25 August 2010 (UTC)

approveAllPages.php
It did not run correctly. I was attempting to run the maintenance script for Approved Revs and nothing happened. From what I can tell, it did not run...or it just ended right away. Nothing printed. --Dgennaro 16:41, 27 August 2010 (UTC)

For me it is not working either, it requires Maintanance.php script, which not exists :(


 * What version of MediaWiki are you using? Yaron Koren 15:15, 22 July 2011 (UTC)

Changes since approval
Is there a way to list all pages that have changes since their last approval? - that is, the results of this query:

SELECT * FROM approved_revs INNER JOIN page ON approved_revs.page_id = page.page_id WHERE page_latest > rev_id

The idea would be to use this special page to be able to click on each page with outstanding approvals, immediately see the diff between the two pages and choose to approve or not. -- Philip 09:43, 2 November 2010 (UTC)


 * This is now available as a list within the 'ApprovedRevs' special page, as of version 0.5. Yaron Koren 02:51, 18 November 2010 (UTC)

Inline query for articles with an approved current revision
Is there a way to do an inline query to return a list of pages whose latest/current revision is 'approved'? (and leave out any pages which have no approved revision or whose current revision is not approved)


 * No - Approved Revs doesn't support inline queries. But you can get that same information by going to the page Special:ApprovedRevs. Yaron Koren 00:48, 23 January 2011 (UTC)

$egApprovedRevsBlankIfUnapproved
setting it to true it will set category pages as unapproved pages too. And if you set $egApprovedRevsNamespaces[] = NS_CATEGORY to fix this problem it will cause some other problems. Newuser1389 08:39, 19 February 2011 (UTC)


 * I believe that problem was fixed in the latest version, 0.5.5 - are you using that one? Yaron Koren 18:42, 20 February 2011 (UTC)


 * Sorry,you're right.Now I'm using the last version. Thank you.--Newuser1389 09:14, 24 February 2011 (UTC)

Conflict with ConfrimEdit extension
Have you installed both of confirmedit and approved_reves together? It seems they conflict with each other. Thanks for your attention.--Newuser1389 07:11, 7 March 2011 (UTC)


 * They're both working together on discoursedb.org... what's the problem you're seeing? Yaron Koren 15:30, 7 March 2011 (UTC)
 * Version: MediWikiVersion:1.16.0, PHP: 5.2.9-2. On confirm page, the content appears 6 times.--Newuser1389 08:30, 8 March 2011 (UTC)


 * Hi - I see the issue, and I think I know how it can be fixed. In your LocalSettings.php, is Approved Revs included before ConfirmEdit? If so, please move it to anywhere after ConfirmEdit, and let me know if that fixed the problem. Yaron Koren 04:58, 9 March 2011 (UTC)
 * Hi. I installed MediaWiki 1.16.2 and Approved Revs inclusion placed after ConfirmEdit. But the problem stayed the same. --Newuser1389 08:00, 9 March 2011 (UTC)


 * Indeed, I was too optimistic. But I just checked in some code to Approved Revs that I think does fix the issue. If you're getting the code from SVN, could you update, and see if the problem goes away? Thanks. Yaron Koren 22:51, 11 March 2011 (UTC)
 * Yes. The problem was fixed. Thanks a lot.-- 06:15, 12 March 2011 (UTC)


 * Cool, that's good to hear! I just released a new version, 0.5.7, containing the fix. Yaron Koren 20:15, 14 March 2011 (UTC)

Special:ApprovedRevs page
Should the special page show up in my Special:SpecialPages list? I don't see it. Right now I have to type in the URL for Special:ApprovedRevs. Otherwise the extension seems to be running fine on my WinXP/XAMPP/MW1.16.2 test server. ~ 05:35, 9 March 2011 (UTC)


 * I see it there, as "Approved revisions" in the "Lists of pages" section. If you still don't see it, what version of Approved Revs are you running? Yaron Koren 20:52, 9 March 2011 (UTC)
 * Very excellent. I found it. Had it turned off in the wrong security section of my file. Just knowing it should be there helped me fix it. Thanks! 22:07, 9 March 2011 (UTC)

Conflict with Admin Links?
Going to Special:AdminLinks page I get the following error at the top of the page: Strict Standards: call_user_func_array expects parameter 1 to be a valid callback, non-static method ApprovedRevsHooks::addToAdminLinks should not be called statically in D:\xampp\htdocs\riftwiki\includes\Hooks.php on line 133 Is this an Approved Revs issue or an Admin Links issue? If I disable Approved Revs the Admin Links page works fine which leads me to Approved Revs as the culprit. 17:49, 9 March 2011 (UTC)


 * Yes, indeed - you've found a bug in Approved Revs when using PHP with "strict standards". This will be fixed in the next version, but for now you can fix it in your code by just replacing "function" with "static function" around line 511 of ApproveRevs.hooks.php. Yaron Koren 20:41, 9 March 2011 (UTC)
 * Made the patch. Fixed it right up. Excellent work. Thanks! 22:07, 9 March 2011 (UTC)

How to configure not to prevent search engines bots
Excuse me about my bad English. Approve Revs by default prevents bots to index the wiki. Is there a way to allow search engines to crawl the wiki? 06:26, 10 March 2011 (UTC)


 * I don't think so - what users see is what search engines see. Yaron Koren 15:35, 10 March 2011 (UTC)
 * I see in wiki html code this tag : . And I think it is added by Approved Revs.--  16:19, 10 March 2011 (UTC)


 * No, it's not. Yaron Koren 18:13, 10 March 2011 (UTC)
 * Thanks for such a good, helpful and optimized extension.-- 22:17, 10 March 2011 (UTC)
 * Hi. Excuse me but I think this problem exists,I correct my question and ask it again. Mediawiki prevents bots to index revisions of pages. And when we use ApprovedRevs, mediawiki prevents bots to index revisions even the approved revision. When there is no revision as approved, MW do not add meta tag. Is my guess true ?-- 06:46, 13 April 2011 (UTC)

Indeed, you were right! Thanks for the clarification. I just checked in what I think is a fix for this problem in SVN - if you're using SVN, feel free to update, and see if it works for you. Yaron Koren 18:31, 13 April 2011 (UTC)


 * Thank you very very much.-- 18:10, 14 April 2011 (UTC)

SMW shows semantic properties of latest (non-approved) version?
From the main page of this extension, I understand that with this extension installed Semantic MediaWiki queries should only consider properties of the approved version of a page. ("Extensions that get specific data from pages, however, such as Semantic MediaWiki and DPL, will, fortunately, display the correct (i.e., approved) data.")

However, the behavior I see is different: queries as well as the Special:Ask page retrieve results based on the latest, non-approved version of the page. Is the behavior I see erratic, or did I misinterpret the information on the main page?

Rcdeboer 22:34, 23 March 2011 (UTC)


 * No - you interpreted it correctly. What versions of MW, SMW and AR are you using? Yaron Koren 23:03, 23 March 2011 (UTC)


 * I'm using MW1.15.4 with Semantic Bundle 0.5.20101125 (SMW1.5.4, AR0.5.2). I've also tried the latest version of ApprovedRevs (0.5.7) without success. Rcdeboer 23:20, 23 March 2011 (UTC)


 * I just tried it again, and it works fine for me - I'm using MW 1.16.2 and SMW 1.5.6. I don't know if either of those are the issue, but I'd say it's a good idea to upgrade in any case... beyond that, I have no idea why it's failing for you. Yaron Koren 01:05, 24 March 2011 (UTC)


 * I found the problem. I have set  $egApprovedRevsAutomaticApprovals  to false. Things work fine if I edit as a normal user without approval rights. I changed the following lines in ApprovedRev.hooks.php. This seems to fix my problem. Rcdeboer 19:26, 28 March 2011 (UTC)

from


 * Oh... oops, that's a bug - and your fix makes sense. Thank you! Yaron Koren 21:55, 28 March 2011 (UTC)

Script does not work with CharInsert
I installed Approved Revs, but CharInsert panel is gone. How I can return the panel? Please, help. THX Oktano 21:56, 30 March 2011 (UTC)


 * I have found the reason of the problem. I have removed a string $wgHooks['ParserBeforeTidy'][] = 'ApprovedRevsHooks::handleMagicWords'; from the ApprovedRevs.php. The CharInsert panel has returned. Is it correct or not? I use MediaWiki 1.16.2. Sorry for my bad English. Oktano 21:40, 13 April 2011 (UTC)


 * Hi - I just tried installing CharInsert myself, and for me the two extensions work fine together - which makes it hard to debug. Your solution, unfortunately, disables part of Approved Revs' functionality, so it's not something I can add. Are you using the latest versions of both Approved Revs and CharInsert? Yaron Koren 14:35, 14 April 2011 (UTC)
 * Yaron, thx for your reply. On the local server I use Denwer, panel CharInsert with Approved Revs does not work. After that I tried to run modules Approved Revs and CharInsert on a server on the Internet, both modules are working well. It is my mistake, sorry for the trouble. Oktano 01:29, 15 April 2011 (UTC)


 * Okay, that's good news. Yaron Koren 02:19, 15 April 2011 (UTC)

Still under Approved Revs control when actually not.
Ill first provide the reproduction and then explain


 * 1) Edit a page under Approved Revs control (preferably a namespace other than main for ease of use)
 * 2) Mark that page as "Approved"
 * 3) Remove the Namespace from Approved Revs control
 * 4) edit the page again and save
 * 5) run index.php?title=Special:ApprovedRevs&show=notlatest

Your page should show up here, this makes sense as the page has been edited and now has a new revision that is not approved but as its no longer under Approved Revs control you cannot bring it forward.

You can resolve this by moving the namespace back under Approved Revs control, go mark the page approved version as "unapproved" which will make the most current rev the current page and then remove that namespace from Approved Revs control again.

__APPROVEDREVS__ not displaying on Special:ApprovedRevs
Pages marked with the magic word __APPROVEDREVS__ via a template are not currently displaying on Special:ApprovedRevs. --Dgennaro 20:30, 25 April 2011 (UTC)


 * Is there any update on the issue above? --Dgennaro 17:21, 16 May 2011 (UTC)


 * Hi, sorry I forgot about this - thanks for the reminder. I think I just fixed the problem in SVN - if you test it out, please let me know if the fix worked. Yaron Koren 01:37, 17 May 2011 (UTC)

approveAllPages.php whines about the parser
If you run approveAllPages.php in 1.17, it will throw notices:

Notice: Undefined variable: parser in /path/to/wiki/extensions/ApprovedRevs/ApprovedRevs_body.php on line 182

It appears to otherwise work fine. —Emufarmers(T 00:24, 29 June 2011 (UTC)


 * Oh, indeed - I'm amazed that this didn't get called earlier, because I don't think the problem is new to MW 1.17. I believe I just fixed this now, in SVN. Yaron Koren 04:52, 29 June 2011 (UTC)

Detect if page is approved
Hello,

is there any way to detect a page/revision is marked as approved or not (in order to show one content or other with a set of templates and parser functions)? Thanks! --Toniher 12:38, 2 July 2011 (UTC)


 * Hi - detect from where - another page? Or the same page? Or elsewhere? Yaron Koren 02:58, 3 July 2011 (UTC)
 * Actually, from the same page. --Toniher 21:18, 3 July 2011 (UTC)


 * That can't be done, no. Yaron Koren 02:05, 4 July 2011 (UTC)

Is it compatible with version 1.17.0
Hi I installed this extension on the version 1.17 but it seems its not working as Im not able to see approve link in my history page?? --Harshadachavan 08:48, 17 August 2011 (UTC)harshadachavan


 * Yeah, it works with MW 1.17 (and higher). Maybe you just lack the permission for it? Are you logged in as an administrator? Yaron Koren 15:09, 17 August 2011 (UTC)

Possible to move the approved and latest message to the bottom?
Hi.

Great extension :) Is it possible to move the approved and latest message to the bottom of the screen?

Thanks! --Mitchelln 16:43, 14 September 2011 (UTC)