Gerrit/Tutorial/ja

このページは、ウィキメディアの開発で Git および Gerrit を使用する方法を説明するチュートリアルです.


 * 時間を節約したい場合、かつ技術に精通している場合は、代わりに非常に短いハウツー ガイドを使用してください:
 * パワー ユーザー向けに、 に追加的な説明文書があります.
 * Gerrit を試したいだけで、「実際の」ウィキメディア ソフトウェア プロジェクトのパッチを書きたいわけではない場合は、代わりに Gerrit テスト インスタンスを使用してください.

このチュートリアルでは、入力するコマンドは以下のようにドル記号 ($) で始まります:. 接頭辞は入力しないでください. コマンドに、自分で変更する必要がある変数も含まれている場合、変数は赤で表示されます:.



Git とは
Gitは、無料でオープンソースの分散型バージョン管理システムです. 「分散」は、リポジトリの中央管理コピーがないことを意味します. Git では、リポジトリのクローンを作成すると、ソースコードの完全に機能するコピーが、すべてのブランチとタグ付きリリースを含めてダウンロードされます.



Gerrit とは
Gerrit は、Git と統合する無料の Web ベースの協同型コード レビュー ツールです.

Basically: You submit your proposed software change (often called "patch", in Gerrit called "changeset") as a new branch. If the first version ("patchset 1") is not yet perfect, you can make more changes ("amend") in that branch ("patchset 2", etc.). Once a patchset receives a "+2" review, it will get accepted and merged into the main branch of the code repository (usually called "master"). Merging means that your change is included by default when anyone checks out or downloads that code repository.



ウィキメディア開発者アカウントの作成
ウィキメディア開発者アカウントをまだお持ちではない場合は、wikitech.wikimedia.org に行ってアカウントを作成してください. 同じ利用者名とパスワードが、下記の Gerrit へのログインでも使用されます.



Git をセットアップする
これらの手順では、Git をコマンド ライン (ターミナル ウィンドウ) ツールとしてインストールする方法を説明します. コマンド ラインではなくグラフィカル ユーザー インターフェイス (GUI) を使用したい場合は、Git プロジェクトが管理しているクライアント一覧を確認してください. 別のインストール手順については、公式の説明文書を参照してください.

Font Awesome 5 brands linux.svg Linux

 * Linuxディストリビューションのグラフィカルソフトウェアパッケージ管理ツールを使用して、 パッケージをインストールします.
 * gitがディストリビューションにパッケージ化されていない場合は、ディストリビューションのサポートフォーラムで質問してください.

Font Awesome 5 brands windows.svg Windows

 * Git for Windowsを https://gitforwindows.org/ からインストールします. これによってGitに加えて、「Git Bash」と呼ばれるシェルが手に入り、この手引きの中のほとんどのコマンドラインがWindowsで動作するようになります.

Apple logo black.svg macOS

 * Homebrewパッケージマネージャーをインストールし、コマンドを実行してください – 更新や他のパッケージのインストールが簡単になるので、これを推奨します.
 * 別の方法として、スタンドアローンのGit for Macをインストールすることができます.



Gitの設定
さてGitがインストールされて、個人情報を設定する時間です. 1回だけこれを行う必要があります. これらのコマンドを再度実行することによって、いつでも個人情報を変更することもできます.

Gitは利用者の名前とメールをチェックすることによって、各々のコミットを誰が行ったのか追跡します. さらに、この情報はあなたのコミットをあなたのGerritアカウントと関連付けるために使われます.

以下の2つのコマンドを入力して、あなたの利用者名とメールアドレスを設定してください. を自分自身のGerrit利用者名で置き換え、を自分自身のメールアドレスで置き換えてください：



GerritでSSH鍵をセットアップする
あなたのコンピュータとGerritの間に安全な接続を確立するために、SSH鍵を使います. The Wikimedia Security Team recommends, as of August 2021, that users creating SSH Keys use the  type for optimum security and performance. 新しい鍵を生成する必要があるかどうか確かめるために、あなたのシステムにSSH鍵が既に存在するのかを確認しましょう. ターミナルでこのコマンドを実行してください：

このコマンドにより（隠されている） ディレクトリ内にあるファイルが一覧されます. もしそのディレクトリがあなたのシステムに既に存在して、 というファイルが一覧に出力されているならば、そのまま#SSH公開鍵をコピーするに進むことができます.



新しいSSH鍵を生成する
新しいSSH鍵を生成するには、Git Bashを開いて、以下のコマンドのを自分自身のメールアドレスに置き換えたものを入力します. 我々はデフォルト設定にしてほしいので、鍵を保存するファイルを入力するように言われたら単にEnterを押してください.

Enter a strong and unique passphrase and press the Enter key.


 * Why do passphrases matter?


 * Passwords aren’t very secure.

'' If you use one that’s easy to remember, it’s easier to guess or brute-force. If you use one that’s random it’s hard to remember, so you might write the password down. Both are very bad. This is why you’re using ssh keys. But using an ssh key without a passphrase is basically the same as writing down that random password in a file on your computer. Anyone who gains access to your drive has gained access to every system you use that key with. That's why you also add a passphrase. To not enter a long passphrase every time you use the key, there’s a tool called. It can save your passphrase securely. If you use macOS or Linux, then your keys can be saved in the system’s keychain to make your life even easier. ''

The  command will create 2 files in   directory:


 * : your private SSH key (for identification)
 * : your public SSH key



SSH公開鍵をコピーする
公開鍵ファイル（例えば ）の内容を手に入れて、クリップボードにコピーします：

選択肢のひとつは、公開鍵ファイルを好きなテキストエディタ（Notepad、TextEdit、geditなど）で開くことです. ディレクトリは隠されているので、ファイルを見つけるにはテキストエディタのファイル選択ダイアログで、「隠しファイルを表示する」を有効にする必要があるかもしれません. 「隠しファイルを表示する」オプションは、ファイル選択ダイアログで右クリックすることによって利用できる場合があります.

その他の選択肢は：


 * Linuxで、を実行して手動で出力をクリップボードにコピーする.
 * On Windows, you can open Git GUI, go to Help 🡒 Show Key, and then press "Copy To Clipboard" to copy your public key to your clipboard.
 * On macOS, you can run to copy the contents of the your public key file to your clipboard.

It’s important you copy your SSH Public key exactly as it is written, without adding any newlines or whitespace. Copy the full text, including the "ssh-ed25519" prefix, the key itself, and the email address suffix.



SSH公開鍵をGerritアカウントに追加する

 * Gerritのウェブインターフェースにログインします. Gerritの利用者名とパスワードは、ウィキメディア開発者アカウントと同一です.
 * Click on your username in the top right corner, then choose "Settings".
 * Click "SSH Keys" in the menu on the left.
 * Paste your SSH Public Key into the corresponding field and click "ADD NEW SSH KEY".



Gitで使うためのSSH秘密鍵を追加する
Git Bashコマンドラインを開始します.


 * 以下によって、sshエージェントを稼働させます
 * シングルクォート ではなく、アクセント  を使っていることを確かめてください.  （この特殊文字を簡単に入力することができないならば、このページからコピーアンドペーストすることができます. ） Note also that if you are using an alternative shell in Linux (for example the Fish shell), this command may not work; switching to Bash will fix the issue.
 * シングルクォート ではなく、アクセント  を使っていることを確かめてください.  （この特殊文字を簡単に入力することができないならば、このページからコピーアンドペーストすることができます. ） Note also that if you are using an alternative shell in Linux (for example the Fish shell), this command may not work; switching to Bash will fix the issue.


 * エージェントに秘密鍵を追加します. 上記の手順に従っていて、鍵がデフォルトの名前 であるならば、コマンドは以下の通りです：


 * To permanently add the SSH key, use command:

For macOS see CodeX article.
 * Connect to the Gerrit server via  to check if everything works as expected. Replace  by your username as shown in your Gerrit settings:

An example Gerrit SSH connection success message looks like this:
 * Be mindful and compare that the "ed25519 key fingerprint" is the same as the SSH fingerprint for gerrit.wikimedia.org:29418. If it is the same, answer "Yes" to "Are you sure you want to continue connecting?". Then enter the passphrase for your key.
 * You should get a message "Welcome to Gerrit Code Review". The last line should show "Connection to gerrit.wikimedia.org closed."
 * If you run into problems, use (replace  by your username).  は問題を見つけるのを手助けするために冗長出力を提供します.  それからGerritトラブルシューティングを読んでください.



Gitを使ってコードをダウンロードする
Let's practice by downloading (also called "cloning") the repository called "sandbox". 以下をGit Bashコマンドラインで実行します：

(Replace by your Gerrit username. And make sure the URL begins with   and not  ).

This will copy the entire history and the code base of the "sandbox" extension repository into your machine. You will have a working directory of the extension's main branch (usually also called "git master"). Enter the new directory (via the command ). Now you can look at the code and start editing it.



Gerritで作業する準備
Gerrit requires that your commit message must have a "change ID". They look like  starting with an I (capital i). Each time you amend a commit to improve an existing patch in Gerrit, this change ID stays the same, so Gerrit understands it as a new "patch set" to address the same code change.

There's a git add-on called git-review that adds a Change-ID line to your commits. Using git-review is recommended. It makes it easier to configure your Git clone, to submit a change or to fetch an existing one.



git-review のインストール
Note that Wikimedia Gerrit requires git-review version 1.27 or later.

For more details, please see Gerrit/git-review#Installation.

Font Awesome 5 brands linux.svg Linux

 * Use the graphical software package management tool of your Linux distribution to install the  package.
 * If git-review has not been packaged by your distribution, check git-review for other options such as installing git-review by using the pip Python package installer.
 * If you use FreeBSD, install git-review through ports.

Font Awesome 5 brands windows.svg Windows

 * Please see git-review Windows.

Apple logo black.svg macOS

 * For OS X 10.11 El Capitan and later, follow Method 1.
 * On versions prior to 10.11, use the pip Python package installer by following Method 2.

Configuring git-review
Git's default remote host name is "origin". This name is also used by Wikimedia projects. We need to tell git-review to use that host. Replace with your Gerrit username:

Setting up git-review
After downloading ("cloning") a repository, you need to set it up for git-review. This will automatically happen the first time you try to submit a commit, but it's generally better to do it right after cloning. Make sure that you are in the directory of the project that you cloned (otherwise you will get an error "fatal: Not a git repository"). Then run this command:

Towards the end of the output, you should see something like this:

This may ask you for your git username, if it's different from the shell username you're using.



パッチを投稿する
Make sure that you cloned the code repository that you are interested in (see here).

Make sure that you are in the directory of the code repository (the command tells you where exactly you are).

Update the main development branch
Make sure that the main development branch (the branch created when you initially cloned the repository) is up to date:

However, note that some repositories use a different name for their main development branch (for example  instead of , or the   repository has a   instead of a   branch).



ブランチの作成
まず、あなたの新しい変更についてローカルブランチを作成します. 以下のを短いけれど適度に説明的な名前で置き換えます. （例えば、あなたの変更に対応するのタスクが存在するならば としたり、 、あるいは ）. 他の人たちもあなたのブランチを識別するために、この名前を使用します.

This will create a new branch (called ) from the latest 'master' and check it out for you. In the example above, we called that new branch.



変更を行う
ローカルのコードに変更を行います. 好きなテキストエディタを使ってファイルを修正してください. 以下の例では、ファイル を編集して言葉を追加しています.

それからテキストエディタを閉じて、ファイルやディレクトリの中で、最後のコミット以降にあなたが行った変更をチェックしてください：

はあなたの変更をユニファイド形式 (Unified format)で表示します：除去された行はマイナス から始まり、追加された行はプラス  から始まります. これらの変更はまだ次のコミットのために（ によって）「ステージ」されていません.

<span id="Stage_your_changes_for_a_commit">

変更をコミットするためにステージする
どの変更をあなたのコミットに組み込むべきか決定するために、を実行してください. これによりディレクトリの中であなたが変更したファイルの一覧が表示されます. At this point, the output will display "no changes added to commit" as the last line.

Use  to make your changed file(s) become part of your next commit. In the example above we modified the file, so the command would be:

Any files you've changed that you have not passed to  will be ignored when running   in the next step.

<span id="Commit_your_staged_changes">

ステージした変更をコミットする
Once you are happy with the list of changes added via, you can turn these changes into a commit in your local repository by using

You will then be asked in your text editor to add a descriptive summary for your commit. You must follow the Commit message guidelines. This is what other people will see when looking at the history of changes in the code repository.

Save the commit message and close your text editor. A summary (the commit ID, your subject line, the files and lines changed) will be displayed.

<span id="Prepare_to_push_your_commit_to_Gerrit">

Gerritへコミットをプッシュする準備
Synchronize your changeset with any changes that may have occurred in the master branch while you've been working ("rebasing"). From within your branch, run:

Now you are ready to push your code to Gerrit for review. If you made several related commits, consider merging them into one single commit for review.

<span id="Push_your_commit_to_Gerrit">

Gerritへコミットをプッシュする
If you followed #Prepare to work with Gerrit above and installed  and ran , then the command to push changes to Gerrit is:

The  option tells git-review not to perform a rebase before submitting the change to Gerrit.

Upon success, you'll get a confirmation and a link to the changeset in Gerrit. In the example above, that link is: https://gerrit.wikimedia.org/r/#/c/sandbox/+/563720

Congratulations! Your patch is in Gerrit and hopefully will get reviewed soon!

View the Change / Next Steps
Open the link to your Gerrit changeset in a web browser.

Under "Files", after you clicked the down arrow at the very right of any file in the list, you can see a diff of your changes per file: The old lines are shown in red color and your new lines are shown in green color.

If your commit addresses a ticket in Phabricator, a comment will be automatically added in the Phabricator task if you followed the Commit message guidelines. If you did not, you could either fix your commit message (by creating an updated patchset), or manually add a comment on that Phabricator ticket which includes a link to your changeset in Gerrit.

<span id="Other_common_situations">

その他のよくある状況
Also see Gerrit Advanced usage if your situation is not covered here.

Squash several commits into one single commit via rebase
If you made several related commits to your local repository prior to wanting to submit for review, you should squash (merge) those commits into one single commit.

The  or   option allows you to change (rewrite) your commit history. For each commit, you can modify and change the commit message, add or remove files, or perform other modifications.

First you need to tell git how far back you want to pull. To get a list of all changes in your branch:

You can also limit the displayed list of recent changes. means pull the last three commits:

After you type this command, your text editor will display your commits in reverse order and a list of available commands:

Since we only want to send one commit to review, we will squash the last two commits into the first. Hence change all but the first "pick" to "squash":

pick aa8cf1d Adding method customFilterFunctionGetRiskyCountryCodeScore to GatewayAdapter. squash 38828e2 Adding $wgDonationInterfaceCustomFiltersFunctionsRiskyCountries to donationinterface.php squash be33007 Fix a typo

When you finished picking and squashing and saved the file, another file will open in your text editor to allow you get to edit and merge your commit messages. Be careful to only keep one of the Change-Id lines and have it be at bottom of the message after one empty line.

Your messages from your previous commits will automatically be placed in this message:

Remember to put your (updated) summary message in the commit. In this case the new summary message will be:

(mingle-fr-2012-69) Adding a custom filter for risky countries.

If all goes well, you should see a successful rebase message:

Afterwards, submit your patch for review:

You should see a message like this showing your git review went to Gerrit (in this example, to https://gerrit.wikimedia.org/r/7187):

Amending a change (your own or someone else's)
Sometimes, you might need to amend a submitted change. You can amend a change as long as the change hasn't been merged yet.

You can amend your own changes. To amend changes submitted by someone else, you need to be a member of Gerrit's Trusted-Contributors group. To become a member of Trusted-Contributors, find someone who is a member and ask them to add you. The group is viral in that members can add new members, use your powers responsibly.

Rebasing
Rebase to bring your local branch up to date with the remote. It's best to make rebase updates a separate patch, so that your code reviewers have an easy time seeing what changes you've made. Assuming you are using Gerrit, you can do this by clicking the "Rebase Change" button when viewing your patch in Gerrit's web interface.

Hard reset and checkout the change with this command: (BEWARE:  performs a hard reset that destroys all local changes. Stash or commit changes first which you wish to preserve!)

例:

You can look in Gerrit to figure out the changenumber. It is the six digit number in the URL of your code review page.

Or, if you already have the change in a branch on your local repository, you can just check it out:

例:

Make changes and push
Next, make some changes with your favorite text editor.

the files as needed, then commit the change (ensuring you are amending the commit):

Push the change:

The  is important here. It tells git-review to not rebase your change against master, which clutters diffs between patch set 1 and 2.

<span id="Push_to_a_branch_different_than_master">

master以外のブランチにプッシュする
Above, the commit was pushed to the master branch. The branch name only appeared as the topic of the commit in the Gerrit UI. If you really want to push to a different branch than master, you have to push via.

<span id="Editing_via_the_web-interface">

ウェブインターフェースを介して編集する
If you're logged in to Gerrit, you can also create code changes directly within the web interface. This can be useful for making small patches, or for non-developers to contribute small fixes.


 * 1) Go to https://gerrit.wikimedia.org/r/admin/repos/ and choose the code repository that you want to edit.
 * 1) Select "Commands" in the sidebar
 * 1) Click "Create Change"
 * 1) Set branch to "master" (if you don't want to use master branch you can use the other branches available for that project)
 * 1) Set the topic to something of your choosing (e.g. "copy-edit" - must be all-one-string) (optional)
 * 1) Write a description ("commit summary") in the big text field by following message guidelines. (Example)
 * 1) Click "Create"
 * 1) In the upper right corner, click the "Edit" button
 * 1) Under "Files", click "ADD/OPEN/UPLOAD" button
 * 1) Type the folder/file path for the file you wish to edit (e.g. i18n/en.json) and click "Confirm"
 * 1) Find the line(s) you want to change, and change them.
 * 1) Click "Save"
 * 1) Click "Close"
 * 1) Click "Publish edit"
 * 1) Click "Mark as active" to remove the "Work in Progress" status from your code changes

Done!

If you need to change the commit message of an existing changeset, you can use these steps:


 * 1) Go to the changeset itself. Example URL: https://gerrit.wikimedia.org/r/c/1234567890 (replace the ID at the end)
 * 1) In the "Files" section, click "Commit message"
 * 1) In the upper right corner, click the "Edit" button
 * 1) Make changes to the commit summary.
 * 1) In the upper right corner, click "Save"
 * 1) In the upper right corner, click "Close"
 * 1) In the upper right corner, click "Publish edit"

Gerrit & Vagrant
MediaWiki-Vagrant is a portable MediaWiki development environment and is readily usable with git-review and gerrit. After installing MediaWiki-Vagrant use  to navigate to your extensions folder. Then follow the instructions above on submitting a patch via gerrit.

How code is reviewed in Gerrit
Code review is an essential part of our contribution workflow. The principle is basic: any patch must be reviewed by others before being merged.

This means that your code will need reviewers. Check our advice for getting reviews.

Review before merge
It's important to us to have a review-before-merge workflow for MediaWiki core and also for any extension we deploy. We will also offer that option to any extension author who wants it for their extension. The one exception is localisation and internationalisation commits, which will be able to be pushed without review.

Who can review? Gerrit project owners
After creating a Developer account, anyone can comment on commits and express criticism and approvals. Anyone can give a nonbinding "+1" to any commit. However, for any given repository ("Gerrit project"), only a small group of people will have the ability to approve code within Gerrit and merge it into the repository. This superapproval is a "+2" even though that's a misleading name, because two +1 approvals DO NOT add up to a +2. These people are "Gerrit project owners".

How to comment on, review, and merge code in Gerrit




誰でもGerritでコードにコメントすることができます.

Viewing and commenting on code
This should only be set if the assignee has agreed. It will report a red or green mark depending on whether the build passes. It'll show up in their Gerrit dashboard. You can double-click on a line and then press the C key to comment on that line, then click "Save" to save the draft comment. Then, at the top of the page click the "Reply" button to publish your comment. These numbers are nonbinding, won't cause merges or rejections, and have no formal effect on the code review. This action removes the diff from the list to review, but leaves it in Gerrit for archival purposes. See T48148 for an example.
 * 開発者アカウントを持っていることを確かめてください.
 * Gerritにログインします. If you know the changeset you want to look at (URL will look like https://gerrit.wikimedia.org/r/#/c/23939/), go to that. Otherwise, use the search box. You can search by author ("Owner"), Gerrit project, branch, changesets you've starred, etc. The Gerrit search documentation covers all of the different search operators you can use.
 * The changeset has a few fields, links and buttons:
 * Assignee. An optional field to make a single person responsible for handling reviewing the changeset.
 * Reviewers. 'jenkins-bot' is the autoreviewer that auto-verifies anything that passes the Jenkins tests.
 * The "Add reviewer" button under Reviewers: in the upper left corner manually request review from someone.
 * Under Files, Expand All opens the diff for each file below.
 * Reply adds your comments to a changeset, including an overall comment and/or inline comments you added (see above).
 * If, upon code review, you approve, use "Code-Review: " under "Reply"; otherwise, use "Code-Review:  " to disapprove.
 * Abandon (you'll see this if you wrote this diff).
 * The "Only Comments" switch allows to hide reviews by non-human bots.

Comparing patch sets
Every time you amend your commit and submit it for review, a new patch set is created. You can compare the different patch sets like this:

On the right of the screen under Patch Set, the latest patch set is preselected. Adjust the selected patch sets to your needs.
 * Under Files, select either Expand All or choose a specific file listed to open that file.
 * On the left side under Patch Set, Base is preselected.

Formally reviewing and merging or rejecting code
If you are one of the Gerrit project owners, you'll also see:


 * Abandon button


 * under Reply, additional Code-Review options to +2 (approve) or -2 (veto) a diff, and a Post button (publish your comment and merge diff into the branch, in 1 step)


 * Submit button (merge -- only useful if you or someone else has already given a +2 approval to the diff, but not merged it)

And once you've merged something into the example Gerrit project you'll see it in https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/examples/.

If you merged a commit that references a task in Phabricator and that commit is supposed to fix that task completely, please go to that task and change its status to "Resolved" (via the Add Action… 🡒 Change Status dropdown). Also reference the merge ID if gerritbot has not already posted it in that task.

トラブルシューティング
問題とその解決方法については、を参照してください.

<span id="See_also">

関連項目
これらのページも有用です：


 * Gerrit チュートリアル tl;dr
 * Gerrit TortoiseGit チュートリアル
 * Wikimedia Gerrit Patch Uploader
 * Gerrit チュートリアル tl;dr
 * Gerrit TortoiseGit チュートリアル
 * Wikimedia Gerrit Patch Uploader