Extension:MobileFrontend/Deployments/2013-05-07

Stories
* https://mingle.corp.wikimedia.org/projects/mobile/cards/425 * Nearby link clicking experience

Bugs
* https://bugzilla.wikimedia.org/show_bug.cgi?id=47597 * [Regression] Read in other languages has disappeared

* https://bugzilla.wikimedia.org/show_bug.cgi?id=48153 * Section level editing surfaced on mobile sites * https://bugzilla.wikimedia.org/show_bug.cgi?id=44959 * Open translatewiki tickets

* https://bugzilla.wikimedia.org/show_bug.cgi?id=31876 * MobileFrontend extension should validate against W3C in Jenkins

* https://bugzilla.wikimedia.org/show_bug.cgi?id=35233 * Mobile sites being indexed by search engines

Uncategorized
* Opera mini header tweaks * Ruby gems update * Move loginCaption and signupCaption * Localization changes * Regression: Make Special:MobileOptions checkboxes work without js * Skin changes * Make Special:MobileMenu work on desktop * Regression: Don't put content_block wrappers in API response * Make css backwards compatible with old html * New script Cachedpage.sh * Allow users to start conversations on talk page (alpha) * Remove conditional for X-CS * Jshint fix * Minerva additions * qunit changes

Git Log
commit 191e4195fdbd3f2af88de4d72a84933e64a05011 Author: jrobson  Date:  Tue May 7 11:51:40 2013 -0700

move loginCaption and signupCaption to correct module the keys are misleading - mf-navigation.js actually uses them Change-Id: Ie7dc4b3fe40c637d3070529d94dcd59b8e884651

commit 4db5edd4aa89aec12bec0e777ccf60e8106f95d4 Author: Zeljko Filipin  Date:  Tue May 7 11:24:38 2013 +0200

Updated parallel_tests Ruby gem Change-Id: I1e0ee297cc28258eb83e67838e24a2af08d44a54

commit 4563e2649d640139a43675a82072cbf29a2aa711 Author: Zeljko Filipin  Date:  Mon May 6 13:30:54 2013 +0200

Updated Ruby gems Change-Id: I382c05caa57858c6d4b4e8829aac925e6a435dec

commit e75f07d15fd64c4f844b096b846f2a282202cb5a Author: jrobson  Date:  Mon May 6 23:13:40 2013 -0700

Opera mini header tweaks Apply hacks to render search box correctly Change-Id: Ib1b96db905de75fce162875e53d4a93fbbc6161a

commit b8c0b83b1307e01023fa76a1c27b13e3566112c9 Author: jrobson  Date:  Mon May 6 15:19:10 2013 -0700

Regression: Make Special:MobileOptions checkboxes work without js   Change-Id: Ib0d0d7ac17821d3e8e94e93efbd0a58bfc571c99

commit ddaaca7c1281fdfd1e12945bdd18637ed7ed1423 Author: Translation updater bot  Date:  Mon May 6 20:21:04 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: Iaee98fe5d616c90ba9f95ac77e69755ea0bd49ff

commit 17692dc21e22fc42df02633ec66697599b942e1e Author: jrobson  Date:  Thu Apr 18 22:54:21 2013 -0700

Upstream skin changes - getLanguageUrls Depends on core change: Related commit: I4a49e704f6fe72c74ecb9103fb081aed93a86de7 This also effects a regression in   Bug: 47597 Change-Id: I04b625c8d76bb6a061e3201847bf97185c6b7a29

commit 91fe7620420c6f56ccecae30293750a65fa13dec Author: jrobson  Date:  Mon Apr 1 16:19:43 2013 -0700

Promote addToBodyAttributes to desktop skin Makes the Special:MobileMenu work on desktop Change-Id: Iaf810fe3251079f1728d2cf4230f1fc60bdeaaab

commit a22e9f1a299a74bcdc089d31984463070b394d0b Author: jrobson  Date:  Mon May 6 10:19:42 2013 -0700

Bug 48153: Remove section edit links Add FIXME note to show why there is the existence of 2 rules for time being Bug: 48153 Change-Id: I46540eff3d01824cd304c10aa3806d17e1fa00d1

commit a7aff19435b7946206cc350e9542909cf8c9f6ba Author: Translation updater bot  Date:  Sun May 5 21:09:29 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I3dfea2cc5c7ff4e53872064af28712ebd1e350c9

commit d7246991c97dfbee708328086b46a360943b5a23 Author: jrobson  Date:  Wed Apr 24 10:56:23 2013 -0700

Story 425: Nearby preview Throwing massive curve ball. Currently it is annoying on the nearby page to click an article link then have to click back to get back to the article. This allows the reader to preview all the articles from the comfort of the nearby page and navigate away when ready. The overlay that shows when clicking on an article shows the lead section text and title with a link to the full article at the top Any tables in the lead section are hidden A user can right click/hold down the link to open it in a new window if they don't like this behaviour Move hacks into mobile.styles as these now apply to overlays in special pages Change-Id: Ifbebdb35cf5c6a758741a41822dd2361f4fa4ccb

commit 0e61e658fa36f4a63c1a3f44d3391a119344224f Author: jrobson  Date:  Sun May 5 11:20:06 2013 +0100

Regression: Don't put content_block wrappers in API response This was introduced in Ic4fffd3cf4ddb558dc966865034dd3398e0bf1fc and shouldn't have been. Change-Id: Iacc45ad3b292e645c84ee2340991fa024e50eb53

commit 4a8a2c890f0bd9ad13adcf9c549f5c0009f29a8c Author: Translation updater bot  Date:  Sat May 4 20:23:43 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I6c258a19cc689a6dc5d5dce2089db1b7eb21d0cd

commit a920dd738b28b731483821329d395e3372c5af54 Author: jrobson  Date:  Fri May 3 23:27:14 2013 +0100

Bug 44959: Change settings label As requested by aharoni Change-Id: Ie802047f2aa3c16b337be7e4fc8f04f421de37c6

commit ab47f93ae0cbdca5c8407260975e1bc535a8d687 Author: jrobson  Date:  Fri May 3 17:31:56 2013 +0100

make css backwards compatible with old html Loading them without this commit shows breakage in the header as   shown in http://imgur.com/vY20Xqf Applying this fix, fixes the cached versions of the page. Added FIXME with suggested removal time (assuming deployment next Tuesday) Change-Id: I4dd7dc95ac8ccfbcbb7fa9296873642d639fd945

commit b32e3d8a947a3e917c1493bb9cfd44d28d000ad2 Author: jrobson  Date:  Fri May 3 20:43:41 2013 +0100

Cachedpage.sh adjustments * Special pages are not effected by html caching so do not bother generate a special cached page * Allow developer to provide a different article other than Main Page via the second argument Change-Id: I7f08008a029506844e6c85a99bc8faf889b1adc6

commit 72245634be3ce9285457afef2bcb236618fedda2 Author: jrobson <jrobson@wikimedia.org> Date:  Tue Apr 30 15:10:26 2013 +0100

Story 425 Nearby: Cache last known location/nearby places Add an additional level of caching to this page so that back button is a little more responsive. Note nearby.js runs at bottom of page so   there is still a slight delay. Lets not make mobile.stable load at top of page just for this.. Change-Id: I458e3ca60c56e25bda65eb4675390b13f4acd91d

commit 34edbbea2a0d470442fffec7ee275b6be581077d Author: jrobson <jrobson@wikimedia.org> Date:  Mon Apr 15 19:21:05 2013 -0700

Alpha: Allow users to start conversations on talk page WIN Introduces: * common .error class styling * Moves preRender and initialize into the render function Change-Id: I4aa6b827e3ee0660dfc0c3b0b8c61dcfe457b12f

commit 7730350f527b2be74e6488a493af525a4472cd34 Author: jrobson <jrobson@wikimedia.org> Date:  Wed May 1 15:24:14 2013 +0100

Bug 31876: Add an html validation test to Makefile This shows we have 3 errors in main namespace and 2 in special namespace. Both appear to be core issues which would be great to fix. Made naming more consistent, moved comment in Makefile to a separate line (jgonera) Bug: 31876 Change-Id: I1414e2fbc71b090e07d4a1073ee3b6f3159f3759

commit 490e085a85b02fa76f9c9362cdc67f11e60f0000 Author: dr0ptp4kt <abaso@wikimedia.org> Date:  Fri May 3 12:00:01 2013 -0700

Remove conditional for X-CS and X-Subdomain check for Vary:. * X-CS and X-Subdomain should be added to Vary: header for 301s, keeping in the spirit of idempotent URLs. Change-Id: Ic830fe37f4ef1372bff0a7d6ac8cb41ff79339cd

commit 131ffe50d1728fb14a71d915bf6dba447c22a8f5 Author: jrobson <jrobson@wikimedia.org> Date:  Fri Apr 19 20:36:45 2013 -0700

[Alpha] Talk: Write the number of talk topics in the talk bubble This gives a sense of the underlying talk page without the user having to go to the talk page. Every time talk page is saved, save a property page_top_level_section_count storing the number of topics Change-Id: I4833a35b121eb4cd1f2e857079cadea6146d30c8

commit f4fe612968aafbc649c3cef8701500fc429b4c87 Author: jrobson <jrobson@wikimedia.org> Date:  Wed May 1 14:37:49 2013 +0100

Add cachedpage.sh to identify potential caching problems Running: ./scripts/cachedpage.sh 5413e645da2067687627b9a9c6a1aee914328a63 Produces cached.html and cached_special.html Added useformat=mobile, otherwise desktop pages are saved (jgonera) Change-Id: Ifb84b8cd2b46f9e92053de12c6ee4749c9814be2

commit e3e9e2529a294325969b7b047ff988833d075649 Author: jrobson <jrobson@wikimedia.org> Date:  Fri May 3 17:58:57 2013 +0100

jshint: fix bad line break make jshint happy Change-Id: I1c475dec02ba399b9a32f6d3fd121bd27466dbd5

commit 9664ee19de98f85902a0f6b230ff761a8f948a37 Author: dr0ptp4kt <abaso@wikimedia.org> Date:  Thu May 2 15:39:59 2013 -0700

Adding X-Subdomain and X-CS to HTTP 301 Vary: header for Zero traffic. * Current Vary header redirect does not include this. * Wrong redirects to [LANG_CODE].m.wikipedia.org may cause unnecessary charges to Zero users. Change-Id: I903d4db7d6e4da09c7ccd7f08d43ac5a59590ee7

commit df947b3059f1dd4ae3ba7862d89800b01074423b Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Thu May 2 20:48:19 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I5484baaa4435dcda4b4984d71bd780db023e6012

commit dc526bd6362189052ddc043a01c853b2fb0fd936 Author: Liangent <liangent@gmail.com> Date:  Thu May 2 13:47:43 2013 +0000

Calculate talk page name correctly for namespaces other than main. Change-Id: Ice5fdcb0469497bfdb807478c73a474ab9649ab0

commit f4b29f2cb1d5b635882945c28fc599d145ba7798 Author: jrobson <jrobson@wikimedia.org> Date:  Fri Apr 12 10:41:36 2013 -0700

Make the universe explode by making a desktop AND mobile skin called Minerva This fills in various functions to make the skin work for desktop as well as mobile On mobile it adds reporttime to allow us to see how long it took for the page to be served To enable: Add $wgValidSkinNames['minerva'] = "Minerva"; to LocalSettings.php This kicks off some work which can lead to consistency between desktop html markup and mobile html markup by beginning to surface the mobile skin on the desktop site o_O To test on desktop apply query string parameter ?useskin=minerva or set $wgDefaultSkin = 'minerva'; Currently desktop skin is just bare bones content with search (uses desktop search javascript) TODO: Make Special:MobileMenu work TODO: Ideally want to use a template engine such as mustache Change-Id: Icfb9e570da7a15ea154ca1377fb245725279146d

commit 8874ac8c3dacc99cb20a78b20413d663f7e94039 Author: jrobson <jrobson@wikimedia.org> Date:  Thu May 2 11:03:11 2013 +0100

Add hashbang to qunit.sh   Change-Id: I2574a8b2d77111108a127eedf719a187356e5003

commit 91bb1dd4d48be8899aeede39bdd5d1aedb442b10 Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Thu May 2 03:57:13 2013 +0400

Rm DeviceDetection::supportsJQuery We now rely on ResourceLoader to decide on this Change-Id: Ia4b2fed70fdff86bd33a04e702a4f18fc10f3b01

commit 7aba4f332e7f744c81ec9e3bff6e78855146e165 Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Wed May 1 20:36:04 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I226a6187ecda4fb66cc6127bd98e50fc6fd8bbf8

commit 2a49b5eed9e289c0c3b0b9c2211d07dace8930cd Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Wed May 1 13:11:24 2013 -0700

Fix file name and description generation in uploads Set a proper time delimiter in file generation and pad months, days, hours and minutes equal to 9 with a 0. Update the function for generating descriptions accordingly (also make   it support old incorrect file names). Change-Id: I51cd99c7e07e19f406ace7c07bd015218e7cd937

commit 9fee75ca5675b26653bdd63123e51add1c48840b Author: jrobson <jrobson@wikimedia.org> Date:  Wed May 1 19:11:30 2013 +0100

Bug 35233: Stop mobile site indexing in google by properly using a canonical url Example #1 of why HTML validation is such a positive thing. Bug: 35233 Change-Id: I1790f38880458588b9ccc5c2d5e0fa67ff00e386

commit eeee0d3a27b23961919c934f144aac47c08e0bf3 Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Fri Apr 26 20:27:03 2013 +0400

Bug 44918: MF part of code that forbids legacy gadgets in mobile view Parent commit: https://gerrit.wikimedia.org/r/#/c/60954/ Bug: 44918 Change-Id: Ibc43852486041b940464310201654e4fa6c53c6e

commit ed69eddc1f22be98aa01386bf886cab361da4516 Author: jrobson <jrobson@wikimedia.org> Date:  Tue Apr 30 12:05:30 2013 +0100

Bug 47857: Deprecate #mw-mf-searchForm, allow search term clearing Previously when typing a search term a cross appeared that allowed you to reset the value. This code seems to have been lying dormant Take opportunity to rename clearlink to more meaningful clear Bug: 47857 Change-Id: Ib3db61be25452c4b3eedb5e54756cfe0d144882a

commit 3dfe2c9425e8e1a6550f1afb16c61253777d8d7f Author: awjrichards <arichards@wikimedia.org> Date:  Tue Apr 30 23:49:05 2013 +0000

Ahem. Revert "Revert "Change remaining #mw-mf-header occurrences to .header"" This reverts commit dd3408381edac77f90ba6163a98d7b91e8087558 Change-Id: Ie33cf2c9fcf0c066ada154f0fc45b3be4507b1d4

commit dd3408381edac77f90ba6163a98d7b91e8087558 Author: awjrichards <arichards@wikimedia.org> Date:  Tue Apr 30 22:28:18 2013 +0000

Revert "Change remaining #mw-mf-header occurrences to .header" This reverts commit 167aeba0d8933cab42d599a8e66fc0c8fc5e7f91 Change-Id: I0492b0c3ab0b06e4f9866f66abd33b98b0230270

commit 179b21d79149d155e8fde2f6c3385bd2c9cff31a Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Tue Apr 30 14:29:08 2013 -0700

Add a comment explaining why SQL's count is not used Change-Id: I672cc659d51c4b2eb702ebdc4d0836d90e1ab000

commit f41fd100c529ca650e9a3e369f7bd3140c2e49a8 Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Tue Apr 30 21:15:53 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I355ac44ba70e674354d5877dd1140321876f386d

commit 7ad5435aa110f33d436698f16d2d28c68ede9441 Author: jrobson <jrobson@wikimedia.org> Date:  Tue Apr 30 14:56:32 2013 +0100

nearby.js: Promise fail, not error This always gets me. Make sure we bind the function correctly so it   runs on an error Change-Id: I600446357db49042362488239b2511a13d7bb477

commit 1a14cb12e14f4c858c87035246e5fe3b85ec0d36 Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Fri Mar 29 17:57:19 2013 +0100

Story 436: Use file name for images with descriptions with templates Modified juliusz's original patchset rather than abandoning it   since we now want a slight variation of this Renders description as filename Minus File: prefix, date and extension. Now avoids unnecessary api call Also addresses: Bug: 45579 Change-Id: Ie1fc7f0591b6312fbdd45d9889895d74b25ded02

commit f8994b399dcb1c01c7b0c6bb3ea8102961123047 Author: jrobson <jrobson@wikimedia.org> Date:  Mon Apr 15 19:18:24 2013 -0700

Alpha: Talk page - allow access to lead section conversation list it as an unnamed discussion Change-Id: Ia4aa2f3560a121d90e65a2eb06daf992efcae8da

commit eeae5bbd78b9812ed412c5a5923eea161d2b7bcb Author: jrobson <jrobson@wikimedia.org> Date:  Mon Apr 29 16:40:12 2013 +0100

Story 477: Only show nearby in menu when supported Change-Id: I106282a302bfdc870b225b85b8b000f65fac4674