User:Jamesmontalvo3/Approved Revs v1.0/Changes

Changes to Master since v1.0 fork
Below are changes to master (on git.wikimedia.org) since the v1.0 fork (on github). These do not include localization updates.

Changes not incorporated

 * SQL Join issues in SQLite?: I could not immediately account for this since the queries on SpecialApprovedRevs changed a lot. Upon initial inspection it looks like I should be able to modify the queries in a similar method as this commit, but I'll need to test it.
 * Fix so that unapprovable pages won't show up in AR lists - patch by Eli Handel: I don't believe in v1.0 this is required because of the way pages are queried. I don't believe unapprovable pages are currently listed. Confirmation needed.

Future Changes
"approvedrevs-permissions": "", "approvedrevs-grandfatheredpages": "", "approvedrevs-grandfathered-description": "", "approvedrevs-approvedfiles": "", "approvedrevs-notlatestfiles": "", "approvedrevs-unapprovedfiles": "", "approvedrevs-grandfatheredfiles": "", "approvedrevs-viewfiles": "", "approvedrevs-historylabel": "", "approvedrevs-approvedfile": "", "approvedrevs-latestfile": "",
 * Deprecate right "approverevisions" (if is set give a warning saying to edit MediaWiki:Approvedrevs-permissions)
 * Possibly make right "viewlinktolatest" handled along with approvability cases (in MediaWiki:Approvedrevs-permissions)
 * If you have approval rights on a page you should be able to view link to latest
 * If you don't have approval rights, could use viewlinktolatest right to give
 * Approved Revs v1.0 added some wfMsg calls that should be replaced by wfMessage. See c3b839 and c7f42f.
 * Need to add v1.0 items to i18n/qqq.json, shown below.

Incorporated Changes

 * Use ResourceLoader to load CSS


 * Call Linker statically (1.19)
 * Changed $article->doPurge to only be called for SMW < 1.9 and SMW code now only called if SMW is installed: These are both incorporated, but I don't understand if this applies to only SMW < 1.9, or simply SMW != 1.9 since it says the bug was fixed in 1.9.1. The if-statement implies anything less than 1.9.
 * Replaced wfMsg calls with wfMessage (finally) (fixed in c7f42f): All these changes incorporated, but ApprovedRevs v1.0 created some
 * Added 'ApprovedRevsPageIsApprovable' hook, via patch from Eli Handel: ApprovedRevs::pageIsApprovable was heavily modified for v1.0. The hook in this commit was incorporated, but I'm not sure what it is for so I can't speak to how well it will work.
 * Changed subtitle for old revisions - patch by Eli Handel: All incorporated, still need to add v1.0 items to qqq.json
 * Fix to not show message for blank page if 'viewlinklatest' is off

Obsolete Changes

 * Fix for display of spaces in history page: I modified structure of history page lines pretty heavily and included CSS classes for better stylizing.