Extension:MobileFrontend/Deployments/2013-03-14

Stories
* https://mingle.corp.wikimedia.org/projects/mobile/cards/141 * Generic banner/notification system

Bugs
* https://bugzilla.wikimedia.org/show_bug.cgi?id=44646 * behavior changed: GettingStarted shows "Looking for more to do" upon null edit

* https://bugzilla.wikimedia.org/show_bug.cgi?id=45742 * Link to CC-by-SA on uploads should go to Creative Commons

* https://bugzilla.wikimedia.org/show_bug.cgi?id=44070 * Dynamically loading SpecialPage ResourceLoader modules causes unnecessary processing on ALL requests * https://bugzilla.wikimedia.org/show_bug.cgi?id=44017 * Leverage browser cache for JS and CSS (separate requests for common and page-specific things)

* https://bugzilla.wikimedia.org/show_bug.cgi?id=44133 * Separate config module which mimics mw.config

* https://bugzilla.wikimedia.org/show_bug.cgi?id=43845 * User should be able to close the menu by clicking anywhere on the white panel, when the left menu is exposed not just on the hamburger

Uncategorized
* Load modules that belong in the head and headItems * Now one click expands the table and another click collapses the table (alpha) * Regression - fix languages (beta) * Refactor diff view to avoid repeating lines * Diff view use background color instead of text color (alpha) * Regression - remove special page style dependency * Regression - fix editing on mobile (beta) * Localization changes * Regression - Initialize photo module on page-loaded event * Style changes * Add donate image tests * Regression - fix margin/padding for language overlay * Show preferred languages at the top of the language selector (alpha) * Updated Cucumber * Updated Ruby Gems * Fix broken tests * Regression - deal with absent wgPhotoUploadAppendToDesc * Never show photo upload button on main page (Discussed in QA Review) * fix infinite spinner on logout (Discussed in QA Review) * Move SkinMobileTemplate to its own file * Reorg css class * Rotate escape overlay arrow for RTL languages * Make png's smaller * Cleanup unused images * Fixed jagged inset shadow * Increase left padding on search input * Make site notice display in mobile configurable * Improve documentation of mf-last-modified module

Git Log
commit b100dfbccea94ed95de5b79794413d2d22f39c7f Author: Translation updater bot  Date:  Thu Mar 14 20:47:50 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: If6e1baa28466c0683e4856003b41dec3af6718cc

commit 6b3dca5f511237f84ea7565b29dda7800681ca00 Author: Translation updater bot  Date:  Wed Mar 13 21:13:25 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I75392171bce9ab8939c9a076d07f950e10cb01ab

commit 72b85ba70c9059c6afe15b2dd8750e769a851cd3 Author: shirayuki  Date:  Sat Mar 9 06:40:09 2013 +0900

Improve documentation of mf-last-modified module Create keys lookup object to allow better grepping Document function Change-Id: I7009cbe7aea33eb4e739827da403bc843de1816a

commit 6eb8065666c774a9118c97d65be44dcf619a1d68 Author: awjrichards  Date:  Wed Mar 13 09:48:40 2013 -0700

Make site notice display in mobile configurable Introduces wgMFEnableSiteNotice, which when set to true, will allow site notices to be rendered in the mobile site. Change-Id: Ib1cad5f167bf7f9ba7f9fe9a5f5b34cda833f37b

commit c9641258d86b10f6d1e0c353c2632b04578edea5 Author: Juliusz Gonera  Date:  Tue Mar 12 21:22:48 2013 -0700

Increase left padding in search input Makes the distance between input's border and text uniform. Also, remove redundant CSS. Change-Id: Id18c8a97681e6f0ed8aa4ebc4ff918144f41b3ae

commit 831d797b26afa1e042d88e39cd8a80dc16cd5722 Author: Juliusz Gonera  Date:  Tue Mar 12 21:07:34 2013 -0700

Fix jagged inset shadow in menu Also, remove unneeded div and make menu text look more vertically centered. https://trello.com/card/menu-inset-shadow-is-not-pixel-perfect/5112b893d0cd43cb370062bd/31 Change-Id: I2e5241655f92b656812ac0ce2155de1cb0f0ad42

commit 739a03d9c5349a6e2307f42aa57d51e2af883c66 Author: Juliusz Gonera  Date:  Tue Mar 12 17:10:00 2013 -0700

Remove unused images Add a script for detecting unused images and move mw.png out of   stylesheets dir, it's not used in CSS. Change-Id: If8a379d7dbb5ebe43ebf1e218143b3e8819b9ff7

commit d3ca9d548bfe7bab345753dc8d55f08d747f4837 Author: Juliusz Gonera  Date:  Tue Mar 12 16:38:55 2013 -0700

PNGCrush all the PNGs Some of them were bigger than they should have been. Change-Id: I161dff03e33f3571690659c84c08fb2e18ced2ef

commit 31ca834cfba78e4409c13ff7aecd0f4f91f5724e Author: Juliusz Gonera  Date:  Tue Mar 12 16:29:10 2013 -0700

Rotate escape overlay arrow for RTL languages Also, delete unused arrow images and pngcrush the one we use. Change-Id: If0358d185331b1954171bbb0b165ea500e44e07f

commit ae692b7b244ae2f183bae3d18bd6dd1b4b17bb35 Author: JGonera  Date:  Tue Mar 12 23:21:30 2013 +0000

Revert "Maintenance: Load minimum possible css / reorg css" This reverts commit 64cd0a0d4ca1c59e19592371623f7b765f162b99 This commit broke the design for the arabic language. The main menu button shows some glitches and escapeOverlay buttons are missing (at least in search). Change-Id: Ia9dc2d9a0e5dcc5bbbb603b7dde8bd926f0c612c

commit 64cd0a0d4ca1c59e19592371623f7b765f162b99 Author: jrobson  Date:  Thu Mar 7 09:10:39 2013 -0800

Maintenance: Load minimum possible css / reorg css The key change this makes is it stops loading unused css for non javascript users. All of css is loaded via javascript as needed * Move css specific to Special:MobileMenu into its own css file * Put all essential css for non-javascript users into ui.css and hamburger.css t(for the left menu) Load all javascript dependant css in javascript * Define mobile.styles.page and put all styles that are not relevant to special pages there * Combine less statements for readability Change-Id: I39d2ced37dde5e6bd2488870918dca2f7600ca6c

commit c0c58a6c580f1a6f35bfb4615f3b404aa56c8ebc Author: Translation updater bot  Date:  Tue Mar 12 21:14:00 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I27467650048b9018bbeeda0b9eaff9bbfbe24d37

commit 3874538349e69b65a45b5975daff372db92b477d Author: jrobson  Date:  Fri Mar 1 16:50:04 2013 -0800

Story 141: Add siteNotice div to skin Allows CentralNotice extension to insert banners Change-Id: I715b6fb534c3d0d41d06c9547b3ef82a70fcb793

commit bf7fc94736f569177eb4805a440908ec3288cf5b Author: Juliusz Gonera  Date:  Thu Mar 7 14:37:57 2013 -0800

Add a generic Drawer view and CtaDrawer This standardizes the drawer we use for CTAs and will be used in the upcoming photo upload CTA commit (Story 343). In future, references could also use a subclass of Drawer (as of now, only the styling is shared). Change-Id: Ice52cf3b288b0f551acd25edc3ec5727c04daf4b

commit 6b699b048eba98d79a4b59f06192fe60c5402879 Author: Juliusz Gonera  Date:  Mon Mar 11 18:52:40 2013 -0700

Bug 43845: Close main menu after tapping the content Bug: 43845 Change-Id: Ie511d566046e661fb3bddfb4aa7c5bdacbd28c97

commit ed9909c7073be4c6a7036cb1cbeda5e317aca4f4 Author: jrobson  Date:  Mon Mar 11 17:09:51 2013 -0500

put css before js   make sure the css doesn't get blocked by javascript loads... Change-Id: I04fa6b1baf56b6d7c6709f1e43334f58843684a3

commit 60f55205e535738c892ee4e0a9f2596fc5dc5e04 Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Mon Mar 11 20:31:30 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I6ff9056b91b4cced61c6eba37a87499c1b540c2e

commit 6a1a919c0e4339db8b00d81f0cedec21053ba15f Author: jrobson <jrobson@wikimedia.org> Date:  Fri Mar 8 12:16:06 2013 -0600

Cleanup: Move SkinMobileTemplate into its own file this keeps confusing me. Change-Id: If7a5c7b6d7342e356a6abf015c3fb9d127c606f5

commit db34a9ad7bd12e5cc4239052662183771ced98a6 Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Mon Mar 11 13:08:48 2013 -0700

Check for EventLogging presence in userlogin.js hack This fixes infinite spinner on logout page for instances without EventLogging. Change-Id: I48c34f04092cd11b03a30d36ee7a8669c65d8493

commit 90eafa3d0f8a57f0418cc0011926315168ea00ed Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Mon Mar 11 13:05:49 2013 -0700

Make sure we never show photo upload button on main page As discussed during QA review. Change-Id: I2329e67b54d4beca4c0a42bf30f0364c0f9b8079

commit ac307626a972348390bdc534493de33944999e59 Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Sun Mar 10 21:35:52 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I987aa4e0fd7c33a93b562f9cf5c4fa343c94ed60

commit 25986027a1a73060cebca051a6f8c9fd9f786538 Author: jrobson <jrobson@wikimedia.org> Date:  Fri Mar 8 14:04:06 2013 -0600

Regression: Deal with absent wgPhotoUploadAppendToDesc Photo uploads broken when not defined Change-Id: Ia466158fcb1dc64154cd164cfd9f7800a018bd77

commit 5a06b6b7c923044edbe3fb77b4149524ba09870e Author: jrobson <jrobson@wikimedia.org> Date:  Fri Mar 8 13:26:41 2013 -0600

Regression: Fix broken tests Not sure how these past jenkins! Change-Id: I8efc1de415f3ec5754c654b0c615af5a029b4e66

commit dae46e7ae68192f0cb95fac687b74af0b9117163 Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Mon Mar 4 16:25:29 2013 -0800

Various fixes to overlay header code Mainly CSS, fixes broken language search input, also: * replaces non-existent message with the correct one * uses mw.msg instead of M.message * removes options.locked in createOverlay (unused) Change-Id: I3ffb4643f91b1d4ee3c6d57014a8dc7736a97a2f

commit 9fdec02c2a54129c0886ce58e15ec5802682af09 Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Fri Mar 8 17:05:40 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I97802e2b9297717a13c2ec064e927dd8f95c49f5

commit 6d2c824e7f078581967428ffee32eaf6ddf053f1 Author: shirayuki <shirayuking@gmail.com> Date:  Fri Mar 8 21:33:26 2013 +0900

American spelling - unrecognized (debug message) Change-Id: I383d7dfa17f644a56033846cfa441144c3b9538c

commit 7d8996c23c1b6478c18a66828cad531efe41653b Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date:  Fri Mar 8 13:23:52 2013 +0100

Updated Cucumber Ruby gem Change-Id: Ie7c96f9021ae5468ae7bc15f74f9efac7baa6ae0

commit 01ba7c3f42dd37f26aaa528b89c97e377b74dbbf Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date:  Wed Mar 6 12:49:52 2013 +0100

Updated Ruby gems Change-Id: Ib9b8da4bb380c9d96adb27f1c090cb30ce36c56b

commit 14793c3b57f190e77acaa898642ba0b952ae7822 Author: jrobson <jrobson@wikimedia.org> Date:  Wed Feb 13 16:46:30 2013 -0800

alpha: show preferred languages at top of language selector based on tracked chosen languages position the most widely used ones at the top and make them bold and slightly bigger Change-Id: Ifa3d7c80e30c9662a3876d9816e3c68c3c01a844

commit 63a6b8aa2c73e308fb7021d0f6296a54bfa2c544 Author: awjrichards <arichards@wikimedia.org> Date:  Fri Mar 8 11:22:05 2013 +0100

Fix comment to reference CentralAuth, rather than CentralNotice Change-Id: I835681d9f0430736206b869b90cdaa1b0359b150

commit 96d6b48224a1aacf737bc24ebe578cf9fc4121e5 Author: jrobson <jrobson@wikimedia.org> Date:  Mon Mar 4 17:31:15 2013 -0800

Regression: fix margin/padding on input in header for language overlay Clicking language opens an overlay where the input currently spills out the page Change-Id: I6ec10127d536a9b83f6df2d49de06eb8a2615203

commit 963cd0ed58d49ee10558459720d207aa2782ddcb Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Thu Mar 7 21:55:11 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: Ib14b370a9557af868985e44600c014db10d0c501

commit 80d51fc1c8cbde47eac8dd7af818a9b88e591503 Author: jrobson <jrobson@wikimedia.org> Date:  Thu Mar 7 12:50:12 2013 -0800

Testing: Add donate image tests For some reason these were not added meaning certain written tests were not being run. Change-Id: Ic180aec96ee6fb91574e674b7c14892204853d4c

commit d764bc2e942e145429ef8def40dde7336e06d1ac Author: jrobson <jrobson@wikimedia.org> Date:  Thu Feb 28 18:32:27 2013 -0800

Bug 44133: Deprecate mwMobileFrontendConfig and setConfig, getConfig use mediawiki core equivalents add new config variables where missing On dynamic page loads for time being update certain config variables (in future a current page object might be used instead) document and tweak getArticleUrl and use it where necessary rather than resorting to config variables Change-Id: I5b2b58140d46bd1f2e0407328b8bab8bce4d1680

commit fc63fc77d455f06f01911917bbfce719cfe9d932 Author: jrobson <jrobson@wikimedia.org> Date:  Wed Mar 6 17:31:19 2013 -0800

Bug 44017: Cleanup ResourceLoader mess add groups to ensure bottom scripts get loaded in their groups (allows   us to separate special page js from normal js) stylesheets/modules/mf-cleanuptemplates.css was being loaded twice make mobile.styles be added automatically mobile.action.edit was being loaded twice. Doh. Addresses bug 44017 in proces Change-Id: I688128038a2e9366a4dca4bdf52dcbfcc548c0e0

commit 6c09b87fe5cb06ce858cdda419dd0cf638dc1d32 Author: jrobson <jrobson@wikimedia.org> Date:  Wed Mar 6 15:50:57 2013 -0800

Cleanup: Remove unused css Change-Id: I68331863c420d7d981fb07dff6d932d44906ed86

commit e6cb251b0292b987804bdb654862b59f9c06e2c9 Author: jrobson <jrobson@wikimedia.org> Date:  Wed Mar 6 11:47:27 2013 -0800

Regression: Initialise photo module on page-loaded event only where available Makes photo uploader show on articles in beta Change-Id: I02d8142f9428f2d07cd7d1751e7fe5861b86e4d6

commit e0c04d5efeaf9f23ae6677870eb9f26b81a5c9ea Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Wed Mar 6 21:53:38 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: Ic26f46ec53fe17ee0c4466e17ea93c176c7c206c

commit 7317544632d48216fcd4698fccd1b5cd50dc9d81 Author: jrobson <jrobson@wikimedia.org> Date:  Wed Mar 6 13:50:51 2013 -0800

Regression: Make editing work again on mobile beta Change-Id: I42be459c78ea05fad9d24bfabd37f18743f41050

commit 9939a45ff270146df51f20db97d17eac0962ac05 Author: jrobson <jrobson@wikimedia.org> Date:  Wed Mar 6 13:40:39 2013 -0800

Regression: Remove special page style dependency The dependency on style modules forces javascript to load earlier than it should Also add missing watchlist script module Change-Id: I9056d2352015ef010eeb0c618200b2820483f00f

commit 472a042f7cc130b20a34c7d8088402976cce4206 Author: jrobson <jrobson@wikimedia.org> Date:  Thu Feb 28 11:02:13 2013 -0800

alpha: diff view use background color rather than text color arguably I find this more readable patchset 2: made the colors a bit lighter (jgonera) Change-Id: If70c897e5cad55cb0154a16785e81d7849fea087

commit e3da3f85dbf5d360a58c14a1dee156568ef827df Author: jrobson <jrobson@wikimedia.org> Date:  Thu Feb 28 11:00:36 2013 -0800

Improvement to diff view Avoid repeating lines by not targetting del or ins elements Use css3 pseudo element to add + and - value Change-Id: I849254201df5bd2062cd3fd921e6b2b97537d4f6

commit 99d9a23798b553684d7de04ff2f077e6dfd07efc Author: jrobson <jrobson@wikimedia.org> Date:  Tue Mar 5 10:20:57 2013 -0800

Bug 44070: Define special page modules manually Doing so dynamically makes our code harder to read and causes unnecessary processing. Reverting back to manual definitions Change-Id: I51bf514c56ebfc459685fcacee822fdab8dc7ce2

commit 6a09599403b31c9ccc05a736d878be9914553108 Author: Reedy <reedy@wikimedia.org> Date:  Tue Mar 5 19:27:31 2013 +0000

Bug 45742 - Link to CC-by-SA on uploads should go to Creative Commons Change-Id: Ia4bd66c4340ddc6fe6ac6c49eca592d849e46852

commit 83c0074f1cfff97a45439367e4462c69e7c9550a Author: jrobson <jrobson@wikimedia.org> Date:  Mon Mar 4 14:26:39 2013 -0800

Regression: Make languages work again on beta Moving dynamic page loads from beta to alpha reveals a problem in   code Also make the languages button show when only one language is   present (assume that the current language is not in that list) Change-Id: I344ec10e04e93de14f7a2798104b59181e8e5205

commit 0c72289793905e9e9792d198884a02d53118738a Author: jrobson <jrobson@wikimedia.org> Date:  Mon Mar 4 16:05:20 2013 -0800

Bug 44646: Standardise login and account creation forms Make them use the same css, tweak css (Munaf approved) Change-Id: I7f799a913d603f309507820ce850d7ef14a05d33

commit a28da03a69252a1e4076701b4248395c2cfc45e9 Author: jrobson <jrobson@wikimedia.org> Date:  Tue Feb 26 09:59:36 2013 -0800

alpha: slight tweak to tables now one click expands the table, clicking again collapses it again using css transforms to avoid using another image Change-Id: I61bc9bb22b958f840a04ebc31811869f0d8e931e

commit 230e8282929fb1e5cfd4f019e40d0170ddfdf32f Author: jrobson <jrobson@wikimedia.org> Date:  Fri Mar 1 15:51:54 2013 -0800

RL: Correctly load modules that belong in the head and headItems We were not doing this previously Some extensions add head items that we currently do not surface Change-Id: Ic8b65b2f602e36f47a492f7660240cd7920e7402