User:Pragunbhutani/GSoC 2013/Implementation Approaches

This page is created for the purpose of documenting and discussing implementation approaches with the community.

Factor getHtmlForClaims out of EntityView
The idea is to factor the getHtmlForClaims part of entity view into a class of its own. This would allow it to be used in EntityView and also in mobile skins intended to make Wikidata mobile friendly (https://bugzilla.wikimedia.org/show_bug.cgi?id=43065).

Update: The bug has been assigned to me and listed as a dependency for BUG 40885.

The getHtmlForClaims calls getHtmlForClaim, which could be placed into a separate class. Since claims are one of the things that are broken on Mobile Wikidata right now, doing this should allow us to use the class in the new skin that I'll be developing for Wikidata Mobile.

I'm also in favor of re-naming getHtmlForClaims to something like claimGenerator because the current naming is very confusing. (getHtmlForClaims and getHtmlForClaim)

Feedback
Please add your feedback below:

UI Mockup v1
I've created the first UI mockup for how Wikidata Mobile should look. Please forgive the use of pencil and paper, I feel a little more comfortable using those. I've tried to keep the look consistent with how Wikipedia Mobile looks so that it's easy to adapt to.

Here are a few points of discussion that I feel could benefit from community feedback. Please feel free to add more should you discover any.
 * Each individual statement is 'closed' when the page is opened and slides down to reveal content when the arrow is clicked. Upon clicking the arrow gets reversed so that you can close it again. Would it be better to leave them all open perhaps?
 * Clicking on a statement text, e.g., 'country' should lead to the item page for country. I'm concerned that some users might get confused and expect that touching on it should slide down to reveal content of that statement.
 * The placement of [edit], [add source] etc. could be reconsidered.
 * The shades of grey used correspond to those used on the desktop site.

Feedback
Please add your feedback below:

UI Mockup v2
Based on some feedback by Denny on the IRC (#wikimedia-wikidata) I've made some changes to v1.

Here's a list of changes made:
 * Tabs in 'Also known as' section removed. The values are now shown as text separated by commas.
 * Preview of values shown in each statement. In case of overflow in value, the statement is terminated by an ellipsis.
 * Upon expanding a particular statement, the preview is removed and all values + sources/qualifiers are shown.
 * All the [add], [edit] etc. for labels AND statements have been aligned.

Feedback
Please add your feedback below: