MediaWiki 1.25/wmf13/Changelog

Core changes

 * - Update EventLogging for cherry-picks
 * - Update WikimediaEvents for cherry-picks
 * - Update CentralAuth
 * - Export mw.Message's string formatter as mw.format
 * - Update MobileFrontend
 * - Update CentralAuth
 * - Update Echo to bring a test fix
 * - Remove silly debug line
 * - Bump MF and Mantle
 * - Update Scribunto to 1.25wmf13 HEAD
 * - Update MobileFrontend and WikiGrok
 * - Update CentralAuth
 * - Update AbuseFilter to 1.25wmf13 HEAD
 * - WikiGrok: https://gerrit.wikimedia.org/r/#/c/183186/
 * - Update EventLogging for cherry-picks
 * - Update WikiGrok
 * - Update EventLogging for cherry-picks
 * - Update MobileFrontend
 * - Update VisualEditor for cherry-pick
 * - Update MobileFrontend
 * - Update WikimediaMessages, adds wikibase-otherprojects-wikidata
 * - Bump MoodBar for bug fixes related to jQuery upgrade
 * - Set $wgInternalTidy to false in unit tests when running under HHVM
 * - Update Wikidata
 * - Update VisualEditor for I0332a98
 * - Update PageTriage with easy JS fix
 * - update CentralNotice submodule
 * - Bump PageTriage for breaking issue due to jQuery live
 * - jquery.tipsy: Unbreak the 'live' option for now
 * - Bump MF
 * - Update VE and MF for T78710
 * - Update test.wikidata, fix Special:NewItem/Property and SetSiteLink
 * - Bump Flow to hide input boxes on preview and add metadata to API responses
 * - Revert &quot;Simplify MWTidy&quot;
 * - xhprof: backport section profiler fixes
 * - Skip ApiFormatWddxTest under HHVM
 * - Bump Flow for user right to create new boards
 * - Bump VisualEditor for I0739e71
 * - SECURITY: Fix CORS origin matching in the API
 * - thumb.php: Set proper output formats for messages going into HTML
 * - Simplify JsonContent::beautifyJSON
 * - Remove $wgJavaScriptTestConfig
 * - Logging related comment updates
 * - Update OOjs UI to v0.6.0 in composer.json too
 * - Update OOjs UI to v0.6.0
 * - Move Test files under same folder structure where class is (/includes/)
 * - Destroy session after running api tests
 * - Move advanced search inputs back into the form
 * - Minor clean up of release notes
 * - Update RELEASE-NOTES for wikimedia/cdb package rename
 * - Deprecate wfErrorLog
 * - Create a generic UDP transport class
 * - Normalize &quot;\r&quot; newlines in preSaveTransform
 * - Fixing wikitable border formatting in shared.css
 * - EditPage: Don't warn if the page already redirects to itself
 * - Skin: handle invalid titles gracefully
 * - MessageCache: Improve GlobalTitleFail log message
 * - Fix prefix search for special pages
 * - Followup cf5f641: pass $params by reference again
 * - Add better error message for files which exceeds $wgMaxImageArea
 * - SpecialBlockList: Remove unused message 'infiniteblock' in formatValue
 * - Add findVariantLink to StubUserLang
 * - Escape parentheses message on watchlist pages
 * - Explaining why user groups are sometimes returned by getRestrictions
 * - Correct documentation for $wgResourceModuleSkinStyles
 * - Minor spelling comment fix
 * - LocalisationCache: Use file_get_contents instead of DOMDocument::load
 * - Made StashEdit log a bit less verbose
 * - Convert more wfRunHooks --&gt; Hooks::run
 * - GlobalFunctions: Fix 'Undefined index' notice in wfBacktrace
 * - Special pages: Change some wfMessage to $this-&gt;msg
 * - resources: Switch OOjs UI from the 'Apex' to the 'MediaWiki' theme
 * - Resources: Split oojs-ui module styling into oojs-ui.styles
 * - Add dependency upon oojs/ui's PHP port
 * - Guard against empty integerPart in Language::commafy
 * - Do not require that a Monolog handler has a formatter
 * - Update OOjs UI to v0.5.0
 * - Pass config to UsercreateTemplate/UserloginTemplate
 * - Check hasTitle in RequestContext::setWikiPage
 * - Log to DBPerformance when queries affect many rows
 * - Always set a title on images when provided
 * - Add more context to globaltitlefail logs
 * - Typo fixes and non-code tweaks
 * - Apply coding conventions for JavaScript
 * - mw.loader: Guard against Object.prototype keys as module names
 * - Fix case insensitive string comparison for http header names
 * - Avoid blocking on ChronologyProtecter check in LoadBalancer::getConnection
 * - composer.json: Update issues link to point to bugs.mediawiki.org
 * - Fix ProfilerStandard sorting and a profile error
 * - Fix parenthesis placement in multi-line condition
 * - Enforce spaces around magic links (RFC, PMID, and ISBN).
 * - Stash edit when user idles
 * - ResourceLoaderImageModule: Allow use on mobile
 * - Fix check for function wddx_deserialize in tests for hhvm
 * - Fix type hint to match php docs
 * - Language: wfRunHooks --&gt; Hooks::run
 * - Replace wfRunHooks calls with direct Hooks::run calls
 * - Adding aliases for speacial pages in Hebrew
 * - Cleaned up LoadBalancer::getConnection
 * - Remove obsolete note from Title-&gt;canExist
 * - Revert &quot;SECURITY: Do not show log action if revdeleted&quot; and fix UI message
 * - Update README from README
 * - Get to the point about howto download Vector :p
 * - API edit: allow ConfirmEdit to use the merged parse
 * - Removed some unnecessary code in LocalFileDeleteBatch
 * - Removed some unnecessary code in LocalFileDeleteBatch

Vendor

 * - Update OOjs UI to v0.6.0

AbuseFilter

 * - Add file_size variable

CentralAuth

 * - Try to verify emails before testing passwords
 * - Only test passwords once in CentralAuthUser::prepareMigration
 * - Reduce Password object creations needed for an account merge
 * - LocalUserMergeJob: Don't continually create User objects for the same user

CommonsMetadata

 * - Replace unneeded empty calls
 * - Make sure spaces in CC license shortnames are handled correctly

ContentTranslation

 * - Remove a slash from the end of default $wgContentTranslationSiteTemplates['cx']
 * - Optimize the dropdown.svg using svgo
 * - Styling adjustments for the new translation dialog
 * - Source selector: Add input event for validation and warning
 * - Adjust styling for red interlanguage link dialog
 * - Source Selector: Set default languages
 * - If autosave is possible, do not show the page unload prompt
 * - Do not adapt links and references if they are restored from draft
 * - Entry point: New translation from MyContributions page
 * - Update composer.json
 * - Links: Fix bug with links from user text
 * - Publishing: Fix publishing button disappearing on publish
 * - Preserve translation selection when clicking source link

DonationInterface

 * - Revert &quot;Prevent double clicks on gc cc forms&quot;
 * - i18n the remaining State fields
 * - (FR #2288) Improved i18n for Canada
 * - (FR #2288) Use i18n for State field label
 * - Clean up a little logspam
 * - Prevent double clicks on gc cc forms

Echo

 * - Fix EchoTitleLocalCacheTest::testGet corner case

EventLogging

 * - Use navigator.sendBeacon if available
 * - Correct events to send schema name
 * - Refactor ext.eventLogging.core.js
 * - Disallow moving Schema pages
 * - Revert &quot;Do not attempt to validate schema titles&quot;
 * - Only allow [a-zA-Z0-9_-]{1,63} as table names
 * - Make tests' event capsule flag clientValidated as boolean
 * - Replace use of wfErrorLog with MWLoggerLegacyLogger::emit

FlaggedRevs

 * - Don't set review flag if it wasn't in the query parameters
 * - Use Title provided by context in MakeGlobalVariablesScript hook

Flow

 * - Add commit metadata to api response and flag for metadataonly
 * - Hide inputs on preview
 * - Create user right for creating flow boards
 * - QA: Then statements with no assertions turned to Whens
 * - Recompile Handlebars to fix discrepancy
 * - Don't pass along schema as an EventLogging argument
 * - Workflow no longer stores any user information
 * - Dont output base hrefs
 * - Clicking reply link should focus the text area
 * - Allow subpage conversion under limited circumstances
 * - Bug: Incorrectly handling reverse pagination
 * - Perf: Dont process post content when formatting recentchanges
 * - Stop recording special pages into pagelinks
 * - Friendly error message for invalid page within NS_TOPIC
 * - Gracefully handle non-ascii hrefs in redlinker
 * - Update ConfirmEdit integration to match master

Interwiki

 * - Guard dereference of iwPrefix['iw_trans'] and iwPrefix['iw_local']

JsonConfig

 * - Fixed 'continue' API warning

Mantle

 * - Implement in View a declarative event map for DOM events

MassMessage

 * - Only mark edits as a bot in User talk namespace

MobileApp

 * - Tweak styling of collapsed infoboxes.

MobileFrontend

 * - Hygiene: Only omit warning messages on LoginForm
 * - Make WikiGrok v B support multiple campaigns at the same time
 * - Conform to schema
 * - Stubbing skins.minerva.icons.images to prevent errors in wmf13 and wmf14
 * - Allow query string overrides even when user isn't in sample
 * - Throttling WikiGrok to 16% of users for upcoming reader test
 * - Don't cache strictEqual and deepEqual - causing errors with QUnit
 * - Make WikiGrok Roulette preload the next page
 * - Hygiene: Load icons from correct place
 * - Fix for header covering edit pencil in alpha
 * - Don't show duplicate messages in LoginForm
 * - Hygiene: Disable Save button on TalkSectionAddOverlay while no content
 * - Provide a possibility to skip preview in mobile frontend
 * - Hygiene: Remove unused method.
 * - Hygiene: Make it possible for alpha to reimplement personal urls
 * - Change navigation easing function
 * - Make WikiGrok not depend on WikiData API
 * - Enable user profile on desktop.
 * - Changing 'items' to 'information' per aharoni suggestion
 * - Hygiene: prep work for collections work
 * - Documentation: Fix typos and remove an unsupported tag.
 * - Refactor: Introduce and use Skin for loading wide screen modules
 * - Hygiene: Remove Skin.js erroneously added
 * - Hygiene: Remove need for #notifications element
 * - Hygiene: Introduce util module
 * - Make use of DatabaseBase::selectRowCount in MobileUserInfo
 * - Hygiene: Add namespaceNumber for getCurrentPage
 * - Polish: make log out button on boundary square
 * - Remove outline on overlay buttons
 * - Hygiene: Remove mw-ui-block modifier from anchor links in ctaDrawer
 * - Hygiene: Use Config object for global configuration vars
 * - Hygiene: Enforce capitalizedNativeCase for types in jscs
 * - Hygiene: Remove log method from mw.mobileFrontend object
 * - Hygiene: Introduce MobileWebClickTracking
 * - Hygiene: Introduce SchemaMobileWebEditing for editing EventLogging
 * - Hygiene: Use Schema for wikigrok event logging
 * - Hygiene: Make inNamespace a method of Page
 * - Hygiene: Nit picks to ErrorReportOverlay
 * - Error reporting interface for alpha
 * - Run 'this page has issues' on category pages
 * - Hygiene: Introduce SchemaMobileWebUploads
 * - Hygiene: Introduce Schema class
 * - Fix notification overlay back behaviour
 * - Fix naming issue to restore ability to switch between editors
 * - Fix image pinch zoom
 * - Update WikiGrok about text
 * - Hygiene: Add missing doc for Watchstar.events
 * - Hygiene: Fix jsdoc errors
 * - Hygiene: Remove unused active property
 * - Standarize jsdoc param types
 * - Hygiene: Move tagButton code into a template
 * - Add jscsc rule &quot;disallowImplicitTypeConversion&quot; and fix existing errors
 * - Hygiene: Enforce documentation of function parameters
 * - Login form tweaks
 * - Hygiene: Remove unnecessary uses of getTokenWithEndpoint
 * - Remove unused test
 * - Hygiene: Use group as a parameter to phpunit
 * - Load correct page actions images
 * - Use ResourceLoaderImage module in MobileFrontend
 * - Refactor Watchstar view to use events map with View
 * - PhotoUploaderButton uses events map
 * - TableOfContents uses events map
 * - Hygiene: Fix add of no-position-fixed
 * - Hygiene: Move &quot;Return to $1 page&quot; to footer
 * - Hygiene: Remove dead code
 * - Add WikiGrok response badges for wg-sidebar
 * - Hygiene: Organise our long list of globals
 * - Make infobox experiment configurable.
 * - Tweaks to login and sign up form in alpha
 * - Hygiene: Generalise instance of field for infobox generation to allow configuration
 * - Hygiene: Prevent JS error - anchors don't necessarily have an HREF
 * - Redo VE toolbar styling
 * - Remove console.log and fixed a couple of jsduck errors
 * - Remove unused variable
 * - Restore main menu animations
 * - Close main menu before showing wikigrok roulette error
 * - Promote auto toggle to stable.
 * - Hygiene: Kill closeOnBack property and OverlayManager FIXMEs
 * - Hygiene: Remove unnecessary overlay code / address FIXME
 * - Hygiene: Rename _save to onSaveBegin and _prepareForSave to onStageChanges
 * - Fix footer on special pages where there is no last modified bar
 * - Don't add VisualEditor related modules if VE isn't installed
 * - Hygiene: Rename misleading onSave name
 * - Hygiene: Make _hasChanged public
 * - Fix jsduck warnings on WikiDataApi (inheritdoc)
 * - Require MW_INSTALL_PATH in both makefile and gruntfile
 * - Hygiene: Make instance of property id configurable
 * - Hygiene: phpdoc comments, unused variables
 * - Alpha: WikiGrok in sidebar
 * - Memoize results of the browser.js methods.
 * - Don't (implicitly) parse the &quot;editsectionhint&quot; message
 * - Prevent asynchronous event logging events in qunit tests
 * - Hygiene: check types are valid in jsdocs
 * - Minor updates to VE integration code
 * - Hygiene: Move anonymousEditing config to EditorOptions
 * - Hygiene: check return types
 * - Fixes to neglected Mobile upload interface (for 3rd parties)
 * - Hygiene: Move file upload support detection to browser.js
 * - Hygiene: Remove redundant returns
 * - Hygiene: Kill dead code
 * - Remove images from infoboxes
 * - i18n/Hygiene: Use Wikibase for infobox labels
 * - Infobox description editing
 * - Making WikiGrok pull property ID and name from new campaign data
 * - VisualEditorOverlay: Update for Idc299e23 in OOUI
 * - Remove old b/c code not needed since late summer
 * - Ensure file page mobile views have the proper title in context
 * - Move M.isIos to browser.js
 * - Hygiene: jscs should check return types
 * - Correct RL targets for site module and user module
 * - Remove unnecessary rule to fix issues overlay rendering
 * - Fix MW_INSTALL_PATH to default to local installation
 * - Fix MobileWebClickTracking documentation errors
 * - Add missing word to parameter description
 * - Remove jscsdoc objective
 * - Let PHP check, if the user can edit a page or not
 * - Combine two seperate .jscsrc files into one.
 * - Hygiene: Document PhotoUploaderButton.js
 * - Hygiene: Update editor, mediaviewer, talk, tutorials, and watchstar
 * - Hygiene: Complete documentation for logging schemas, Api and Icon
 * - Hygiene: Add documentation for PhotoApi
 * - Hygiene: Photo upload overlay documentation
 * - Hygiene: Update WikiGrok and specials/nearby documentation
 * - Expose Wikidata descriptions via mobileview
 * - Give editor an empty label to prevent rendering bug
 * - Hygiene: Update search, talk, and TOC documentation
 * - Hygiene: Update uploads and watchstar documentation
 * - Hygiene: Update editor documentation
 * - QA: update locator for talk button
 * - QA: watchlist icon is no longer a link but a span
 * - Hygiene: Update notifications, preferred languages, and references documentation
 * - Rename caller of '_prepareToSave'
 * - Hygiene: Update mediaviewer, mobile redirect, and nearby documentation
 * - Hygiene: Update documentation
 * - Hygiene: Remove redundant include in uploads
 * - Hygiene: Fix incorrect documentation in PageList
 * - Fix structure suite
 * - Followup Ia6bf604c, I431a9025: Update way VE target is constructed
 * - Revert &quot;Load correct page actions images&quot;
 * - Serve description even if the wiki data item has no instance of claims
 * - Hygiene: Update lastEdited documentation
 * - Avoid GlobalTitleFail in SkinMinerva::getHistoryLink
 * - Don't show page issues link, when no page issues on the page
 * - Polish: Fade in and out the search overlay
 * - Redoing how mobile handles tables
 * - Hygiene: Move class name generation to browser.js
 * - Hygiene: Move lockViewport to Browser.js
 * - Don't enable search enhancement on Android 2
 * - Fix borders in main menu hover
 * - Hide the Nearby main menu button correctly
 * - Flag to disable main page transformations
 * - Hygiene: Introduce Browser.js
 * - Load correct page actions images
 * - Restyle/reposition page issues in alpha
 * - Clean qunit coverage reports in `make clean` method in Makefile
 * - Hygiene: Adding documentation and prettifying some code in EditorOverlay
 * - Fix unneeded Watched api call
 * - Put description below title
 * - Give a better error message for blocked users trying to edit
 * - Restyle/reposition page actions
 * - Hygiene: Refactor secondary actions generation
 * - Hide hat notes on mobile
 * - Minerva friendly version of Special:Preferences
 * - Hygiene: Document methods in uploads folder
 * - Make sure page images get shown on next page of watchlist
 * - Remove waiting when close Overlay
 * - Fix php notice
 * - Infoboxes: Expose images and wikidata urls
 * - Hygiene: Refactor wikiGrokCampaigns code
 * - Alpha experiment: Replace search bar with branding and icon
 * - Do not show donate button when enabled on special pages
 * - Hygiene: inheritdoc for AbuseFilterPanel methods
 * - useFileCache hook must be prefixed with the correct class
 * - Hygiene: Documentation for nearby code
 * - Don't generate qunit test coverage on every commit
 * - Hygiene: Documentation fixups - inherited methods and ignored methods
 * - Hygiene: Document VisualEditorOverlay
 * - Hygiene: Fix up documentation
 * - Make sure a campaign exists before rendering WikiGrokDialog
 * - Fix Schema errors
 * - Fix undefined index warning
 * - Hygiene: Fix phpcs complaints in hooks
 * - Hygiene: Some upload documentation
 * - Alpha: move lastmodified to bottom of article
 * - Hygiene: Document EditorOverlay and EditorOverlayBase
 * - Hygiene: Refactor EditorOverlay's templates
 * - Documentation for SearchApi
 * - Regression: Fix search in language overlay
 * - Hygiene: Document issues JavaScript
 * - Documentation and QUnit coverage for LanguageOverlay
 * - Use correct API parameter to avoid search JS exceptions
 * - Fixing query string override for loading WikiGrok on en.wiki
 * - Hygiene: Fix JSDuck warnings
 * - Hygiene: Update `make jsduck` dependencies
 * - Regression: Restore this page has issues
 * - QA: no_javascript view no longer has watchlist or Log inavailable
 * - Hygiene: Use a better way to add Main menu sitelinks
 * - Fix the preview header when switching from VE to wikitext
 * - Hygiene: Make uploads page agnostic about current skin
 * - EventLogging: break up MobileWebClickTracking

MoodBar

 * - Fix dashboard links that are visible on hover
 * - Stop using jQuery.live

MultimediaViewer

 * - Log Last-Modified header in performance logger
 * - QA: WIP update tests for RSpec3 syntax etc.

PageTriage

 * - Fix PageTriage JS dialog parameter
 * - Replace .live function calls with .on

Scribunto

 * - Pass the title's fragment to getExpensiveData
 * - Don't attempt to parse non-Modules in the console
 * - Record a link to pages looked up by ID

SecurePoll

 * - Don't skip key import on the second call to SecurePoll_GpgCrypt::decrypt
 * - Avoid holding many open DB connections
 * - Edit translations for all jump wikis on central wiki

Thanks

 * - Match changed MobileWebClickingSchema

Translate

 * - Fixing some white space errors
 * - Revert &quot;Request csrf tokens in JS when supported&quot;

UniversalLanguageSelector

 * - Update from upstream jquery.uls

UploadWizard

 * - Further refactor of location fields
 * - Move some upload step UI stuff out of ui.Wizard
 * - Remove references to upload in FirefoggTransport
 * - Replace Firefogg callbacks with OOJS events
 * - Remove upload object from FDT
 * - Replace FDT callbacks with OOJS events
 * - Move some details UI stuff out of the Wizard UI
 * - Replace IframeTransport callbacks with OOJS events
 * - Replace hash characters in basename
 * - Add plural support to mwe-upwiz-campaign-media-count-desc
 * - Fix Flickr import bug due to change in newUpload
 * - QA: adjust spacing in steps and feature
 * - Reset progress bar on wizard reset due to removal
 * - Gate a bunch of state changes for aborted files

VisualEditor

 * - Update setupToolbar signature in mobile target
 * - Update VE core submodule to wmf/1.25wmf13 for cherry-pick (34f4110)
 * - Fix Ia6bf604c: Update another caller to ve.init.mw.Target
 * - VE-MW fix commit for I4efbae614e
 * - [BrowserTest] clear default text before entering search text
 * - [BrowserTest] update test for new selector
 * - [BrowserTest] update general markup test
 * - [BrowserTest] update Links test
 * - [BrowserTest]Fixing options test
 * - Remove use of bind for inline functions
 * - [BrowserTest] changing the css paths for Cite options for fixing the tests
 * - [BrowserTest] Adding tests for checking fields under Page Settings
 * - Set 's' accesskey on save button inside save dialog
 * - Edit/view source tab: Do not hijack middle click to display confirmation, only left click
 * - Check for stopped propagation before showing close dialog
 * - Follow-up I64f5e2f6c: Bump wfUseMW version given breaking OOjs UI dependency
 * - Rename some things for my sanity
 * - Mark primary buttons as progressive as well
 * - Fix image alignment in media dialog search
 * - build: Suppress the 'unique-headings' warning from CSSLint
 * - Add timing data for the first transaction
 * - Bump command help dialog height again
 * - [BrowserTest] issues with Chrome at SauceLabs causes test to fail
 * - Surfaces should have parent document direction
 * - Follow-up I4e38607d8: Register &lt;visualeditor-find-and-replace-regular-expression&gt;

WikiGrok

 * - Show for anons by default, import classes
 * - Maintenance script to refresh old versions of questions
 * - Fix campaigns picking
 * - Include the campaign property's Wikidata label
 * - Make sure campaign data isn't set to false
 * - Convert API help for wikigrokresponse to use i18n
 * - Fix EventLogging of responses when correct is null

Wikidata

 * - Update Wikibase: Fix SpecialEntityData and enhance populateSitesTable
 * - Update Wikidata, fixes for Special:NewItem, NewProperty, SetSiteLink
 * - Update Wikidata - pull in latest backports from last branch

WikimediaEvents

 * - Remove sendBeacon experiment
 * - Update SendBeaconReliability revid

WikimediaMessages

 * - Add messages for Wikidata and test.wikidata.org &quot;other projects&quot; sidebar links

ZeroBanner

 * - Optimized imagemagik invocation

ZeroPortal

 * - Simplified config changing to '+' and '-'
 * - Proper edit token validation
 * - Fixed $wgAutoloadClasses for ConfigMerger
 * - Add autoload entry for ZeroPortal\\ConfigMerger

Vector

 * - Revert &quot;Replace desktop watchstar icon with mobile skin one&quot;
 * - Remove 'margin-left: -1px;' on &quot;More&quot; menu
 * - Use $GLOBALS for globals
 * - Add version check for Vector