User:Legoktm/Gadgets 2.0 Audit

Individual files
km-mpb:Gadgets km$ find. ./api/ApiQueryGadgetCategories.php ./api/ApiQueryGadgetPages.php ./api/ApiQueryGadgets.php ./backend/CachedGadgetRepo.php ./backend/ForeignAPIGadgetRepo.php ./backend/ForeignDBGadgetRepo.php ./backend/Gadget.php ./backend/GadgetPageList.php ./backend/GadgetRepo.php ./backend/GadgetResourceLoaderModule.php ./backend/LocalGadgetRepo.php ./content/GadgetDefinitionContent.php - ✅ ./content/GadgetDefinitionContentHandler.php - ✅ ./content/GadgetDefinitionDeletionUpdate.php - ✅ ./content/GadgetDefinitionSecondaryDataUpdate.php - ✅ ./COPYING - ✅ ./Gadgets.alias.php - ✅ ./Gadgets.hooks.php ./Gadgets.i18n.php - ✅ ./Gadgets.namespaces.php - eh, do we need this? ./Gadgets.php ./install.settings ./migrateGadgets.php ./modules/ext.gadgets.api.js ./modules/ext.gadgets.gadgetmanager.css ./modules/ext.gadgets.gadgetmanager.js ./modules/ext.gadgets.init.js ./modules/ext.gadgets.preferences.css ./modules/ext.gadgets.preferences.js ./modules/ext.gadgets.specialgadgets.prejs.css ./modules/ext.gadgets.specialgadgets.tabs.js ./modules/images/close.png ./modules/images/edit-faded.png ./modules/images/edit.png ./modules/images/input-error.png ./modules/images/input-loading.gif ./modules/images/input-ok.png ./modules/jquery.createPropCloud.js ./populateGadgetPageList.php ./README ./SpecialGadgets.php ./sql/gadgets.sql ./sql/patch-gadgetpagelist.sql ./tests/GadgetsTest.php ./tests/old/GadgetsTest.php - should we just delete this?

Commits to master that may not be in RL2
Full list:


 * https://gerrit.wikimedia.org/r/#/c/22426/ Replace remaining deprecated wfMsg calls. - RL2: ✅
 * https://gerrit.wikimedia.org/r/#/c/24668/ Add "#mw-prefsection-gadgets" to preferences links ✅
 * https://gerrit.wikimedia.org/r/#/c/33733/ Typo in comment - n/a
 * https://gerrit.wikimedia.org/r/#/c/61736/ tests: Rename file to end in Test.php ✅
 * https://gerrit.wikimedia.org/r/#/c/65010/ Gadget-definitions: Make comment matching non-greedy - RL2: ✅
 * https://gerrit.wikimedia.org/r/#/c/68692/ HTTPS MediaWiki.org redirects to HTTP, so changing to WWW. - RL2: ✅
 * https://gerrit.wikimedia.org/r/#/c/73617/ Don't cache the gadget-defintion in case no gadgets were found - n/a
 * https://gerrit.wikimedia.org/r/#/c/83914/ Invalid argument supplied for foreach in ApiQueryGadgets.php on line 58 - n/a
 * https://gerrit.wikimedia.org/r/#/c/81880/ Move hooks to a separate file ✅
 * https://gerrit.wikimedia.org/r/#/c/81881/ Profiling - We probably just need to do this everywhere
 * https://gerrit.wikimedia.org/r/#/c/103938/ Replace usage of SpecialPage::getTitle with getPageTitle - RL2:
 * https://gerrit.wikimedia.org/r/#/c/104499/ Fix typo in API doc ✅
 * https://gerrit.wikimedia.org/r/#/c/107766/ Add COPYING ✅
 * https://gerrit.wikimedia.org/r/#/c/75506/ Add 'top' flag to allow Gadgets to top-load - already in RL2
 * https://gerrit.wikimedia.org/r/#/c/60954/ Allow disabling of legacy gadgets (Mobile support) - filed as 69681
 * https://gerrit.wikimedia.org/r/#/c/121322/ Migrate to JSON i18n ✅
 * https://gerrit.wikimedia.org/r/#/c/138153/ Remove galanguage from list=gadgets - n/a
 * https://gerrit.wikimedia.org/r/#/c/138167/ Fix warning "Invalid argument supplied for foreach" - n/a
 * https://gerrit.wikimedia.org/r/#/c/142470/ Improve tests
 * https://gerrit.wikimedia.org/r/#/c/152962/ Add space before closing parenthesis - n/a