Extension:MobileFrontend/Deployments/2013-07-23

Stories
Story 920: Make upload tutorial screen have an upload and cancel button

Story 805: Move Left Nav grouping to Stable

Story 902: Promote editing to stable

Story 903: [CACHE FLUSH] Promote new in-article nav to stable

Bugs
Bug: 51061 - Add namespace field to mobile editing

Bug: 51894 - Add GFDL to editor legal text

Bug 51840: removeChild on a non-object in HtmlFormatter line 256

Bug: 51735 - Mobile language selector "conversions" repeating entries on wikis with variants

Bug: 51414 - Non-javascript version of new nav is weird

Bug: 51597 - Toggle icon shows up on sections that cannot be toggled

Bug: 51579 - Log-in and Sign-up pages should not have user button

Bug 51627: Fix return to link in Cta drawers to include namespace

Bug 51480: Add placeholder text to textarea

Bug: 51377 - Mobile cannot keep a login for more than 2 days

Bug 51458: Allow watching outside main namespace

Bug 48917: Fix extracts

Bug: 51261 - Wiki name is double escaped in left nav

Regression
Regression: Center login button in drawer

Hygiene
Hygiene: Rename mf-cleanuptemplates to issues

Hygiene: Package up language modules

Hygiene: Package up search modules into directory

Hygiene: Rename css to be consistent with uploads directory

Hygiene: Drop mf- prefix on all common JavaScript

Hygiene: Rename mf-view.js to View.js

Hygiene: Remove dead css

Hygiene: Remove dead test

Hygiene: Remove another unnecessary closure

Hygiene: Remove M.prefix

Hygiene: Break the handshake

Hygiene: Remove dead css

QA
QA: Correct the acceptance tests for main page

Updated Cucumber Ruby gem

Uncategorized
Localization Changes

Minor cleanup: unused vars, annotations

Remove unnecessary closure

Add event binding in initialize for PhotoUploaderPageActionButton

SkinMobile shouldn't call itself Minerva

Enable anonymous photo upload cta by default

Editing: Make sure lists are styled in preview

Rename the horrible overlay class to something more meaningful

Apply page blacklisting only when choosing a skin

Fix position-fixed workaround for older devices in overlays

Reuse jQuery vars

A hack for the editor on Android 2.x

Nobody knows what span.t is, and video removals don't work ever since we switched our video extension.

Fix license image alignment in editor and uploads

Disable animations on Android 2.x

Add returnToQuery to editor cta

Scope animations-related workaround inside .animations

Remove unnecessary RTL CSS rule

Simplify WAPness detection

Avoid adding duplicate styles on watchlist and nearby

Git Logs
commit c0b89195543ad10d01d1392312381ee343a9b878 Author: jrobson  Date:  Thu Jul 18 10:27:04 2013 -0700

Story 920: Make upload tutorial screen have an upload and cancel button Also, fix line-height (make it the same as in uploads dashboard   tutorial) and make padding around the image smaller to make sure it fits on most devices (jgonera). Change-Id: Id44543263056c6b999e541076817aeddd46aceeb

commit 15e7db2b3cd9d6ccce42b01a04b2ad0435304789 Author: Max Semenik  Date:  Wed Jul 24 01:22:09 2013 +0400

Licensing fix per Erik Bug: 51894 Change-Id: I019273b5c59d29ca3bb38ba5ee0c61f506f6a97a

commit 2aa084218d6fe93086687f3f53ee6f8be810e97b Author: Translation updater bot  Date:  Tue Jul 23 18:40:31 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: Idab3838a76fe69c080cc06a2832fc4475c2d912e

commit de6c7f80a43358913054de747a34462de2312794 Author: Max Semenik  Date:  Tue Jul 23 01:40:21 2013 +0400

Bug 51840: removeChild on a non-object in HtmlFormatter line 256 Change-Id: I2e3317abfba62991ec528d6d1a3e826dfd33bcb1

commit 48d2ecd4cd730f29ec8c01e8e6ab2c307f91679d Author: Translation updater bot  Date:  Mon Jul 22 20:15:13 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I623e432a3e0634cba9c7b29f43892c5d3c18fc54

commit a6d4a787cf6fb34b8bb84a34a2256424d3a88213 Author: jrobson  Date:  Sun Jul 21 16:20:22 2013 -0700

Enable login for older phones Fix the watch star behaviour in no JavaScript mode for logged out users by turning it into a link to the login form Enable the login link in the menu Bug: 51414 Change-Id: I49d4b998397d8c1ca119f5fa0f5177c0a980e128

commit 7803d3b677c4d9bef33e4ce8cca0e6ecbd99c89d Author: jrobson  Date:  Sun Jul 21 16:35:00 2013 -0700

Fix variants in language overlay Bug: 51735 Change-Id: I1d56a332c77ff0d428104cff1f7e8edd9cc505f8

commit 6e3a136542ad4b91e501fd478e908ea6d66ce36b Author: Translation updater bot  Date:  Sun Jul 21 19:15:09 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: Id3c1da56f40f458af9569ad35e1924170868efc8

commit bb1027f66d2cc7ea900944e45206c53023034064 Author: Translation updater bot  Date:  Sat Jul 20 20:48:30 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I13a41860ad499e9510d162543ebc7fd7d6285ca0

commit 62ce1b50aa30b8e7972171a56b07ae8943b4b333 Author: jrobson  Date:  Fri Jul 19 16:58:35 2013 -0700

Hygiene: Rename mf-cleanuptemplates to issues Change-Id: Id73db43539ed20ea06fd4c6dba24fb14389b2909

commit cb3f39059489addc6b03eb79a8a53f8c96a250a8 Author: jrobson  Date:  Fri Jul 19 16:56:44 2013 -0700

Hygiene: Package up language modules Change-Id: I51cc4c7bf1a4dad7a45f2ca633b871280b180235

commit 08c025b45ca372ffe4432b8df9484ccdc8e9eb05 Author: jrobson  Date:  Fri Jul 19 16:52:35 2013 -0700

Hygiene: Package up search modules into directory Make css file correspond to it   Change-Id: I2254c3448670615922c608ae6a267ebd0bfd3815

commit 553811dc190692bafd29ff143bc3fc6ba60365cc Author: jrobson  Date:  Fri Jul 19 16:51:10 2013 -0700

Hygiene: Rename css to be consistent with uploads directory Change-Id: I7505e3f29d5c8cf93f0e3cd44bec818006f5dd06

commit d08099bdd3b7efd63cf301667e0c0fe5c4fa2e48 Author: jrobson  Date:  Fri Jul 19 16:27:28 2013 -0700

Hygiene: Drop mf- prefix on all common JavaScript Change-Id: I7fc1638de2edf1810918f118878eeb42b2012b62

commit 8ab116674152de854c69681d51c1e73816f4f21c Author: jrobson  Date:  Fri Jul 19 16:17:58 2013 -0700

Hygiene: Rename mf-view.js to View.js   Change-Id: Ib1471e1004f3ef25d5869e32c0431be793de95d3

commit 75c357176f90b02075c6ca77abcceb24dfd60d19 Author: jrobson  Date:  Fri Jul 19 16:14:57 2013 -0700

Hygiene: Remove dead css Change-Id: Id358a58d0dd94b46e47a04e4102149b532695d39

commit 4002eab8116c4cfa3060560a9948c268c3be817b Author: jrobson <jrobson@wikimedia.org> Date:  Fri Jul 19 16:14:14 2013 -0700

Hygiene: Remove dead test Change-Id: I50ea4c79436cc4b2a2691709e1d473d51eb255a5

commit 8e1ca0694533bb2f12e7dcb7ee0dbc1f42c6c594 Author: jrobson <jrobson@wikimedia.org> Date:  Fri Jul 19 16:13:24 2013 -0700

Hygiene: Remove another unnecessary closure Change-Id: I6526d0a1365d8e26d52adf1c07c0e2f6f766ddc3

commit 91af49096899d0fa5ef3c7b9d2c035025b6cd7d2 Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Fri Jul 19 19:47:33 2013 +0400

Minor cleanup: unused vars, annotations Change-Id: I750bdb11d25a6b79aab3676c3e6b9f420378bdec

commit eb8dfd66fc9d22c731c4bca799de2fe88f02ccd2 Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Fri Jul 19 21:25:49 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: Id08c757766d0d296c0a81a30e5131882844fa5fa

commit 606cc24b1e1e6208e25dfa496eef2a0709be130a Author: jrobson <jrobson@wikimedia.org> Date:  Fri Jul 19 14:09:55 2013 -0700

Hygiene: Remove M.prefix Change-Id: I2b9149d26688c20f88f2de121d67e26dee0ca8b4

commit 1815b3a49c99fb869bc8223b32cfe3611369a44d Author: jrobson <jrobson@wikimedia.org> Date:  Fri Jul 19 14:07:43 2013 -0700

Remove unnecessary closure Change-Id: I35db0f4c09768c6d610c92d6b1f4eccf1a0ee701

commit e723f638a25407e02e50b12a7382d5f896e9d438 Author: jrobson <jrobson@wikimedia.org> Date:  Fri Jul 19 10:34:12 2013 -0700

Hygiene: Break the handshake Kill it with fire. Long live SUL. * Also removes loginhandshake.js, userlogout RL modules and handshake messages Change-Id: I75f378cf5f49bd4dd8ef17a67a09b243ddcceb7a

commit 6280ec0e53dc636b09c8ec9e290b7a18839a19d9 Author: jrobson <jrobson@wikimedia.org> Date:  Wed Jul 17 16:53:34 2013 -0700

Add event binding in initialize for PhotoUploaderPageActionButton This allows us to reuse it elsewhere easily e.g. in first time uploader tutorial Rename to more generic LeadPhotoUploaderButton Change-Id: I93899aeafd13e3d12cfe594374d443d015715d7d

commit 5205f53f16248d33659abf39c1da4b20e6f4a1ac Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Fri Jul 19 19:22:01 2013 +0400

SkinMobile shouldn't call itself Minerva Change-Id: If3ce7edf6771a8afb6192b3e1315d61e22b21bed

commit 8dd7eef75ee5676dc529686a922168688f27dc2b Author: jrobson <jrobson@wikimedia.org> Date:  Thu Jul 18 18:33:17 2013 -0700

Hide upload and edit for non JavaScript users Bug: 51414 Change-Id: I797fbdf2c8922f1bee4c887f7025dee9b9a01185

commit 3afd0e2a8033f0e9865997e27eac883b016e6cb7 Author: jrobson <jrobson@wikimedia.org> Date:  Thu Jul 18 12:34:24 2013 -0700

Do not leave a gap on stub pages The toggle icon is not shown as toggling is not possible so   remove the gap Bug: 51597 Change-Id: I459bbe5c9d043b960dc64742e21f8f3adce97834

commit be92a769212c1470a84d3b015a81fe6b8d372d28 Author: jrobson <jrobson@wikimedia.org> Date:  Thu Jul 18 13:53:01 2013 -0700

Enable anonymous photo upload cta by default Hope there is no Selfie Apocalypse sequel Change-Id: I0515977bf4bf58147b70a62b414f2c1518684aad

commit 50db1b5f58afa9a4dd9af83c3ac1d16de2097636 Author: kaldari <kaldari@gmail.com> Date:  Fri Jul 12 17:24:44 2013 -0700

Stories 902, 903: Promoting pageactions (including editing) to stable * Makes mf-api.js a startup module (now needed by history.js) * Address FIXMES in lead photo upload and css Also removing unused 'pagetitle' message Change-Id: I7c1379874b115cf05ebd932b2f713d94062e08ee Dependancy: I466d36e48dec1f798f38152c829a25eb80f8b67b

commit 2070f49f96cd1dda55a70e588257d6246f439370 Author: jrobson <jrobson@wikimedia.org> Date:  Thu Jul 18 13:46:35 2013 -0700

Hide the user button on the login screen Bug: 51579 Change-Id: I491f91971187d07cf7914d5f0a9d74e8068c78b2

commit 7668625bd5a9b9c9b3af8cb4f67a6bba8fe9ad81 Author: jrobson <jrobson@wikimedia.org> Date:  Thu Jul 18 13:45:20 2013 -0700

Hygiene: Remove dead css Change-Id: If4ce83c143c0e6194f0b69dd40eae9e57b74a6b1

commit e902bb6e48276332d22f2f56a626a5b765382250 Author: jrobson <jrobson@wikimedia.org> Date:  Thu Jul 18 13:31:52 2013 -0700

Regression: Center login button in drawer Use correct variable Change-Id: Ic5e4ef5380333c6dc0457013d02fda42477d05b2

commit 32255da3c8c200198524ef875d50c5ef1aa7a4bf Author: jrobson <jrobson@wikimedia.org> Date:  Thu Jul 11 13:44:31 2013 -0700

Update to latest schema Will log namespace as requested in Bug: 51061 As well as user edit count at time of edit to identify new editors As well as whether AB test was run Dependency: I7e7a99fd5e17dc1b5038b14df21d32320e581806 Change-Id: I37079a3501844cff433ccadd42c0b813b7cc2e37

commit 92795fb5adf8bfecaab7167812c2f89a64bd36de Author: jrobson <jrobson@wikimedia.org> Date:  Tue Jul 16 11:14:36 2013 -0700

Editing: Make sure lists are styled in preview Change-Id: Ib8d14a15bbade032d7cdeac42316458782ced6f1

commit 0f60903aa07777191689c53146d493707e35678c Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Thu Jul 18 19:49:02 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: Ief00596e10bcfd0dd57e5a33816fbcd9fbea03d1

commit 4cea7659abd82a80c991893bf344201c07708bcb Author: jrobson <jrobson@wikimedia.org> Date:  Tue Jul 16 17:00:42 2013 -0700

Rename the horrible overlay class to something more meaningful Rename badly named mf-navigation.js file Update README Consistent name to navigation-enabled Change-Id: I2d89d756f1756c15b62418e4cb88ffeb537808b8

commit 2d4439ba25f004880257ab3a037017a2893299e4 Author: jrobson <jrobson@wikimedia.org> Date:  Thu Jul 18 11:08:48 2013 -0700

Bug 51627: Fix return to link in Cta drawers to include namespace Bug: 51627 Change-Id: Ic6d44d5b1e446f166fd2e2b33a8031282aa31e0c

commit 14f739940aed7ad18ea507d1d031b4c9695d030a Author: jrobson <jrobson@wikimedia.org> Date:  Thu Jul 18 10:41:37 2013 -0700

Bug 51480: Add placeholder text to textarea Challenge the user to edit it! Bug: 51480 Change-Id: I0111600a031e53f035d1261f17ea11b32077686e

commit 1c1b1f712d054aa587f11b6f3edc3b9b5b27ff68 Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Thu Jul 18 20:04:48 2013 +0400

Apply page blacklisting only when choosing a skin Otherwise, things like canonical redirects break Change-Id: I67e9064f2970f39a9bc15d262c31479c99f0a168

commit 9968877808aa37d6e3be6f0138bef76b151a1a9f Author: jrobson <jrobson@wikimedia.org> Date:  Fri Jul 12 17:59:58 2013 -0700

Story 920: Show uploads tutorial after following anon cta Enable the anonymous user CTA in beta. Refactor photo uploads tutorial css to be more generic Create ContentOverlay - an overlay designed to appear within the page rather than over the page Currently shown to all users after logging in to make testing easier Note: currently doesn't work with the CentralAuth intermediate screen of death (as this steals article_action=photo-upload from   query string) Change-Id: Ic54af4d87553218b2e382544ee852508717bdf39

commit df54bf18d45a82c8d7b0103db46960d0d3f50b4c Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Tue Jul 16 17:35:52 2013 -0700

Fix position-fixed workaround for older devices in overlays Could be observed in the editor. The bottom bar would stay in the middle of the page. It also fixes the overlays on iPhone 3G (the overlay was not covering   the web site below it) and almost fixes the position: fixed fallback on    this phone (it didn't work, now it does, although the bottom bar does not    stick to the bottom, but almost to the bottom). Change-Id: I957ddea76d64d406602a4bd80d64316a43bfc6bc

commit 26cc8a1af02ad8520f6d8aa9632a6e8c723edf45 Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Wed Jul 17 19:25:46 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I80ea1dfebbd767e5e021e9563f65bfad53c14f4c

commit 21a6ac8d95532b7e3c5d9a775f131d992bd94126 Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Tue Jul 16 18:07:09 2013 -0700

Reuse jQuery vars Change-Id: Idab8cf68bfe6b9fb03001db2c0c7b1dd650bc2a9

commit d46698d8c298b31e25c78a1b10e71aafd3a2adce Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Tue Jul 16 14:22:59 2013 -0700

A hack for the editor on Android 2.x   Makes the cursor and scrolling behavior more predictable. Change-Id: I66e59dc64508b48907c41d194fc0a97223b488cf

commit d493aac4a07b657d46e2679d192cac3159b64283 Author: jrobson <jrobson@wikimedia.org> Date:  Tue Jul 16 17:47:45 2013 -0700

Sigh. Take what anyone says with a pinch of salt. This has been set on account creation but not on login. Bug: 51377 Change-Id: I4c797dcd3e523d73852756803420cf587e16adb0

commit f655083ba8d83ce17a6bbab2de12a6f22106af85 Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Tue Jul 16 23:09:36 2013 +0400

Remove some removals Nobody knows what span.t is, and video removals don't work ever since we   switched our video extension. Change-Id: I411a1b44ce1e7a2f18bbcb6570441e99f102617d

commit aee6764d8e52ec8ebdd97ad70bb666cd3a143a4d Author: jrobson <jrobson@wikimedia.org> Date:  Tue Jul 16 14:53:31 2013 -0700

Bug 51458: Allow watching outside main namespace Bug: 51458 Change-Id: Ie855c05bda0fe0a44767874b32d003e8c6928729

commit 99b098e2607d53864e12c3b811fb28b8052391c6 Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Tue Jul 16 14:43:09 2013 -0700

Fix license image alignment in editor and uploads Misaligned after one of the CSS cleanups. Change-Id: If58735321545fe23b1829148c036352237e712a9

commit 3450ffc1dfd32b7c7592b5a5286e06121058ab53 Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Tue Jul 16 14:09:41 2013 -0700

Disable animations on Android 2.x   They cause weird bugs in textareas (random scrolling, cursor jumping). Change-Id: I6c559b4bf3e4e9079dd77d4a0bba62bcb256bde3

commit 0db659d1075574032f3fa68611e881d948f1aa7e Author: jrobson <jrobson@wikimedia.org> Date:  Tue Jul 16 14:10:15 2013 -0700

Add returnToQuery to editor cta Use of'article_action=edit' will allow us to log accounts created from edit cta Change-Id: I25ec9432c85736ca97f9586e843e9afd61fc955b

commit 60a9762deca8c02792d64efad530f1c89d5b275d Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Tue Jul 16 14:05:10 2013 -0700

Scope animations-related workaround inside .animations Change-Id: Iaadb457e2af4505257caad784072dfffb5e8581b

commit a1677776fcb5453f52e95919df0472940cfac339 Author: MaxSem <maxsem.wiki@gmail.com> Date:  Wed Jun 19 20:56:59 2013 +0000

Bug 48917: Fix extracts * Removes rules from MobileFormatter (now handled by WMF-specific config) See: Iffc54344121fea029d22ba17b68b2b03476ce884 Change-Id: If5a88d0a21b736325dc7a0168427efa344308355

commit 8d1a8e840264c61af00c87a131ccd7d88dc34583 Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Tue Jul 16 20:04:50 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I268ea394cc354157d7f717ed783f93fd365fec00

commit d5193765ce82b826f6aa5d5107825e68b457954b Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Mon Jul 15 17:53:21 2013 -0700

Remove unnecessary RTL CSS rule Change-Id: I3f23b5684476f046a6e5923d6fb7ed7986111705

commit 973bb4f1d339e7a26a121950e41f54c9f6bc658e Author: jrobson <jrobson@wikimedia.org> Date:  Wed Jul 10 13:43:41 2013 -0700

QA: Correct the acceptance tests for main page A whole bunch of refactoring. Change-Id: Ia5fdaba8450266735981a470cbc0ae376f4f792c

commit c4c68443dce111ba024ffb3baaaa3eb41d85014c Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Mon Jul 15 16:27:09 2013 -0700

Make editor button work on Android 2.x   Apparently, the event object passed to hashchange callbacks in Android Browser 2.x does not contain some properties available in newer browsers. This patch changes the way the hash is fetched making the Router more reliable on older browsers. Change-Id: I25716393e7c8526c709f39375b06453a6dec26ef

commit 416c3cd340fee90c67f46f75604b1483c65af61c Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Wed Jul 10 23:55:14 2013 +0400

Simplify WAPness detection Now only Accept header is used for WAP detection, User-agent is used for mobileness. Change-Id: Ib180b72de810f0f1be57ee82dded48cd870cee40

commit 4fdf621a2af8af87aef4b41e542f92414b678bc3 Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Wed Jul 10 17:01:18 2013 -0700

Story 805: Move Left Nav grouping to Stable Also fix a bug in the process. Bug: 51261 Change-Id: I19bc98fddee46d4e80546f200144fcc15522b278

commit e1b3e17480eeb49749ebbd1fb802a68d05437019 Author: jrobson <jrobson@wikimedia.org> Date:  Mon Jul 15 15:13:04 2013 -0700

Avoid adding duplicate styles on watchlist and nearby Make pagelist css a global style Change-Id: If51e36286b0a650eed2988e0911fb0224c5c47e9

commit 71d1ed0515d39fd1796b76790166d14bbf9a7ef0 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date:  Mon Jul 15 15:07:07 2013 +0200

Updated Cucumber Ruby gem Change-Id: I61ecee57213f9f7e5518376afe277ca0254ed815