Gerrit/Project ownership

__NEWSECTIONLINK__ This page queues individuals' requests to be added to the Gerrit project owner groups for specific Gerrit projects (each of which corresponds to a Git repository). A Gerrit project owner has the power to approve changes for merger into that Gerrit project's master branch, and to veto changes.

"When/how we'll add, remove people from Gerrit project owner groups" has procedural details. Sumana Harihareswara will regularly look at new requests for project owner membership and contact the existing project owners. If the candidate gets zero vetoes and at least one yes from the existing project owners, then we'll approve the candidate. For each new candidate the process shouldn't take more than two weeks, and usually much less.

If your codebase/extension/tool isn't in Git yet, use this form to create a new Gerrit project: Git/New repositories

To see the current list of Gerrit project owners for a specific Gerrit project, visit https://gerrit.wikimedia.org/r/#/admin/groups/.

Ownership structure
Example: an extension is named foo.
 * The Gerrit group "foo" should usually be an owner of the Gerrit project "foo."
 * Sometimes, meta-groups will be included in the group. This is for people have ownership over multiple extensions, so you can add/remove members in one place.
 * Rights to the group may be inherited from other groups (Look for a "Rights Inherit From:" in the project access.)

Specific example: the project "mediawiki/extensions/DonationInterface" is owned by group "extension-DonationInterface." This group includes the meta-group "fundraising." Also members of the group "mediawiki" has ownership via "Rights Inherit From: "mediawiki/extensions access"

By keeping the naming convention ("extensions/foo" is owned by group "extension-foo"), it'll make the "automatically setup a repo" process much more scriptable when we hit that bridge.

(Note to Gerrit group creators: remember to check the "Make group visible to all registered users." checkbox and leave the group type as "Internal group" and not LDAP.)

= Requests =

[ Add a request]

A bunch of new groups
I'd like to have an $extension-trusted group (initially empty and with no rights assigned) for the following extensions: Validator, Maps, SemanticMaps, Push, LiveTranslate, SubPageList, Spark, IncludeWP, Survey, DidYouKnow, Gitweb (once created), DataValues (once created), Diff, SemanticWatchlist, SemanticImageInput and SemanticBundle.

These groups would be owned by their respective $extension-owner group.

This will allow me to manage my extension myself without posting a request here each time someone should get access :) --Jeroen De Dauw (talk) 19:25, 17 August 2012 (UTC)

Comments

 * Support. --siebrand (talk) 16:06, 21 August 2012 (UTC)
 * Since these are non-deployed extensions, I think this is fine. But I'd like to get input from Chad before we start introducing new group structures. --Catrope (talk) 18:02, 21 August 2012 (UTC)
 * I don't *like* it as proposed since this is very quickly going to explode the number of groups we have. Ideally all extension-$name groups should be owned by an extension-$name-owner (other than deployed exts, perhaps). The reason it's all currently owned by the "Project & Group Creators" was so people could process this page and add new users to their respective groups. What I'd like is either A) A way to manage all groups without giving out admin privs, or B) Multiple owners of groups. The former is probably easier. This all being said, perhaps we can go ahead with this structure for a few non-deployed extensions anyway and see if we really need this page at all for granting access to those. ^demon (talk) 14:05, 22 August 2012 (UTC)
 * Well then I suppose we'd be supportive of adding Jeroen as the owner of all those groups? Also, it seems to me that there are a number of them should be in some metagroup fro SMW. Tychay (talk) 20:56, 5 October 2012 (UTC)
 * Chad, sorry for being obtuse, but when you say "perhaps" is that a go-ahead for me to go ahead and create the "extension-Validator-trusted", "extension-Maps-trusted", etc. Gerrit groups, and when necessary, the "extension-[name]" groups to own the "trusted" groups? Thanks. Sharihareswara (WMF) (talk) 15:44, 8 October 2012 (UTC)

Nischyan branch owner in SemanticMaps
I tried making Nischyan owner of the nischyan branch of SemanticMaps by adding a group he's member of as owner of this branch. I want him to be able to happily merge in stuff without needing approval of someone else. Since this did not work, I tried giving him pretty much all other rights on the branch, but he says he's still not able to approve his own commits. Am I doing something wrong? https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/SemanticMaps,access
 * -- Jeroen De Dauw (talk) 15:04, 24 September 2012 (UTC)


 * Reviewing commits (Verified+1, CodeReview+2, Submit) needs to be assigned to the appropriate refs/for/* refspace, not the destination ref. Compare and . ^demon (talk) 19:23, 24 September 2012 (UTC)


 * So it should be refs/for/refs/heads/nischyan? --Jeroen De Dauw (talk) 18:26, 28 September 2012 (UTC)


 * Yes ^demon (talk) 18:21, 18 October 2012 (UTC)

This does not appear to work - can you check the settings to see if they are correct? --Jeroen De Dauw (talk) 18:53, 21 October 2012 (UTC)

+2 rights to Wikia team members for extension/VisualEditor
VisualEditor is developed jointly with Wikia and WMF; right now, all four WMF devs have +2 and none of the Wikia ones do, which we'd like to fix:
 * inez &mdash; Inez Korczyński
 * christian &mdash; Christian Williams
 * Jdforrester (WMF) (talk) 22:06, 18 October 2012 (UTC)

Comments

 * Tychay (talk) 23:21, 18 October 2012 (UTC)
 * Trevor Parscal (talk) 02:56, 19 October 2012 (UTC)
 * , of course. --Eloquence (talk) 06:58, 19 October 2012 (UTC)
 * ✅ Thanks! Sharihareswara (WMF) (talk) 17:19, 19 October 2012 (UTC)

Me to mediawiki group
So I am authorized to manage my own engineers (and volunteers) to their extensions. :-) Tychay (talk) 23:24, 18 October 2012 (UTC)

Comments

 * --Eloquence (talk) 06:58, 19 October 2012 (UTC)

PediaPress developers for Collection extension
I'm going to give the PediaPress developers (Heiko Hees and Ralf Schmitt) +2 on the Collection extension right now -- please speak up on this page if you think I shouldn't have. Sharihareswara (WMF) (talk) 20:34, 19 October 2012 (UTC)
 * Given to Ralf. Looks like Heiko does not have a Gerrit account so I will ask Heiko to make one. Sharihareswara (WMF) (talk) 20:36, 19 October 2012 (UTC)

Tpt: DoubleWiki and Labeled Section Transclusion
I have been working on ProofreadPage for the past few months in order to clean the code and add new features required by Wikisource contributors. DoubleWiki and Extension:Labeled Section Transclusion are two extensions used also by Wikisource that have no maintainer and I would like to give them a few love. A commit access will help me significantly. Tpt (talk) 14:38, 21 October 2012 (UTC).
 * Support. Tpt is virtually alone to maintain these Wikisource-specific extensions.
 * No project ownership creates a bottleneck: Gerrit trivial change I0bd75d6a has been submitted in June, reviewed in September and today. Four months and the trivial change is still not merged.
 * Note: This requires to create the groups extension-DoubleWiki and extension-LabeledSectionTransclusion--Dereckson (talk) 21:14, 21 October 2012 (UTC)
 * Note: This requires to create the groups extension-DoubleWiki and extension-LabeledSectionTransclusion--Dereckson (talk) 21:14, 21 October 2012 (UTC)

2 new members for 2 groups
Please add jeroendedauw and markus to semanticmediawiki-trusted and semanticresultformats-trusted. --Jeroen De Dauw (talk) 18:54, 21 October 2012 (UTC)

+2 for core and extensions
I am requesting +2 for core and all extensions mainly for l10n/i18n related patches as member of the translatewiki.net team.

Gerrit name: Raimond Spekking / username: raymond

Thanks. Raymond (talk) 07:20, 23 October 2012 (UTC)
 * I support this request. --siebrand (talk) 11:01, 23 October 2012 (UTC)
 * Clear support - Hoo man (talk) 00:54, 24 October 2012 (UTC)

wmf-deployment +2 for spage
I'm already doing deployments of E3 Experiments on fenari, but after I "Commit the submodule update", I don't have the ability to +2 it. I have to find someone to approve changes like -Subproject commit 58f36f071e0558e74f8601ce822874ee44744fe2 +Subproject commit a7469d9a355eeae683673b8017f5dced874ab028 If people actually check the change then the review step adds value, otherwise it just lengthens our deployments. -- S Page (WMF) (talk) 02:09, 24 October 2012 (UTC)
 * ✅ already when I added some missing deployers to the wmf-deployment group. ^demon (talk) 20:08, 24 October 2012 (UTC)

Alex Monk be added to Echo
+2 privs for Alex Monk on Echo --Tychay (talk) 19:49, 24 October 2012 (UTC)