Extension talk:Link Attributes

It seems that there is a problem with the source code

Line


 * 1) $attribsText = Html::expandAttributes( array( 'class' => 'external '.$linktype ) );

should not start from sharp sign #

Invalid signature
After taking the above advice (uncommenting the # line in linkattr_ExternalLink), then I reversed the change I made to the 'includes/Linker.php' page. It then gave an error that there was an invalid signature in linkattr_ExternalLink. To fix it, I removed, and changed   to. That fixed the errors for me.

Is patch necessary?
Hi, I would like this extension very much, but I hate it when you have to do a patch in a file that requires extra administration for new installations of a wiki or upgrades.

Is the patch really necessary?


 * Hi 84.105.220.61,
 * I hadn't any time to look at the new registration system of MW1.25, but it is on my agenda.
 * I can verify that it works without any problems for MW1.24.X as you also can see at Wikiapiary.
 * If you have a MW1.25 installation and if it doesn't work out of the box, simply ping me (best is with logs or error messages) and I will have a look why it doesn't work and how to fix it.
 * Regards,
 * Dennisroczek (talk) 12:55, 30 July 2015 (UTC)

Notice after purge
Hello all,

there is a little issue after use of purge --all maintaining on server. Mediawiki 1.26 printed fllowing:

Notice: Undefined index: rel in /var/www/html/mediawiki/test/extensions/Link_Attributes/Link_Attributes.php on line 60

Notice: Undefined index: class in /var/www/html/mediawiki/test/extensions/Link_Attributes/Link_Attributes.php on line 58

For patching i must change the linkattr_ModifyLink to

Can you check the patch and add it to source? Best Regards

--Sundance Raphael (talk) 12:13, 12 April 2016 (UTC)

wfLoadExtension( 'Link Attributes' ); -> wfLoadExtension( 'Link_Attributes' );
wfLoadExtension( 'Link Attributes' ); --> wfLoadExtension( 'Link_Attributes' );

missing _ underscore character in installation notes


 * Thanks, I've updated the page. —Sam Wilson 01:49, 16 November 2020 (UTC)

Possible to add more attributes? (feature request)
Hi there, thank you for your effort with the extension! In order to integrate bootstrap functionality I would love to see the option to add more attributes. Maybe it is possible to use your syntax with additional special characters?
 * data-toggle
 * role
 * aria-expanded
 * aria-controls

Thank you very much in advance!

Add: actually I looked into the code and it wasn't too difficult to do myself. Maybe you want to integrate it into yours. The special characters were chosen at absolute random. Works like a charm with bootstrap framework!
 * data-toggle = '+'
 * role = '%'
 * aria-expanded = '#'
 * aria-controls = '$'

Chaeidras (talk) 22:32, 22 March 2022 (UTC)