Wikimedia Apps/Team/iOS/Translation review

Bernd Sitzmann from the Android team posts iOS translations patches for review to Gerrit for the iOS Wikipedia app. These are based on an automated script.

Review should be conducted expediently by iOS engineers. This includes reviewing the files in the patchset plus testing the app on at least one device to ensure it doesn't break. It's advisable if there are major changes in a particular file to invoke the app with the correct language or wiki language as appropriate if there's any doubt about how the app would behave.

Often, the review is uneventful. A quick review of the change, such as the this one, can be +2'd by an iOS engineer.

Other times, the change introduces a line that says "// Fuzzy". If this is the case, visit the apps translatewiki.net page, choose the "Wikipedia iOS Mobile" option, and then set the translation language in the top-right corner to the corresponding language where there's a "Fuzzy" marker. Look for the message key above and below the "Fuzzy" marker and see if you can figure out what's wrong and whether whatever is wrong is even material. Often, volunteer translators will already have fixed whatever was wrong or whatever is wrong is immaterial (i.e., it wouldn't break the user experience or the app).

If you spot a serious error, one that would create an inconsistent state (e.g., missing or incorrectly expressed substitution markers), download the patch and amend it (you may need to just remove the offending line(s)) and submit it to Gerrit and +2. Then visit translatewiki.net and leave a !!FUZZY!! marker corresponding to the appropriate language key with a polite explanation in the edit summary to translators on what's needed going forward.