User:Salvatore Ingala/Review 2


 * I'd like to be able at least to see the numeric value of track bars. Ideally, it should be possible to enter from keyboard.
 * ✅ except for keyboard input; added something similar to tooltips in ; keyboard input needs this jQuery.UI bug to be fixed to be useful. Salvatore Ingala 17:41, 17 August 2011 (UTC)
 * "Settings saved successfully" message box is too intrusive, better use a non-modal confirmation.
 * ✅ in . Salvatore Ingala 23:12, 18 August 2011 (UTC)
 * Save button should be clickable only if settings are actually changed.
 * ✅ in . Salvatore Ingala 23:12, 18 August 2011 (UTC)
 * Use standard buttons in dialog, otherwise Mac users might want to apply tar and feathers to you.
 * Probably unfeasible, would break the jQuery.UI theme . Salvatore Ingala 23:12, 18 August 2011 (UTC)
 * $( '.ui-button' ).removeClass.unbind( 'mouseover' ) will not break anything. Max Semenik 15:21, 19 August 2011 (UTC)
 * Yeah, ✅ in . Salvatore Ingala 21:39, 19 August 2011 (UTC)
 * Re-check proxy caching headers for Gadget API modules and module visibility for RL modules to avoid leaking private data.
 * Summary of current setup:
 * API
 * getgadgetprefs has cache mode 'private' (which is the default); it allows GET, but client side caching is disabled as of.
 * setgadgetprefs has cache mode 'private' and requires POST requests.
 * Modules
 * GadgetsMainModule ('ext.gadgets') has no private info, only setups the mw.gadgets object and the list of configurable gadgets;
 * ResourceLoaderGadgetModule ('ext.gadget.Foo') only contains gadget's code, so it is safe to leave it public. As of, the output script is made independent of whether the gadget has preferences or not.
 * GadgetOptionsResourceLoaderModule ('ext.gadget.Foo.prefs') contains the user preferences: it is in the group 'private'.
 * I think it's the right setup. Salvatore Ingala 18:28, 20 August 2011 (UTC)

Errors

 * ✅, should be fixed in . Salvatore Ingala 09:08, 17 August 2011 (UTC)

If we try to save prefs with invalid JSON:


 * ✅, should be fixed as per this change in . Salvatore Ingala 09:08, 17 August 2011 (UTC)