Extension:MobileFrontend/Deployments/2013-10-01

Dependency
commit 337b22be1059bda73c952ac32cb40932735eda41 Author: jrobson  Date:  Wed Sep 25 11:26:19 2013 -0700

Story 475: Add EventLogging to profile clicks *Add generic form of click tracking to mobile * Turn the watchlist interaction schema into a more generic schema * Use this schema to track clicks in the hamburger menu in beta mode as well as the existing clicks Dependency: I68b537e6a813b1866403135fb9d3bb7db6ca32f3 Change-Id: Icc50587a107c42caaf8441b1608d35b5cc0da97b

Stories
Story 1263: Add previous and next buttons to diff

Story 475: Add EventLogging to profile clicks

Story 1030: [performance] Reduce the size of top-loaded styles - Clean up ui.less

Story 1163: Mobile Captcha support for editing

Bugs
Bug: 54580 - [Experimental] Query string disappears after page is loaded

Bug: 54613 - numbers are not formatted on Special:Nearby

Bug: 54243 - Preview renders table of contents when multiple headings

Bug: 53378 - ApiMobileView::getData: PoolCounter didn't return parser output

Bug: 54414 - Language Variants do not show up on pages that do not have any non-variant languages.

Bug: 54238 - Ajax page loading: Page refreshes on a hash change Bug: 52047 - Mobile editor doesn't support captcha

Bug: 52857 - Formatter: Cannot edit lead section of articles containing h1's

Bug: 49440 - MobileFrontend images shown double-sized in Retina desktop, iOS 7 beta

Bug: 53342 - Improve Error handling of GeoLocation api

Bug: 51586 - Liquid threads and mobile talk dislike each other

Bug: 54386 - Uploads tutorial doesn't show on first visit to uploads page

==== Hygiene ====

Hygiene: Run make less

Regression
Regression: Don't close drawers when tapping on them

Regression: Fix previews

Regression: Exit talk after a successful save of a new topic

Regression: Ensure cancel button label loads for talk overlay

Regression: Fix echo overlay for Echo in beta

Regression: Remove Echo button from Nearby page / anon page views

Regression:Restore the First time user uploads tutorial

QA
QA#1251 Create a first time user to make sure that the tutorial displays for uploads

QA-id changed for Notification to secondary-button from user-button

QA: Add QA tests for I3f49cd50ed0c1778f8914b45cbc492fcc1775ca6

Uncategorized
Removing redundant div.magnify CSS selector

Stylistic changes to profile page

Moving some content hiding from server-side to CSS Add Profiling to Special:UserProfile

Only show smiley face in beta number of languages varies in each test env

Using language aware comma and native digits on MobileDiff Localization Changes

Don't display file name with underscores

link text is not consistent, check for target instead, see comment Add comments about localization of licensing strings.

Bug: Check user exists before trying to render it.

Fix fatals

Profiles: Stop the heading from being a link

Debug logging for latest PoolCounter weirdness

Alpha: Update title of page on a lazy load

Clean up login/create account form and captcha CSS

Update templates to contain new mobile edit links

Show proper button bar in editor on errors

Git Logs
commit 21e1f4246401c2da1eecbfe56646dc7aa701752f Author: kaldari  Date:  Mon Sep 30 16:56:14 2013 -0700

Removing redundant div.magnify CSS selector This is already hidden in common.less Change-Id: I909ba28098d2343f39caa8a4be12139029d55404

commit ced636cc6f459d427449175e87345fb57d1152b7 Author: jrobson  Date:  Mon Sep 30 15:17:49 2013 -0700

Stylistic changes to profile page * Separate into 3 sections, use icons rather than headings to identify them * fix wording of photo upload caption * clean up dead css Change-Id: I2fdc4a9013c847e4a843fc583d8d80699aa804c3

commit 2b913fab4b2b9a46efb477586add03d39bd410e9 Author: jrobson  Date:  Thu Sep 26 18:04:22 2013 -0700

Ajax Page Loads: Don't drop the query string Bug: 54580 Change-Id: I6d166096059444c1f8f30cb91ede23435733d35d

commit 9af3e1545f8c7db3a815bf65135d4aa02a802bba Author: kaldari  Date:  Mon Sep 30 15:46:29 2013 -0700

Moving some content hiding from server-side to CSS This is a two part transition. First we will introduce the new CSS, let people's old CSS caches expire, then we will remove the corresponding HTML stripping code from MobileFrontend or the config Change-Id: Ica45dfa10e6b510af13240ccf658172418b8ba26

commit 715ab2f9cd7d5d838e631e842b880771d01ab905 Author: jrobson  Date:  Mon Sep 30 15:19:38 2013 -0700

Story 1263: Add previous and next buttons to diff Change-Id: Ib38aafc59900f8bb368cb11721b98dddb3973ac7

commit 0e9a7acc68e8b8d2754065e59c1b900a5148f8a9 Author: Max Semenik  Date:  Mon Sep 30 23:30:45 2013 +0400

Add Profiling to Special:UserProfile Change-Id: I970033c4538b504b02fdb437a10ec0dfa38e6341

commit 3adc1b41ad262425aabc51bdfecde0214e5edd67 Author: Juliusz Gonera  Date:  Mon Sep 30 12:59:45 2013 -0700

Regression: Don't close drawers when tapping on them Currently in alpha you can't click Login or Sign Up because the drawer closes before the click event is fired. Change-Id: I3cbb71e40256b69487e6aa1ae3988871972cf4df

commit d49485bf48733dac8b94d3d0fe1c49ad4caf7b73 Author: jrobson  Date:  Mon Sep 30 11:48:43 2013 -0700

Only show smiley face in beta Kenan was concerned about a prominent UI change going straight to stable, reverting to old icon in stable Change-Id: I75a7fbf50f059581d73b1c8fa567a2f372e8e251

commit 2de227e57b0933cb8133a2e717a89f3826258c45 Author: jrobson  Date:  Mon Sep 30 11:29:28 2013 -0700

Hygiene: Run make less Change-Id: I7f75f9cb8ec7b0643b55da0ce9cdd149b2c3f20f

commit c96db739c3476db0d135f1700f7741f047225968 Author: cmcmahon  Date:  Mon Sep 30 10:25:20 2013 -0700

number of languages varies in each test env Change-Id: I88d96f5b8fc969c50c5a1cf78bca886dfd19852d

commit bef544b308757b071edacf3c907a9a512b26a053 Author: Translation updater bot  Date:  Sun Sep 29 20:07:00 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I9ac5e6e39a6e9cedac1f3442915d6f263d0ab390

commit 9a37a4209088f93c600590ef1ba832fdd122f64c Author: Ebrahim Byagowi  Date:  Fri Sep 27 10:18:00 2013 +0000

Using language aware comma and native digits on MobileDiff Change-Id: I0408f95ab327db1b27132a5eb50c8b5d55f373c0

commit fe30882760d13d93598b9813c46e996b6a49b4e7 Author: Max Semenik  Date:  Tue Sep 24 19:42:50 2013 +0400

Add context to GetMobileUrl hook Change-Id: I7a888e78df3a149b7c514c4ae4994eaa92122c18

commit a67aa9db36cd09ddcd0220ab7217fa1264a3b421 Author: Max Semenik  Date:  Thu Sep 26 20:19:02 2013 +0400

Get rid of MobileContext::singleton in skins Change-Id: I8f175d67895a2ef8378a7347e84b63655e079a3a

commit 29fe232e942ff6e1b79971a5729aeffc968dafc9 Author: kaldari  Date:  Wed Sep 25 18:21:18 2013 -0700

Migrating Mobile thanks into Thanks extension Adding mobile.stable.common as a dependency for mobile.mobilediff.scripts since we need it for the toast and mediawiki.jqueryMsg. Plus we'll need more of it in the future for support of profile features. Also changing the Thank button to green per Vibha. Hardcoding it   for now, but eventually will use mediawiki.ui instead. See also: change Ifaf44fe8 Change-Id: I56e2c5bc69f85e83ab3dfd9b9e617dbb98661870

commit 337b22be1059bda73c952ac32cb40932735eda41 Author: jrobson <jrobson@wikimedia.org> Date:  Wed Sep 25 11:26:19 2013 -0700

Story 475: Add EventLogging to profile clicks *Add generic form of click tracking to mobile * Turn the watchlist interaction schema into a more generic schema * Use this schema to track clicks in the hamburger menu in beta mode as well as the existing clicks Dependency: I68b537e6a813b1866403135fb9d3bb7db6ca32f3 Change-Id: Icc50587a107c42caaf8441b1608d35b5cc0da97b

commit 62394e2274387247482534c45bb982c0c25bbf1c Author: Amir E. Aharoni <amir.aharoni@mail.huji.ac.il> Date:  Wed Sep 25 13:50:19 2013 -0700

Add convertNumber to localize the distance Bug: 54613 Change-Id: I60f139ae38c344c87175b6214ab4a78a93503fae

commit e94ac377ba65ab2604f5c4eb1ebcee10375d81ce Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Wed Sep 25 18:09:55 2013 -0700

Story 1030: Clean up ui.less In the process: * remove old watchstar code * remove lots of unused, undocumented CSS rules * convert multiple rules (e.g. background-*) into a single rule (background) * increase the size of clearing X in the search input Change-Id: I4929cc38eb7154f2b010ef6378969a6175289947

commit 273e1d97f69574805a37b808da7a74489b877f2e Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Thu Sep 26 12:20:12 2013 +0000

Fix typo. Spotted by Jean-Fred and reported at https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Mobile-frontend-profile-user-desc-3 Change-Id: I5b159994bda221dc932a70b0354c669aa15aaa6e

commit 2a9cca62391318b1431e8664ec5a7e2f254c4421 Author: jrobson <jrobson@wikimedia.org> Date:  Mon Sep 23 17:33:50 2013 -0700

Story 475: Link user profile from left menu in beta This completes story 475 Change-Id: If019249cc06cc4fef35fc5146cd726fbbb0149b8

commit b1a6556767091eb5642ba1b7fa4accd183ce12b0 Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Wed Sep 25 22:53:08 2013 +0400

Don't display file name with underscores Change-Id: Iddc849bd16abbcb956d3d2bcdf17559b776e12a8

commit 9944ccf4ce8ed77502b2836dd199ed3009182d6b Author: jrobson <jrobson@wikimedia.org> Date:  Wed Sep 25 10:25:22 2013 -0700

Regression: Fix previews previews broken by I28fdffca6d160b68ca1b37bcefc2e033a742568e add workaround for bug 54607 Change-Id: If367d4de53ccb73f0818d9d1886903bd6654ced1

commit fcdd1a7bd7e264749e7c91b9673f51c7846e0e70 Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Wed Sep 25 20:44:07 2013 +0400

Use mobile-friendly HTML for previews Bug: 54243 Change-Id: I28fdffca6d160b68ca1b37bcefc2e033a742568e

commit 568aeb35e5db69b37cbb46e7e2dd114b7a8b0651 Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Wed Sep 25 18:28:02 2013 +0400

Check latest revision in mobileview Bug: 53378 Change-Id: I9862785a26e0ceab5de3bea9b335a81a006acc46

commit 3faf50c4cfea1df0a3e5cfec102076746d8688da Author: Michelle Grover <jcmish1@gmail.com> Date:  Tue Sep 24 23:18:12 2013 -0600

QA#1251 Create a first time user to make sure that the tutorial displays for uploads Change-Id: Ifbe7068a8cf13bf3e9ca032309dce8bb1cf977c2

commit 86e7e409d85ba1cc4fc2825a463ac6e7e6f7a812 Author: cmcmahon <cmcmahon@wikimedia.org> Date:  Tue Sep 24 16:44:22 2013 -0700

link text is not consistent, check for target instead, see comment Change-Id: I8b038ae1145b97991033b054cbfe67e6b667ccdc

commit 993034845085d11ed8fc2983c8fa20f565080b0d Author: kaldari <rkaldari@wikimedia.org> Date:  Tue Sep 24 16:36:10 2013 -0700

Add comments about localization of licensing strings. Change-Id: Iac3a1d117898b9922c7528a9a1d53cba5b767898

commit a6ec15f2ca5c3fec91d5c2b581bbefea12bf3ddf Author: jrobson <jrobson@wikimedia.org> Date:  Tue Sep 24 15:23:06 2013 -0700

Profile: Get correct file for profile page Change-Id: Ida433b4f165dc60181e7c25a15cee2dae84a1409

commit cae2a7fd2187d12be47ec61561de2a9229295168 Author: jrobson <jrobson@wikimedia.org> Date:  Tue Sep 24 15:20:38 2013 -0700

Bug: Check user exists before trying to render it. Change-Id: I14820a9508ad4d0b750ef5671d62dfdccba1e6df

commit c7950f1e1b7ba8ab9f7583e67153100f03a1d48f Author: jrobson <jrobson@wikimedia.org> Date:  Tue Sep 24 15:00:31 2013 -0700

Regression: Don't enable toggling on main page We didn't used to so let's not do it now! Change-Id: Icc50bddf9433738fd5dd16c04d6338650ba70447

commit d4ca2fc63f1d9ec40149e151277a7e877da4f5fd Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Wed Sep 25 01:50:53 2013 +0400

Fix fatals Change-Id: I39f2f4d66ad340b395ecf66e259fab2f8a59bda9

commit da82e005b465210c36052bce70f8e504e2defa04 Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Tue Sep 24 14:18:51 2013 -0700

Make language variant selection possible on all pages Previously variant selection was available only on pages that had language interwiki links, but all pages have variants on wikis with variants enabled. Bug: 54414 Change-Id: Id21a6ebc055b6f6bf49debb307751a7dbe026317

commit fdd0009dcdb5c7ebeef23ea225ed051a40817e39 Author: jrobson <jrobson@wikimedia.org> Date:  Tue Sep 24 13:39:01 2013 -0700

Regression: Exit talk after a successful save of a new topic Currently takes you back to parent overlay and it looks like nothing was added. appendSection function looks broken so removing for time being Change-Id: Iee10d9a4eec4d750b5dbb800cb10dc8b68314e66

commit 90cb24b112aac9fda9ff041ac3ffeaa28b3f8c82 Author: jrobson <jrobson@wikimedia.org> Date:  Tue Sep 24 13:38:37 2013 -0700

Regression: Ensure cancel button label loads for talk overlay Broken in I4aa7976e88dbb214e37c7c6aae082a82623d3a3d Change-Id: Id4e3657006052d86c9e80682568981691953b773

commit 38583bf5e5da2acd6eb2711b133955a090f800a9 Author: jrobson <jrobson@wikimedia.org> Date:  Tue Sep 24 13:29:07 2013 -0700

Regression: Fix echo overlay for Echo in beta Also broken by UserProfile refactor Change-Id: I68b6b0fc779afd83b53bcd5fa2b6dc90086b3148

commit 3445225c4bf72aae798252ee8adfb95d0907273f Author: jrobson <jrobson@wikimedia.org> Date:  Tue Sep 24 13:19:10 2013 -0700

Regression: Remove Echo button from Nearby page / anon page views This shouldn't be here. Broken in profile change. (I59ed57fcd2c75788f42d6d306cba81719c964204) Change-Id: I12dfe25e9a0fc40fef319acaf2591d8821d2f3e3

commit a848515f8b3ecec709f80a0edaa2cbf39739a7d2 Author: Michelle Grover <jcmish1@gmail.com> Date:  Tue Sep 24 12:55:56 2013 -0600

QA-id changed for Notification to secondary-button from user-button Change-Id: I0cd6aeb869fdddd30a85b822269ea191685267a7

commit 9b70001083313c02dc17f7f18e7643a55e19365b Author: jrobson <jrobson@wikimedia.org> Date:  Mon Sep 23 17:39:47 2013 -0700

Profiles: Stop the heading from being a link Vibha and Kaity have said this is confusing and the user page link should be surfaced in an alternative way. Change-Id: I8b972daa09efb9d1690da19c6a9ed2886cc4e111

commit 40634d69ca0aaa5c3db8a07eef3fad0812e9e11a Author: jrobson <jrobson@wikimedia.org> Date:  Mon Sep 23 17:01:58 2013 -0700

Beta: Link diff page to user profile Part of story 475 Change-Id: I295794bfbf4bd47513487fbb5483ec56a9d1d742

commit dfefa8fc6d96c2fba850bfecf4a30f9ee0248587 Author: kaldari <rkaldari@wikimedia.org> Date:  Mon Sep 23 16:17:04 2013 -0700

Use shorter text for some common licensing strings in the footer Unfortunately, this is a bit hacky since the installer only stores the license as a string. Change-Id: I1aed744919f55134456a09b6c9c9d2e627b75c0e

commit c1668a96cba128fdd725371b90ea3ab3c3446d0c Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Tue Sep 24 03:47:37 2013 +0400

Debug logging for latest PoolCounter weirdness Change-Id: I2f86bf9c80d1dc8edde08982216c6583a20ca82c

commit eb7d182a81e07e497813c8bf59c18ba3eae9c058 Author: jrobson <jrobson@wikimedia.org> Date:  Mon Sep 23 16:30:38 2013 -0700

Alpha: Update title of page on a lazy load Change-Id: I104a718017bcbe17ff8f44ba2f843b0b61c5b428

commit 80d2596c007fe2012fd8a3f58da7346bba00e29b Author: jrobson <jrobson@wikimedia.org> Date:  Mon Sep 16 13:39:30 2013 -0700

Stop refreshing page on a hash change Keep tabs on the current url and only do so when the url changes Bug: 54238 Change-Id: I819600b87c63fa5aef10039f73808e3e225aa982

commit 15689acf09e03cea3b7d0eb0c953dd6227254688 Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Thu Sep 19 17:46:35 2013 -0700

Clean up login/create account form and captcha CSS Now that it is reused in the editor too, CSS can be shared. Change-Id: I6f909baaf2fc764484a009d7be2e32dbee78d8d2

commit 357be27901c06f6db18c9293e882a42fd389e127 Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Thu Sep 19 17:12:24 2013 -0700

Story 1163: Mobile Captcha support for editing Add support for FancyCaptcha from ConfirmEdit extension. Reuses captcha styling from account creation (CSS cleanup in the following commit). Bug: 52047 Change-Id: I4850ed8eade5e76d141155d40f7ccd83d9cdfa57

commit eaef5a57dc545c0bbcce3886756bc838ad1b5cde Author: jrobson <jrobson@wikimedia.org> Date:  Tue Sep 17 14:34:51 2013 -0700

Collapse on h1s when present * When h1s are present collapse on these rather than h2s Bug: 52857 Change-Id: I5e8d723d061f7003599b2a7f639bbe1301ba92e0

commit c2a9e0531fc65d91718d10ce1a76997feb6bac5d Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Fri Sep 20 12:31:27 2013 -0700

Update templates to contain new mobile edit links They should reflect server generated markup. Also, without this change section editing links would stop working after removing obsolete code from editor.js (FIXME on L89). Change-Id: I160a7d5ff7d6fc025cbd518b9f37d3caa54965b4

commit fd45ff3c0c145c2e3642adab0b63cc364a55a8cb Author: jrobson <jrobson@wikimedia.org> Date:  Tue Sep 17 10:29:04 2013 -0700

Leave width of image rendering of infoboxes up to the template However make sure it doesn't exceed the size of the viewport * Disclaimer: This will break rendering of image on phones that do   not support max-width and have resolutions smaller than the image - but this should be left to the template to take care of   Bug: 49440 Change-Id: Iec09df6c8a513287d24f29dba1700c58a155a5ae

commit 1df7a5c888d3b9c359f75c4c2654a73866df662b Author: jrobson <jrobson@wikimedia.org> Date:  Mon Sep 16 15:57:56 2013 -0700

Improve nearby error handling Bug: 53342 Change-Id: I7686553a66021ce8e63437521a1b6bdddcc28024

commit 74156462ee0b4a7eb9cbf02b90a159fa70f07a7c Author: jrobson <jrobson@wikimedia.org> Date:  Fri Jul 26 17:24:43 2013 -0700

Story 475: UserProfile special page (first pass) Change-Id: I59ed57fcd2c75788f42d6d306cba81719c964204

commit 0c6161ab46e9357d4e143891651c65e749958b30 Author: jrobson <jrobson@wikimedia.org> Date:  Mon Sep 16 16:52:09 2013 -0700

Redirect to talk page when liquid threads enabled Bug: 51586 Change-Id: Ie1bb49e3395a7286d7fa84f41b39a83624bff9f4

commit 57657fa689c07359b08849e9beb828f9dfb00641 Author: jrobson <jrobson@wikimedia.org> Date:  Mon Sep 23 12:23:38 2013 -0700

QA: Add QA tests for I3f49cd50ed0c1778f8914b45cbc492fcc1775ca6 Change-Id: I33c8a64ddb521a3bdaf2f1371fcf45b021a2014f

commit 923b6ea10069e947b228fb5eee30205f436eeecb Author: jrobson <jrobson@wikimedia.org> Date:  Fri Sep 20 14:07:10 2013 -0700

Regression:Restore the First time user uploads tutorial * Restore the styling of this page Bug: 54386 Change-Id: I3f49cd50ed0c1778f8914b45cbc492fcc1775ca6

commit 2be64cb80321eb5339cd63cf250e2eebfdbb4af7 Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Fri Sep 20 12:41:18 2013 -0700

Show proper button bar in editor on errors Errors happen when the preview is visible, not the textarea, so if an   error occurs when saving, we should show preview's button bar. Change-Id: I1d1222770fa5b498877ba5b917bee7e013a2e780