Extension:MobileFrontend/Deployments/2013-01-17

Stories
Log watchlist star use - https://mingle.corp.wikimedia.org/projects/mobile/cards/310 Watchlist - last edited time on a-z list view - https://mingle.corp.wikimedia.org/projects/mobile/cards/308

Bugs
Page title doesn't update when a page is loaded - https://bugzilla.wikimedia.org/show_bug.cgi?id=43631 Distinct edit summaries/tags for image uploads via mobile - https://bugzilla.wikimedia.org/show_bug.cgi?id=43490 Donate image page broken(beta) - https://bugzilla.wikimedia.org/show_bug.cgi?id=43788 File pages broken in beta - https://bugzilla.wikimedia.org/show_bug.cgi?id=42741 Special:MobileDiff: Call to a member function getPrevious on a non-object - https://bugzilla.wikimedia.org/show_bug.cgi?id=43267

Uncategorized
* Remove all inline styles from #content in alpha * Center the content of Special:MobileOptions/Language page * Don't show the photo uploader on edit page when action parameter is set * Refactor test for infobox and navbox loader * Add the ability to unwatch articles in the watchlist view (design input needed) * Fix broken history link in Beta * Code Cleanup - move global variables to javascript * Localization changes * Device detection refactor

Git Log
commit f7d78fea9032dc8f4512a4806a8fae38142c0516 Author: Max Semenik  Date:  Sat Jan 5 01:39:28 2013 +0400

DeviceDetection improvements * Add a method to detect if user agent is mobile for folks who don't     have infrastructure as complex as ours, based on current Squid ACLs. So far it's not used * Switch all device capabilities querying to OOP interface * Use DeviceDetection::factory which allows to override our device detection * Refactoring Change-Id: Ifcd7c34572c6864978d55e775298bae91b64fbb6

commit 2059da86432a9a927375310e561a978f8717ad2e Author: jrobson  Date:  Thu Jan 3 23:14:27 2013 +0000

don't throw exception when bad revision id given (bug 43267) 404 when one is given Change-Id: I973c443287a6bf2bbf1aa08eb60ee5f2cd3c951c

commit 2c8d63b16ceeb48eff8ce134d0303f508abf5e32 Author: Translation updater bot  Date:  Tue Jan 15 21:32:42 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: Ie13f13bd42d543cb5f73ac9945e697be1b1895b4

commit 61c120372fa4d7a26be7138d2322d305deeff0a0 Author: Juliusz Gonera  Date:  Mon Jan 7 17:28:49 2013 -0800

(card #308) Add modified date to All view in watchlist [beta] Change-Id: I5ba50088de855c814777a401101b1659f0b96515

commit 0efffb50a3faf4e0e5d9c0b686e8c11b5d7d2e34 Author: Translation updater bot  Date:  Mon Jan 14 21:54:48 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: If577b54c439bbc84ee00a2c779ec17bbfda7c9ec

commit 1a99e106f5a9898957bda0e144e239af9368fc05 Author: jrobson  Date:  Wed Dec 26 23:14:33 2012 +0000

don't remove the sections on file page / remove special casing (bug 42741) this stops sections from being scrubbed on file pages the result of this is sections on the file page cannot be toggled if toggled sections are wanted this should be done on the server side or   at the very least involve refactoring mf-toggle.js/mf-toggle-dynamic.js    Change-Id: I5cf27696bb89bdfd3b283659efcce552ccb97c0e

commit 1f289674b8024e6d3e2889227ce670eda38c1a77 Author: jrobson  Date:  Wed Jan 9 14:24:54 2013 -0800

log watchlist actions (beta) this completes story 310 Change-Id: Iae3a0dbf581945882f759543b62176d95bfa3283

commit a91d0423b3ade548b0c1b980bda2a9529b612ada Author: jrobson  Date:  Wed Jan 9 13:56:25 2013 -0800

bring global variables to javascript brings us a bit closer to a desktop like js   environment Change-Id: I003737c3bb92336aa5c4896c6409182023c35fb2

commit ed9fa25fd055da1ee59431468c16e50372329cf6 Author: jrobson  Date:  Wed Jan 9 18:45:09 2013 -0800

fix broken history link in beta stop double encoding but do prettify.. Change-Id: Ic81937892398a860b296c13c9f6dd5700ffc2ed3

commit a145dbda2c011bdc563b27e00a78f7a2a821a57d Author: jrobson  Date:  Wed Jan 9 18:28:23 2013 -0800

allow ability to unwatch articles in watchlist view no design input as of yet - but seems that the right of the a-z list item seems a logical place Change-Id: I172f50a6444d7876cbce8cc1a49ab2011b3ce5d4

commit fa0485372e83cf8dfa33b0e22fe7ff851f901fad Author: jrobson  Date:  Wed Jan 9 17:45:55 2013 -0800

Make test for infobox and navbox's stricter Certain articles have a .navbox or .infobox in a section other than the lead These need photos e.g. http://en.m.wikipedia.org/w/index.php?title=Todd_Heisler&oldid=523920334 Change-Id: I1da573554cc331db74cf4a63e88352dc52f3fbf7

commit f285ea672066e86aba34b4b303e8dbf60eccf221 Author: jrobson  Date:  Wed Jan 9 17:41:19 2013 -0800

don't show photo uploader on edit page don't show it when action parameter is set Change-Id: Ib3e41366832066f9c986c0485982c027a34259cb

commit 9fb6f08543290b7b3f1e087211648b6aea9313af Author: jrobson  Date:  Wed Jan 9 09:21:48 2013 -0800

show photo upload on Special:DonateImage (bug 43788) mf-user-gallery is being prevented from working due to relying on   the supported property of the photos module The supported property should just say whether the user is allowed to   upload and should not limit the context - the init function for mf-photo should check this itself Change-Id: I5bb9d41639e2e4658618f187988405ffc80b2709

commit efd8bc4aff807ffbe84eb645c6f93a43f4958834 Author: jrobson  Date:  Wed Jan 9 09:17:21 2013 -0800

distinguish between images uploaded for articles / donated images (bug 43490) if an article is just uploaded but not used give it a different edit summary Change-Id: I663401fa1f34d6cc1d4d28ab58af98e5e156da9e

commit 3c4b76f4187b0bb34a033e2cc56c0a1408f3b0f9 Author: jrobson  Date:  Wed Jan 9 09:00:42 2013 -0800

update page title on dynamic page load (bug 43631) Change-Id: I927e2dfbeeb2d763296d00607975ec1a0376af1a

commit 5053cafb7f21860a2b49c6be9d4f3628abdddbc7 Author: jrobson  Date:  Wed Jan 9 08:45:32 2013 -0800

center the content of the Special:MobileOptions/Language page Change-Id: Ie1e7cb4f561799b2a17dd6b99b53219da11079d2

commit 1e8678090653740a4acca8588bf7c02acd75a93f Author: jrobson <jrobson@wikimedia.org> Date:  Tue Jan 8 11:45:25 2013 +0000

experimental: remove all inline styles from #content in ALPHA This bold move scrubs inline styles from alpha. This allows us to   assess the benefits inline styles provide and use this as a springboard for targeting styles via classes and stylesheets instead. This is cheaper than doing on the server side. See http://www.mediawiki.org/wiki/Deprecating_inline_styles for more information on problem Change-Id: Ia36ed825fbfb5290af06382d35cc61102b1457dc

Stories
Photo upload improvements - https://mingle.corp.wikimedia.org/projects/mobile/cards/282

Bugs
Fix wrong picture linking due to link hijacking - https://bugzilla.wikimedia.org/show_bug.cgi?id=43539 Make sure Toast Message is centered - https://bugzilla.wikimedia.org/show_bug.cgi?id=43755 Add pagination to watchlist a-z view - https://bugzilla.wikimedia.org/show_bug.cgi?id=43254

Uncategorized
* Automation Tests for Adding/Removing articles from the watchlist * Code cleanup remove unnecessary items now that screen scraping has been disabled * Localization changes * Automation test framework changes * Move jQurery history related code to mf-history-jquery * Add additional constraints to make sure that code does not bleed over into production that should only be in beta * Watchlist styling * Center account creation just like login form * Fix http detection by disabling secure login by default * Load EventLogging if it's enabled and present * Correctly position the edit link * Make search load canonical URLs * Fix watchlist header buttons when the text is too large * Don't output username for anons * Ensure that https enforcement for login/acct creation only happens on mobile * Assume the watchlist has taken the pageimages API into account * Document why the watchlist limit is set to 50 so that it's not arbitrarily raised

Git Log
commit 9d7bf940bf95a68e3985e2946af0b4bcdb812869 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date:  Mon Jan 14 12:45:50 2013 +0100

Updated Ruby gems ffi and page-object. Change-Id: Id7bebaf6c39247a1a3084cb0cd87c6ba4b67017f

commit 54a1a9a75f86d34c751fc3d5ab7f0adbf932b865 Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Sun Jan 13 20:38:44 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: Ib85023022ea2fe8b74a62deec67a11a1e36f6646

commit 890332d8efe0649668b11acc44f3ed01557d1370 Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Sat Jan 12 20:28:21 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I2e85682c963063a5d016bb2ec074d4a2f1b5959d

commit fb4a81be528aa7b022eb90dadc453fa6b6a42994 Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Fri Jan 11 20:34:47 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I3527807e460fbf2b4f3768f736eadacaa3016996

commit 1ded0894cdbc089370a58ba41aeb4db53e5c7345 Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Thu Jan 10 21:08:43 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I5efccc6a38b300c5fa6e845333a8cff2af136988

commit 7e48a2a7350665c2256a2e9a72c9257972d599ae Author: jrobson <jrobson@wikimedia.org> Date:  Thu Jan 10 10:35:39 2013 -0800

assume the watchlist has taken pageimages api into account document why the limit is 50 so no one ups it   Change-Id: I8c9b9ba1885a6640ec9087c635e7e81be44dd65a

commit f854fe961724803a691f0a1d2c429ef865f3b7cc Author: awjrichards <arichards@wikimedia.org> Date:  Wed Jan 9 14:57:35 2013 -0700

Ensure https enforcement for login/acct creation only happens on mobile Without this change, if wgMFForceSecureLogin is set to true, then all attempts to access account creation will be sent to the mobile version of the site, even if the request was made from the desktop version of   the site. This was a bone-headed oversight. Change-Id: If8cb2e7d81c8466b1506bde19ffd4a4ab061d2b0

commit dee00285b1551147229a284377cb8bb3e00c9405 Author: jrobson <jrobson@wikimedia.org> Date:  Mon Dec 24 11:07:22 2012 +0000

add pagination to watchlist a-z view (bug 43254) add more link to the bottom of watchlist page in future this should be hijacked to work with infinite scroll Change-Id: I4193c8e21a8db1cc14a1348bde8e5103d15eb276

commit 55b3fea2d5c7b328a508bdf185ef85e7383eb17c Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Wed Jan 9 22:14:25 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: Ic959f79d71af4d8352313000dd0f5fc4f2a7151d

commit 7b4faee0b9b29dbc04047960652edf5bdb3a0d85 Author: jrobson <jrobson@wikimedia.org> Date:  Wed Jan 9 11:03:40 2013 -0800

Make sure the toast message is always centered (bug 43755) Change-Id: I7e375bd0b733974ccb336958a0a64daaef93eebe

commit 70a9eaf39b6fafac3f770fbc4e2299a3bf80b3db Author: jrobson <jrobson@wikimedia.org> Date:  Thu Jan 3 21:22:00 2013 +0000

don't hijack image links (bug 43539) also restrict to beta - this shouldn't have leaked into non-beta Change-Id: I0823376c24d9807a8d50ab225f90a2281f6dbc86

commit d2ded4bff80fe3fa75d180c98f3c3b5925c34643 Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Wed Jan 9 17:51:55 2013 +0400

Don't output username for anons Change-Id: I821a7c5b35fc679c986b37e92017d08ed94076cf

commit 0eceb4a78d7244a1fd89dd7c99f240fa16ad2335 Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Tue Jan 8 14:18:01 2013 -0800

Fix watchlist header buttons when text is too large Don't make them duck and keep button text in a single line. Change-Id: I0dae117234c028890b55d0e270e0a2d239fdf8c8

commit 9ba514fc240d0e9df86ee8e8150e36b4dadf5238 Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Wed Jan 9 01:28:24 2013 +0400

Fix switching to HTTPS Change-Id: I9d151dda0979ea7b69231e6868cf6ad42da55a3c

commit 9388c6f75cc4696c31dbe59168f8b280dc98c472 Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Tue Jan 8 20:28:58 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: Iefc43daf6d636f3d6b183bb3dc48e1265820b9a4

commit 81cd427c5435e7dfb27b94b346f07fcfe8e021fd Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Tue Jan 8 18:38:32 2013 +0400

Make search load canonical URLs Change-Id: I5cf0480340e6bf59119e726e0d7545c26e3ae8e4

commit 81ff32e0ae4a3ff14a559287d6e2b6ab68adc127 Author: jrobson <jrobson@wikimedia.org> Date:  Tue Jan 8 17:53:29 2013 +0000

correctly position edit link Change-Id: I783588a23a9a28f199df26698b1463e2ec7d8e14

commit 1df1dbbd52f1f5b2f3afa27f4585a0b450c7706b Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date:  Tue Jan 8 13:01:59 2013 +0100

Do not set MEDIAWIKI_URL env variable automatically This got commited by mistake, reverting. Change-Id: I3c5d830d4ba2fc872714f16e8dc6118d6ce80b0a

commit 6b5cffbbc8ee850a9916a87b567e001b8db49542 Author: jrobson <jrobson@wikimedia.org> Date:  Mon Dec 24 09:57:33 2012 +0000

promote photo uploads to beta this completes 282 Change-Id: I9d69b56384ced3c29b12191306efdd0d4ab33f32

commit a0c8076735a27d3e88ff9d29161f7b6a51a0604a Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date:  Tue Jan 8 11:02:09 2013 +0100

Updated Ruby gems chunky_png and ffi. Change-Id: I72c21e2684062adbd31978bd715ad764fe80af5c

commit c3800e5ca0a6fcfb8f28c297165e377637c4b505 Author: Ori Livneh <ori@wikimedia.org> Date:  Wed Jan 2 17:17:18 2013 -0800

Load EventLogging if it is enabled and present. Change-Id: Ic7745dcd48cc2c94833aeec16bb8957541dc531f

commit 917fb5ac82b76c5df19b85c2d8f455682aced7e2 Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Fri Jan 4 03:14:44 2013 +0400

Fix https detection, disable secure login by default Otherwise, lots of wikis, including dev ones, will break Change-Id: I86ef72107b440651f8fc98a8327f9310c1982855

commit 67e8d86abc7c7edae8e2140519199de02c02f17b Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Mon Jan 7 20:58:16 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I798066623d42175b0bbd96f83a902f83e88cb008

commit de7d5d8006869fe91455d614a865ad10dc6b190c Author: jrobson <jrobson@wikimedia.org> Date:  Fri Jan 4 15:09:38 2013 +0100

move account create into center just like login form currently too squashed at edges Change-Id: I571f07256db60e56c226a3ef8e5dc2f452bac8fb

commit 9e46d47a98787ccd1a2de7e5823fb49084b9d5f6 Author: jrobson <jrobson@wikimedia.org> Date:  Fri Jan 4 15:19:45 2013 +0100

ensure diff/watchlist is styled regardless of whether js available previously with javascript disabled the page would appear completely unstyled. This is significant when we consider browsers without jQuery Change-Id: I0199b2a8780adac3323b018ca6ed6465ad46aa8a

commit 05759f876e7aa9d5464acd3b5fc33ed686da3f9c Author: jrobson <jrobson@wikimedia.org> Date:  Fri Jan 4 11:55:00 2013 +0100

move jQuery history specific code to mf-history-jquery untangle messy code isolate to beta to allow more experimentation without fear of breaking production Change-Id: I39e1ad46d6033e6e3ba95b73341a8d80b828b343

commit e995c2d9c7d3236c63d7e841c79ff4f0634dfec1 Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Sun Jan 6 20:12:26 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I2d40c11f16f49cda08f03fede22e986463c87f0a

commit d59c5e9f6d06af59067773143aca3b967be9fba1 Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Sun Jan 6 04:03:41 2013 +0400

Clean up items to remove Lots of this stuff became unneeded after we stopped screen-scraping. Improves performance a tiny bit. We should remove more selectors, this commit removes only a 100% safe set. Change-Id: If8e3cc9262a87a7085b3883dfb20fa4ff6b6001c

commit e8f2e6d0140f913ebbbd9bd57a4c9aecf2026221 Author: Michelle Grover <jcmish1@gmail.com> Date:  Fri Jan 4 00:45:44 2013 -0700

add/remove articles to/from watchlist Change-Id: I8f26582e0b30c0bc8649077e6d4cc42e093ff74e