Thread:User talk:Cryptocoryne/Extension:AutoProxyBlock

hi! you asked me a question on irc, but then didn't respond when I did. So I'm cnp'ing it here incase you missed it.

16:34 Hi. I write to you accord to Sumana's answer, as a extension developer. Please review http://www.mediawiki.org/wiki/Extension:AutoProxyBlock and source code (I commited code in svn) 16:36 Hello, Sumana sent you to me? 16:38 I'm pretty new at all this stuff myself. Don't even have svn access yet 16:39 but I have made a few extensions so maybe I can share what I've learned through the project so far 16:39 in AutoProxyBlock.i18n.php it seems to be the convention to prefix your message names 16:40 I'm not sure how important this is, or if a collision is even possible, you'll have to ask in #mediawiki 16:40 I know you make a new $messages each time, but is it then merged into a bigger common array? I don't know 16:41 for AutoProxyBlock.php 16:42 I suggest setting the 'version' key for $wgExtensionCredits, yes you will have to update it yourself, however extensions like Extension:Update currently use it to let administrators know there are new versions out 16:42 eventually it will allow svn/git checks but it's a really tricky world in terms of "what constitutes a              release" -- version keys are clear. 16:43 you can use __DIR__ instead of dirname(__FILE__), but that's ultra minor. 16:46 generally if your global variable is not in core, you'll want to make sure you prefix it to avoid collisions 16:46 so $wgAutoProxyBlockSources is a great variable name 16:47 but $wgProxyCanPerform is not, because maybe some Extension:Proxy will use the same name 16:49 for AutoProxyBlock.body.php 16:49 it mostly looks ok, but generally you want to set the referer to your extension for Http::get 16:50 Http::get is more for the core, you'll have to use the more general purpose function so you can set the referer. 16:50 although there is a bug report so we can set referer in ::get 16:50 anyways, like I said I'm a beginner here too, although a few weeks ahead of you. I hope it goes well and if              you discover any secrets please send them my way! 16:51 the extensions I work on are listed here, if you'd like to take a look: http://www.mediawiki.org/wiki/User:Olivier_Beaton