Reading/Multimedia/Scrum notes/tgr

Last update on: 2014-07-28 Previous update on: 2014-07-25

2014-02-06

 * Yesterday:Prev/next preloading, small bugfixes, code review, OPW weekly review
 * Today:Fixing reviewed patches, Show Permissions (maybe)

2014-02-07

 * Yesterday: Fixes to prev/next patch per review (including refactoring of bucketing code), fix for showing metadata panel in fullscreen mode
 * Today: Some more prev/next fixes, code review, permissions 

2014-02-10

 * Yesterday: More prev/next refactoring, merged loading time logging, added license to Commons test images
 * Today: Even more prev/next preload refactoring (sigh), OPW, fix up low res loading prototype

2014-02-11

 * Yesterday
 * Prev/next preload refactoring (dragging on and on...), OPW review and weekly video chat, review of design documents, fix for some bugs in code merged earlier


 * Today
 * Finally finish prev/next, whatever ticket is still free

2014-02-12

 * Yesterday
 * Finished prev/next preload refactoring, fixed some more bugs related to event handling and earlier refactoring.


 * Today
 * OPW review, move debounce to core (also needed for OPW), look into double requests caused by perf logger, permissions.

2014-02-13

 * Yesterday
 * OPW review, move debounce to core, permissions


 * Today
 * permissions, code review, test data URIs on IE, finish up anything still open from last iteration.

2014-02-14

 * Yesterday
 * Finished permissions (still needs design input), went on some bug hunts: keydown handler leak, event logging (didn't find anything, must have been old code), resize issues (to be cont'd)


 * Today
 * More bug hunt, alternative proposal for url logging, re-test JSDuck puppet conf, test data URIs on IE, continue with other permissions card

2014-02-18

 * Friday
 * Experimentation with URL logging (ResourceTiming API), several fixes


 * Today
 * Code review, more bug hunt, re-test JSDuck puppet conf + make it a standalone role, test data URIs on IE, continue with other permissions card

2014-02-19
<section begin="2014-02-19" />
 * Yesterday
 * Code review, some bugfixes, test data URIs on IE (they don't work)


 * Today
 * More bug hunt (tests still break in strange ways), re-test JSDuck puppet conf + make it a standalone role, continue with other permissions card<section end="2014-02-19" />

2014-02-20
<section begin="2014-02-20" />
 * Yesterday
 * Fixed unit test bugs, fixed tests for permissions, tested image preloading & removed data URIs


 * Today
 * Fix up reviewed cards, fix JSDuck in vagrant, code review, continue with other permission card <section end="2014-02-20" />

2014-02-21
<section begin="2014-02-21" />
 * Yesterday
 * Fixes based on reviews (permission, cross-origin preloading), code review


 * Today
 * uhh... forgot to write this in time <section end="2014-02-20" />

2014-02-24
<section begin="2014-02-24" />
 * Friday
 * Participate in IRC office hour, code review, fix up reviewed cards, OPW review


 * Today
 * this too<section end="2014-02-24" />

2014-02-25
<section begin="2014-02-25" />
 * Yesterday
 * code review + fixes, bugfix for #253, merge MultiLightbox into MultimediaViewer (#177)


 * Today
 * Code review, fix JSDuck in vagrant(#142), pick other permission card (#197)<section end="2014-02-25" />

2014-02-26
<section begin="2014-02-26" />
 * Yesterday
 * Code review, fix JSDuck in vagrant(#142), permissions bugfix + provisional 'view more' functionality to, OPW weekly chat


 * Today
 * OPW support, proper 'view more' support in permissions<section end="2014-02-26" />

2014-02-27
<section begin="2014-02-27" />
 * Yesterday
 * OPW support, code review, attempt at 'view more' with dotdotdot, fix $.color in core.


 * Today
 * (forgot to fill)<section end="2014-02-27" />

2014-02-28
<section begin="2014-02-28" />
 * Yesterday
 * code review, bug tracking and fixes (62019, 62033)


 * Today
 * (forgot to fill)<section end="2014-02-28" />

2014-03-03
<section begin="2014-03-03" />
 * Friday
 * Sitelink middle-click fix, searching for a good way to avoid promise rejection chains


 * Today
 * Finish promise handling improvements, take next card<section end="2014-03-03" />

2014-03-04
<section begin="2014-03-04" />
 * Yesterday
 * Code review, logging of promise rejections, turn LightboxInterface into a proper UI class (almost)


 * Today
 * Finish turning LightboxInterface into a proper UI class, merge MultiLightbox into LightboxInterface<section end="2014-03-04" />

2014-03-05
<section begin="2014-03-05" />
 * Yesterday
 * Code review, finish turning LightboxInterface into a proper UI class, merge MultiLightbox into LightboxInterface


 * Today
 * Bug triage, finish merging classes, help with share/embed or pick new card<section end="2014-03-05" />

2014-03-06
<section begin="2014-03-06" />
 * Yesterday
 * Bug triage, merge MultiLightbox into LightboxInterface, fix bug 57620 (black-on-transparent images are invisible), start download card


 * Today
 * Lots of meetings, continue with download card<section end="2014-03-06" />

2014-03-07
<section begin="2014-03-07" />
 * Yesterday
 * Lots of meetings, continue with download card


 * Today
 * Finish download card (maybe)<section end="2014-03-07" />

2014-03-10
<section begin="2014-03-10" />
 * Friday
 * Download card + related refactorings


 * Today
 * Download<section end="2014-03-10" />

2014-03-11
<section begin="2014-03-11" />
 * Yesterday
 * Code review, OPW review, bug triage, rebasing stuff


 * Today
 * More OPW stuff<section end="2014-03-11" />

2014-03-12
<section begin="2014-03-12" />
 * Yesterday
 * Tried to setup a Labs instance for the OPW project prototype; eventually gave up and moved it to Amazon


 * Today
 * Continue with download<section end="2014-03-12" />

2014-03-13
<section begin="2014-03-13" />
 * Yesterday
 * Planning meeting, code review, merging patches for share/embed


 * Today
 * Planning meeting #2, code review, share/embed fixes <section end="2014-03-13" />

2014-03-14
<section begin="2014-03-14" />
 * Yesterday
 * Planning meeting #2, rebase/review/fix for metadata animation patch, share/embed fixes


 * Today
 * share/embed <section end="2014-03-14" />

2014-03-17
<section begin="2014-03-17" />
 * Friday
 * Triaged 50399, worked on share/embed


 * Today
 * more share/embed<section end="2014-03-17" />

2014-03-18
<section begin="2014-03-18" />
 * Yesterday
 * Share/embed, bug 62580, some investigation about downloading


 * Today
 * Share/embed<section end="2014-03-18" />

2014-03-19
<section begin="2014-03-19" />
 * Yesterday
 * Share/embed, git wrangling, brainstorming about network performance improvements, Shift-Esc bug


 * Today
 * Share/embed<section end="2014-03-19" />

2014-03-20
<section begin="2014-03-20" />
 * Yesterday
 * Share/embed


 * Today
 * More share/embed...<section end="2014-03-20" />

2014-03-21
<section begin="2014-03-21" />
 * Yesterday
 * Weekly meeting, embed text


 * Today
 * Final fixes to embed text (add license, site information)<section end="2014-03-21" />

2014-03-24
<section begin="2014-03-24" />
 * Friday
 * Quarterly review meetings, add more license and site information to MMV models; debugging per-user opt-out links (62946)


 * Today
 * Finish embed text, pick next card<section end="2014-03-24" />

2014-03-25
<section begin="2014-03-25" />
 * Yesterday
 * Debugging per-user opt-out links (63033), add license and site information to embed text (functionality is done, wrangling unit tests)


 * Today
 * Finish unit tests for embed, strip whitespace in CommonsMetadata, look for other things to fix in share/embed<section end="2014-03-25" />

2014-03-26
<section begin="2014-03-26" />
 * Yesterday
 * Finish unit tests for embed, strip whitespace in CommonsMetadata, small bugfixes for embed (dropdown handling, sanitization, start work on 0x0 bug)


 * Today
 * Fix 0x0 bug, continue with other embed issues<section end="2014-03-26" />

2014-03-27
<section begin="2014-03-27" />
 * Yesterday
 * A utility class + carious small fixes to better sanitize & format HTML code coming from CommonsMetadata


 * Today
 * Fix issues from code review, debug opt-out, pick some more cards<section end="2014-03-27" />

2014-03-28
<section begin="2014-03-28" />
 * Yesterday
 * Sprint meeting, fix opt-out, start on new above-the-fold buttons


 * Today
 * Continue with buttons<section end="2014-03-28" />

2014-03-31
<section begin="2014-03-31" />
 * Friday
 * Code review & testing


 * Today
 * Finish buttons<section end="2014-03-31" />

2014-04-01
<section begin="2014-04-01" />
 * Yesterday
 * Code review, more work on buttons


 * Today
 * Finish buttons for real<section end="2014-04-01" />

2014-04-02
<section begin="2014-04-02" />
 * Yesterday
 * Metadata panel buttons <section end="2014-04-02" />

2014-04-03
<section begin="2014-04-03" />
 * Yesterday
 * Fix code review issues with buttons<section end="2014-04-03" />

2014-04-04
<section begin="2014-04-04" />
 * Yesterday
 * planning meeting, some refactoring, SVG issues, final pass on buttons


 * Today
 * Advanced logic for survey button (popup, site config)<section end="2014-04-04" />

2014-04-07
<section begin="2014-04-07" />
 * Friday
 * Advanced logic for survey button (popup, site config)


 * Today
 * Code review, fix review comments, next card<section end="2014-04-07" />

2014-04-08
<section begin="2014-04-08" />
 * Yesterday
 * Code review, fix review comments, meetings, OOJS-UI issues (#412)


 * Today
 * Code review, fix review comments, next card<section end="2014-04-08" />

2014-04-09
<section begin="2014-04-09" />
 * Yesterday
 * Make Commons link more prominent (#270), BSOD issues (#414)


 * Today
 * Fix review issues, Thumbnail URL guessing (#424)<section end="2014-04-09" />

2014-04-10
<section begin="2014-04-10" />
 * Yesterday
 * Fix review issues, Thumbnail URL guessing (#424)


 * Today
 * Sprint planning meeting, code review, pick next card<section end="2014-04-10" />

2014-04-11
<section begin="2014-04-11" />
 * Yesterday
 * Sprint planning meeting, fix missing icon, debug localization bug (#437/#438)


 * Today
 * Code review, meetings, pick next card<section end="2014-04-11" />

2014-04-14
<section begin="2014-04-14" />
 * Friday
 * Code review, meetings, small bugfixes (c125510, #443), research on URL encoding (#371)


 * Today
 * URL encoding, pick next card<section end="2014-04-14" />

2014-04-15
<section begin="2014-04-15" />
 * Yesterday
 * URL encoding, localized surveys (#420)


 * Today
 * Fix review comments, finish tests for thumbnail URL guessing, pick next card<section end="2014-04-15" />

2014-04-16
<section begin="2014-04-16" />
 * Yesterday
 * Fix review comments, code review, localized surveys (#420/#454)


 * Today
 * IRC office hour, code review, finish tests for thumbnail URL guessing<section end="2014-04-16" />

2014-04-17
<section begin="2014-04-17" />
 * Yesterday
 * IRC office hour, code review, finish tests for thumbnail URL guessing, sinon.js experiments


 * Today
 * CC links + whatever else comes up<section end="2014-04-17" />

2014-04-18
<section begin="2014-04-18" />
 * Yesterday
 * Sprint meeting, bug triage, Firefox scrollbars, download button file type


 * Today
 * <section end="2014-04-18" />

2014-04-21
<section begin="2014-04-21" />
 * Yesterday
 * Disable fullscreen preloading, some improvements to license display, cache API responses


 * Today
 * Code review, fix review comments, grab next card<section end="2014-04-21" />

2014-04-22
<section begin="2014-04-22" />
 * Yesterday
 * Code review, fix review comments, split progress bar component, fix users API caching


 * Today
 * Code review, fix review comments, update survey languages, grab next card<section end="2014-04-22" />

2014-04-23
<section begin="2014-04-23" />
 * Yesterday
 * Code review, fix review comments, update survey languages, fix gallery captions (#338)


 * Today
 * Code review, pick some new cards<section end="2014-04-23" />

2014-04-24
<section begin="2014-04-24" />
 * Yesterday
 * Planning meeting, add ackrc to vagrant, fix License.isCc bug, start progressbar refactoring


 * Today
 * Finish progressbar refactoring, pick some more cards<section end="2014-04-24" />

2014-04-25
<section begin="2014-04-25" />
 * Yesterday
 * reworked thumbnail loading mocks, looked at NavigationTiming extension, read up on PoolCounter, looked at PreloadJS (they use the same AJAX preload approach we do, but have lots of hacks for cross-browser behavior, might be useful in the future)


 * Today
 * Progress bar / blur refactor (#489)<section end="2014-04-25" />

2014-04-28
<section begin="2014-04-28" />
 * Friday
 * Progress bar / blur refactor, scaler performance meeting


 * Today
 * Cycle planning meeting, bug triage, bugfixes (#527, #497, #521)<section end="2014-04-28" />

2014-04-29
<section begin="2014-04-29" />
 * Yesterday
 * Cycle planning meeting, bug triage, bugfixes (#527, #497, #521)


 * Today
 * Cycle planning meeting #2, code review fixes, SWAT<section end="2014-04-29" />

2014-04-30
<section begin="2014-04-30" />
 * Yesterday
 * Cycle planning meeting #2, code review fixes, SWAT, JSONP caching (#547)


 * Today
 * Code review fixes, check non-Commons metadata parsing (#249)<section end="2014-04-30" />

2014-05-01
<section begin="2014-05-01" />
 * Yesterday
 * Weekly meeting, code review, code review fixes, fix non-Commons metadata parsing td/th issue (#249), fix a localization issue (#553), change metadata panel logic per Pau's recommendations (#548)


 * Today
 * Pick some new cards<section end="2014-05-01" />

2014-05-02
<section begin="2014-05-02" /> <section end="2014-05-02" />
 * Yesterday
 * Metrics meeting
 * add namespaces to NavigationTiming extension
 * backport CMD information template fix
 * code review
 * chart image hit/miss ratio
 * Today
 * read a bunch of mail backlog (mipmapping, ops)
 * test API caching
 * create vagrant role for GlobalUsage, fix API cache mode
 * create mass message about marking up templates
 * fix a minor issue with localizations

2014-05-05
<section begin="2014-05-05" /> <section end="2014-05-05" />
 * tested API caching some more (HTML is hard)
 * wrote mail about namespace localization issue
 * metadata panel logging (#559)
 * vagrant setup for GWToolset
 * GWToolset bugfix (pending)

2014-05-06
<section begin="2014-05-06" /> <section end="2014-05-06" />
 * unbreak GWToolset (#573)
 * investigate GWToolset throttling settings

2014-05-07
<section begin="2014-05-07" /> <section end="2014-05-07" />
 * weekly meeting
 * GWToolset throttling (#535)
 * poor man's zoom (#588)

2014-05-08
<section begin="2014-05-08" /> <section end="2014-05-08" />
 * paperwork (Concur)
 * read performance guidelines/RfC
 * 1:1 with RobLa
 * fix patches
 * explore the wonderful world of PHP unit testing of MediaWiki (bug 64597)

2014-05-09
<section begin="2014-05-09" /> <section end="2014-05-09" />
 * code review
 * fix thumb URL guesser
 * simple zoom

2014-05-12
<section begin="2014-05-12" /> <section end="2014-05-12" />
 * fixed review bugs
 * created MMV deploy patches
 * tried to set up Safari on Ubuntu for testing, did not work out
 * participated in a discussion about how to mark non-content images
 * dusted off UploadWizard test environment, fixed some issues with it

2014-05-13
<section begin="2014-05-13" /> <section end="2014-05-13" />
 * fixed review bugs
 * started refactoring mmv.js to extract zoom logic; gave up when it looked like it would take too much time
 * summarized GWToolset situation on ops list, wrote some suggestions
 * investigated possibilities for funnel logging, wrote to mailing list
 * started writing logging code for UploadWizard (#305)

2014-05-14
<section begin="2014-05-14" /> <section end="2014-05-14" />
 * weekly meeting
 * zoom link fixes; fixes on fixes; feature flag
 * basic UploadWizard funnel logging, based on the mailing list discussion

2014-05-15
<section begin="2014-05-15" /> <section end="2014-05-15" />
 * 1:1 with Rob
 * track down reason for tests failing with jQuery 1.9, fix
 * vagrant box troubles (bug 65386)

2014-05-16
<section begin="2014-05-16" /> <section end="2014-05-16" />
 * IRC/mailing list discussion with Ori and several Analytics team members about our usage of EventLogging
 * add sampling for logging, backport
 * look into getFileSearchOptions bug

2014-05-19
<section begin="2014-05-19" /> <section end="2014-05-19" />
 * bug triage
 * fix & refactor logging patch
 * tried to figure out why Jenkins is failing but no success so far
 * made schema pages on Meta easier to find
 * more struggling with bug 65386

2014-05-20
<section begin="2014-05-20" /> <section end="2014-05-20" />
 * investigating Commons upload stash errors
 * reading up on gap locking & consistent reads in MySQL to better understand the related code
 * CR/backport of Aaron's patches
 * CR for sampling patches

2014-05-21
<section begin="2014-05-21" /> <section end="2014-05-21" />
 * weekly planning meeting
 * fix failing tests for basic funnel logging
 * fix text selection jQuery bug (#638)
 * re-review sampling patch
 * fix test issues with own patch

2014-05-22
<section begin="2014-05-22" /> <section end="2014-05-22" />
 * UW planning meeting
 * weekly status report
 * learned how to deploy config changes \o/
 * collected tasks for improving access to original file
 * wrote mail about image view tracking

2014-05-23
<section begin="2014-05-23" /> <section end="2014-05-23" />
 * fix UW / EventLogging include order issues (bug 65680)
 * work on #636

2014-05-27
<section begin="2014-05-27" /> <section end="2014-05-27" />
 * finish CommonsMetadata multi-value handling fix (#636)
 * add tests for the CMD hook (#666)
 * [multimedia/#623] Create poolcounter group for expensive thumbnails

2014-05-28
<section begin="2014-05-28" /> <section end="2014-05-28" />
 * weekly planning meeting
 * fix review comments for #636, #666, #623
 * create PgedTiffHandler vagrant
 * fix MediaViewer for ES3 compatibility

2014-05-29
<section begin="2014-05-29" /> <section end="2014-05-29" />
 * yearly planning meeting
 * review structured logging patches
 * fix review comments for #636, #666, #623
 * self-review

2014-06-02
<section begin="2014-06-02" /> <section end="2014-06-02" />
 * fix
 * CR for
 * some small fixes
 * grid RFC review

2014-06-03
<section begin="2014-06-03" /> <section end="2014-06-03" />
 * Wikidata catch-up meeting
 * more CR for
 * looked at Composer RFC
 * enable survey on enwiki
 * work on more UW funnel metrics

2014-06-04
<section begin="2014-06-04" /> <section end="2014-06-04" />
 * Weekly planning meeting
 * backport some fixes
 * work on more UW funnel metrics

2014-06-05
<section begin="2014-06-05" /> <section end="2014-06-05" />
 * Cycle planning meeting
 * Metrics meeting / team lunch
 * 1:1 with RobLa
 * chat with Bryan Davis about and
 * more CR for

2014-06-06
<section begin="2014-06-06" /> <section end="2014-06-06" />
 * breakfast with Lila
 * triaging bugs/talk page feedback
 * more CR for
 * coworker feedback

2014-06-09
<section begin="2014-06-09" /> <section end="2014-06-09" />
 * community catchup meeting
 * design meeting
 * CR / fixing for a bunch of smaller patches (,, , ...)
 * find way to use Vagrant with IE VM
 * look into IE display bug

intermission
(a week of frantically fixing MediaViewer bugs, in which I forgot about this completely)

2014-06-18
<section begin="2014-06-18" /> <section end="2014-06-18" />
 * sprint planning meeting
 * help with an UW issue on IRC (turns out UW 1.23 is actually 1.22 - )
 * fix issues with my patches
 * improve logging (,

2014-06-19
<section begin="2014-06-19" /> <section end="2014-06-19" />
 * metrics meeting
 * 1:1
 * set up a bunch of patches for SWAT
 * debug SWAT i18n issues
 * probably other stuff I forgot

2014-06-20
<section begin="2014-06-20" /> <section end="2014-06-20" />
 * lots of emails
 * code review for
 * read CI sandboxing RfC
 * write server-side Javascript error logging RfC
 * work on

2014-06-23
<section begin="2014-06-23" /> <section end="2014-06-23" />
 * more emails
 * structured logging code review
 * more fixing of the UW release branch mess
 * CR for
 * talk page responses

2014-06-24
<section begin="2014-06-24" /> <section end="2014-06-24" />
 * talk page responses
 * fix and SWAT aspect ration distortion issue
 * fix and SWAT test failure

2014-06-25
<section begin="2014-06-25" /> <section end="2014-06-25" />
 * sprint planning meeting
 * scrum of scrums
 * SWAT TMH embed fixes
 * talk page responses, a few related DB queries, mails etc

2014-06-26
<section begin="2014-06-26" /> <section end="2014-06-26" />
 * MMV bug triage + talk page triage
 * 1:1 with Rob
 * fix+rebase for
 * 3rd party MMV troubleshooting on IRC; improve MMV defaults
 * start
 * fix for

2014-06-27
<section begin="2014-06-27" /> <section end="2014-06-27" />
 * RTL fixes
 * (more prominent Commons + reuse links)

2014-06-30
<section begin="2014-06-30" /> <section end="2014-06-30" />
 * meeting with Maarten
 * lots of small patches for the download panel
 * fix patch based on Pau's feedback

2014-07-01
<section begin="2014-07-01" /> <section end="2014-07-01" />
 * Wikidata catchup meeting
 * wrote notes for UploadWizard planning meeting
 * worked on
 * worked on

2014-07-02
<section begin="2014-07-02" /> <section end="2014-07-02" />
 * sprint planning meeting
 * UploadWizard refactoring planning
 * some more work on

2014-07-03
<section begin="2014-07-03" /> <section end="2014-07-03" />
 * metrics meeting
 * even more work on
 * fix progress bar display glitch

2014-07-07
<section begin="2014-07-07" /> <section end="2014-07-07" />
 * update per new requests
 * review patch for

2014-07-08
<section begin="2014-07-08" /> <section end="2014-07-08" />
 * UW refactor meeting
 * review patch for
 * read GLAM stats docs (NARA pilot, Europeana report, Analytics page)
 * organize some thumbnail-related bugs
 * trip planning

2014-07-09
<section begin="2014-07-09" /> <section end="2014-07-09" />
 * weekly sprint meeting
 * config patch to test
 * another round of
 * start conversation about GWT test

2014-07-10
<section begin="2014-07-10" /> <section end="2014-07-10" />
 * RfC meeting
 * discussion with analytics team members about optout logging setup
 * code review
 * more features for
 * try to locate where thumbnails are stored on beta

2014-07-11
<section begin="2014-07-11" /> <section end="2014-07-11" />
 * bug triage
 * talk page triage
 * code review
 * more features for
 * debug setup problems

2014-07-14
<section begin="2014-07-14" /> <section end="2014-07-14" />
 * community response review meeting
 * structured data API draft
 * review optout logging proposal with Fabrice
 * reinstalling mediawiki-vagrant after an upgrade ended up badly

2014-07-15
<section begin="2014-07-15" /> <section end="2014-07-15" />
 * wikidata meeting
 * finish restoring old dev environment up mediawiki-vagrant
 * (hopefully) last round of (scrolling behavior)
 * debugging test suite problems

2014-07-16
<section begin="2014-07-16" /> <section end="2014-07-16" />
 * sprint planning meeting
 * optout metrics meeting
 * more vagrant issues
 * code review
 * small fixes to commons logo positioning
 * small fixes to commons logo positioning

2014-07-22
<section begin="2014-07-22" /> <section end="2014-07-22" />
 * fix dashboard codes
 * remove generated dashboard code from version control
 * MediaViewer stats data collection
 * metadata positioning bug

2014-07-23
<section begin="2014-07-23" /> <section end="2014-07-23" />
 * sprint planning meeting
 * more fixing of dashboard codes
 * collecting data about MediaViewer

2014-07-24
<section begin="2014-07-24" /> <section end="2014-07-24" />
 * travel briefing
 * more MediaViewer data collection
 * 1:1 with Rob
 * caption bugfix
 * small fixes duration dashboards
 * investigations related to image loading time measurements

2014-07-25
<section begin="2014-07-25" /> <section end="2014-07-25" />
 * debugging various stuff related to the commons vagrant role
 * probably other stuff that I forgot

2014-07-28
<section begin="2014-07-28" /> <section end="2014-07-28" />
 * fix MediaViewer Opera 10 breakage
 * add CORS support to commons vagrant role
 * review InstantCommons patch