Gerrit/Project ownership/Archive

raymond (Translate)
Please add raymond (Raimond Spekking) as maintainer of the Translate extension. siebrand (talk) 17:37, 12 May 2012 (UTC)

--Antoine &#34;hashar&#34; Musso (talk) 02:14, 16 May 2012 (UTC)=== Comments ===
 * +1 --Catrope (talk) 19:11, 15 May 2012 (UTC)
 * Antoine &#34;hashar&#34; Musso (talk) 02:14, 16 May 2012 (UTC)
 * --Nikerabbit (talk) 09:13, 21 May 2012 (UTC)
 * Platonides (talk) 15:23, 21 May 2012 (UTC)
 * ✅ - sorry for the wait! Congrats, Raimond. Sumana Harihareswara, Wikimedia Foundation Engineering Community Manager (talk) 19:23, 23 May 2012 (UTC)

Fundraising extensions
The Wikimedia Fundraising team would like to request ownership by the fundraising group for the following extensions:
 * CentralNotice
 * ContactPageFundraiser
 * ContributionReporting
 * DebianISOCodes
 * FundraiserLandingPage
 * LandingCheck

All of the above extensions were either written exclusively for fundraising or are part of the core fundraising infrastructure.

For those wondering about the ones we are "missing," we already have:
 * ContributionTracking
 * DonationInterface

--Pgehres (WMF) (talk) 18:36, 18 May 2012 (UTC)
 * Arthur Richards (talk) 18:39, 18 May 2012 (UTC)
 * Khorn (WMF) (talk) 18:45, 18 May 2012 (UTC)
 * Kaldari (talk) 18:52, 18 May 2012 (UTC)
 * Tychay (talk) 23:40, 18 May 2012 (UTC)

Can we have a list of the fundraising team members? – Nikerabbit (talk) 09:14, 21 May 2012 (UTC)
 * We are not asking for access for all team members, just the fundraising group in gerrit which is limited to the team members with deployment access (currently only Katie Horn). --Peter Gehres (WMF) (talk) 17:53, 21 May 2012 (UTC)
 * ✅ Thanks and sorry for the delay. Sumana Harihareswara, Wikimedia Foundation Engineering Community Manager (talk) 19:06, 23 May 2012 (UTC)

Kaldari (Front-end)
I'd like to nominate Ryan Kaldari to join the mediawiki group. Ryan's been focused on front-end development, and with +2 rights he'd be able to help us keep up with front-end changes in core and extensions, which is currently an area that's under-resourced. I believe he can be trusted to apply his own judgment to not merge changes outside his areas of expertise.--Eloquence (talk) 18:13, 16 April 2012 (UTC)

Comments

 * , yum more code reviewers!!!! Antoine &#34;hashar&#34; Musso (talk) 21:17, 18 April 2012 (UTC)
 * , from experience working with Kaldari, he's an excellent code reviewer and I can't think of a reason why he should not have +2. Arthur Richards (talk) 21:27, 18 April 2012 (UTC)
 * Platonides (talk) 23:00, 18 April 2012 (UTC)
 * ✅ Sumana Harihareswara, Wikimedia Foundation Volunteer Development Coordinator (talk) 05:17, 20 April 2012 (UTC)

Ian Baker (TimedMediaHandler)
Ian Baker should be given merge rights in the TimedMediaHandler extension, which he is intimately familiar with based on his joint code review with NeilK.--Eloquence (talk) 18:16, 16 April 2012 (UTC)

Comments

 * +1 --Catrope (talk) 18:24, 18 April 2012 (UTC)
 * +1 --Kaldari (talk) 21:07, 18 April 2012 (UTC)
 * Antoine &#34;hashar&#34; Musso (talk) 21:17, 18 April 2012 (UTC)
 * Arthur Richards (talk) 21:28, 18 April 2012 (UTC)
 * ✅ Created the Gerrit group extension-TimedMediaHandler, added Ian as a member, and told Gerrit project mediawiki/extensions/TimedMediaHandler to allow that group as an owner. Sumana Harihareswara, Wikimedia Foundation Volunteer Development Coordinator (talk) 05:29, 20 April 2012 (UTC)

Trevor Parscal
Trevor said that he needed MediaWiki core project ownership, and Antoine gave it to him. Sumana Harihareswara, Wikimedia Foundation Volunteer Development Coordinator (talk) 18:49, 3 April 2012 (UTC)


 * ✅ hashar added Trevor to mediawiki group. Antoine &#34;hashar&#34; Musso (talk) 18:50, 3 April 2012 (UTC)

Timo Tijhof

 * krinkle
 * "mediawiki" group (for https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git)
 * WMF contractor, core contributor, previously also a reviewer in SVN via the "coder" group on mediawiki.org Krinkle (talk) 17:45, 27 March 2012 (UTC)

Comments

 * Sounds good to me, but would like to get input from other core reviewers as well --Catrope (talk) 16:01, 28 March 2012 (UTC)

Status
✅ Sumana Harihareswara, Wikimedia Foundation Volunteer Development Coordinator (talk) 19:03, 3 April 2012 (UTC)

Katie Horn, 27 March 2012

 * Katie Horn
 * https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/DonationInterface.git;a=summary
 * WMF staff, fundraiser tech lead, author and maintainer of DonationInterface on mediawiki,org, previously also a reviewer in SVN via the "coder" group on mediawiki.org. Khorn (WMF) (talk) 00:38, 28 March 2012 (UTC)

Comments

 * +1 --Catrope (talk) 16:01, 28 March 2012 (UTC)

Status
✅ Sumana Harihareswara, Wikimedia Foundation Volunteer Development Coordinator (talk) 18:13, 30 March 2012 (UTC) I will take the hit on this -- I didn't circulate it per policy but Fundraising really needed the ability to deploy. Today I'll be circulating the rest of these per procedure.
 * Tweaked the permissions just slightly. All fundraising people can now be added/removed through the meta-group "fundraising" in gerrit. ^demon (talk) 15:11, 2 April 2012 (UTC)

Victor Vasiliev, 21 March 2012

 * vvv
 * https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/TitleBlacklist.git;a=summary
 * One of the initial authors of TitleBlacklist; "used to "ok" revisions on CentralAuth and TitleBlacklist back when there was some pre-release backlog" ‎ --VasilievVV 16:27, 22 March 2012

Comments

 * +1 --Catrope (talk) 16:01, 28 March 2012 (UTC)

Status
✅ ^demon (talk) 15:14, 2 April 2012 (UTC)

Gabriel Wicke, April 3 2012

 * gwicke
 * "mediawiki" group (for core); ParserFunctions
 * WMF contractor, core contributor, previously also a reviewer in SVN via the "coder" group on mediawiki.org Gabriel Wicke (GWicke) (talk) 18:44, 3 April 2012 (UTC)

Comments

 * +1 Krinkle (talk) 18:45, 3 April 2012 (UTC)
 * +1 Sounds good to me ^demon (talk) 14:32, 4 April 2012 (UTC)

✅ Sumana Harihareswara, Wikimedia Foundation Volunteer Development Coordinator (talk) 13:50, 5 April 2012 (UTC)

Kaldari, 27 March 2012

 * kaldari
 * https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/WikiLove.git;a=summary
 * WMF staff, core contributor, previously also a reviewer in SVN via the "coder" group on mediawiki.org Kaldari Kaldari (talk) 23:40, 27 March 2012 (UTC)

Comments

 * +1 --Catrope (talk) 16:01, 28 March 2012 (UTC)

Status
✅ ^demon (talk) 15:18, 2 April 2012 (UTC)

Jeroen De Dauw, 19 March 2012

 * Jeroen De Dauw
 * https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git
 * Wikimedia Foundation contractor, Wikidata developer, contributor to several extensions

Comments

 * Jeroen should have project ownership of all extensions he maintains. I recommend against giving him ownership of core --Catrope (talk) 16:01, 28 March 2012 (UTC)
 * Concur with Roan. ^demon (talk) 21:49, 2 April 2012 (UTC)

Status
Since two core contributors have vetoed this, rejecting and archiving. Sumana Harihareswara, Wikimedia Foundation Volunteer Development Coordinator (talk) 19:02, 3 April 2012 (UTC)

Victor Vasiliev, 21 March 2012

 * vvv
 * https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/CentralAuth.git;a=summary
 * One of the major contributors of CentralAuth ‎ --VasilievVV 16:27, 22 March 2012

Comments

 * +1 --Catrope (talk) 16:01, 28 March 2012 (UTC)
 * +1, certainly is a major author for it. Maybe get Tim's opinion since it's deployment-critical. ^demon (talk) 15:15, 2 April 2012 (UTC)
 * +1 Aaron (talk) 20:33, 3 April 2012 (UTC)
 * +1 Platonides (talk) 13:49, 4 April 2012 (UTC)

✅ Sumana Harihareswara, Wikimedia Foundation Volunteer Development Coordinator (talk) 13:47, 5 April 2012 (UTC)

Jeroen De Dauw, 19 March 2012

 * Jeroen De Dauw
 * (his extensions)
 * Wikimedia Foundation contractor, Wikidata developer, contributor to several extensions

Comments

 * Jeroen should have project ownership of all extensions he maintains. I recommend against giving him ownership of core --Catrope (talk) 16:01, 28 March 2012 (UTC)
 * Concur with Roan. ^demon (talk) 21:49, 2 April 2012 (UTC)
 * I'd tend to agree with the above. I'd be a bit worried about code (albeit with lots of cool ideas) getting merged that needs wider discussion first. Aaron (talk) 20:40, 3 April 2012 (UTC)
 * Jeroen has wrote and does maintain a ton of very useful extension. So yes we want Jeroen to be the owner of his extensions. We probably need a list :-D Antoine &#34;hashar&#34; Musso (talk)
 * We do have a list ^demon (talk) 14:33, 4 April 2012 (UTC)
 * We aren't discussing core but just his extensions, for which I think there's consensus (I support it, too). Platonides (talk) 13:49, 4 April 2012 (UTC)

Status
✅ For all extensions Jeroen owns that are in git (or that will be migrated Friday).

Matthias Mullie (Article Feedback Tool v5)
Matthias Mullie needs ownership rights on Article Feedback Tool v5 because he is slated to take over the project from OmniTi in July and replace Roan as primary deployer for this project needs merge rights to do this). This would free up Roan's time for VisualEditor (in the short term) and school (in the long term).

--Tychay (talk) 19:20, 24 May 2012 (UTC)

Comments

 * Fabrice Florin (talk) 20:27, 24 May 2012 (UTC) For what it's worth, you have my vote! Matthias has already proven himself to be an excellent developer, highly qualified and very responsive. Plus, he's a really nice guy! Who could ask for more? ;o)
 * Asking the current Gerrit project owners for their thoughts; will process this request on Tuesday, 29 May. Sumana Harihareswara, Wikimedia Foundation Engineering Community Manager (talk) 04:04, 25 May 2012 (UTC)
 * I'm OK with this in the understanding that Matthias won't review his own code, someone else will still need to review that. --Catrope (talk) 11:27, 25 May 2012 (UTC)
 * I hope not! I reminded Matthias just in case.. ;-) Tychay (talk)
 * ✅ Sumana Harihareswara, Wikimedia Foundation Engineering Community Manager (talk) 22:25, 29 May 2012 (UTC)

MediaWiki core - MaxSem
Request for Max Semenik (MaxSem) to be part of the "mediawiki" Gerrit group; he's being given deployment cluster access, I believe, so this makes sense. Code samples. Sumana Harihareswara, Wikimedia Foundation Engineering Community Manager (talk) 20:38, 25 May 2012 (UTC)
 * Support - No reason I can think of not to give it to him. ^demon (talk) 20:42, 25 May 2012 (UTC)
 * -- Platonides (talk) 17:09, 28 May 2012 (UTC)
 * ✅ Sumana Harihareswara, Wikimedia Foundation Engineering Community Manager (talk) 22:26, 29 May 2012 (UTC)

Adam Wight - Fundraising
Katie Horn requested today to add new employee Adam Wight (adamw) to the Fundraising Gerrit group so I have done so. Sumana Harihareswara, Wikimedia Foundation Engineering Community Manager (talk) 17:46, 12 June 2012 (UTC)

UploadWizard - Jeroen De Dauw
Right now I cannot approve stuff submitted by others, while I'm one of the people most familiar with the code of this extension --Jeroen De Dauw (talk) 18:10, 28 May 2012 (UTC)

Comments

 * Makes sense to me. The more eyes we have on the project the less backlog. Tychay (talk) 17:36, 29 May 2012 (UTC)
 * We need more reviewers for this extension. I'll talk to Jeroen a bit more about reviewing standards for it (e.g. how to handle UX issues).--Eloquence (talk) 17:51, 1 June 2012 (UTC)
 * Antoine &#34;hashar&#34; Musso (talk) 18:22, 10 June 2012 (UTC)
 * +1. Max Semenik (talk) 16:35, 12 June 2012 (UTC)
 * ✅ Sumana Harihareswara, Wikimedia Foundation Engineering Community Manager (talk) 20:43, 12 June 2012 (UTC)

Nuke - Jeroen De Dauw
I sort of ended up maintaining nuke somewhere in the last 12 months so I'd be good if I could review and merge changes of others --Jeroen De Dauw (talk) 19:08, 2 June 2012 (UTC)
 * Thanks for maintaining Nuke :-] Antoine &#34;hashar&#34; Musso (talk) 18:22, 10 June 2012 (UTC)
 * Why not? Max Semenik (talk) 16:34, 12 June 2012 (UTC)
 * - sounds good to me. Nobody else is actively maintaining it :) ^demon (talk) 17:45, 12 June 2012 (UTC)
 * ✅ Sumana Harihareswara, Wikimedia Foundation Engineering Community Manager (talk) 20:50, 12 June 2012 (UTC)

WikimediaIncubator - SPQRobin
I request to be a project owner of the WikimediaIncubator extension (extension page) of which I am the primary developer. I of course won't review&merge my own commits, unless they're simple typo fixes or such. FYI, I was/am already a coder on this wiki. Thanks, SPQRobin (talk) 20:32, 29 May 2012 (UTC)


 * I fully trust SPQRobin :-] Antoine &#34;hashar&#34; Musso (talk) 18:22, 10 June 2012 (UTC)
 * +1. Max Semenik (talk) 16:35, 12 June 2012 (UTC)
 * Definitely. ^demon (talk) 17:45, 12 June 2012 (UTC)
 * ✅ Sumana Harihareswara, Wikimedia Foundation Engineering Community Manager (talk) 20:54, 12 June 2012 (UTC)

Merge Rights for Daniel Kinzler
Hi all

I would like merge rights for mediawiki/core/master and mediawiki/core/Wikidata. Since I had the right to commit to core in SVN, I supposed you can trust me with this.

Having these rights should help to ease the strain the Wikidata team puts on the core team, and also allows me to help out with the normal core review process for core.

-- Daniel Kinzler (WMDE) (talk) 14:19, 15 June 2012 (UTC)

In reply to some of the comments below: -- Daniel Kinzler (WMDE) (talk) 15:54, 15 June 2012 (UTC)
 * I'm pretty reluctant to submit anything to core just yet. I guess once i collected a bit more experience, i'll do it more often.
 * Whether I should be approving Wikidata-related changes - well, most of them are in our extensions, and we are reviewing them internally, as long as they are not deployed. And I am submitting/merging things there.
 * Core changes for wikidata should be rare and small once the WikiData branch has been merged. I'd not want to approve big changes to the core, but may merge the addition of a hook point or some such.
 * As to my rights on the Wikidata branch: apparently, I'm in the owner group and can submit, but I can't +2 changes, for some reason... maybe just an oversight.


 * I think we can trust him :) ^demon (talk) 15:35, 15 June 2012 (UTC)
 * Although I'm not sure you should be doing the review of precisely WikiData commits, on whose development you are participating at the same time. Platonides (talk) 15:43, 15 June 2012 (UTC)
 * Trusting Daniel to do some nice work. Please be careful since a merge in mediawiki/core is roughly equals to a deployment on the live site. Also you usually want to wait a bit to let a chance to other people to see the patches :-] Antoine &#34;hashar&#34; Musso (talk) 15:44, 15 June 2012 (UTC)
 * Ownership for Wikidata is a no-brainer, it seems like he partially has it already but the permissions are messed up somehow. As for ownership of core, I don't think we should give this to someone who, by their own admission, is "reluctant to submit anything to core just yet" and doesn't need to approve anything in core except the occasional hook addition. If core changes for Wikidata are rare and small, I don't think they need a WD person with merge access, they can just go through the normal review process. So I'm gonna say yes to the Wikidata ownership request but no to the master request, unless someone convinces me otherwise. --Catrope (talk) 20:12, 15 June 2012 (UTC)
 * The core changes for Wikidata are huge and will require maintenance. That's why we're talking about a Wikidata branch, not a Wikidata extension. I think it's best if the person who looks after that code is physically present at WMDE. Daniel has been contributing to the MediaWiki core since 2006, I'm sure we can trust his judgement. -- Tim Starling (talk) 02:18, 18 June 2012 (UTC)
 * Alright, that's fine then. I didn't realize the changes were that large. --Catrope (talk) 18:46, 18 June 2012 (UTC)
 * [branch/master] From his history, the code he submitted that I reviewed so far, and his cautiousness, I'm not really worried about +2 in master. I also think there is lots of stuff he could review in master, in theory. Once the branch is merged, as Tim said, there will be the maintenance factor. I expect that others might see breakage and make patches, of which it would be nice if he could merge. Aaron (talk) 17:04, 18 June 2012 (UTC)
 * ✅ Sumana Harihareswara, Wikimedia Foundation Engineering Community Manager (talk) 09:14, 4 July 2012 (UTC)

Project Ownership request for extensions: DiscussionThreading,NSFileRepo,NewUserNotif,StringFunctionsEscaped
Gerrit Username: Jpond  SVN/GIT ID: jdpond

It probably makes sense for me to at least be an authorized member, if not the owner for the following extensions(authored by me or got dumped into my lap). None of them have a current owner or any members. All are very stable, but still get update requests on their Talk pages and have corresponding bugzilla areas.


 * extension-DiscussionThreading: DiscussionThreading - a light weight forum-like extension to structure postings and replies on talk pages.  LiquidTheads is better, but this one works all the time and much less overhead.  Would like to sunset it, but several admins still have trouble gettin LQT working.
 * extension-NSFileRepo: NSFileRepo - Access protection based on Namespace for uploading and reading files/images
 * extension-NewUserNotif: NewUserNotif - New User Email Notification, Automatic email to admins when a new user registers (or needs approval)
 * extension-StringFunctionsEscaped: StringFunctionsEscaped - Allows String functions to work with escaped characters, e.g., \n, \t . ..

--jdpond (talk) 17:54, 16 June 2012 (UTC)
 * Partially done; NSFileRepo is maintained by Jpond per the extension wiki page and Jpond is the one who requested the move into Git, so I've added Jpond as an owner for that Gerrit project. Sumana Harihareswara, Wikimedia Foundation Engineering Community Manager (talk) 19:34, 16 June 2012 (UTC)
 * ✅ Jpond also requested the other 3 moves. Thanks! Sumana Harihareswara, Wikimedia Foundation Engineering Community Manager (talk) 20:16, 16 June 2012 (UTC)

Project ownership for extensions PanScroll and SideBarMenu
Gerrit username: MathiasLidal (mathiaslidal@gmail.com)

Git Gerrit projects:
 * https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/PanScroll
 * https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/SideBarMenu

I am going to take over development of these extensions from user Netbrain (kim@heldig.org) so could you give me project ownership access?
 * ✅ Sumana Harihareswara, Wikimedia Foundation Engineering Community Manager (talk) 09:13, 4 July 2012 (UTC)

Add PeterG to fundraising group
His username is pgehres. I'm just adding it here so this request is logged somewhere.


 * ✅ by Katie (group owner)

editor-engagement to own extensions it already owns
The Editor Engagement and Experimentation teams already own a number of extensions through individual members, it makes sense to add (or change ownership to) the group membership (editor-engagement) where it can be managed instead of handling each person independently.

They are:
 * mediawiki/extensions/ArticleCreationWorkflow: add editor-engagement
 * mediawiki/extensions/ArticleFeedbackv5: add editor-engagement
 * mediawiki/extensions/ClickTracking: create clicktracking access group, add editor-engagement
 * mediawiki/extensions/E3Experiments: add editor-engagement
 * mediawiki/extensions/Echo: create echo access group, add editor-engagement and explicitly add werdna (he already has perms through mediawiki)
 * mediawiki/extensions/PageTriage: add editor-engagement

Tychay (talk) 17:48, 26 June 2012 (UTC)

Comments

 * Also add mediawiki/extensions/LastModified: create last modified access group, add editor-engagement (currently there is a request to change ownership to Ori) Tychay (talk) 21:35, 29 June 2012 (UTC)
 * +1. Please god let it be so. Steven Walling (WMF) &bull; talk   22:14, 29 June 2012 (UTC)
 * +1, Amen, etc. Maryana (WMF) (talk) 22:19, 29 June 2012 (UTC)
 * +1 thank you. -Kgladstone (WMF) (talk) 22:32, 29 June 2012 (UTC)
 * +2 !! Great idea, would make all of our lives so much easier! Fabrice Florin (talk) 22:34, 29 June 2012 (UTC)
 * . This would help things tremendously. Kaldari (talk) 21:08, 30 June 2012 (UTC)
 * Agree that this would help. —The preceding unsigned comment was added by Ori Livneh (WMF) (talk • contribs) 08:23, 1 July 2012 (UTC)
 * Andrew Garrett (talk) 03:11, 2 July 2012 (UTC)
 * Mlitn (talk) 14:12, 2 July 2012 (UTC)
 * ✅ Should all be implemented. Sumana Harihareswara, Wikimedia Foundation Engineering Community Manager (talk) 09:22, 4 July 2012 (UTC)

Helder.wiki in BookManager
I wanted the Helder.wiki be added to this list https://gerrit.wikimedia.org/r/#/admin/groups/123,members

Because he is the coauthor of the extension.

This will make you able to edit the extension, right?

Raylton P. Sousa (talk) 19:54, 30 June 2012 (UTC)
 * ✅ Sumana Harihareswara, Wikimedia Foundation Engineering Community Manager (talk) 09:12, 4 July 2012 (UTC)

add jamesur to extension-CentralNotice
Please add jamesur (wiki username User:Jalexander ) the CentralNotice owner group 'extension-CentralNotice'. Jalexander (talk) 19:05, 3 July 2012 (UTC)
 * . Yes please. Kaldari (talk) 19:06, 3 July 2012 (UTC)
 * ✅ Sumana Harihareswara, Wikimedia Foundation Engineering Community Manager (talk) 09:12, 4 July 2012 (UTC)

Editor Engagement (meta-group)
This is a request for a new meta-group to be created for the Editor Engagement and the Editor Engagement Experimentation team (as they will be working on the same extensions). Instead of individually assigning extension access (for things like Page Triage) to each member, we can just request the meta-group be given control (like Fundraising does with the DonationInterface).

Group members:
 * Ryan Kaldari (already in the mediawiki group, but can't hurt)
 * Andrew Garret (already in the mediawiki group, but can't hurt)
 * Benny Situ
 * Ori Livneh
 * Matthias Mullie

This is not a request that the meta-group be given ownership of anything (yet).

Comments

 * This should be pretty straightforward to do--can't see any reason not to. ^demon (talk) 17:45, 12 June 2012 (UTC)
 * Chad, do you care what we name this, internally? I see we're being a little inconsistent in terms of capitalization, spaces instead of hyphens, etc. Do you care? Sumana Harihareswara, Wikimedia Foundation Engineering Community Manager (talk) 20:56, 12 June 2012 (UTC)
 * Created as Group "editor-engagement". ✅ Sumana Harihareswara, Wikimedia Foundation Engineering Community Manager (talk) 23:28, 13 June 2012 (UTC)
 * Alolita requested via email that we add Dario Taraborelli and Ryan Faulkner to this group. I accidentally removed my ability to add someone to the group; could one of the group members please do it? Thanks. Sumana Harihareswara, Wikimedia Foundation Engineering Community Manager (talk) 00:18, 14 June 2012 (UTC)
 * Matthias did it. Thanks, Matthias! Sumana Harihareswara, Wikimedia Foundation Engineering Community Manager (talk) 19:20, 17 July 2012 (UTC)

Semantic Forms Inputs
Project ownership for yaron and jeroendedauw. Asked Stephan about this and he's fine with it. --Jeroen De Dauw (talk) 21:24, 7 July 2012 (UTC)
 * ✅ Thanks. Sumana Harihareswara, Wikimedia Foundation Engineering Community Manager (talk) 19:27, 17 July 2012 (UTC)

Tpt: ProofreadPage
I have been working on ProofreadPage for the past few months in order to clean the code and add new features required by Wikisource contributors. Here is my activity on Gerrit:. Sumanah has told me that it would be a good idea to ask for the ownership in order to save time in the process of merging code. Tpt (talk) 23:39, 15 July 2012 (UTC)
 * Aaron (talk) 21:45, 18 July 2012 (UTC)
 * Even if my opinion shouldn't have a lot of weight because I'm not active enough in the development of this extension. I just want to say, that I follow carefully Tpt's work on the extension and that I think that giving ownership to him is a good idea. Zaran (talk) 22:26, 18 July 2012 (UTC)
 * ✅ Sumana Harihareswara, Wikimedia Foundation Engineering Community Manager (talk) 00:22, 19 July 2012 (UTC)

TimedMediaHandler / MwEmbedSupport
I would need +2 rights for TMH and MwEmbedSupport to review and fix code while in SF. My Gerrit username is J

https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/TimedMediaHandler https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/MwEmbedSupport


 * Suport. TMH will receive additional security review from Chris Steipp. Giving J +2 on it will help to keep things moving.--Eloquence (talk) 17:26, 17 July 2012 (UTC)
 * Antoine &#34;hashar&#34; Musso (talk) 09:55, 18 July 2012 (UTC)
 * ✅ Sumana Harihareswara, Wikimedia Foundation Engineering Community Manager (talk) 00:19, 19 July 2012 (UTC)

OfflineImportLexicon

 * Gerrit username: liaveja
 * Gerrit project: mediawiki/extensions/OfflineImportLexicon

--LiaVeja (talk) 15:36, 18 July 2012 (UTC)

Comments

 * I don't see this listed in https://gerrit.wikimedia.org/r/#/admin/projects/ . Have you requested an import into Gerrit yet, via Git/New repositories or Git/Conversion/Extensions queue? Sumana Harihareswara, Wikimedia Foundation Engineering Community Manager (talk) 00:26, 19 July 2012 (UTC)
 * ✅ When I created the repo. ^demon (talk) 12:43, 30 July 2012 (UTC)

Add editor-engagement as included group for extension-UploadWizard
Upload Wizard has no love in the WMF. This is temporary until multimedia spins up later this year, at which point we'll probably have a "multimedia" group and I'll assign the reassign privs to that group. Tychay (talk) 22:54, 24 July 2012 (UTC)

Comments
✅ ^demon (talk) 12:44, 30 July 2012 (UTC)

iAlex for MediaWiki core ownership
Siebrand suggests iAlex for MediaWiki core ownership.


 * iAlex is one of the core contributors. He has an extensive knowledge about all the MediaWiki codebase and is a defacto a better reviewer than me. So yeah definitely welcome to come in the cabal :-D (just remember to not self merge!) Antoine &#34;hashar&#34; Musso (talk) 08:29, 27 July 2012 (UTC)
 * I've floated this idea for a while. Aaron (talk) 01:48, 28 July 2012 (UTC)
 * --Nikerabbit (talk) 11:27, 1 August 2012 (UTC)
 * ✅ -- added him to the 'mediawiki' group. ^demon (talk) 12:44, 1 August 2012 (UTC)

Semantic MediaWiki group
repo: extensions/SemanticMediaWiki

A new group named SemanticMediaWiki or SMW-trusted or whatever, next to our existing extension owner group. This group should be able to


 * Merge in stuff of others (but not themselves)
 * Push tags
 * Create branches (and if possible be able to merge their own commits to these)

Initial members:


 * Kghbln
 * Nischayn22
 * Mwjames
 * yaron
 * Foxtrott
 * Daniel Werner
 * Denny Vrandecic

Ideally this group would be manageable (both permission and member wise) by either the extension-SemanticMediaWiki group or both Markus and me. --Jeroen De Dauw (talk) 15:19, 24 July 2012 (UTC)

And a similar group for extensions/SemanticResultFormats with same rights and same initial members.

Comments

 * SMW isn't a WMF extension so I don't see a problem with this. Tychay (talk) 22:57, 24 July 2012 (UTC)
 * Yeah more Semantic people :-] Antoine &#34;hashar&#34; Musso (talk) 08:28, 27 July 2012 (UTC)
 * Why not. Maybe this will reduce the self-merges. --Nikerabbit (talk) 11:26, 1 August 2012 (UTC)
 * Not completely possible right now - We can do the branch creations, review, and tagging. But limiting it to "only people other than yourself" requires some Prolog-writing. There's a commit pending upstream for a "Prolog cookbook" to illustrate how to do this and other things. ^demon (talk) 12:42, 1 August 2012 (UTC)
 * Then please create the stuff without this restriction - if that works in core, it will probably work here as well --Jeroen De Dauw (talk) 18:12, 3 August 2012 (UTC)
 * Will do. It'll take me a little bit to sort all this out properly, but I'll get to it this week. ^demon (talk) 22:47, 6 August 2012 (UTC)


 * ✅ Ok, I think I've got everything sorted out here. Please let me know if you've got any problems or need the permissions tweaked further. ^demon (talk) 18:27, 10 August 2012 (UTC)
 * Thanks! --Jeroen De Dauw (talk) 22:31, 11 August 2012 (UTC)

Deployment Branch Access for Ori.livneh
My Gerrit username is Ori.livneh. I intend to only use this to sync the E3Experiments extension to master. I was granted deployment rights in RT: 3325. --Ori.livneh (talk) 21:50, 7 August 2012 (UTC)
 * ✅ Confirmed you already have deploy access, so this group is a no-brainer. ^demon (talk) 17:14, 8 August 2012 (UTC)
 * Thanks! --Ori.livneh (talk) 23:49, 8 August 2012 (UTC)

Group Request: Multimedia
Request that a group "multimedia" be created. Made group owner of the TimedMediaHandler and UploadWizard extensions (also keep "editor-engagement" as owner for UploadWizard). Group owner/member should be RobLa. Tychay (talk) 20:00, 9 August 2012 (UTC)
 * ✅ Group created, and given the requisite permissions. RobLa's the initial member, and he'll be able to manage it via his "Project and Group Creators" role he's already a member of. ^demon (talk) 18:55, 10 August 2012 (UTC)

Move branch svg-chart to be new master, get rid of old master (orgcharts)
master has never been used for orgcharts, because A) by the time it was on Gerrit, I had moved to a separate branch for all development and B) the master branch won't merge easily with the svg-chart branch anymore. I've totally abandoned anything in master, so I'd just like svg-chart to be moved over, if possible. MarkTraceur (talk) 21:49, 18 June 2012 (UTC)

CURRENT STATUS: User:^demon said he'd fix it this week (before 2012-07-21, presumably).
 * We fixed the branch, but HEAD is still pointing at the wrong place. Filed ticket in RT for Ryan to fix. ^demon (talk) 12:42, 30 July 2012 (UTC)
 * ✅ --MarkTraceur (talk) 22:55, 20 August 2012 (UTC)

DumpHTML
I'd like to become a project owner for mediawiki/extensions/DumpHTML. I'm using it actively at my site (http://spiele.j-crew.de). I just submitted a few changes to unbreak the extension (it has been broken in SVN/Git since several months). My Gerrit username is tbleher. Best regards -- Tbleher (talk) 15:38, 5 August 2012 (UTC)
 * . Aaron (talk) 19:50, 7 August 2012 (UTC)
 * ✅ Thanks! Sumana Harihareswara, Engineering Community Manager (talk) 16:00, 21 August 2012 (UTC)

Santhosh for MediaWiki core ownership
Siebrand suggests Santhosh for MediaWiki core ownership.


 * I think this is a bit early because Santhosh hasn't contributed to MW core very much (11 merged commits, 1 pending, and a handful of reviews of others' code AFAICT), but he's on the right track, and with more activity I could see him getting merge rights in the future. --Catrope (talk) 23:48, 21 August 2012 (UTC)
 * ❌ Sumana Harihareswara, Engineering Community Manager (talk) 15:09, 24 August 2012 (UTC)

Requsting admin for UploadWizard and TimedMediaHandler projects
I only aim to +2 the areas that I am qualified to review. thanks --Mdale (talk) 15:08, 6 August 2012 (UTC)

Comments

 * just don't abuse it ;-) Tychay (talk) 19:53, 9 August 2012 (UTC)
 * --Catrope (talk) 23:18, 21 August 2012 (UTC)
 * Antoine &#34;hashar&#34; Musso (talk) 19:52, 23 August 2012 (UTC)


 * Kaldari (talk) 20:37, 23 August 2012 (UTC)
 * ✅ Sumana Harihareswara, Engineering Community Manager (talk) 14:55, 24 August 2012 (UTC)

+2 for Mark Holmquist on mediawiki/extensions/UploadWizard
I'd like to request +2 rights for Mark Holmquist (MarkTraceur) on mediawiki/extensions/UploadWizard. We're doing a sprint from 8/20 to 8/31 to implement high priority fixes and improvements ahead of Wiki Loves Monuments. Mark has been casually reviewing code across MediaWiki for a couple of months now, and has authored many patches, especially for UW. I think it's time for him to be able to merge code (and live with the consequences :-).--Eloquence (talk) 18:28, 20 August 2012 (UTC)
 * For selfish reasons, I agree with this idea. I also question whether it's wise for me to want this. Even so, it would be nice to have. Thanks! --MarkTraceur (talk) 22:57, 20 August 2012 (UTC)
 * Support. --siebrand (talk) 16:05, 21 August 2012 (UTC)
 * +1 --Catrope (talk) 17:58, 21 August 2012 (UTC)
 * Antoine &#34;hashar&#34; Musso (talk) 19:51, 23 August 2012 (UTC)
 * +1 Kaldari (talk) 20:36, 23 August 2012 (UTC)
 * ✅ Sumana Harihareswara, Engineering Community Manager (talk) 14:54, 24 August 2012 (UTC)

Submit right for everyone
Right now one cannot submit a change to core even when it's been verified and +2'd. This happens when someone +2's and hits the wrong button or +2's before the change has been verified and then forgets about it. Rather silly you can't submit then and have to poke someone with the rights :) --Jeroen De Dauw (talk) 19:12, 9 August 2012 (UTC)
 * Absolutely not. There are many reasons why you might +2 something but not be ready to press Submit yet. Looking at Gerrit, I only see 10 changes that are +2 but not submitted...and all of them fall into one of the following 3 categories:
 * Needs a rebase/there's conflicts
 * Has unresolved dependencies
 * Someone has explicitly said "please don't submit this just yet"
 * Submitting a change is a big deal because that's what actually merges the change into the destination branch, so yeah, opening this up to everyone is a bad idea. ^demon (talk) 18:16, 10 August 2012 (UTC)


 * If there is a conflict or unresolved dependency, you cannot submit anyway. "please don't submit this just yet" should be a -2. So none of these seem like a valid argument against handing out this right. --Jeroen De Dauw (talk) 22:30, 11 August 2012 (UTC)


 * And I've yet to see a reason why it should be granted. The only reason you gave is one that simply isn't happening. This is a solution in search of a problem. ^demon (talk) 16:33, 21 August 2012 (UTC)
 * Agree with Chad, there's no good reason to disconnect submit rights from +2 rights. --Catrope (talk) 17:58, 21 August 2012 (UTC)

Bawolff for mediawiki/extensions/intersection
I'd like merge rights for intersection. I've been effectively the maintainer of that extension for the last 3 years (not that I've done very much to it) [obviously I wouldn't merge my own code]. Bawolff (talk) 21:42, 21 August 2012 (UTC)
 * +1 --Catrope (talk) 23:18, 21 August 2012 (UTC)
 * +1 Can't see any reason why not. ^demon (talk) 14:03, 22 August 2012 (UTC)
 * Antoine &#34;hashar&#34; Musso (talk) 19:51, 23 August 2012 (UTC)
 * Am about to implement this -- just checking with Chad as to whether I should name the group "extension-Intersection" or "extension-intersection". Sumana Harihareswara, Engineering Community Manager (talk) 15:04, 24 August 2012 (UTC)
 * ✅ Sumana Harihareswara, Engineering Community Manager (talk) 17:46, 24 August 2012 (UTC)

Semantic Watchlist
Ownership for SemanticWatchlist repo:


 * Nischayn22
 * yaron
 * markus


 * I guess Jeroen will have the final word there. Antoine &#34;hashar&#34; Musso (talk) 15:18, 4 September 2012 (UTC)


 * I think I posted this request - maybe I forgot to sing it or something. Either way, I'm definitely fine with it :) --Jeroen De Dauw (talk) 12:33, 10 September 2012 (UTC)
 * ✅ So sorry for the wait! I have now done this! Sumana Harihareswara, Engineering Community Manager (talk) 20:25, 20 September 2012 (UTC)

Rob Moen for mediawiki/extensions/VisualEditor

 * LDAP user name : Robmoen
 * Gerrit link : mediawiki/extensions/VisualEditor

The team would like Rob to have +2 too, to speed up code review. Jdforrester (WMF) (talk) 18:50, 20 September 2012 (UTC)
 * +1 --Catrope (talk) 20:18, 20 September 2012 (UTC)
 * ✅ Decided that I'll take the heat if Trevor objects. ;-) Congrats, Rob! Sumana Harihareswara, Engineering Community Manager (talk) 20:24, 20 September 2012 (UTC)

dsc to integration group
Just so anyone know, I am adding David "dsc" Schoonover to the integration group so he can merge things in integration/jenkins.git. Antoine &#34;hashar&#34; Musso (talk) 19:21, 24 September 2012 (UTC)

Comments

 * Sounds fine to me. ^demon (talk) 19:23, 24 September 2012 (UTC)
 * ✅ Antoine &#34;hashar&#34; Musso (talk) 19:23, 24 September 2012 (UTC)

Mathias Lidal for extension SmoothGallery
LDAP username: MathiasLidal I would like to take over maintainership of the SmoothGallery extension. As far as I can see this is no longer actively maintained. I have deployed this extension for a client and will continue to develop it (already have some bugfixes I would like to merge in)
 * Asking the author (Ryan Lane). Sharihareswara (WMF) (talk) 15:47, 27 September 2012 (UTC)
 * I'm fine with it. I don't have time to maintain it. I'm glad someone else wants to.--Ryan lane (talk) 19:55, 29 September 2012 (UTC)
 * ✅ Congrats, Mathias! Please change the Extension:SmoothGallery page to note that you are now the maintainer. Sharihareswara (WMF) (talk) 01:05, 30 September 2012 (UTC)

Add Ori to MediaWiki group
It's mostly a formality, but it is highly weird we have a features engineer with +2 in core, but not the extensions. Besides, all the other project teams but E3 have a mediawiki group member (some like Mobile and VisualEditor have multiple)… I suppose this is an artifact of me collecting all the core mediawiki contributors in VE.

Comments

 * I am the requestor -Tychay (talk) 21:30, 5 October 2012 (UTC)
 * --Eloquence (talk) 21:33, 5 October 2012 (UTC)
 * -- Gabriel Wicke (GWicke) (talk) 22:40, 5 October 2012 (UTC)
 * -- Antoine &#34;hashar&#34; Musso (talk) 14:36, 8 October 2012 (UTC)
 * ✅ Added Ori.livneh to the MediaWiki group. Sharihareswara (WMF) (talk) 14:38, 8 October 2012 (UTC)

Editor engagement owns MoodBar
I'd like to assign the developers of MoodBar to be able to +2 the MoodBar backlog. So that's a number of small changes (all related).


 * creation of the extension-MoodBar group
 * group membership of "editor-engagement" to MoodBar extension
 * me added explicitly to extesnion-Moodbar group
 * me added "editor-engagement" extensions groups (me added to the extension-$extension groups below)
 * Article Creation Workflow
 * ArticleFeedbackv5
 * ClickTracking
 * E3Experiments
 * Echo
 * PageTriage
 * UploadWizard
 * TimedMediaHandler

BTW, I already can empower individuals to the extension via "editor-engagement", but I need finer-grained control for some extensions so I can add people outside the WMF to some editor engagement extensions, but not all..

Comments

 * I am the requestor -Tychay (talk) 17:59, 5 October 2012 (UTC)
 * Fabrice Florin (WMF) (talk) 21:47, 5 October 2012 (UTC)
 * Tfinc (talk) 23:03, 5 October 2012 (UTC)
 * ori (talk) 19:20, 6 October 2012 (UTC)
 * Mlitn (talk) 09:26, 8 October 2012 (UTC)
 * ✅ Sharihareswara (WMF) (talk) 15:41, 8 October 2012 (UTC)

User:Jan Luca for mediawiki/extensions/CentralAuth

 * LDAP user name : jan

I would like to join the CentralAuth-project because I think this is a very important extension for the community of Wikimedia and currently there is only one other project owner for this project (beside the MW core-owner). --Jan Luca (talk) 14:33, 21 September 2012 (UTC)

Comments

 * Jan, thanks. Since Victor Vasiliev is the existing Gerrit project owner here (other than the MediaWiki core team of course) I'm pinging him to ask for comment.  Owners commenting: see Jan's reviews and Jan's changesets. Sumana Harihareswara, Engineering Community Manager (talk) 18:02, 21 September 2012 (UTC)
 * I'm sorry, but I am not much familiar with your MediaWiki work (that's my fault). Could you please link to some of your Gerrit reviews (+1 or -1)? Preferrably in CentralAuth. vvvt 05:00, 22 September 2012 (UTC)
 * My reviews and changesets. Jan Luca (talk) 10:51, 22 September 2012 (UTC)
 * Two changes for CentralAuth as example:
 * 
 * 
 * --Jan Luca (talk) 22:09, 22 September 2012 (UTC)
 * To be honest, I expect to see more thorough testing for the deployment-level code. vvvt 04:06, 26 September 2012 (UTC)
 * Jan, from Victor's comment, it sounds as though we are not accepting your request at this time. I infer from Victor's comment that you should submit patchsets that have more thorough tests associated with them, and that you should test others' patchsets more thoroughly before giving them +1 marks, and then request again.  Thanks for your contribution and I look forward to seeing your future +2 request! Sharihareswara (WMF) (talk) 15:46, 8 October 2012 (UTC)

Add Jon Robson and Rob Moen as owners of vector
Two things:


 * Create a extension-Vector group that owns the vector extension
 * Add the following to the group
 * Trevor Parscal
 * Jon Robeson
 * Rob Moen

Comments

 * I'm requesting on OK from Trevor, who doubles as the mediawiki ok ;-) -Tychay (talk) 21:02, 5 October 2012 (UTC)
 * Having Jon involved with reviews on Vector is going to facilitate properly cascaded stylesheets that work across platforms without requiring piles of ad-hoc overrides. He is the Kwisatz Haderach. ori (talk) 19:20, 6 October 2012 (UTC)
 * Antoine (hashar) gave a +1 just now over IRC. Sharihareswara (WMF) (talk) 15:57, 8 October 2012 (UTC)
 * indeed :-) Antoine &#34;hashar&#34; Musso (talk) 15:58, 8 October 2012 (UTC)
 * ✅ Sharihareswara (WMF) (talk) 16:02, 8 October 2012 (UTC)

Jeroen De Dauw for MediaWiki core ownership
And yes, I will only approve stuff of others that I'm qualified to review :) -- Jeroen De Dauw (talk) 18:14, 3 August 2012 (UTC)


 * -- Daniel Kinzler (WMDE) (talk) 16:15, 21 August 2012 (UTC)
 * We went over this in April, and the consensus was to grant +2 for certain extensions but not for core. I still have the same opinion. --Catrope (talk) 23:40, 21 August 2012 (UTC)
 * I love Jeroen changes, but I would prefer having a safeguard before landing them in production :-) Antoine &#34;hashar&#34; Musso (talk) 19:53, 23 August 2012 (UTC)
 * ❌ Sumana Harihareswara, Engineering Community Manager (talk) 15:09, 24 August 2012 (UTC)

As I understand it, the reason for not giving me merge rights is because I would supposedly go and merge my own stuff without discussion and break core. I understand that I should not merge my own code very well, and think I am quite responsible enough not to break things by being sloppy. I have merge rights to quite a few extensions, including WMF deployed ones, and AFAIK I have not merged in a single change that needed to be reverted since the git migration. So the argumentation against granting merge rights here seem invalid to me. At the very least, I'd like to ask for giving me a chance and revoking the right as soon as I merge in any of my own commits (which I guarantee you I will not do). --Jeroen De Dauw (talk) 20:07, 27 August 2012 (UTC)
 * It's not about merging your own changes, it's about about trust in general. We only give +2 access to people if the other reviewers trust their judgment. Once we actually have a process for revoking +2 access, I guess we could be more liberal about giving people access and taking it away from them if they break certain yet-to-be-determined rules, but right now we don't have such a process and we don't have those rules spelled out very well. So currently we can't really say "here's your access, but don't do X or we'll take it away", we can only say "here's your access, we're confident you'll use it well" or "sorry, you don't get merge access". I think that middle ground option should exist, and if and when it does that's what I'd vote to give you, but since it doesn't exist right now I'm voting conservatively. --Catrope (talk) 18:33, 31 August 2012 (UTC)
 * Sure. I'm absolutely fine with you not doing a +1 on this, as we don't know each other very well and have never worked together, hence it seems rather hard for you to properly judge my sense of responsibility. However, you are giving a -1, which I'm rather curious to hear what it is based upon. When I joined the community 3 years ago I was very novice, had no clue how stuff worked, and thus messed things up. I'm getting the impression this is being held against me here. --Jeroen De Dauw (talk) 12:43, 10 September 2012 (UTC)

suggesting thedj for MediaWiki Core
I suggest that TheDJ (Derk-Jan Hartman) be given Gerrit project ownership for the "mediawiki/core" Gerrit project. He's authored many improvements in MediaWiki, in Git and in Subversion, and reviewed as well. Sharihareswara (WMF) (talk) 19:38, 9 October 2012 (UTC)
 * +1, TheDJ is a solid long-time contributor, and we could definitely use another frontend reviewer with approval rights --Catrope (talk) 22:30, 9 October 2012 (UTC)
 * Support. Mind you that "reviewed" is not very accurate. The query result provides "submits to which a user was added as reviewer", which is in no way the same as "has reviewed revision and provided feedback". siebrand (talk) 22:31, 9 October 2012 (UTC)
 * +1 Krinkle (talk) 22:44, 9 October 2012 (UTC)
 * +1 Platonides (talk) 22:57, 9 October 2012 (UTC)
 * +1 I think he would be quite useful to help with core review and approval. Kaldari (talk) 20:58, 10 October 2012 (UTC)
 * , as if more support was needed. ;-) --Eloquence (talk) 22:40, 10 October 2012 (UTC)
 * ✅ Congratulations, Derk-Jan. Sharihareswara (WMF) (talk) 11:47, 11 October 2012 (UTC)
 * Thank you all. I'll try to contribute when I can, as always. TheDJ (talk) 10:23, 14 October 2012 (UTC)

Suggesting SPQRobin for MediaWiki core
I suggest that we give SPQRobin (Robin Pepermans) Gerrit project ownership for the "mediawiki/core" Gerrit project. He is currently the maintainer of the Wikimedia Incubator and was a Google Summer of Code student with Wikimedia in 2012. He's authored many MediaWiki changesets in Git and in Subversion, and has reviewed code as well. There are dozens of Gerrit reviews where he +1'd or merged without comment; he commented in at least the following reviews:


 * Sharihareswara (WMF) (talk) 19:33, 10 October 2012 (UTC)


 * He has made significant contributions and lot of his code is deployed at WMF, most prominently the Incubator extension. – Nikerabbit (talk) 16:22, 11 October 2012 (UTC)
 * ✅ Congratulations, Robin. Sharihareswara (WMF) (talk) 12:04, 12 October 2012 (UTC)
 * Thanks! SPQRobin (talk) 16:26, 13 October 2012 (UTC)

suggesting Anomie for MediaWiki Core
I suggest that Anomie (Brad Jorsch) be given Gerrit project ownership for the "mediawiki/core" Gerrit project. He has submitted several MediaWiki changesets that were merged in Git. Merged patches by Anomie in Subversion:

Substantive discussion, patches, or review include bugs and patches going back to 2008:

His reviews in Gerrit include:


 * Sharihareswara (WMF) (talk) 00:23, 11 October 2012 (UTC)
 * Anomie has been around for years, so he's very familiar with a couple of obscure things in MW core like the API and the preprocessor. He also knows a lot about JavaScript internals, which few of our +2ers do. He's been more actively eviewing code lately and the reviews I've seen from him were all good ones, so +1 --Catrope (talk) 00:26, 11 October 2012 (UTC)\


 * ✅ Congratulations, Brad. Sharihareswara (WMF) (talk) 12:03, 12 October 2012 (UTC)

proposing bawolff for MediaWiki core
I suggest that Brian Wolff (bawolff) get Gerrit project ownership for the "mediawiki/core" Gerrit project. He was a Google Summer of Code student, and has been contributing to MediaWiki since January of 2010. Brian has submitted several MediaWiki changesets that were merged in Git, and more than 200 commits in Subversion (including core and extensions). About 2/3 of these changesets include substantive reviews from Brian; sorry that I'm not specifically linking to each of them. Sharihareswara (WMF) (talk) 03:04, 12 October 2012 (UTC)
 * ^demon (talk) 18:09, 18 October 2012 (UTC)
 * I haven't worked with too much of Brian's code, but what I've seen has shown good judgement. CSteipp (talk) 19:04, 18 October 2012 (UTC)
 * ✅ Congratulations, Brian! Sharihareswara (WMF) (talk) 19:12, 18 October 2012 (UTC)

Suggesting myself (Victor Vasiliev) for MediaWiki core
Hello,

I do not commit to core much currently (since most code I work on is in extensions), but as far as I understand, that is where the majority of code review backlog is, and thus, I'd like to volunteer, if people find me suitable for this task. vvvt 23:12, 12 October 2012 (UTC)
 * +1 --Catrope (talk) 02:23, 13 October 2012 (UTC)
 * +1 Platonides (talk) 21:16, 13 October 2012 (UTC)

+1 - Hoo man (talk) 14:24, 17 October 2012 (UTC)
 * ✅ Congrats, Victor. Sharihareswara (WMF) (talk) 16:14, 18 October 2012 (UTC)
 * Thanks! vvvt 16:16, 18 October 2012 (UTC)

+2 rights to team members for extension/PostEdit
PostEdit is developed by E3, so team members spage, swalling, massaf should have +2 rights. (And Ori.livneh, but I assume he does already.) -- S Page (WMF) (talk) 19:10, 16 October 2012 (UTC)
 * I am exercising my powers as a nominal member of the MediaWiki core group to grant this. ✅ Sharihareswara (WMF) (talk) 21:19, 18 October 2012 (UTC)

+2 rights to Wikia team members for extension/VisualEditor
VisualEditor is developed jointly with Wikia and WMF; right now, all four WMF devs have +2 and none of the Wikia ones do, which we'd like to fix:
 * inez &mdash; Inez Korczyński
 * christian &mdash; Christian Williams
 * Jdforrester (WMF) (talk) 22:06, 18 October 2012 (UTC)

Comments

 * Tychay (talk) 23:21, 18 October 2012 (UTC)
 * Trevor Parscal (talk) 02:56, 19 October 2012 (UTC)
 * , of course. --Eloquence (talk) 06:58, 19 October 2012 (UTC)
 * ✅ Thanks! Sharihareswara (WMF) (talk) 17:19, 19 October 2012 (UTC)

Me to mediawiki group
So I am authorized to manage my own engineers (and volunteers) to their extensions. :-) Tychay (talk) 23:24, 18 October 2012 (UTC)

Comments

 * --Eloquence (talk) 06:58, 19 October 2012 (UTC)
 * ✅ - Thanks. Sharihareswara (WMF) (talk) 21:57, 26 October 2012 (UTC)

+2 for core and extensions
I am requesting +2 for core and all extensions mainly for l10n/i18n related patches as member of the translatewiki.net team.

Gerrit name: Raimond Spekking / username: raymond

Thanks. Raymond (talk) 07:20, 23 October 2012 (UTC)
 * I support this request. --siebrand (talk) 11:01, 23 October 2012 (UTC)
 * Clear support - Hoo man (talk) 00:54, 24 October 2012 (UTC)
 * ✅ Congratulations and welcome! Sharihareswara (WMF) (talk) 22:00, 26 October 2012 (UTC)

wmf-deployment +2 for spage
I'm already doing deployments of E3 Experiments on fenari, but after I "Commit the submodule update", I don't have the ability to +2 it. I have to find someone to approve changes like -Subproject commit 58f36f071e0558e74f8601ce822874ee44744fe2 +Subproject commit a7469d9a355eeae683673b8017f5dced874ab028 If people actually check the change then the review step adds value, otherwise it just lengthens our deployments. -- S Page (WMF) (talk) 02:09, 24 October 2012 (UTC)
 * ✅ already when I added some missing deployers to the wmf-deployment group. ^demon (talk) 20:08, 24 October 2012 (UTC)

Alex Monk be added to Echo
+2 privs for Alex Monk on Echo --Tychay (talk) 19:49, 24 October 2012 (UTC)

Comments

 * ✅ Congrats! Sharihareswara (WMF) (talk) 21:59, 26 October 2012 (UTC)

Tpt: DoubleWiki and Labeled Section Transclusion
I have been working on ProofreadPage for the past few months in order to clean the code and add new features required by Wikisource contributors. DoubleWiki and Extension:Labeled Section Transclusion are two extensions used also by Wikisource that have no maintainer and I would like to give them a few love. A commit access will help me significantly. Tpt (talk) 14:38, 21 October 2012 (UTC).
 * Support. Tpt is virtually alone to maintain these Wikisource-specific extensions.
 * No project ownership creates a bottleneck: Gerrit trivial change I0bd75d6a has been submitted in June, reviewed in September and today. Four months and the trivial change is still not merged.
 * Note: This requires to create the groups extension-DoubleWiki and extension-LabeledSectionTransclusion--Dereckson (talk) 21:14, 21 October 2012 (UTC)
 * Support 122.174.185.57 07:06, 30 October 2012 (UTC)
 * Who are you? You should probably log in. -- Krenair (talk &bull; contribs) 11:45, 30 October 2012 (UTC)
 * Support TheDJ (talk) 20:21, 30 October 2012 (UTC)
 * Support Raymond (talk) 17:43, 4 November 2012 (UTC)
 * ✅ Congratulations, Tpt! Sharihareswara (WMF) (talk) 23:16, 5 November 2012 (UTC)
 * ✅ Congratulations, Tpt! Sharihareswara (WMF) (talk) 23:16, 5 November 2012 (UTC)

Me (hoo) for +2 on AbuseFilter and CentralAuth
I would like to get +2 access on the WMF-deployed AbuseFilter and CentralAuth extensions, as I'm quite firm with them and would like to help further improving them. As a long term Wikimedia user, who is doing script works on the live Wikimedia wikis, I think I can be trusted to not abuse these rights and to only merge things I'm sure about. (Me on gerrit) - Hoo man (talk) 22:35, 26 October 2012 (UTC)
 * +1 on CentralAuth, as long as no non-trivial self-merges are done (which is the default assumption, but I believe I need to reiterate it here). vvvt 00:29, 30 October 2012 (UTC)
 * Sure, I don't think someone can be really sure about controversial changes he made himself (out of experience)... - Hoo man (talk) 22:29, 30 October 2012 (UTC)
 * Yep, that's part of the +2 policy. -- Krenair (talk &bull; contribs) 00:42, 30 October 2012 (UTC)
 * No objections. TheDJ (talk) 20:32, 30 October 2012 (UTC)
 * +1 The  helpful  one  21:15, 1 November 2012 (UTC)
 * ✅ Since hoo has gotten support for his CentralAuth request I'm granting him +2 there, but not on AbuseFilter since he hasn't gotten support there. Congrats on the new privileges, hoo! Sharihareswara (WMF) (talk) 18:50, 2 November 2012 (UTC)
 * From IRC: "[19:00:20 	 sumanah: I have to run, don't have time to edit the wiki page, but you can give hoo +2 on AF as far as I'm concerned"]
 * ✅ Granted +2 on AbuseFilter. Congrats, hoo! Sharihareswara (WMF) (talk) 19:01, 2 November 2012 (UTC)

PediaPress developers for Collection extension
I'm going to give the PediaPress developers (Heiko Hees and Ralf Schmitt) +2 on the Collection extension right now -- please speak up on this page if you think I shouldn't have. Sharihareswara (WMF) (talk) 20:34, 19 October 2012 (UTC)
 * Given to Ralf. Looks like Heiko does not have a Gerrit account so I will ask Heiko to make one. Sharihareswara (WMF) (talk) 20:36, 19 October 2012 (UTC)
 * Heiko says he doesn't need an account, so I'm calling this ✅. :) Sharihareswara (WMF) (talk) 21:07, 6 November 2012 (UTC)

Add rotsee to extension-SemanticExtraSpecialProperties
It's his extension after all :) --Jeroen De Dauw (talk) 14:36, 31 October 2012 (UTC)
 * ✅ Thanks! Sharihareswara (WMF) (talk) 21:08, 6 November 2012 (UTC)

2 new members for 2 groups
Please add jeroendedauw and markus to semanticmediawiki-trusted and semanticresultformats-trusted. --Jeroen De Dauw (talk) 18:54, 21 October 2012 (UTC)
 * I don't have the power to do this; Yaron, DanWe, Denny, Foxtrott, Kghbln, Mwjames, and Nischay are the ones who can. I've asked Yaron to look into it. Thanks. Sharihareswara (WMF) (talk) 21:15, 6 November 2012 (UTC)


 * It doesn't appear like I can do it either. I'm a member but not an administrator, or something like that. Yaron Koren (talk)
 * I'm told that Jeroen can add them himself. extension-SemanticMediaWiki is the owner of that group (as requested, so he could manage it). Go ahead, Jeroen! Sharihareswara (WMF) (talk) 16:25, 8 November 2012 (UTC)

Oh great, I can indeed manage these groups. Used to not being able to do this myself since this is the case everywhere else. Anyway, issue closed :) --Jeroen De Dauw (talk) 20:08, 12 November 2012 (UTC)

SPQRobin for translatewiki
I would like to have +2 access for the translatewiki.net group. I already have +2 access to MediaWiki core, and I am a staff member on translatewiki.net, though I'm not really active, but +2 access can still be useful. Thanks, SPQRobin (talk) 19:37, 15 November 2012 (UTC)
 * Confirmed. Raymond (talk) 19:41, 15 November 2012 (UTC)
 * ✅ & sorry for the wait! Sharihareswara (WMF) (talk) 01:28, 8 January 2013 (UTC)

Isarra requesting ownership of 5 unmaintained extensions
Something about ownership so I can more easily attempt to maintain these, or some such? I didn't write any of them or nothing, but apparently nobody wants them or something.

In the extensions pile:
 * DPLforum
 * MediaWikiAuth
 * RandomImage
 * Editcount
 * LogoFunctions

Thanks, I think. Although this is probably going to wind up smacking me in the face. Or something. -— Isarra ༆ 05:05, 24 November 2012 (UTC)
 * I'd link to them, but I'm not even sure what I'd link to at this point. I'm sorry, I have no idea what I'm doing, but hopefully I'll figure it out at some point. Yeah. -— Isarra ༆ 05:09, 24 November 2012 (UTC)
 * Isarra, is it correct to say that you are requesting ownership of these 5 extensions so you can improve them? The way you are writing makes it sound like you don't actually want that ownership and have no particular plans to improve the extensions.  Sharihareswara (WMF) (talk) 14:36, 25 November 2012 (UTC)
 * Improve, or at least maintain them as needed so they keep working with new versions. The notion of 'owning' the things is a little off-putting, but without anyone else around apt to look after them I don't see much for a better idea at present. -— Isarra ༆ 05:56, 26 November 2012 (UTC)
 * These extensions aren't deployed and no one else seems to have much love for them, so if you want to maintain them, knock yourself out. +1 for ownership rights. --Catrope (talk) 23:14, 27 November 2012 (UTC)
 * DPLforum is on Wikia and Uncyclopedia, Editcount is on Wikia. Odd that no one is maintaining these, but if you're willing to do so please go ahead. Carlb (talk) 01:48, 24 December 2012 (UTC)

Oh, this also goes for Jack Phoenix - as he is also on the project, he should have ownership as well. Whatever the case, however, at very least someone involved should or we're going to have some mighty trouble making changes... -— Isarra ༆ 18:07, 30 December 2012 (UTC)
 * I support the request for MediaWikiAuth, raising priority, as this extension has waiting reviewed commits pending a merge. --Dereckson (talk) 03:16, 3 January 2013 (UTC)


 * ✅ I've created the relevant extension ownership groups and added Isarra & Jack Phoenix for all 5 of these extensions. Please update Developers/Maintainers. Sharihareswara (WMF) (talk) 05:07, 8 January 2013 (UTC)


 * Odd, I would have thought I'd have had ownership to be able to commit stuff . . . I'm pretty sure I mentioned the project when I requested a gerrit account. Nevertheless, I don't mind the above two having it, since I am not currently in a position to maintain it. GreenReaper (talk) 05:15, 8 January 2013 (UTC)

Request myself as project owner of mediawiki/extensions/SoundManager2Button
--Kroocsiogsi (talk) 22:33, 19 November 2012 (UTC)
 * ✅ Sorry for the wait. I see no one else minded, so I'm approving you. Sharihareswara (WMF) (talk) 05:10, 8 January 2013 (UTC)

Mwdumper
Please include me in the mwdumper group. I would like to merge some bug fixes, since no one seems to be interested. Thanks, Bean49 (talk) 09:51, 19 November 2012 (UTC)
 * Mwdumper could sure use some love. Ownership request looks good to me, provided the user is willing to stick around for awhile after merging in their own fixes, commenting on or reviewing changes other people might make.  -- ArielGlenn (talk) 06:22, 20 November 2012 (UTC)
 * . --ori (talk) 00:41, 28 December 2012 (UTC)
 * Am checking with Bean49 as to whether s/he is okay with ArielGlenn's requirements. :) Sharihareswara (WMF) (talk) 01:25, 8 January 2013 (UTC)

I am concerned about the possibility to use mwdumper to import dumps into the database. Right now, mwdumper can be used to import dumps, even a binary is provided. If any problem occurs, I will be glad to help resolving it. --Bean49 (talk) 10:12, 8 January 2013 (UTC)
 * ✅ Thanks! I've added you. Sharihareswara (WMF) (talk) 21:53, 9 January 2013 (UTC)
 * Thanks! --Bean49 (talk) 22:50, 9 January 2013 (UTC)

Krenair for MediaWiki Core
Alex Monk (Krenair) has demonstrated good care with code review and has been a prolific fixer of bugs, in core and other projects. He's a prolific reviewer and bug-fixer (in the last two days, he has patched four bugs in core). Back in March, our then-bugmeister awarded him the MediaWiki Bug Squad Barnstar for his bug fixes. Finally, he is also an active and helpful admin on mediawiki.org, and has made significant contributions to the documentation. --ori (talk) 10:40, 25 December 2012 (UTC)

Supporting material

 * Gerrit reviews (all projects)
 * +/- 1s (mediawiki/core)
 * Gerrit changes (mediawiki/core)
 * Gerrit changes (all projects) Bugzilla activity
 * Contributions on mediawiki.org

Discussion

 * As requestor. --ori (talk) 10:40, 25 December 2012 (UTC)
 * Sounds like a great idea to me. Kaldari (talk) 10:47, 25 December 2012 (UTC)
 * Krenair has been a great help. CSteipp (talk) 01:15, 27 December 2012 (UTC)
 * Yes -trusted, helpful and experienced. The  helpful  one  01:31, 27 December 2012 (UTC)
 * Tychay (talk) 05:06, 27 December 2012 (UTC)
 * Aude (talk) 07:31, 27 December 2012 (UTC)
 * He's not already? Let's fix that. Anomie (talk) 14:22, 27 December 2012 (UTC)
 * Jdlrobson (talk) 16:04, 27 December 2012 (UTC)
 * --MZMcBride (talk) 21:48, 27 December 2012 (UTC)
 * Haven't (yet) seen many non-trivial changes by other people that he has reviewed as +1 that were merged as-is (which ought to be an obvious requirement for merge rights as those CR+1 would generally become CR+2 and merge). We no longer require permissions for patch submission access, so assuming this request is for granting merge rights (and thus ability to approve patches that will not be reviewed by others and deployed/released as-is in 2 weeks), I'd rather see a little more reviewing in current status. He is very helpful in bug triaging and documentation maintenance, but that's not quite the same as merge approval on changes for mediawiki core. Opposing as "not yet". I'd expect him to become a core contributor within a few months. His contributions are almost equally valuable without merge rights (having merge rights does not change patch submission as one doesn't merge own code; reviewing other's code with -1 for improvement is very helpful and about as helpful as +2, both reduces review load from mergers). Krinkle (talk) 17:51, 28 December 2012 (UTC)
 * I don't feel our criteria needs to be having a lot of +1's on core that are merged, since we've given +2 to WMF employees. In the past I think we've been minimizing type II error, at the cost of type I error—the fear of "bad committers" has hurt made an unreasonably high bar for community involvement at certain levels (then again, I feel the bar you, Roan, and others cleared was unreasonably high too). Things like +2 to WMF engineering have changed this dynamic and I'd like to see that new order extended to the community. I see this request more along the lines of fixing the imbalance between his responsibility in Echo and those of the WMF vs. the same action/participation on core patches that are Echo related (and others). The main criteria is do we feel he may act to be irresponsibly with +2 or, conversely, is he as responsible as current +2'ers (he's certainly more responsible with +2 than I am ;-))? Having said that, there's no harm in holding off on +2 for a month, since Alex probably represents the first of, what I hope, is a tidal wave of more community +2'ers in core and extensions. Tychay (talk) 22:07, 31 December 2012 (UTC)
 * I think Krinkle makes a reasonable point, but I really enjoyed the first sentence of your reply. :-) I'd say that discretion is also fairly important to consider in this forming Git model. Some volunteer devs have +2 now, but they only review changes they're comfortable reviewing (as it should be with everyone, really) and it seems to be working very well. Code review is a long tail and you need as many helping hands as possible. In terms of Krenair's ability to distinguish what's appropriate to merge and not merge, I'm not concerned. --MZMcBride (talk) 00:51, 3 January 2013 (UTC)
 * Am checking with Krinkle to see whether he would prefer to let his veto stand, so I can close this discussion. Thanks all. Sharihareswara (WMF) (talk) 01:23, 8 January 2013 (UTC)
 * It's fine to close the discussion. I plan on reopening/starting again on January 28th. If Alex hasn't blown up anything by then, then I think Timo's concerns are adequately addressed Tychay (talk) 22:35, 9 January 2013 (UTC)
 * I don't like to think of my opinion as a veto. When someone asks for my opinion I'm happy to share my view on things. May rational arguments be used. I've already given my view, and have nothing to add. Given the responses though I like to say (about merge rights in general) that I believe we should not confuse our merge rights with the ability to contribute. We solved this problem last year by radically changing our workflow to allow anyone to contribute without needing authorisation (i.e. Git/Gerrit review) and bugzilla has always been open (anyone can mark bugs as resolved etc.). We certainly should not start treating merge rights as the kind of thing we need to hand out to be friendly to volunteers. That would be a solution looking for a problem. With our new workflow comes different expectations and responsibilities. We no longer review master before deployments and releases, merging is the review. Merging a change effectively means nobody will ever look at it again and it will be deployed and released unconditionally. Submission of patches is unrelated to merge rights. And helping others code better, reduce review backlog is related but not restricted to having merge rights. Krinkle (talk) 14:09, 8 January 2013 (UTC)
 * The criteria for a request being approved are 1) the request has been open to comments for a reasonable period of time, 2) at least one existing owner has +1ed and 3) no existing owner has -1ed. So any -1 is a veto, that's how this process is designed. --Catrope (talk) 20:13, 8 January 2013 (UTC)


 * Per Anomie --Catrope (talk) 20:13, 8 January 2013 (UTC)

Not done. Moving to archive. Thanks all for the discussion. Sharihareswara (WMF) (talk) 18:11, 11 January 2013 (UTC)

Yurik for Core +2
I, Yurik would like to get Core +2.

I intend to use it mostly for the API patches (obviously not my own). My contributions include several recent patches to the API, as well as the API framework and action=query itself.

--Yurik (talk) 06:49, 13 February 2013 (UTC)
 * Eh, why isn't he one already? Support, of course. Max Semenik (talk) 09:44, 13 February 2013 (UTC)
 * do we really need to have a vote for this? --Bawolff (talk) 20:49, 13 February 2013 (UTC)
 * Welcome back --Catrope (talk) 00:12, 14 February 2013 (UTC)
 * I haven't worked with the historic Yurik from the mythic age of legends, but I can speak to the quality of his recent work, which is very good and much needed. --Ori.livneh (talk) 00:37, 14 February 2013 (UTC)
 * Aaron (talk) 05:19, 14 February 2013 (UTC)
 * Cool, nice to see API getting love again Tychay (talk) 23:13, 14 February 2013 (UTC)
 * ✅ Thank you, Yuri, and congratulations. Sumana Harihareswara, Engineering Community Manager (talk) 13:20, 19 February 2013 (UTC)

--Wikinaut (talk) 15:43, 7 January 2013 (UTC)


 * Platonides (talk) 20:58, 4 February 2013 (UTC)
 * Raymond (talk) 11:37, 14 February 2013 (UTC)
 * ✅ Thank you for your work, Wikinaut! Sumana Harihareswara, Engineering Community Manager (talk) 13:39, 19 February 2013 (UTC)

Krenair added to mediawiki group
It's been a month. Has he blown up anything? If not, I'd like him to be given mediawiki access -Tychay (talk) 18:52, 28 January 2013 (UTC)


 * Yes, please. --ori (talk) 18:30, 29 January 2013 (UTC)
 * --Catrope (talk) 03:04, 30 January 2013 (UTC)
 * . I'd also like to say thank you to Krenair for being extremely helpful lately in moving bugs forward with his changesets. Wonderful work that I hope continues! --MZMcBride (talk) 01:08, 31 January 2013 (UTC)
 * Mlitn (talk) 17:48, 31 January 2013 (UTC)
 * and ✅ ^demon (talk) 18:58, 4 February 2013 (UTC)

Wikinaut on Extension:RSS
https://www.mediawiki.org/wiki/Extension:RSS

I already maintain and own


 * EtherpadLite
 * AJAXPoll
 * OpenID
 * Suhosin
 * WikiArticleFeeds

In addition to that, I also volunteer to become owner of this extension, if everyone agrees. I understand, how it works, and kept already and keep the documentation up-to-date, and supplied many bug fixes and improvements.

--Wikinaut (talk) 15:43, 7 January 2013 (UTC)


 * Platonides (talk) 20:58, 4 February 2013 (UTC)
 * Raymond (talk) 11:37, 14 February 2013 (UTC)
 * ✅ Thank you for your work, Wikinaut! Sumana Harihareswara, Engineering Community Manager (talk) 13:39, 19 February 2013 (UTC)