Extension talk:ShareThis

Active X
This is a great extension, but it seems to be causing in error in IE7. I am running
 * MediaWiki: 1.9.2
 * PHP: 5.0.5 (cgi)
 * MySQL: 4.1.21-standard-log

The error comes when I first access my MW installation, a pop-up, asking to click 'ok' to run Active X control. I click 'ok' then IE7 crashes. Does anyone else experience this problem? --Rovo 03:30, 29 March 2007 (UTC)


 * Hmm - that's very strange. I haven't been able to reproduce this yet - I wonder if others are experiencing the same problem?  Are you sure it's ShareThis and not another extension? What other extensions do you have installed (if any)?  Thanks in advance. --Jimbojw 18:20, 29 March 2007 (UTC)

Minor Bug
The present code for the extension contains a bug: function wfInsertShareThisSidebar($template) {

global $wgShowShareThisSidebar, $wgShareThisSiteList, $wgTitle, $wgStylePath;

# Short-circuit if sidebar has not been activiated. if (!$wgShowShareThisSidebar) return;

# Close out the MonoBook toolbox and create a new "sharethis" portlet echo(       wfMsgForContent( 'share-this-toolbox-escape-html', wfMsgForContent('share-this-sidebar-header') )   );

# Display the links uksort($wgShareThisSiteList, 'strcasecmp'); foreach ($wgShareThisSiteList as $name=>$url) { $url = str_replace('$1', urlencode($wgTitle->getFullURL), $url); $url = str_replace('$2', urlencode($wgTitle->getText), $url); echo(           "" .            "" .            " " .            "$name"        );

} }

A return true; statement should be included at the end of the hook function in order for other extensions to have the chance to successfully hook themselves on 'MonoBookTemplateToolboxEnd' hook. This cause problems with other extensions such as Extension:Clipboard. Jean-Lou Dupont 18:33, 16 May 2007 (UTC)


 * Fixed! Thanks Jean-Lou --Jimbojw 20:19, 16 May 2007 (UTC)