User:Bryan/PagedTiffReader review notes

Note: I only reviewed the extension per line and did not look very much at the general overview. Also I didn't test it.

PagedTiffHandler_body

 * class PagedTiffHandler uses PHP4 type constructor
 * Why does it explicitly set $wgShowEXIF true?
 * PagedTiffHandler::isMultiPage
 * Why return true if the image does not exist?
 * PagedTiffHandler::check
 * wfLoadExtensionMessages is no longer required
 * Use the auto-loader for TiffReader, don't use require
 * PagedTiffHandler::normaliseParams
 * Needs to validate and normalize $params['lossy']
 * PagedTiffHandler::doTransform
 * WMF deployment requires TRANSFORM_LATER support
 * Integer conversion can better be done using (int) or intval
 * PagedTiffHandler::pageCount
 * Not really an issue, but we prefer functions to begin with a verb e.g. getPageCount
 * PagedTiffHandler::getLongDesc
 * Do NOT use $_GET; use $wgRequest
 * PagedTiffHandler::isMetadataValid
 * $metadata != serialize(array) is not required, since an empty array will fail the if check after the unserialize anyway.
 * PagedTiffHandler::visibleMetadataFields should begin with a verb

PagedTiffImage

 * PagedTiffImage::retrieveMetaData
 * This function returns -1 if the data is cached. It is supposed to just return the cached data if I am correct.
 * Not all callers are able to handle the non-array return data of this function