Extension talk:CloseWikis

Some review notes
consider renaming tables.sql to closewiki.sql (naming conventions)

Consider adding a timestamp and 'by' field to the closed table.

Credits info references http://www.mediawiki.org/wiki/Extension:CloseWikis which is blank

CloseWikis::getList cache seems like it should be unnecessary.

Instead of trawling through a list of every closed wiki ever, consider checking just the state of the current wiki individually in the permission checks.

Secondly, it just looks very weird to me -- first, the userCan hook looks like it'll apply to *any* action, but we close wikis only by locking them to read-only. What's the actual affect here?

Why not plug into the read-only hooks? What's intended?

$wgOut->addHTML( 'getLocalURL . '">' );

^^ URL needs escaping

public function doClose( $wiki, $dispreason ) {

^^ consider encapsulating all DB access into a single class here; let the special page and the hooks be clients of that class.

-- brion 18:29, 23 October 2008 (UTC)