Extension talk:Checkpoint

Hi, Thank you for your great extension. I have a small problem with your extension in my wiki which is running mediawiki 1.15.1. It works fine but when I install Extension:FlaggedRevs and approve the page as stable page, it does not work for further edits. Please let me know if any suggestions?

Use of "preview=yes" in query string
This extension is ancient, so I don't know if I'll get any replies, but here goes...

The behavior of this (very useful) extension is strange in the latest MediaWiki versions (e.g., 1.28). When you click "Save and continue editing," the content does get saved, but the page refreshes and leaves you in preview mode. This is weird because right at the top of the previewed page is a note that says the page wasn't saved:


 * Remember that this is only a preview. Your changes have not yet been saved!

I would argue that the use of "preview=yes" in the URL query string, which is set in the function, is no longer appropriate and should be changed as in this diff:

if ( $frag == '' ) { // just append our query to the end -     $url .= $querystr. 'action=edit&preview=yes'; +     $url .= $querystr. 'action=edit'; } else { // do a string replace -     $url = str_replace( $frag, $querystr . 'action=edit&preview=yes' . $frag, $url ); +     $url = str_replace( $frag, $querystr . 'action=edit' . $frag, $url ); }

Any reason why this shouldn't be changed?

--Maiden taiwan (talk) 21:34, 4 January 2017 (UTC)


 * This is normal behavior. Removing preview=yes would prevent the preview from appearing after hitting the button, if you have set in preferences that you don't want to display the preview just after hitting the edit link. preview=yes forces the preview appear on first hit of edit, even if in your preferences you doesn't have it. Example: . This is probably worth a bugreport against MediaWiki core, not this extension, suggesting to split the message about the preview and the warning about changes aren't saved, because the warning should appear only after you hit preview changes and not on the first edit screen. --Ciencia Al Poder (talk) 10:35, 5 January 2017 (UTC)