Extension talk:LocalisationUpdate/Archive 1

Some comments: +siebrand> LocalisationUpdate.php should be smaller, and you should lazy load from class files. +Nikerabbit> the sql should probably be hooked to LoadExtensionSchemaUpdates, it doesn't seem to support table prefixes +Nikerabbit> I also don't like that it creates a new entry point, either write a command line scripts, a special page or both +Nikerabbit> how does it determine which updates are compatible and which are not? +Nikerabbit> $query = "select value from localisation where identifier = '".$db->strencode($lckey)."' and language = '".$db->strencode($langcode)."'"; +Nikerabbit> we have nice $db->select for this :) +Nikerabbit> I also see some code duplication there – Nikerabbit 07:25, 20 May 2009 (UTC)

+Nikerabbit> any reason not to use preg_foo?
 * Done --TheDevilOnLine 07:50, 20 May 2009 (UTC)

+Nikerabbit> can you use Http::get instead of curl directly?
 * Done --TheDevilOnLine 07:50, 20 May 2009 (UTC)