Extension:Email notification/Bugs

'Please use Your feedback'' for questions to me, I will answer you directly as soon as possible. Thank you. --Nyxos 12:00, 14 Oct 2004 (UTC)'''

Links to pages with Umlauts in Name are broken
The links in the notification email are also broken for pages that have Umlaut characters in their name.

Links to diffs of disambiguated pages are broken in Thunderbird
When a page contains brackets, such as disambiguated pages, the link to the diff is broken in Mozilla Thunderbird. I haven't tested other MUAs. The link is basically cut off at the closing bracket, so looks something like this:

 http://domain.net/wiki/index.php?title=Foo_(Bar_Food )&diff=0&oldid=955

So, clicking on the link will make the browser open this URL:

http://domain.net/wiki/index.php?title=Foo_(Bar_Food


 * I think you should use rawurlencode($title). Reporter was HJ from Munich - Hi Tom!
 * This is not the correct function, we need wfUrlencode which leaves / as they are. --Tom Gries mail 03:29, 18 Nov 2004 (UTC)

when enabling disabled enotifs in user preferences: clear flags manually on your watchlist (one click)
When a user enables one of the basic enotif mail option (enotif for page changes; enotif for user_talk page changes), the eventually existing notification flags are not cleared automatically. This means essentially, that the user does not receive "further" mails - because the flags say, that he "already got an enotif". But this wasn't sent, because the former status was "do not send mails".

Solution: go to your watchlist page and click the button to one-click-clear all notification flags.

email sent out mistakenly when saving a pre-viewed page with zero changes
Discovered by Chris Phoenix, 25.10.2004

An email is sent out mistakenly, when - no changes were done - user clicks "Show Preview" - user clicks "Save" (instead of Cancel)

The not-changed page is not listed in the recent changes view, but an email notification is sent out. This is confirmed to be a bug. --Tom Gries (talk) mail me 21:12, 25 Oct 2004 (UTC)

"updated" marker marks all versions instead only the non visited version of watched pages
Enotif v1.21 now suppresses displaying the marker  updated (since my last visit) in recent changes view for the older (already visited) versions of watched pages - i.e. page versions before the enotif was sent do not bear that marker any longer.

diff MediaWiki1.3.6 incl. enotif v.1.21 against MediaWiki1.3.5 incl. enotif v1.2 @@ -156,7 +157,10 @@ 			if ( ! ( $hideminor && $obj->rc_minor ) ) { $rc = RecentChange::newFromRow( $obj ); $rc->counter = $counter++; -				$s .= $sk->recentChangesLine( $rc, !empty( $obj->wl_user ), $obj->wl_notificationtimestamp ); +				if ($obj->wl_notificationtimestamp && ($obj->rc_timestamp >= $obj->wl_notificationtimestamp)) { +					$showupdated = true; } +				else $showupdated = false; +				$s .= $sk->recentChangesLine( $rc, !empty( $obj->wl_user ), $showupdated ); --$limit; } 		}

Mail header problem. Subject: lines are empty
David reported empty Subject: headers in the sent notification mails. The problem is related to the way I am currently using the PHP mail function: I pass all mail headers such as to: and subject: via the mailbody. I should better use the dedicated to: and subject: parameters of the php mail function.

See http://bugs.php.net/bug.php?id=14799


 * Problem solved in Enotif versions > 1.21 .--Tom Gries (talk) mail me 22:31, 21 Oct 2004 (UTC)