Extension:MobileFrontend/Deployments/2013-07-30

Stories
Story: 997: Adding 'thank' link to MobileDiff view

Bugs
Bug: 52047: how error message on CAPTCHAs and extension errors

Bug: 52049: how error message on CAPTCHAs and extension errors

Bug: 46893: QA: Remove page-object gem deprecation warnings

Bug: 51994: Increasing timestamp font size on MobileDiff page

Bug: 51789: Fix CentralAuth logins

Bug: 51894: Licensing fix per Erik

Bug 51840: removeChild on a non-object in HtmlFormatter line 256

Bug: 51414: Enable login for older phones

Bug: 51735: Fix variants in language overlay

Regression
Regression: Fix nearby refresh button

Regression: After refresh make sure sections can be refreshed

Hygiene
Hygiene: Make it clearer where mobilediff code runs

Hygiene: Rename mf-cleanuptemplates to issues

Hygiene: Package up language modules

Hygiene: Package up search modules into directory

Hygiene: Rename css to be consistent with uploads directory

Hygiene: Drop mf- prefix on all common JavaScript

Hygiene: Rename mf-view.js to View.js

Hygiene: Remove dead css

Hygiene: Remove dead test

Hygiene: Remove another unnecessary closure

Hygiene: Get rid of $wgExtMobileFrontend

QA
QA: Remove page-object gem deprecation warnings

QA: New Automation test Menu urls for bug 51078

Uncategorized
Localization Changes

Show error message on CAPTCHAs

Simplify opt-in cookies

Header refactoring

Fix tag mobile edits

Obey the schema

Disable file input during upload

Blacklist editing on older phones

Minor cleanup: unused vars, annotations

Git Logs
commit 7035b40299b71b86c05cd8535a885f5f2becd5d3 Author: Translation updater bot  Date:  Mon Jul 29 19:33:59 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: Ibfd8b4134b644896caea9b5317b6c82243008416

commit dd2f9e6e889e4590f74263acf9b4b9c0493b4514 Author: Translation updater bot  Date:  Sun Jul 28 19:12:23 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I6eafa5dcf759086dfeb67ce21a314eb9ffe84b59

commit 54d188e2c8a7da65249c5cdba8683785ab2bb426 Author: kaldari  Date:  Wed Jul 24 18:24:51 2013 -0700

Adding 'thank' link to MobileDiff view See https://mingle.corp.wikimedia.org/projects/mobile/cards/997 Depends on having the Echo and Thanks extensions installed. Change-Id: I4c294252201f5f350798629cf11d76fa18506334

commit 743bae7d2a696bf9b83d545d0d357c0c440ade36 Author: Juliusz Gonera  Date:  Fri Jul 26 16:12:23 2013 -0700

Show error message on CAPTCHAs and extension errors Previously editor would silently fail in those unsupported scenarios. This commit does not fix bugs 52047 and 52049, it only makes the editor behaviour more predictable and prevents users from losing their edits completely. Also log those cases as errors in event logging (with error code if   available). Bug: 52047 Bug: 52049 Change-Id: I5494063a86d8c9f732eb05a007fdac903e2e6b20

commit 12e55b14681d2e67906aaa32f2f1259eeefa019b Author: Max Semenik  Date:  Fri Jul 19 23:01:04 2013 +0400

Simplify opt-in cookies * Don't use two cookies where you can use one * Simplifies accessors greatly Change-Id: I4db3329d36ee3e5d3af276dae34fc38b4b1f70be

commit b225bc78b2228a24ba0bb1fb74455ab479f92895 Author: JGonera  Date:  Fri Jul 26 22:01:04 2013 +0000

Revert "Fix: Tag mobile edits" This reverts commit 6bb8334b397b8bc8bf587b81431ba34e89c2df52. It did nothing. The problem was elsewhere. Fixed in 3e3332e112435d2822c1cc59954bc88ddfcc6e9e Change-Id: I8b43cb005c1ba855e29dd34722b2baa91461e633

commit 581f6272782cc3d13b71c2824667215118c7d4a8 Author: Translation updater bot  Date:  Fri Jul 26 20:36:18 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I5bb17e8329d3c72dda381dbf8555aaf69de0872f

commit 3e3332e112435d2822c1cc59954bc88ddfcc6e9e Author: jrobson  Date:  Thu Jul 25 16:54:49 2013 -0700

Re-enable mobile edit tagging Change-Id: I4639c655045ae32c83693390e352ba3887ecc964

commit 23e1cfb444b5a73c8c32f03858c3af4a435c1dd9 Author: Max Semenik  Date:  Fri Jul 26 02:22:18 2013 +0400

Get rid of $wgExtMobileFrontend Change-Id: Ia21b12ec9da02e00404a4572d13ec2d91db29c47

commit 569e317a674483ba0d825d6aa6ca2c7c1da58fa5 Author: jrobson  Date:  Thu Jul 25 13:02:12 2013 -0700

Hygiene: Make it clearer where mobilediff code runs Change-Id: Ia9434ab263b098b1d9f9d1a8ac365566a990c9b5

commit 96d723b994494f383ba6fbea82dbb6fd56764d45 Author: Translation updater bot  Date:  Thu Jul 25 19:29:24 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I3a352303dd280551a192bbc3427dd95b248fbabb

commit 621dd4f7b40dfc1ec200ff4dbbda0b675201e12d Author: Max Semenik  Date:  Thu Jul 25 21:14:00 2013 +0400

Headers refactoring * Move code from ExtMobileFrontend to MobileFrontendHooks because it's more logical - headers should be sent when we're displaying a mobile skin, not when we're processing HTML. * Add an explicit check for mobile mode, because before it was only accidentally that we weren't sending X-Analytics to desktop. This moves some changes out of https://gerrit.wikimedia.org/r/#/c/69336/ Change-Id: I618c6124a23232b27ad3223240550519ec76dda5

commit 762b320e27bab0c77e629342f21aad2021fa3dda Author: cmcmahon  Date:  Thu Jul 25 09:11:22 2013 -0700

Forgot to tell the test to visit a page, Jenkins builds need this Change-Id: I403e8945940d2d7f82d788c034ca668664e61b50

commit 314b59135bed79c51c71e077f23feb578a6251c2 Author: Tomislav Plavcic  Date:  Thu Jul 25 01:56:06 2013 +0200

QA: Remove page-object gem deprecation warnings Bug: 46893 Change-Id: I1b8343f7d5fbc641c6e27037bb7353073c8d6ebc

commit 64945ce121ece15608b5baaed0145233068d96af Author: jrobson  Date:  Wed Jul 24 16:01:14 2013 -0700

Regression: After refresh make sure sections can be refreshed This is currently due to lazy section loading in mf-toggle-dynamic This is only meant as a temporary workaround - we should either kill toggle-dynamic or refactor the existing code Change-Id: Ib8f78110a79459700439570cd7a386ce65568ad1

commit 6bb8334b397b8bc8bf587b81431ba34e89c2df52 Author: Juliusz Gonera  Date:  Wed Jul 24 15:30:50 2013 -0700

Fix: Tag mobile edits This should fix it. In the worst case it will do nothing. Change-Id: Ib42b64c0feb8614447709db6f1744bd900e408ab

commit 211495a0d589b6986cca2ce97b76c3eb61927ecf Author: jrobson <jrobson@wikimedia.org> Date:  Wed Jul 24 15:29:27 2013 -0700

Obey the schema The current used schema requests that the edit count is a number not a string otherwise it will not log Change-Id: I827f6d36045ac285c7a8aa3e430ef68c0549b43a

commit 35173037fb2680375d27fa8b4ce841d86f1564b5 Author: Michelle Grover <jcmish1@gmail.com> Date:  Wed Jul 10 00:05:25 2013 -0600

QA: New Automation test Menu urls for bug 51078 Make sure that Menus open to the correct bug Mingle Ticket #996 Change-Id: Iaa00ab48ac4d802b68c1c87ea14104cac01324dd

commit 591565e0875c9503002c836736d4478200f3d532 Author: kaldari <kaldari@gmail.com> Date:  Wed Jul 24 15:19:17 2013 -0700

Increasing timestamp font size on MobileDiff page Bug: 51994 Change-Id: I309a3c7c2e5b017fe30e3a420104be487a2fe742

commit fa4616b72591faf9d22b63708a489cdc46843176 Author: jrobson <jrobson@wikimedia.org> Date:  Wed Jul 24 13:44:54 2013 -0700

Disable file input during upload When you currently click upload the button disappears meaning you can't recover from a failed upload This instead disables it and re-enables it on a failure Change-Id: I3da47a1ab4bd4353f820ee5f4c4f76e4c0826173

commit d985a33dfc9a85add6cb9dfd8332b61c8b7aae94 Author: jrobson <jrobson@wikimedia.org> Date:  Wed Jul 24 13:32:09 2013 -0700

Blacklist editing on older phones Bug to be raised soon. There are issues with the editor and position fixed. Since this accounts for < 1% of our traffic this is probably acceptable Change-Id: I934c2d969b9934dce52068791b24a56069cdc5ff

commit 2351b74da49ac5e919d3f41bdfaabe96a84fff2a Author: jrobson <jrobson@wikimedia.org> Date:  Wed Jul 24 13:24:37 2013 -0700

Regression: Fix nearby refresh button Change-Id: If396b1ea81ea1fe3437036332f2b02639abc9943

commit 4f4f9082be0d3adeca4c91353e5a36606de7b91b Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Wed Jul 24 19:54:11 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I9bcea913993d0e9807658b70171171741bc3accc

commit a7e5aed8bc19d0082d91706df3e88dc58e666235 Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Mon Jul 22 23:37:26 2013 +0400

Fix CentralAuth logins Depends on https://gerrit.wikimedia.org/r/75154 but doesn't require it   for deployment. Bug: 51789 Change-Id: I578b69555ec1fd9e2014ca06c6e0533057a2c7f8

commit 15e7db2b3cd9d6ccce42b01a04b2ad0435304789 Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Wed Jul 24 01:22:09 2013 +0400

Licensing fix per Erik Bug: 51894 Change-Id: I019273b5c59d29ca3bb38ba5ee0c61f506f6a97a

commit 2aa084218d6fe93086687f3f53ee6f8be810e97b Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Tue Jul 23 18:40:31 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: Idab3838a76fe69c080cc06a2832fc4475c2d912e

commit de6c7f80a43358913054de747a34462de2312794 Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Tue Jul 23 01:40:21 2013 +0400

Bug 51840: removeChild on a non-object in HtmlFormatter line 256 Change-Id: I2e3317abfba62991ec528d6d1a3e826dfd33bcb1

commit 48d2ecd4cd730f29ec8c01e8e6ab2c307f91679d Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Mon Jul 22 20:15:13 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I623e432a3e0634cba9c7b29f43892c5d3c18fc54

commit a6d4a787cf6fb34b8bb84a34a2256424d3a88213 Author: jrobson <jrobson@wikimedia.org> Date:  Sun Jul 21 16:20:22 2013 -0700

Enable login for older phones Fix the watch star behaviour in no JavaScript mode for logged out users by turning it into a link to the login form Enable the login link in the menu Bug: 51414 Change-Id: I49d4b998397d8c1ca119f5fa0f5177c0a980e128

commit 7803d3b677c4d9bef33e4ce8cca0e6ecbd99c89d Author: jrobson <jrobson@wikimedia.org> Date:  Sun Jul 21 16:35:00 2013 -0700

Fix variants in language overlay Bug: 51735 Change-Id: I1d56a332c77ff0d428104cff1f7e8edd9cc505f8

commit 6e3a136542ad4b91e501fd478e908ea6d66ce36b Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Sun Jul 21 19:15:09 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: Id3c1da56f40f458af9569ad35e1924170868efc8

commit bb1027f66d2cc7ea900944e45206c53023034064 Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Sat Jul 20 20:48:30 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I13a41860ad499e9510d162543ebc7fd7d6285ca0

commit 62ce1b50aa30b8e7972171a56b07ae8943b4b333 Author: jrobson <jrobson@wikimedia.org> Date:  Fri Jul 19 16:58:35 2013 -0700

Hygiene: Rename mf-cleanuptemplates to issues Change-Id: Id73db43539ed20ea06fd4c6dba24fb14389b2909

commit cb3f39059489addc6b03eb79a8a53f8c96a250a8 Author: jrobson <jrobson@wikimedia.org> Date:  Fri Jul 19 16:56:44 2013 -0700

Hygiene: Package up language modules Change-Id: I51cc4c7bf1a4dad7a45f2ca633b871280b180235

commit 08c025b45ca372ffe4432b8df9484ccdc8e9eb05 Author: jrobson <jrobson@wikimedia.org> Date:  Fri Jul 19 16:52:35 2013 -0700

Hygiene: Package up search modules into directory Make css file correspond to it   Change-Id: I2254c3448670615922c608ae6a267ebd0bfd3815

commit 553811dc190692bafd29ff143bc3fc6ba60365cc Author: jrobson <jrobson@wikimedia.org> Date:  Fri Jul 19 16:51:10 2013 -0700

Hygiene: Rename css to be consistent with uploads directory Change-Id: I7505e3f29d5c8cf93f0e3cd44bec818006f5dd06

commit d08099bdd3b7efd63cf301667e0c0fe5c4fa2e48 Author: jrobson <jrobson@wikimedia.org> Date:  Fri Jul 19 16:27:28 2013 -0700

Hygiene: Drop mf- prefix on all common JavaScript Change-Id: I7fc1638de2edf1810918f118878eeb42b2012b62

commit 8ab116674152de854c69681d51c1e73816f4f21c Author: jrobson <jrobson@wikimedia.org> Date:  Fri Jul 19 16:17:58 2013 -0700

Hygiene: Rename mf-view.js to View.js   Change-Id: Ib1471e1004f3ef25d5869e32c0431be793de95d3

commit 75c357176f90b02075c6ca77abcceb24dfd60d19 Author: jrobson <jrobson@wikimedia.org> Date:  Fri Jul 19 16:14:57 2013 -0700

Hygiene: Remove dead css Change-Id: Id358a58d0dd94b46e47a04e4102149b532695d39

commit 4002eab8116c4cfa3060560a9948c268c3be817b Author: jrobson <jrobson@wikimedia.org> Date:  Fri Jul 19 16:14:14 2013 -0700

Hygiene: Remove dead test Change-Id: I50ea4c79436cc4b2a2691709e1d473d51eb255a5

commit 8e1ca0694533bb2f12e7dcb7ee0dbc1f42c6c594 Author: jrobson <jrobson@wikimedia.org> Date:  Fri Jul 19 16:13:24 2013 -0700

Hygiene: Remove another unnecessary closure Change-Id: I6526d0a1365d8e26d52adf1c07c0e2f6f766ddc3

commit 91af49096899d0fa5ef3c7b9d2c035025b6cd7d2 Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Fri Jul 19 19:47:33 2013 +0400

Minor cleanup: unused vars, annotations Change-Id: I750bdb11d25a6b79aab3676c3e6b9f420378bdec