Extension talk:Tabber

Thank you for this excellent extension! :D
It does just what I wanted, and more. I like that you can put anything in a tab, yes: anything. Kudos. --Jacmoe 18:03, 25 April 2009 (UTC)

re:
thanks for the feedback! --Kenyu73 00:08, 26 April 2009 (UTC)

error msg
Undefined variable: htmlTabs in ... on line 34

did you test this in different browsers? - just curious. Thinking of putting it on a public site.

Thanks! Evgeny Fadeev 23:48, 26 April 2009 (UTC)

re:
I think this is a warning, not an error correct? I didn't really go though and initialize the variables so trivial could pop up. I'll clean this up on the next release package though.

re: re:
Encountered the same problem. Fixed it by defining htmlTabs as nothing. Here's the code:

'Tabber',    'author'=>'Eric Fortin',    'url'=>'http://www.mediawiki.org/wiki/Extension:Tabber',    'description'=>'Create tabs that contain wiki compatible based data',    'version'=>'1.0' );
 * 1) Credits

$wgExtensionFunctions[] = "wfTabber";

// function adds the wiki extension function wfTabber { global $wgParser; $wgParser->setHook( "tabber", "renderTabber" ); }

function renderTabber( $paramstring, $params = array ){ global $wgParser, $wgScriptPath; $wgParser->disableCache; $path = $wgScriptPath. '/extensions/tabber/';

$htmlHeader = ' ' . '' . ' ';	$htmlFooter = ' '; $htmlTabs = '';

$arr = explode("|-|", $paramstring); foreach($arr as $tab){ $htmlTabs .= buildTab($tab); }

return $htmlHeader. $htmlTabs. $htmlFooter; }

function buildTab($tab){ global $wgParser; if( trim($tab) ==  ) return ; $arr = split("=",$tab); $tabName = array_shift( $arr ); $tabBody = $wgParser->recursiveTagParse( implode("=",$arr) ); $tab = '' . ' '.$tabBody.' ' . ' ';

return $tab; }

edit section links within tabs don't work
I'm getting a message like this when I click on edit tab:

You tried to edit a section that doesn't exist. Since there is no section 2, there's no place to save your edit. Evgeny Fadeev 23:53, 26 April 2009 (UTC)

re:
I may have to add to the php code to remove the section edits. I remember having the same issue with my presentation extension too. I'm not sure if they're really compatible in this manner. I'll dig a bit deeper thoough.

tab wrapping
when I make browser window narrower then width of combined tabs, vertical spacing of tabs appears less then their height. so they are right on top of each other

Evgeny Fadeev 23:58, 26 April 2009 (UTC)

re:
I knew about this issue, but I'm not really sure currently how to fix that one. JavaScript doesn't have a "NOWRAP" like HTML (=. I haven't done much in the original authors JavaScript code so I'll have to walk though it.

behavior switch magic word
Do you think it would be nicer to have a magic word like:

__TABSECTIONS__

and have tabs generated from the section structure? maybe it might be possible to do it through javascript alone.

Cheers, Evgeny. Evgeny Fadeev 00:03, 27 April 2009 (UTC)

paragraphs glued
the extension seems to cause consecutive paragraphs to be combined into one.

makes text harder to read.

Evgeny Fadeev 00:27, 27 April 2009 (UTC)

re:
This one is interesting... dunno why its removing the extra whitespace. It shouldn't?!? I'll have to debug that one for sure! As a workaround, use  tags.

re: Evgeny Fadeev
Thanks for posting the issues you found. I have though of using sections, but that would limit the tabs to the page level (ie: wouldn't be able to add tabs to a table that contains links and such). I'll see what I can do about the other bugs you've mentioned too.

Thanks! Eric

re
Hi Eric.

Take a look at this: http://www.bennadel.com/index.cfm?dax=blog:1563.view

maybe it's possible to mark up tabs with html comments, then have js build the tabs in browser?

That way everything would work normally even if javascript is off.

Evgeny Fadeev 17:51, 27 April 2009 (UTC)

Auto Rotate
It would be nice to have an auto rotate from Tab to Tab so that it can function like a featured content box as well. Anyone know how to do this? please e-mail me: kdanko@finestationery.com

Favourite Tab
I'm using this extension on my main page and it would be really neat to be able to mark one tab as my favourite tab, to be automatically selected when I go to the wiki! Generally, I'm finding that most users use just one of the tabs most of the time, so I guess it would be a user-specific setting. Anyone have any ideas of how this could be achieved?