Extension:MobileFrontend/Deployments/2013-08-27

Dependencies
commit d20c66dc4449da3c9f8d1d2e393483cea15deb50 Author: kaldari  Date:  Mon Jul 29 16:26:18 2013 -0700 Fixes a bug with the display of the fixed userinfo panel when the left-nav is open. It now behaves the same as the article content - squishing at large screen sizes and clipping on small screens. Also fixes weird white box bug in Chrome and Safari. Also consolidating css for #mw-mf-diffview #mw-mf-userinfo. Depends on having the Echo and Thanks extensions installed. Dependency: Ibc6916640840b5c1f05297f8f05ee44746f37b9d Change-Id: I41ef2e80001ae3eb8fd012d554430076b3bc0e3d

Stories
Story 834: Adding new notifications overlay

Story 1092: Show section-level edit login/signup CTA

Story 964: Move Echo to stable

Bugs
Bug: 50967: MobileContext::getDesktopUrl desn't really work for hosts like www.mediawiki.org <-> m.mediawiki.org

Bug: 49033: Inline code tags styled strangely in articles

Bug 51977: Hide the talk icon when refreshing talk pages

Bug 51924: Special case main page history link

Bug: 52361:Edit Spinner and Edit's Continue Button on Opera Mobile Classic Funky

Bug: 53282:'Contribute an image' button on Special:Uploads not working - Class.extend seems unreliable

Bug: 53160:Desktop nearby: pagelist.css not loading on Nearby desktop version

Bug 53103: Apply RTL styling for upload button

Bug 53104: Avoid showing last modified timestamp on non-existant pages

Bug 53078: Underscore characters in watchlist confirmation toast message

Bug 51639: Rephrase from 'All' to 'List'

Bug 53102: Simple fix for text indent in older browsers on cancel button

Bug: 49029:Cannot view old revisions of article on mobile (redirects to diff)

Bug 53059: Attach the message to the page

Regression
Regression: Stop edit cta showing for things that are not editable

Regression: Don't add edit link cta to footer for anonymous users

Regression: make section edit buttons work in alpha

Hygiene
Hygiene: get rid of M.getApiUrl

Hygiene: Kill FIXME

Uncategorized
Introduce PageApi

Localisation updates from http://translatewiki.net.

Uncomment token check in Special:MobileOptions

Log thank events from diff view

Refactor removals configuration

Add an extra paranoid check to blacklisting of WAP devices from HTTPS

Rm header logging, several days worth of data should be enough

Fix various Qunit tests

Fix MobileContext::getDesktopUrl

Blacklist WAP phones from HTTPS

Fix doxygen

Add user_mobile AbuseFilter variable, to allow debugging mobile edits.

Ensure uploads from user namespace go to correct page

Make toasts centered on Android browser

Log Accept headers in conjunction with User-agent

Git Logs
commit fc0aad4e5b34601060e0f5efcd7c9c8857a7a61e Author: kaldari  Date:  Fri Aug 23 16:03:04 2013 -0700

Story 834: Adding new notifications overlay Change-Id: I844b179f6d7972433afb9921755503abf96397dc

commit be51a404ad213fdaaf6ab35cf1081645b002bbd0 Author: jrobson  Date:  Mon Aug 26 13:27:52 2013 -0700

Style pre and code tags properly Bug: 49033 Change-Id: I2559599bae8c22b5d209e6c324666167b05e0468

commit 88f45489a666a75ff87f27db740715683a535dd1 Author: Juliusz Gonera  Date:  Wed Aug 14 20:49:21 2013 +0800

Introduce PageApi * Use it to dynamically load pages instead of M.history. * Make Page thinner (transformations in API). Change-Id: I8452b4d3ba1ff7d88dcf7582bdc4d480b4c3a493

commit 3b4ea8e24b0ad9834f8b4ff3f5768346381be87f Author: Translation updater bot  Date:  Mon Aug 26 19:40:41 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: If2540dcbe8a7e1db74f4ad9c5c7129ced971f169

commit dc3034f27f1eeb0ac949dcabeb8846a9e7d79e3f Author: Max Semenik  Date:  Thu Aug 22 19:11:08 2013 +0400

Uncomment token check in Special:MobileOptions Tested live - it works properly with current Varnish configuration Change-Id: I0c1697e73cdca22131085cdad4d4b9d75ccede88

commit 8b07ad089543482af657ac7ce27e489b57f9c6f0 Author: jrobson  Date:  Mon Aug 26 11:18:34 2013 -0700

Regression: Stop edit cta showing for things that are not editable In process do some refactoring for readability purposes sectionId is not the same as the hash (this confused me) Make reusable extractSectionIdFromEditLink Change-Id: I4ab40eeb7f1fdcec23f548845a30c4ffeaa1a655

commit f0fcfaeec88034a9840c698bf0d4799609955a22 Author: jrobson  Date:  Fri Aug 23 13:29:24 2013 -0700

Log thank events from diff view Made additional ResourceLoader module to prevent all JavaScript loading at top of page * Make reusable thanks module * refactor createThankLink to be more generic Change-Id: I87e10e1283d8299f42fb675c839391e3f0142e4f

commit 54b5fc1b6b9710ccb1653d637d73434766df6045 Author: Juliusz Gonera  Date:  Mon Aug 26 18:36:07 2013 +0200

Don't use document.body Can't be trusted, is null in some cases. Bug: 52361 Bug: 53282 Change-Id: Ifb45718a29b8d3147be483349b30a4bc080604d6

commit 0420f12ea90008f94bde0a40199f56f2d5700f63 Author: Translation updater bot  Date:  Sun Aug 25 20:03:33 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: Ic3b292d5026daba3857ec3506fbf724d73d0f1b6

commit 421031f4caa291ef5b3d6b244d43696548cb09f1 Author: Translation updater bot  Date:  Sun Aug 25 13:28:25 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: Ia3b3a1affc80c88314fe4affb9f7f2f92a9b0239

commit 89ba3dd9fbffbcd3f920ac095dbea17d920492c1 Author: jrobson  Date:  Fri Aug 23 14:31:29 2013 -0700

Desktop: Load pagelist styles on nearby Bug: 53160 Change-Id: Ic9f0737be18e909c44a9e7f05728b3e66765b3fb

commit 43d2ce684eb01193ef46b5f4e059988ec0786a36 Author: jrobson  Date:  Fri Aug 23 14:19:18 2013 -0700

Regression: Don't add edit link cta to footer for anonymous users Change-Id: Ia237399e04466ee917e395cf445049ec63ab9d2c

commit 7aef7def093d115e6d5da7a42b06fae42ec4535f Author: jrobson  Date:  Fri Aug 23 12:59:26 2013 -0700

Bug 53103: Apply RTL styling for upload button Change-Id: Id50ac8949157e50262b1d2d32f63f7f1ce54b854

commit c311ae183a97a09cbe876771b6b3dce1b9a5cda1 Author: jrobson  Date:  Fri Aug 23 12:51:56 2013 -0700

Bug 53102: Simple fix for text indent in older browsers on cancel button Change-Id: I5da54a5e0169a9df552825c6d5d259e2ca379928

commit 1dad413b63b805aa889ebf64204761a608e17a88 Author: Translation updater bot  Date:  Fri Aug 23 19:47:06 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I2fa2bfa5693ccfe390f1816220d0973bf31a092b

commit 22ecd85f8b2d6f86333007d75ae4c0d761d1b9f8 Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Wed Aug 21 23:20:08 2013 +0200

Story 1092: Show section-level edit login/signup CTA Change-Id: Ie750d44da5d53f7123910b3333b38f0d6a05d3fb

commit bbbeb9e7b95d617f259f1d8959c63647bdcf4b54 Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Fri Aug 23 01:06:35 2013 +0400

Refactor removals configuration Now all the aspects of DOM transformation are configured separately, allowing to control things more precisely. Change-Id: I432e1a06b736fb2a5b3d4aece294bf59241ec352

commit e75554d10f49c37354d7a5f00a1d2b58dcfd3423 Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Thu Aug 22 19:46:57 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I634319cbcbc9755582e3cef5dc2258d8669eb522

commit 7c5e3e5fd7cd96cedffc0e9a551ff7e8072cef32 Author: jrobson <jrobson@wikimedia.org> Date:  Wed Aug 21 15:12:43 2013 -0700

Story 964: Move Echo to stable Add is-authenticated class to body tag for logged in users * Hide echo button when not logged in   ** Drop the echo log in cta * Customise Notifications special page for mobile to add a return to link at top of page * Move css to stable Change-Id: Id5ea7a54546fa166fd3ee3d9bb22ca1ab725cffe

commit feb8b1b4171e5dc31c4ca159e78cb41a1f71b0df Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Tue Aug 20 21:52:59 2013 +0400

Don't redirect everything with oldid to MobileDiff Bug: 49029 Change-Id: I44e51ae5a4935a8bd4330a59f3721f10dd8ae859

commit 9df94e497b5b0344f159eab58619595edb8456a5 Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Thu Aug 22 21:47:38 2013 +0400

Add an extra paranoid check to blacklisting of WAP devices from HTTPS Change-Id: Ida98aa8e886d3e1cca7f57897435b43dde5defc1

commit bb140936b0ea54c55d3766b6a91db8458f7c7aa8 Author: jrobson <jrobson@wikimedia.org> Date:  Thu Aug 22 10:21:26 2013 -0700

Bug 53059: Attach the message to the page The message is being used but not available on the client. Change-Id: I28db86fa6a145c768fc4023428092b5d9ec79734

commit 40ef1ef5a50e84c0f5f7215e2a2dcf1ef3e99574 Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Thu Aug 22 19:16:34 2013 +0400

Rm header logging, several days worth of data should be enough Change-Id: I47db8b14a47f557ffd87d1ff4d6dea138e010e25

commit d20c66dc4449da3c9f8d1d2e393483cea15deb50 Author: kaldari <kaldari@gmail.com> Date:  Mon Jul 29 16:26:18 2013 -0700

Fixes a bug with the display of the fixed userinfo panel when the left-nav is open. It now behaves the same as the article content - squishing at large screen sizes and clipping on small screens. Also fixes weird white box bug in Chrome and Safari. Also consolidating css for #mw-mf-diffview #mw-mf-userinfo. Depends on having the Echo and Thanks extensions installed. Dependency: Ibc6916640840b5c1f05297f8f05ee44746f37b9d Change-Id: I41ef2e80001ae3eb8fd012d554430076b3bc0e3d

commit 5c799815d88c03469dc486c57849f4c11be94629 Author: jrobson <jrobson@wikimedia.org> Date:  Wed Aug 21 17:29:56 2013 -0700

Bug 53104: Avoid showing last modified timestamp on non-existant pages Change-Id: Idb1b1ff1db8d191f8de7bc0d17e6b20a763f8eea

commit e20ce3a9c904d9a230c020a2792e8cb9487b3e29 Author: jrobson <jrobson@wikimedia.org> Date:  Wed Aug 21 17:12:54 2013 -0700

Bug 53078: Underscore characters in watchlist confirmation toast message Change-Id: I747def547c5d69713dba5b88ffa0eab45d84e054

commit cafba458bb0064524561b2a5cc3548f6aef345d5 Author: jrobson <jrobson@wikimedia.org> Date:  Wed Aug 21 17:06:24 2013 -0700

Bug 51639: Rephrase from 'All' to 'List' This makes it distinct from the all button in modified view Change-Id: I23c3eefa89a88e6e578ab934db71de6aba0baab0

commit 58dded6c494fa3d98df95ab419c555b33dd63fcb Author: jrobson <jrobson@wikimedia.org> Date:  Tue Aug 20 15:13:36 2013 -0700

Fix various Qunit tests These appear to be due to recent changes introducing tap and assertMode functions Note there are still 3 tests failing in debug mode to do with overlays Change-Id: I7ec5914168d81f532a93ce2ac4cd581e26b65eb6

commit 89a17992e4cd915405e6505caed2c3f10f177d70 Author: jrobson <jrobson@wikimedia.org> Date:  Wed Aug 21 15:09:29 2013 -0700

Hygiene: Kill FIXME Change-Id: Ib1502797385ae01d924faf7d9ce12633d4ce9491

commit bd79c269d992de2b23452405d1c71d1aa7b264a6 Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Wed Aug 21 20:59:21 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I4c4f0f93d4940bf0a879d69ab415ad3940c4c3a0

commit f0f5d59a4dad3676cc5052ff7be76767fd151a2c Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Mon Jul 8 23:13:46 2013 +0400

Fix MobileContext::getDesktopUrl Uses $wgServer to reset desktop hostname rather than attempt to strip out mobile-specific domain name elements as was done previously. Bug: 50967 Change-Id: I18ae772e35bf34063538e987ea1d28d9517c51a2

commit b8ceaed25ff75c19fcc2912729e08e93018dcd9e Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Wed Aug 21 11:21:18 2013 +0400

Blacklist WAP phones from HTTPS Change-Id: I4b4585a1dd51b94234c5ab82713fc991c3a64107

commit 5667bfbcb0848fbeab9b02acee5e7f84f9ed84f6 Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Wed Aug 21 11:28:42 2013 +0400

Fix doxygen Change-Id: I9e5c9368b1c2cdf99ef44405581f975be1e8b4cd

commit 6a0c6dfbf467a9ab798fa473afb7cb49b8496b8d Author: Andrew Garrett <agarrett@wikimedia.org> Date:  Tue Aug 20 15:37:09 2013 -0700

Add user_mobile AbuseFilter variable, to allow debugging mobile edits. Change-Id: I30276fc8d9ed7869dd8d21eddc054497e88a9b9a

commit 1a7ad4bf96c653b195a610b60a460ef6803cdf0c Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Wed Aug 21 00:10:17 2013 +0200

Regression: make section edit buttons work in alpha Change-Id: Iff4a6464d9245fec7ab1c8b3f4e172287dffa284

commit 9c09d11198cf929d7716995bf956270befa28617 Author: jrobson <jrobson@wikimedia.org> Date:  Tue Aug 20 15:03:02 2013 -0700

Ensure uploads from user namespace go to correct page Currently they are always going to main namespace Change-Id: I6c9b9d94b53bc2d28db2faedc6e7773841be35fd

commit 5befcaf165f9897f45d14752337eae335ab32327 Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Tue Aug 20 22:47:53 2013 +0200

Make toasts centered on Android browser A small regression after notifications rewrite. Change-Id: I0dec675d6de570b809b8a7e011a39e00e366c19c

commit 16cd4eaf50261cac65f11c42549bfb6abc3ef3df Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Wed Aug 14 20:48:42 2013 +0800

Hygiene: get rid of M.getApiUrl Change-Id: Idaa5bef8c420b18ac3a9c14ada79fb4932061b0c

commit 4a6dc127db3b6c9f84fe6f6c373a765a8569e3cf Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Wed Aug 14 19:01:17 2013 +0800

Make page heading markup uniform Same HTML, both when loading dynamically and when not. Change-Id: Id42f3e990a73e44f073049c78d98c4bd8e752414

commit 39ba1ad218be37b4dc7e9ca56ef44c90d1b8b232 Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Tue Aug 20 19:34:22 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: Ia522002952f3d2be550053353c87b369861fda5e

commit 41df27ecbb795921ce9c812d08fcf8d8ee63eb3a Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Tue Aug 20 19:20:37 2013 +0400

Log Accept headers in conjunction with User-agent I need this to figure out what to do with X-WAP detection. Change-Id: I51d4420ac8a1e21a5ed29fefc07941cf7e4180af

commit 239c7766344d9f4baa8b358fec3064ab39827d2c Author: jrobson <jrobson@wikimedia.org> Date:  Wed Aug 14 15:57:41 2013 -0700

Bug 51977: Hide the talk icon when refreshing talk pages Change-Id: Ie97266dd6c5ad49b1a10cd2424e16c1960864792

commit 06acfe90a070eb8f84fbb6c129dff15d05ae7953 Author: jrobson <jrobson@wikimedia.org> Date:  Thu Aug 15 14:15:56 2013 -0700

Bug 51924: Special case main page history link Change-Id: Ie223558ba9078424b2406f667639c3fc7b5077f2