Gerrit/Project ownership

__NEWSECTIONLINK__ This page queues individuals' requests to be added to the Gerrit project owner groups for specific Gerrit projects (each of which corresponds to a Git repository). A Gerrit project owner has the power to approve changes for merger into that Gerrit project's master branch, and to veto changes.

"When/how we'll add, remove people from Gerrit project owner groups" has procedural details. Sumana Harihareswara will regularly look at new requests for project owner membership and contact the existing project owners. If the candidate gets zero vetoes and at least one yes from the existing project owners, then we'll approve the candidate. For each new candidate the process shouldn't take more than two weeks, and usually much less.

If your codebase/extension/tool isn't in Git yet, use this form to create a new Gerrit project: Git/New repositories

To see the current list of Gerrit project owners for a specific Gerrit project, visit https://gerrit.wikimedia.org/r/#/admin/groups/.

Ownership structure
Example: an extension is named foo.
 * The Gerrit group "foo" should usually be an owner of the Gerrit project "foo."
 * Sometimes, meta-groups will be included in the group. This is for people have ownership over multiple extensions, so you can add/remove members in one place.
 * Rights to the group may be inherited from other groups (Look for a "Rights Inherit From:" in the project access.)

Specific example: the project "mediawiki/extensions/DonationInterface" is owned by group "extension-DonationInterface." This group includes the meta-group "fundraising." Also members of the group "mediawiki" has ownership via "Rights Inherit From: "mediawiki/extensions access"

By keeping the naming convention ("extensions/foo" is owned by group "extension-foo"), it'll make the "automatically setup a repo" process much more scriptable when we hit that bridge.

(Note to Gerrit group creators: remember to check the "Make group visible to all registered users." checkbox and leave the group type as "Internal group" and not LDAP.)

= Requests =

[ Add a request]

A bunch of new groups
I'd like to have an $extension-trusted group (initially empty and with no rights assigned) for the following extensions: Validator, Maps, SemanticMaps, Push, LiveTranslate, SubPageList, Spark, IncludeWP, Survey, DidYouKnow, Gitweb (once created), DataValues (once created), Diff, SemanticWatchlist, SemanticImageInput and SemanticBundle.

These groups would be owned by their respective $extension-owner group.

This will allow me to manage my extension myself without posting a request here each time someone should get access :) --Jeroen De Dauw (talk) 19:25, 17 August 2012 (UTC)

Comments

 * Support. --siebrand (talk) 16:06, 21 August 2012 (UTC)
 * Since these are non-deployed extensions, I think this is fine. But I'd like to get input from Chad before we start introducing new group structures. --Catrope (talk) 18:02, 21 August 2012 (UTC)
 * I don't *like* it as proposed since this is very quickly going to explode the number of groups we have. Ideally all extension-$name groups should be owned by an extension-$name-owner (other than deployed exts, perhaps). The reason it's all currently owned by the "Project & Group Creators" was so people could process this page and add new users to their respective groups. What I'd like is either A) A way to manage all groups without giving out admin privs, or B) Multiple owners of groups. The former is probably easier. This all being said, perhaps we can go ahead with this structure for a few non-deployed extensions anyway and see if we really need this page at all for granting access to those. ^demon (talk) 14:05, 22 August 2012 (UTC)
 * Well then I suppose we'd be supportive of adding Jeroen as the owner of all those groups? Also, it seems to me that there are a number of them should be in some metagroup fro SMW. Tychay (talk) 20:56, 5 October 2012 (UTC)
 * Chad, sorry for being obtuse, but when you say "perhaps" is that a go-ahead for me to go ahead and create the "extension-Validator-trusted", "extension-Maps-trusted", etc. Gerrit groups, and when necessary, the "extension-[name]" groups to own the "trusted" groups? Thanks. Sharihareswara (WMF) (talk) 15:44, 8 October 2012 (UTC)
 * Jeroen, I set up the relevant groups for Validator and I think I set them up how you'd like. Is that right? Tried to ping you in IRC, haven't gotten a response -- let me know if that's the right model and I'll do the rest of the groups. Sharihareswara (WMF) (talk) 23:52, 9 November 2012 (UTC)

Thanks for setting that group up Sumanah. You made the group owner of itself. If this is an acceptable thing to do, then perhaps there is no point in having such extra groups, as you could just make the extension-name groups own themselves, solving the issue with less work and clutter. Think chad had some reason to not do this though. --Jeroen De Dauw (talk) 20:15, 12 November 2012 (UTC)

Nischyan branch owner in SemanticMaps
I tried making Nischyan owner of the nischyan branch of SemanticMaps by adding a group he's member of as owner of this branch. I want him to be able to happily merge in stuff without needing approval of someone else. Since this did not work, I tried giving him pretty much all other rights on the branch, but he says he's still not able to approve his own commits. Am I doing something wrong? https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/SemanticMaps,access
 * -- Jeroen De Dauw (talk) 15:04, 24 September 2012 (UTC)


 * Reviewing commits (Verified+1, CodeReview+2, Submit) needs to be assigned to the appropriate refs/for/* refspace, not the destination ref. Compare and . ^demon (talk) 19:23, 24 September 2012 (UTC)


 * So it should be refs/for/refs/heads/nischyan? --Jeroen De Dauw (talk) 18:26, 28 September 2012 (UTC)


 * Yes ^demon (talk) 18:21, 18 October 2012 (UTC)

This does not appear to work - can you check the settings to see if they are correct? --Jeroen De Dauw (talk) 18:53, 21 October 2012 (UTC)

Mwdumper
Please include me in the mwdumper group. I would like to merge some bug fixes, since no one seems to be interested. Thanks, Bean49 (talk) 09:51, 19 November 2012 (UTC)
 * Mwdumper could sure use some love. Ownership request looks good to me, provided the user is willing to stick around for awhile after merging in their own fixes, commenting on or reviewing changes other people might make.  -- ArielGlenn (talk) 06:22, 20 November 2012 (UTC)
 * . --ori (talk) 00:41, 28 December 2012 (UTC)
 * Am checking with Bean49 as to whether s/he is okay with ArielGlenn's requirements. :) Sharihareswara (WMF) (talk) 01:25, 8 January 2013 (UTC)

I am concerned about the possibility to use mwdumper to import dumps into the database. Right now, mwdumper can be used to import dumps, even a binary is provided. If any problem occurs, I will be glad to help resolving it. --Bean49 (talk) 10:12, 8 January 2013 (UTC)
 * ✅ Thanks! I've added you. Sharihareswara (WMF) (talk) 21:53, 9 January 2013 (UTC)

valhallasw (LDAP: Merlijn van Deen) for LabeledSectionTransclusion
LST on gerrit

Sumana suggested I should apply for (co)ownership of the LabeledSectionTransclusion extension. I am the author of the recent patch that added support for section tags in templates, and thus have some knowledge of the code base. As such, I think I could be helpful in reviewing & merging new patches. Valhallasw (talk) 08:50, 28 November 2012 (UTC)
 * +1 Tpt (talk) 14:08, 28 November 2012 (UTC)
 * Thanks and sorry for the wait on this. I am getting a weird error when I try to add you to the group: "Merlijn van Deen (email) is not a registered user."  I'll ask Chad to look at this. Sharihareswara (WMF) (talk) 01:20, 8 January 2013 (UTC)

Creation of a repository for my extension, PreloadContent
I am developing a new extension, Extension:PreloadContent and I want to have my code hosted on MediaWiki repos. --Milad Naseri (talk) 11:09, 3 December 2012 (UTC)
 * Can you please describe this extension in greater detail, or provide a code sample? --ori (talk) 00:40, 28 December 2012 (UTC)

carlb on extension-SpecialNamespaces
Am attempting initial check-in of extension:SpecialNamespaces (39720) and was sent here to request merge access to the repository to import existing code. I doubt that this extension is deployed on any major site outside the foreign-language Uncyclopedia set, where it originated in 2006 as what should have been a short-lived stopgap. Carlb (talk) 01:44, 24 December 2012 (UTC)

Krenair for MediaWiki Core
Alex Monk (Krenair) has demonstrated good care with code review and has been a prolific fixer of bugs, in core and other projects. He's a prolific reviewer and bug-fixer (in the last two days, he has patched four bugs in core). Back in March, our then-bugmeister awarded him the MediaWiki Bug Squad Barnstar for his bug fixes. Finally, he is also an active and helpful admin on mediawiki.org, and has made significant contributions to the documentation. --ori (talk) 10:40, 25 December 2012 (UTC)

Supporting material

 * Gerrit reviews (all projects)
 * +/- 1s (mediawiki/core)
 * Gerrit changes (mediawiki/core)
 * Gerrit changes (all projects) Bugzilla activity
 * Contributions on mediawiki.org

Discussion

 * As requestor. --ori (talk) 10:40, 25 December 2012 (UTC)
 * Sounds like a great idea to me. Kaldari (talk) 10:47, 25 December 2012 (UTC)
 * Krenair has been a great help. CSteipp (talk) 01:15, 27 December 2012 (UTC)
 * Yes -trusted, helpful and experienced. The  helpful  one  01:31, 27 December 2012 (UTC)
 * Tychay (talk) 05:06, 27 December 2012 (UTC)
 * Aude (talk) 07:31, 27 December 2012 (UTC)
 * He's not already? Let's fix that. Anomie (talk) 14:22, 27 December 2012 (UTC)
 * Jdlrobson (talk) 16:04, 27 December 2012 (UTC)
 * --MZMcBride (talk) 21:48, 27 December 2012 (UTC)
 * Haven't (yet) seen many non-trivial changes by other people that he has reviewed as +1 that were merged as-is (which ought to be an obvious requirement for merge rights as those CR+1 would generally become CR+2 and merge). We no longer require permissions for patch submission access, so assuming this request is for granting merge rights (and thus ability to approve patches that will not be reviewed by others and deployed/released as-is in 2 weeks), I'd rather see a little more reviewing in current status. He is very helpful in bug triaging and documentation maintenance, but that's not quite the same as merge approval on changes for mediawiki core. Opposing as "not yet". I'd expect him to become a core contributor within a few months. His contributions are almost equally valuable without merge rights (having merge rights does not change patch submission as one doesn't merge own code; reviewing other's code with -1 for improvement is very helpful and about as helpful as +2, both reduces review load from mergers). Krinkle (talk) 17:51, 28 December 2012 (UTC)
 * I don't feel our criteria needs to be having a lot of +1's on core that are merged, since we've given +2 to WMF employees. In the past I think we've been minimizing type II error, at the cost of type I error—the fear of "bad committers" has hurt made an unreasonably high bar for community involvement at certain levels (then again, I feel the bar you, Roan, and others cleared was unreasonably high too). Things like +2 to WMF engineering have changed this dynamic and I'd like to see that new order extended to the community. I see this request more along the lines of fixing the imbalance between his responsibility in Echo and those of the WMF vs. the same action/participation on core patches that are Echo related (and others). The main criteria is do we feel he may act to be irresponsibly with +2 or, conversely, is he as responsible as current +2'ers (he's certainly more responsible with +2 than I am ;-))? Having said that, there's no harm in holding off on +2 for a month, since Alex probably represents the first of, what I hope, is a tidal wave of more community +2'ers in core and extensions. Tychay (talk) 22:07, 31 December 2012 (UTC)
 * I think Krinkle makes a reasonable point, but I really enjoyed the first sentence of your reply. :-) I'd say that discretion is also fairly important to consider in this forming Git model. Some volunteer devs have +2 now, but they only review changes they're comfortable reviewing (as it should be with everyone, really) and it seems to be working very well. Code review is a long tail and you need as many helping hands as possible. In terms of Krenair's ability to distinguish what's appropriate to merge and not merge, I'm not concerned. --MZMcBride (talk) 00:51, 3 January 2013 (UTC)
 * Am checking with Krinkle to see whether he would prefer to let his veto stand, so I can close this discussion. Thanks all. Sharihareswara (WMF) (talk) 01:23, 8 January 2013 (UTC)
 * I don't like to think of my opinion as a veto. When someone asks for my opinion I'm happy to share my view on things. May rational arguments be used. I've already given my view, and have nothing to add. Given the responses though I like to say (about merge rights in general) that I believe we should not confuse our merge rights with the ability to contribute. We solved this problem last year by radically changing our workflow to allow anyone to contribute without needing authorisation (i.e. Git/Gerrit review) and bugzilla has always been open (anyone can mark bugs as resolved etc.). We certainly should not start treating merge rights as the kind of thing we need to hand out to be friendly to volunteers. That would be a solution looking for a problem. With our new workflow comes different expectations and responsibilities. We no longer review master before deployments and releases, merging is the review. Merging a change effectively means nobody will ever look at it again and it will be deployed and released unconditionally. Submission of patches is unrelated to merge rights. And helping others code better, reduce review backlog is related but not restricted to having merge rights. Krinkle (talk) 14:09, 8 January 2013 (UTC)
 * The criteria for a request being approved are 1) the request has been open to comments for a reasonable period of time, 2) at least one existing owner has +1ed and 3) no existing owner has -1ed. So any -1 is a veto, that's how this process is designed. --Catrope (talk) 20:13, 8 January 2013 (UTC)


 * Per Anomie --Catrope (talk) 20:13, 8 January 2013 (UTC)

Wikinaut on Extension:RSS
https://www.mediawiki.org/wiki/Extension:RSS

I already maintain and own


 * EtherpadLite
 * AJAXPoll
 * OpenID
 * Suhosin
 * WikiArticleFeeds

In addition to that, I also volunteer to become owner of this extension, if everyone agrees. I understand, how it works, and kept already and keep the documentation up-to-date, and supplied many bug fixes and improvements.

--Wikinaut (talk) 15:43, 7 January 2013 (UTC)