User:Werdna/GlobalBlocking checklist

Per brion's comments on bug 8707:
 * GlobalBlocking class..
 * GlobalBlocking::getUserPermissionsErrors
 * lack of caching may or may not be worrying


 * conditions...
 * $conds = array( 'gb_address' => $ip, 'gb_timestamp<'.$dbr->addQuotes($dbr->timestamp(wfTimestampNow)) );
 * ok that looks totally broken.
 * no ip range checks
 * timestamp in the past? wtf? we want future blocks?
 * add the range checks
 * remove this extra timestamp check
 * add an expiry check
 * $expiry changes data types (coded timestamp -> text), this is poor practice
 * change this to another var
 * expiry is loaded but not checked
 * expire if we're old!
 * $block->gb_by_wiki is dumped straight into err msg output without a clear data type
 * what's the type of db_by_wiki? dbname or interwiki?


 * GlobalBlocking::getGlobalBlockingMaster
 * GlobalBlocking::getGlobalBlockingSlave
 * uses wfGetDB... is this right for the current load balancersystem?


 * GlobalBlocking::buildForm
 * just replace this with wfBuildForm since it calls through...


 * SpecialGlobalBlock...


 * SpecialGlobalBlock::execute
 * if (!is_array($errors) || count($errors)>0) {
 * wtf? this is some u


 * SpecialGlobalBlock::trySubmit
 * Error-out for dupe bl