User:APatro (WMF)/Patch Review Feedback

<< INPROGRESS >>


 * 1) Always ensure you run `composer fix` before submitting patch.
 * 2) `@param` conventions - The convention is to use all lowercase for primitive types and TitleCase for objects. For eg: `string` instead of `String`
 * 3) Warnings should never be suppressed for a large section of code.
 * 4) `@param / @return` - Array of strings, including associative arrays can be denoted by - `string[]`. Same for other types of arrays.
 * 5) Throw an exception incase of unintended effects. Use specific exceptions from here - http://php.net/manual/en/spl.exceptions.php
 * 6) Avoid violating module boundaries. *For eg*: This class MessageGroups should not have intimate knowledge how different message groups behave.
 * 7) Use `setTemporaryHook` when adding hooks for test cases.
 * 8) Use PHPUnit method - `assertInstanceOf` instead of checking `instanceof`
 * 9) JavaScript - When declaring function documentation - Please leave an empty line between the previous code / function and the comment.
 * 10) You shouldn't update the other language files besides `en.json` and `qqq.json`. Rest of the files will update automatically once the changes go through translatewiki.net.
 * 11) In case of UI changes test with atleast the Timeless and Vector skin.
 * 12) For JS code, do not use the word extension or component..Instead use **module**.