Extension:MobileFrontend/Deployments/2013-12-12

Dependencies

 * [//gerrit.wikimedia.org/r/#q, I786b63ab57518fc6af7761501259ed66592f70e3,n,z Dependency: I786b63ab57518fc6af7761501259ed66592f70e3]
 * [//gerrit.wikimedia.org/r/#q,I708006fd6733cac89128bc76a1cd34c0d091c371,n,z Dependency: I708006fd6733cac89128bc76a1cd34c0d091c371]

Stories

 * [//wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1402 Story 1402: A/B test showing edit guider after user creates an account]

Bugs
[//bugzilla.wikimedia.org/show_bug.cgi?id=57994 Bug: 57994] commitcommit 4b386d6edc898d2c57a5cc7986b0ebc720065e68 Author: Max Semenik  Date:  Tue Dec 10 03:57:44 2013 +0400

Add PageImages to action=mobileview Bug: 57994 Change-Id: I8094bc4afdb9fe62ee69493d6ba3a1e01598acff [//bugzilla.wikimedia.org/show_bug.cgi?id=57415 Bug: 57415] commit 64386ef9883eb43798637e9c203ba254d6072c95 Author: Kunal Mehta  Date:  Sun Dec 8 21:44:40 2013 -0800

Only show geonotahack beta feature if nearby is enabled Bug: 57415 Change-Id: I244105f2758123df81904df571a4a93eeda764a7 [//bugzilla.wikimedia.org/show_bug.cgi?id=57710 Bug: 57710] commit 285e41e1fccda1957b4c8056ab020ee64fb46b56 Author: Juliusz Gonera  Date:  Mon Dec 9 16:34:53 2013 -0800

Increase the gap between username and roles in diff Fix cropped user icon in watchlist in the process. Bug: 57710 Change-Id: Ifc3e21858423390e62ba61839256132ad487228d [//bugzilla.wikimedia.org/show_bug.cgi?id=58102 Bug: 58102] commit 65377aba93138c9399386aed1f8c1903e0c1be71 Author: jrobson  Date:  Fri Dec 6 10:23:19 2013 -0800

Override language_urls template data to avoid hook abuse Various extensions abuse the SkinTemplateOutputPageBeforeExec hook to append things that are not language urls to this template variable. Mobile expects these all to be actual languages - not links to edit languages or other 'phantom' list items. We only recently started using core to generate this list 2 weeks ago and since then we've hit various bugs so it's obviously not in a usable state. As a result we should revert back to the tried and tested way of   2 years of generating this list ourself after the hook has run to ensure we get what we need. Bug: 58102 Bug: 57091 Bug: 57094 Change-Id: I09a870aa8e2a8b9be8c45b54d5c646ae5b105cf9 [//bugzilla.wikimedia.org/show_bug.cgi?id=57091 Bug: 57091] commit 65377aba93138c9399386aed1f8c1903e0c1be71 Author: jrobson  Date:  Fri Dec 6 10:23:19 2013 -0800

Override language_urls template data to avoid hook abuse Various extensions abuse the SkinTemplateOutputPageBeforeExec hook to append things that are not language urls to this template variable. Mobile expects these all to be actual languages - not links to edit languages or other 'phantom' list items. We only recently started using core to generate this list 2 weeks ago and since then we've hit various bugs so it's obviously not in a usable state. As a result we should revert back to the tried and tested way of   2 years of generating this list ourself after the hook has run to ensure we get what we need. Bug: 58102 Bug: 57091 Bug: 57094 Change-Id: I09a870aa8e2a8b9be8c45b54d5c646ae5b105cf9 [//bugzilla.wikimedia.org/show_bug.cgi?id=57094 Bug: 57094] commit 65377aba93138c9399386aed1f8c1903e0c1be71 Author: jrobson  Date:  Fri Dec 6 10:23:19 2013 -0800

Override language_urls template data to avoid hook abuse Various extensions abuse the SkinTemplateOutputPageBeforeExec hook to append things that are not language urls to this template variable. Mobile expects these all to be actual languages - not links to edit languages or other 'phantom' list items. We only recently started using core to generate this list 2 weeks ago and since then we've hit various bugs so it's obviously not in a usable state. As a result we should revert back to the tried and tested way of   2 years of generating this list ourself after the hook has run to ensure we get what we need. Bug: 58102 Bug: 57091 Bug: 57094 Change-Id: I09a870aa8e2a8b9be8c45b54d5c646ae5b105cf9 [//bugzilla.wikimedia.org/show_bug.cgi?id=57931 Bug: 57931] commit 3d509562b855f597decd1719dc242fd2f0092caa Author: kaldari  Date:  Tue Dec 3 18:11:10 2013 -0800

Don't create empty user descriptions for User Profile If the initial description and new description are both empty, just switch the User Profile back to view mode instead of trying to save the user description page with no content. Bug: 57931 Change-Id: I54f51476833d400db3a4276f8db35870f18a898e

Hygiene

 * hygiene and appearance
 * Hygiene: Make use of M.isBetaGroupMember
 * HYGIENE: Deprecating @baseFontSize
 * HYGIENE: Removing FIXME that has been fixed.

I18n
Localisation updates from https://translatewiki.net. commit c1ac5dce6165b34eba6d3ff70f0e9123c4922854 Author: Translation updater bot  Date:  Wed Dec 11 20:27:27 2013 +0000

Localisation updates from https://translatewiki.net. Change-Id: Iff4b2edc1e1497e02f72cc6bff56751518e2a867 Localisation updates from https://translatewiki.net. commit 1f3c57137afae1d0f8ac602b62dccc741893d670 Author: Translation updater bot  Date:  Tue Dec 10 20:43:12 2013 +0000

Localisation updates from https://translatewiki.net. Change-Id: I6b06c518c539f2824de2b20c88633b624041586b Localisation updates from https://translatewiki.net. commit a2416037d23878205a26e540868f29f68c9343aa Author: Translation updater bot  Date:  Mon Dec 9 21:25:17 2013 +0000

Localisation updates from https://translatewiki.net. Change-Id: I06382069392863c1b644017b242f433c670e3ccf Localisation updates from https://translatewiki.net. commit e07c97ec16177ce0c24231223057b5049f6658eb Author: Translation updater bot  Date:  Sun Dec 8 20:26:08 2013 +0000

Localisation updates from https://translatewiki.net. Change-Id: I7873eec212925dfdef8726b2ac979f9652b7e7d3 Localisation updates from https://translatewiki.net. commit 32a98bffc724d525af0b0781116f8ee07c1c484b Author: Translation updater bot  Date:  Sat Dec 7 01:44:01 2013 +0000

Localisation updates from https://translatewiki.net. Change-Id: Ib09a7cc51d8c3c37a40dce001d6901216303c57f Localisation updates from https://translatewiki.net. commit 46c2e8b850c9d8412f52253ba61a0c4e8e7d7434 Author: Translation updater bot  Date:  Thu Dec 5 21:17:49 2013 +0000

Localisation updates from https://translatewiki.net. Change-Id: I5efe0d8aabfdd6ebeb9962284e04571c4af7ebe4

Regressions

 * Regression: Fix file uploads

Other
commit 8b9d3cee762d4a818ce9997d28bb16fb71fab6af Author: MaxSem  Date:  Tue Dec 10 22:45:24 2013 +0000

Return 404s on MobileHistory without a title This reverts commit 49c6a1c49078818f5fb1a69df77a2f017c5d0397. Change-Id: I1f225422d588742291774a5135191de00fec989d commit dadbf1166e03f348fb09e91d6020e0bc23b10a38 Author: jrobson  Date:  Mon Dec 9 11:54:33 2013 -0800

Kill some php notices when $wgDevelopmentWarnings = true; * getLang deprecated in favour of getLanguage * special pages are case sensitive Change-Id: I5f671c3164a9f79c312f360f33cbe0017f70015e commit 236405b13b08df80d81757d757d1a7dd29824cf6 Author: aude  Date:  Fri Dec 6 11:39:55 2013 +0100

Fix logout link code to use Userlogout instead of alias When $wgDevelopmentWarnings = true; there are various php error notes triggered whilst creating the login/out link "Found alias defined for Userlogout when searching   for special page aliases for UserLogout. Case mismatch? " Change-Id: I05e31a8b7cd8f046384ea9636466e02d897ac159 commit 2bc11bf0b91495252d19d3b04494cd7213d0c5e5 Author: cmcmahon <cmcmahon@wikimedia.org> Date:  Fri Dec 6 11:14:59 2013 -0700

new test for uploading an image Change-Id: Ib6b14ab3d8bdbf096bfc74b553a058104027f219 commit e2977bf9023f498f772dfe0d3f269cb606567ffa Author: jrobson <jrobson@wikimedia.org> Date:  Wed Nov 27 14:14:21 2013 -0800

Beta: Override Special:Contributions and Special:RecentChanges with mobile equivalents Obviously more work is needed on both of these views before pushing to   stable but at least they render much more nicely in the mobile skin. Change-Id: Ia00fc297e9687ad8c08c17ad1a0f4df1832f1125 commit 0b969fa1d6fa813c708f8de231d9ba8c4705c85e Author: Rob Moen <rmoen@wikimedia.org> Date:  Wed Dec 4 09:55:57 2013 -0800

Add general errorHandling to VisualEditorOverlay Change-Id: I6635e5048145699907ca763eaa4d268d8175d971 commit 14cae75306c62eff8449366a18eae94573275cd4 Author: Rob Moen <rmoen@wikimedia.org> Date:  Thu Dec 5 17:35:41 2013 -0800

Prefetch wikitext on summary screen This reflects recent changes to the save method in the mw.target module Exchange html to wikitext from parsoid in the summary view, once fetched, the submit (or save) button becomes enabled. Change-Id: I81191b3e8895b0041ab08c6b1e15589ca5656e88

Raw git log
commit 4b386d6edc898d2c57a5cc7986b0ebc720065e68 Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Tue Dec 10 03:57:44 2013 +0400

Add PageImages to action=mobileview Bug: 57994 Change-Id: I8094bc4afdb9fe62ee69493d6ba3a1e01598acff

commit 8b9d3cee762d4a818ce9997d28bb16fb71fab6af Author: MaxSem <maxsem.wiki@gmail.com> Date:  Tue Dec 10 22:45:24 2013 +0000

Return 404s on MobileHistory without a title This reverts commit 49c6a1c49078818f5fb1a69df77a2f017c5d0397. Change-Id: I1f225422d588742291774a5135191de00fec989d

commit c1ac5dce6165b34eba6d3ff70f0e9123c4922854 Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Wed Dec 11 20:27:27 2013 +0000

Localisation updates from https://translatewiki.net. Change-Id: Iff4b2edc1e1497e02f72cc6bff56751518e2a867

commit 1f3c57137afae1d0f8ac602b62dccc741893d670 Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Tue Dec 10 20:43:12 2013 +0000

Localisation updates from https://translatewiki.net. Change-Id: I6b06c518c539f2824de2b20c88633b624041586b

commit 64386ef9883eb43798637e9c203ba254d6072c95 Author: Kunal Mehta <legoktm@gmail.com> Date:  Sun Dec 8 21:44:40 2013 -0800

Only show geonotahack beta feature if nearby is enabled Bug: 57415 Change-Id: I244105f2758123df81904df571a4a93eeda764a7

commit 285e41e1fccda1957b4c8056ab020ee64fb46b56 Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Mon Dec 9 16:34:53 2013 -0800

Increase the gap between username and roles in diff Fix cropped user icon in watchlist in the process. Bug: 57710 Change-Id: Ifc3e21858423390e62ba61839256132ad487228d

commit dadbf1166e03f348fb09e91d6020e0bc23b10a38 Author: jrobson <jrobson@wikimedia.org> Date:  Mon Dec 9 11:54:33 2013 -0800

Kill some php notices when $wgDevelopmentWarnings = true; * getLang deprecated in favour of getLanguage * special pages are case sensitive Change-Id: I5f671c3164a9f79c312f360f33cbe0017f70015e

commit a2416037d23878205a26e540868f29f68c9343aa Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Mon Dec 9 21:25:17 2013 +0000

Localisation updates from https://translatewiki.net. Change-Id: I06382069392863c1b644017b242f433c670e3ccf

commit 236405b13b08df80d81757d757d1a7dd29824cf6 Author: aude <aude.wiki@gmail.com> Date:  Fri Dec 6 11:39:55 2013 +0100

Fix logout link code to use Userlogout instead of alias When $wgDevelopmentWarnings = true; there are various php error notes triggered whilst creating the login/out link "Found alias defined for Userlogout when searching   for special page aliases for UserLogout. Case mismatch? " Change-Id: I05e31a8b7cd8f046384ea9636466e02d897ac159

commit 2bc11bf0b91495252d19d3b04494cd7213d0c5e5 Author: cmcmahon <cmcmahon@wikimedia.org> Date:  Fri Dec 6 11:14:59 2013 -0700

new test for uploading an image Change-Id: Ib6b14ab3d8bdbf096bfc74b553a058104027f219

commit 3ea1a92f2f20cef1ba853c3e1cfa9c2539236936 Author: cmcmahon <cmcmahon@wikimedia.org> Date:  Mon Dec 9 10:14:57 2013 -0700

hygiene and appearance Change-Id: I8b7d3eb67e4cbed0d9ca3e104876c8f1493b2bb9

commit e07c97ec16177ce0c24231223057b5049f6658eb Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Sun Dec 8 20:26:08 2013 +0000

Localisation updates from https://translatewiki.net. Change-Id: I7873eec212925dfdef8726b2ac979f9652b7e7d3

commit 32a98bffc724d525af0b0781116f8ee07c1c484b Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Sat Dec 7 01:44:01 2013 +0000

Localisation updates from https://translatewiki.net. Change-Id: Ib09a7cc51d8c3c37a40dce001d6901216303c57f

commit ea41655a6af9b09ee8cbc2e6b4fcd6fef99d2999 Author: jrobson <jrobson@wikimedia.org> Date:  Thu Dec 5 16:18:52 2013 -0800

Hygiene: Make use of M.isBetaGroupMember Change-Id: I643c95db3ee4c8faa6fc8ef91585adf6b488984d

commit 65377aba93138c9399386aed1f8c1903e0c1be71 Author: jrobson <jrobson@wikimedia.org> Date:  Fri Dec 6 10:23:19 2013 -0800

Override language_urls template data to avoid hook abuse Various extensions abuse the SkinTemplateOutputPageBeforeExec hook to append things that are not language urls to this template variable. Mobile expects these all to be actual languages - not links to edit languages or other 'phantom' list items. We only recently started using core to generate this list 2 weeks ago and since then we've hit various bugs so it's obviously not in a usable state. As a result we should revert back to the tried and tested way of   2 years of generating this list ourself after the hook has run to ensure we get what we need. Bug: 58102 Bug: 57091 Bug: 57094 Change-Id: I09a870aa8e2a8b9be8c45b54d5c646ae5b105cf9

commit e2977bf9023f498f772dfe0d3f269cb606567ffa Author: jrobson <jrobson@wikimedia.org> Date:  Wed Nov 27 14:14:21 2013 -0800

Beta: Override Special:Contributions and Special:RecentChanges with mobile equivalents Obviously more work is needed on both of these views before pushing to   stable but at least they render much more nicely in the mobile skin. Change-Id: Ia00fc297e9687ad8c08c17ad1a0f4df1832f1125

commit dac6751b6fb30b70d65ecd6fa2e5522ad53a2b74 Author: jrobson <jrobson@wikimedia.org> Date:  Thu Dec 5 15:02:58 2013 -0800

Story 1402: A/B test showing edit guider after user creates an account Also introduce M.isBetaGroupMember Change-Id: I996d2872a948d870eb6d0cd74b9c2c6e010e52aa

commit 112b1a4943a92c2735ccf10bb73f39d79e22d711 Author: kaldari <rkaldari@wikimedia.org> Date:  Fri Dec 6 14:37:10 2013 -0800

HYGIENE: Deprecating @baseFontSize We are reinventing the wheel here. The unit 1em means the browser's   base font size (as set in the preferences). So 2em is just a   multiplier on that. There is no reason for us to duplicate this logic by redeclaring our own baseFontSize that is also 1em and multiplying everything by that. In essence we are reimplementing the functionality of the em unit. And if we do actually want to change all of our font sizes, we   would adjust @fontScalingFactor anyway, not @baseFontSize. In converting our own multiplier to ems, I rounded to the nearest tenth in some cases, which should have negligible impact. The only exception to this is bodyLineHeight which I converted to a pure multiplier (which is better to use for a default line-height due to   inheritance), and rounded up instead of down since 1.3 is a rather cramped line-height and most of our text is set to much larger line-height values anyway (1.5 or 1.65) Change-Id: Ib9864ba6c951cf3a30bd45c8bbb5aa7d36ab8d4a

commit 6ed4daa298bd77e369d1396afc36f4f7663db527 Author: kaldari <rkaldari@wikimedia.org> Date:  Fri Dec 6 13:08:26 2013 -0800

HYGIENE: Removing FIXME that has been fixed. Change-Id: Id74a73df8f347f08e7986a9e31c8e35d399851c4

commit 0b969fa1d6fa813c708f8de231d9ba8c4705c85e Author: Rob Moen <rmoen@wikimedia.org> Date:  Wed Dec 4 09:55:57 2013 -0800

Add general errorHandling to VisualEditorOverlay Change-Id: I6635e5048145699907ca763eaa4d268d8175d971

commit 14cae75306c62eff8449366a18eae94573275cd4 Author: Rob Moen <rmoen@wikimedia.org> Date:  Thu Dec 5 17:35:41 2013 -0800

Prefetch wikitext on summary screen This reflects recent changes to the save method in the mw.target module Exchange html to wikitext from parsoid in the summary view, once fetched, the submit (or save) button becomes enabled. Change-Id: I81191b3e8895b0041ab08c6b1e15589ca5656e88

commit 819e673624489041ddffa4816535735b6e65804e Author: jrobson <jrobson@wikimedia.org> Date:  Thu Dec 5 15:19:09 2013 -0800

Regression: Fix file uploads The change introduced in Iadb4ee2b336e07ae2dfec7f09798ba210f409f6b prevents uploads from having format=json set. This rectifies that. Change-Id: I5ac0f7aa26f28841ad1a2c1a9cca07d0e5f8a2c0

commit 46c2e8b850c9d8412f52253ba61a0c4e8e7d7434 Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Thu Dec 5 21:17:49 2013 +0000

Localisation updates from https://translatewiki.net. Change-Id: I5efe0d8aabfdd6ebeb9962284e04571c4af7ebe4

commit 5e3774adea632ccb0e837aff89310d5d0216b9fb Author: jrobson <jrobson@wikimedia.org> Date:  Wed Nov 20 17:07:11 2013 -0800

VE editing on tablets in alpha Requires this patch, Visualeditor and Parsoid installed, and the following changes to be merged: Dependency: I786b63ab57518fc6af7761501259ed66592f70e3 Dependency: I708006fd6733cac89128bc76a1cd34c0d091c371 Change-Id: I09037c1ef289f8e871bc99372f2e2e810a250af4

commit 3d509562b855f597decd1719dc242fd2f0092caa Author: kaldari <rkaldari@wikimedia.org> Date:  Tue Dec 3 18:11:10 2013 -0800

Don't create empty user descriptions for User Profile If the initial description and new description are both empty, just switch the User Profile back to view mode instead of trying to save the user description page with no content. Bug: 57931 Change-Id: I54f51476833d400db3a4276f8db35870f18a898e