Thread:Extension talk:TemplateData/MediaWiki 1.22 or higher?/reply (3)

In part, yes, I was not using the correct definitions. Frankly, I should have looked at the source code to begin with.

However, I have now looked at the actual code (from download) that is available for MediaWiki 1.21 and 1.22. Both versions of the code downloaded claim to be TemplateData version 0.1.0. The download for MW 1.21 claims that it requires at a minimum MediaWiki version of 1.20. The download for MediaWiki 1.22 states that it requires MW 1.22wmf18.

However, there appears to be a significant issue. The code, not just translations, changed substantially between the version provided with MW 1.21 and that provided with MW 1.22, but the version number of the TemplateData code was not changed.

The version downloadable for MW 1.21 contains: 364 lines of code 153 lines specifying the TemplateData JSON 44 lines of language localization 0 lines of tests

The version downloadable for MW 1.22 contains: 918 lines of code 108 lines specifying the TemplateData JSON 1009 lines of language localization 621 lines of tests

Discounting the changes to the TemplateData JSON spec, the translations, and existence of tests, that is more than 2.5 times as many lines of code in the version released with MW 1.22 as that released with MW 1.21, yet the TemplateData version number on both is 0.1.0. Admittedly, some of those changes are just re-formatting. But there are real, substantial changes in there.

I'm new to even looking at MediaWiki code, but there is no situation that I have seen where this much change in the actual code (discounting translations and tests) does not justify at least some change in the version level of the code. There is a lot of functionality in there now that was not in there in the code released with MW 1.21. In most situations I have seen if the code changes after a release, the version number is changed, even if it is a very minor change in the code. What I have normally seen is: the code is different from what was released in any way → it gets a new version number. Adding tests, and translations doesn't necessarily require a change in version number, but these are some significant functional changes.

Just to check, I have also glanced at the latest development version. The current master version: 1077 lines of code 120 lines specifying the TemplateData JSON 2032 lines of language localization 829 lines of tests The TemplateData version number is still 0.1.0

Given that all of them claim to be version 0.1.0, and the earliest claims compatibility with MW 1.20, I have changed the infobox back to 1.20, which is where it was prior to any recent changes. It should be noted that the date on the "current version" is also inaccurate. The date on the code provided for MW 1.21 is 2013-03-15. The date on the code for MW 1.22 is 2013-10-22. Given that the TemplateData revision number is the same for all of the versions, I am not going to change the date in the infobox from its current value of 2013-05-16. This is more me saying that the issue needs to be addressed by someone closer to the development than anything else.