Extension:MobileFrontend/Deployments/2013-01-29

Stories
* https://mingle.corp.wikimedia.org/projects/mobile/cards/307 * Watchlist Empty Message

Bugs
* https://bugzilla.wikimedia.org/show_bug.cgi?id=43909 * https interferes with clicking watchlist icon when logged out and then automatically watching the article when redirected back

* https://bugzilla.wikimedia.org/show_bug.cgi?id=43878 * Curse of the lead section toggles

* https://bugzilla.wikimedia.org/show_bug.cgi?id=44089 * No special page styling on aliased special pages

Uncategorized
* Localization Changes * Readd onUserLoginComplete hook handler so that an anon's watchlist * jshint changes * upload postion/logo (beta) * update upload page (beta)

Git Log
commit 6e4a833fa426223e3e59c6459c730030b957941e Author: Translation updater bot  Date:  Sun Jan 27 18:53:50 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: Ia17ecc0a3f3a5f1796c4d2e6c2c1b4489e359a1c

commit 1f5717d489ef30d9ce9d84a55c93d5181ad0bf56 Author: Translation updater bot  Date:  Sun Jan 27 17:48:34 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I639acfd7a82865a5b575bf379fc8f6a80747d701

commit cd733aadb9e85f88cc2d71c2204c83039376e921 Author: Translation updater bot  Date:  Sat Jan 26 20:13:48 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: Id59678bf1764c7053571b38f214da2458fae52f6

commit 2860e198b339bfaf03278d7f1eb7605b84d440d4 Author: awjrichards  Date:  Fri Jan 25 17:35:27 2013 -0700

Readd onUserLoginComplete hook handler This seems to have been eaten by a bad merge earlier. Without this, there is no handling of an anon's watchlist tap post-login or acct creation. Change-Id: I48377b5400f83ebd866ef0306621c8f36e62457b

commit a6bb6711b1b6b410cd5f4cc9342229dfdb5654fa Author: awjrichards  Date:  Fri Jan 25 16:41:40 2013 -0700

Standardize hook handler names (Replaces Change: I592a2514bb51157f2ba5b3d0c601f3ec58d8d884) Change-Id: Ie4fa8d244dd420f8d791cfe08a2b84304924afc3

commit 3853dbfce1fca32cc9287059a7e4336a2a5a0c21 Author: jrobson  Date:  Fri Jan 25 13:31:06 2013 -0800

only show nearby link in menu if on (minor) Change-Id: If2cbdd5b36bfb35799ee26ff23ae46020638cba8

commit 2f4d7f67a9cb416fba201614e2c37d22a29a641f Author: Max Semenik  Date:  Sat Jan 26 03:02:33 2013 +0400

I think I already fixed that... Change-Id: I9c258c956001542a187e9864574f9e67ed1a464e

commit 6751d99a48c7c8fc3cf50c5bcadf023cdc7650ab Author: awjrichards  Date:  Wed Jan 23 16:43:21 2013 -0700

(bug 43909) (mingle 377) Add watch article hidden field in account creation form If a user has come to the account creation form after tapping the watchlist star on an article as an anon, this will ensure that the article is watched upon successful account creation and login. Change-Id: I33ed5fea7e92eb6b89340de10a9464758289b259

commit 184769f0599d96704c38ab0dc10b5dd77a2f7daf Author: awjrichards  Date:  Fri Jan 25 14:38:47 2013 -0700

Refactor hook handlers from MobileFrontend.body.php to MobileFrontend.hooks.php This is intended to improve general code organization for improved readability, codeability, etc. Also turns all hooks into static methods. There are still two legacy hook handlers in MobileFrontend.body.php that should be migrated to   MobileFrontend.hooks.php after the following are merged: Change: I33ed5fea Change: Ie01bc7f7 Change: I5c1a1c1f Change-Id: I97099fb6232b542edbd853c460c864969602cff0

commit 49c2284c4ae95d643cb0e762e336642b8bd192a6 Author: awjrichards  Date:  Wed Jan 23 16:42:30 2013 -0700

(bug 43909) (mingle 377) Move watchlist data prep for login form to private method This is in preparation for being used for account creation as well as login. Change-Id: Ie01bc7f7ff97cb67d7c7e5e0991e0c7a8aafe7d3

commit e75f11af74fc044e8ecf43608adcc9263a246c0c Author: Translation updater bot  Date:  Fri Jan 25 20:39:18 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I026afaee2d6407429ded1209a2e4c0648a9031eb

commit 4c6a25fd145c45991af71682eebea7a9713b44e8 Author: jrobson  Date:  Tue Jan 22 12:23:11 2013 -0800

DonateImage code cleanup (minor) use msg instead of wfMessage use Message as argument of setTitle take away method exists check for header access skin inside getHeader Change-Id: I1a001550319aca4ec94fcf977acc8361e7b3d704

commit de3c579e09ea51b1a012818a5ff89f694aaef844 Author: jrobson  Date:  Tue Jan 22 13:40:54 2013 -0800

add method to allow adding classes to #content_wrapper useful for cancelling default margins Change-Id: I959094cf98019f202d4aa944a15500fff7ab9383

commit 9f8ee0cdb5756c6c5fc1c4bc198a9323394f31fa Author: awjrichards  Date:  Wed Jan 23 16:23:46 2013 -0700

(bug 43909) (mingle 377) Invoke UserLoginComplete hook to watch an article after login If a non-logged in user requested to watch an article, and then tapped 'login' from the resulting drawer, then logged in, this will cause the article to actually be watched immediately after successful login, by processing the watch request when the UserLoginComplete hook runs. Change-Id: I5c1a1c1fb9cf0e3ee3cb754b593d50368bbe4784

commit e645f05ff1761440cf30abd191df206dd51bf191 Author: jrobson  Date:  Tue Jan 22 11:05:51 2013 -0800

change upload position/logo in menu (beta) Given I am a mobile Beta user I see a menu item ‚ÄúUploads‚Äù which links to the existing Special:DonateImage page. positioned under home and watchlist (also promote to beta) Change-Id: I9f4533b6a0e9056730eca2f0ce271c594ca0f235

commit a25cfdc5f2a93c1b6b121116205d87cc6ccf8965 Author: jrobson  Date:  Thu Jan 24 17:03:27 2013 -0800

fix jshint error (minor) listen to jshint my bad that this got through code review Change-Id: I0e1264206b11850f30ae545c10995e1a9ad21e3f

commit 1d1bc9bb0a73fa4d1a13af837abdfc6972b8abc5 Author: jrobson <jrobson@wikimedia.org> Date:  Wed Jan 23 15:25:54 2013 -0800

add getHtmlHeader and setHtmlHeader methods using a property on the output is very hacky update watchlist header to use it correctly Change-Id: I6ffdb639c18f02bb35311006dbb28a4e6889331e

commit d39c71634a7d01d6d00875857ef8a066e7d13ef1 Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Wed Jan 23 13:03:52 2013 -0800

Add api module + tests Also fix getToken cache and add Sinon.JS to our test suite for easy spies, mocks and stubs. Change-Id: I9d9b3c996cb8ab7a9638a130d654802cb7482116

commit fee66dca169753c6e69783d48f54bfe198b94b4f Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Tue Jan 22 17:01:45 2013 -0800

Add M.define and M.require + tests This should make sharing code between different JS files easier and more consistent. Names taken from CommonJS AMD specs. Deprecate M.registerModule and M.getModule. Change-Id: I0d9ff1dc6af9028f76424269c9460feddc0051ac

commit 53417aef26eef4ea2cd6ac53ec4573c118951967 Author: jrobson <jrobson@wikimedia.org> Date:  Thu Jan 24 14:07:51 2013 -0800

stop dynamically loaded lead sections from being toggleable sections (bug 43878) regression due to no use of templates. remove class Change-Id: I34c8d2eec6e84d583250b334ae7aa90a68f02e14

commit 915531fc3b619f40e0546520af9435362f61d8d3 Author: jrobson <jrobson@wikimedia.org> Date:  Tue Jan 22 12:23:11 2013 -0800

Update upload page (beta) * Add menu button in header chrome * Make h1's have no margin and add margin to #content_wrapper .content instead * simplify upload page html (div-itis) * show message for anonymous users * move upload button to top of page * center images in generated list * remove border on images * increase thumbnail size to 320 and make constant * change overlay heading color * style the call to action at top of the upload dashboard to be fixed to   the top chrome bar * special page specific: ** only serve js in mf-user-gallery to Special:DonateImage ** add stylesheet for donate page and remove list style on items ** when a list is empty explain why a user should start uploading Depends on: https://gerrit.wikimedia.org/r/#/c/45489/ Change-Id: Iddaa736592c4e88d4be18af6a2787f0a12c8fb14

commit 69f718a9b06920c6104ce2ae2526d923a248e305 Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Thu Jan 24 20:59:39 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I824cd7925ab81b7a9f5ef36933bccdd3af350d8e

commit e6a9b841fa2fe634b5321634d04daf431a3e839e Author: jrobson <jrobson@wikimedia.org> Date:  Thu Jan 24 12:11:11 2013 -0800

package mf-photo.js messages with mf-photo.js   a bad merge seems to have occurred! Change-Id: Ia2bfead92be5952413cb7f4b3e240537c07df9ce

commit 849f018c1897c485c03302f52b8c2e67e7f910b9 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date:  Thu Jan 24 12:35:05 2013 +0100

Updated Ruby gems childprocess and page-object. Change-Id: I620b75bfb6b0bad5c212196c062b2ee7f969fc99

commit 12c6bd31a7a5168e6f4e9a0515e694843532491e Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Wed Jan 23 23:30:08 2013 +0400

Reduce memcached usage by not caching small pages Change-Id: Ia127fbe4a46c59f37b7b29459a1ae4608e61b222

commit 67549d92c790f7c88d8d591ab1507c563ea566af Author: raymond <raimond.spekking@gmail.com> Date:  Thu Jan 24 08:35:43 2013 +0100

Fix typo from Iabe54543 Change-Id: I5f4e2548c78eb6d81d5e7c674e573b88917fe82c

commit ce2fc18760d8a7830d5498f0a87baa6cc569d741 Author: jrobson <jrobson@wikimedia.org> Date:  Wed Jan 23 17:27:39 2013 -0800

make generic .loading class this keeps popping up and it would be nice to have a sensible default Change-Id: I521ab86bc712cab38dbfb91bae2cbac44343165e

commit 7cb054ef25c0e8410ac0800ae843bd523d85ff32 Author: awjrichards <arichards@wikimedia.org> Date:  Wed Jan 23 15:46:29 2013 -0700

(bug 43909) (mingle 377) Include article to watch information in login form If a user is coming to the login form from tapping the 'add to   watchlist' icon on an article, this will include the article to    be watched in a hidden field in the login form. This will later be used to actually watch that specific article after login is   complete. Change-Id: I8b7263557761610ffd87f8793d01775b5c85610b

commit efb004d9baa6b324fc6c0cd84d0fe2521c4e86a2 Author: awjrichards <arichards@wikimedia.org> Date:  Wed Jan 23 14:52:08 2013 -0700

(bug 43909) (mingle 377) Remove local storage component of non-logged in watchlist star tap Change-Id: Ic1e9e8521240aeb0188ba5e650957fcd0befab24

commit 0c7755307124cd03bc11ad51bc04ac1850f1e949 Author: jrobson <jrobson@wikimedia.org> Date:  Tue Jan 22 13:18:02 2013 -0800

make alert styling available outside overlays Change-Id: Ib31356ee33c6019341be9f554240f30a481168a8

commit f65f1ada69d7dc7be7c03540f60011ff7d9c87da Author: jrobson <jrobson@wikimedia.org> Date:  Wed Jan 23 15:09:14 2013 -0800

disable footer on special pages Change-Id: I5047ea950ab34ef2b1a7b2eca832cbb2dcbf8ad7

commit cc4b73b1131272afd74bcc7002ee9ec38255c36c Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Wed Jan 23 22:13:59 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I5b809ba9a0c14d588c8993a57194c23773110b5b

commit cb0a933fff6e0fe2320dd706f294b0d332af6ac3 Author: jrobson <jrobson@wikimedia.org> Date:  Wed Jan 23 13:43:41 2013 -0800

allow special pages to register messages Starting with Special:Nearby Change-Id: Ic135994974398a18e020af4165864206c9daa007

commit 7259f3e8b411603e86e1f3ec0eb8abeebf64b8f8 Author: jrobson <jrobson@wikimedia.org> Date:  Mon Jan 7 09:19:20 2013 +0100

on new pages add a textarea currently replaces textarea with input which is not useful Change-Id: I5b7358bae98630aa2d4a246be8d7e05eb7267f11

commit 0435a6c99f30f6d80adadb78dc7e1dd290b7b9c9 Author: jrobson <jrobson@wikimedia.org> Date:  Fri Jan 11 14:50:26 2013 -0800

Add nearby page to mobile site [alpha] Only works when $wgMFNearby is enabled This lists up to 100 articles within 1km of the users current location Changes: Allow reuse of suggestions-results and suggestions-result classes outside the search module Change-Id: Iabe54543d457bb47280449b0185c0f1b1209c38c

commit 8c147d9cc47b38a10e51264dbe4d74454a3c6dbd Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Wed Jan 23 22:57:52 2013 +0400

Minor improvements * Remove second parameter to ExtMobileFrontend::DOMParse, it     always receives the same value * Doxygen tweaks * Rm selector in a format not understood by HtmlFormatter Change-Id: I74e3faf720031874ff0ca1688afcd3cc20645a13

commit 933dc54edb02ebbede37421969905723f6828476 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date:  Wed Jan 23 15:42:57 2013 +0100

Make it easy to run tests using PhantomJS If BROWSER_LABEL environment variable is not set, tests will run using Firefox. If it is set, the tests will run using the browser provided in   the variable. Example for PhantomJS: $ export BROWSER_LABEL=phantomjs Change-Id: Idbab16f03c297899e34fda0724cf3099087c9e80

commit 930c722a6f645ef30476a35d2ad763e965b1b5bb Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date:  Wed Jan 23 00:42:55 2013 +0100

Fixed failing iOS tests Looks like iOS does not really understand #send_keys. Instead of   sending :enter or :return, it prints funny icons. Shoe for :enter and t-shirt for :return. Summiting the form instead of sending :enter key. It does the same thing and does not confuse iOS. For a screenshot of a t-shirt icon instead of :return see the bottom of   this page: https://saucelabs.com/tests/9cfbf395848a47808cb14ee692bdeb82 The test now checks page URL to make sure San Francisco Chronicle page really opens. Change-Id: Ifadd4ccc9724d917ee56634011d8de54bd261c87

commit 978d99a8ed17eeb4db155fdf89a7a81c1a18f518 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date:  Tue Jan 22 23:41:27 2013 +0100

Renamed "and" steps to appropriate given/when/then steps Deleted some whitespace too. Change-Id: I4f21c25ab6653519431b89859b6f16a87f77fb71

commit 09512cfc553cbd93e275d43325d40bd04eb7a19a Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date:  Tue Jan 22 23:30:27 2013 +0100

Removed duplicate code "When I search for the same article and select the watchlist icon   again" step has the same code as   "When I search for an article and select the watchlist icon" step Change-Id: I236871128bf99d2e721134074ec6030c28e3ff99

commit e72ad696cf0429fcf3656ac9eb59b5f96a2d0c5b Author: awjrichards <arichards@wikimedia.org> Date:  Tue Jan 22 15:19:33 2013 -0700

Removes unneeded MobileContext::checkUserLoggedIn This appears to have been introduced a bagillion years ago (like   back in the days of SVN) and was related to ancient attempts to    implement mobile login. It is currently not used for anything, so it and its invocation have been removed. Change-Id: Ifd31b202ad08faba69399182f39bc0931e55efa9

commit c88028ae7b33d64e0c8e1a3779a727bac7cbd0f8 Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Tue Jan 22 13:39:56 2013 -0800

Fix JS error on pages with no alternative languages Change-Id: Iec793a504daecea201856a9fef820488cf706f82

commit 589ec0479e6d808bc71127388d97f2933c9f594e Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Tue Jan 22 20:50:14 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I3a1cb85ea2c2ffc1945023d02f0707b1904934f6

commit dbd77851bb188f60e3c7838c3ed3f05e24a2eb81 Author: awjrichards <arichards@wikimedia.org> Date:  Tue Jan 22 13:46:19 2013 -0700

Fix fatal call to unknown function MobileContext::isLocalTarget Follow-up to Change-id: Ic3fcceb90fbc0814895adb7cd4c5bc572e01f927, forgot to update method name in invocation. Change-Id: Ie7356b726b04c971826c4a782ae9cccdfc6dfd7e

commit b6824e12f4f0297038f909639a8564c758e264b8 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date:  Tue Jan 22 21:15:30 2013 +0100

PhantomJS needs some time for search resutls to appear Change-Id: I9e02707d8bda734d52a6f4b3a8e57668665b925a

commit 860e731f94c169d22a3e48269dd61c2cadb6dc15 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date:  Tue Jan 22 21:07:17 2013 +0100

Removed line that does nothing page.search_box_element always returns Watir::TextField, RSpec matcher considers that a "true value", and always passes. If a check is required here, then it should be: page.search_box_element.should exist Change-Id: I77dfb1bdf0e19c1767aa5506b982db4793dbf0e2

commit e204f38f433738d71d37f494952136f25a6a401a Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Fri Jan 4 20:04:58 2013 +0400

Bug 43123: force mobile URLs only for local redirects Change-Id: Ic3fcceb90fbc0814895adb7cd4c5bc572e01f927

commit e80757985c8fcfa11ea8f4e68493242e3bdd08a9 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date:  Tue Jan 22 15:36:10 2013 +0100

Make Cucumber progress formatter the default one HTML and XML reports are more useful at Jenkins machine and progress formatter is more useful when running tests locally. Change-Id: I3316bc1f0122ec26c972638a5999768a1e547da0

commit f845c936d66f36e16126f898f75c5a3658530ac9 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date:  Tue Jan 22 15:06:43 2013 +0100

Upgrade Firefox to version 18 Change-Id: I3ecbd2c087f451e2e308ba1a793e906bdbbea4fa

commit bf89601cba19085c7f2b687d9151384b9a8dd900 Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Mon Jan 21 20:49:14 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: If3b6f9de5be54f35974428b2e82de1f6bb30c4da

commit 27df025dd7ece9022b0559059d556cd7a2189ed5 Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date:  Mon Jan 21 20:39:40 2013 +0100

Updated Ruby gems Change-Id: Iabb7907e4c7898cabce50cc5b76121e5e39cf041

commit 8bc6ea6184ecaa69ff2963528abb5a01feea747d Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date:  Mon Jan 21 20:34:34 2013 +0100

Upgrade Ruby to 1.9.3-p374 Change-Id: I517e3fa5ec5ab775428470784eb96d586368a6d0

commit 02f185a4985b14800863183b0d2ae42c568f17ca Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Sun Jan 20 19:44:18 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: I5d7245ce4ef643a686e70a76e680945b61271f9f

commit 5fe2526b13d472bd0270a8cd8c07ddcb0075ddb1 Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Sat Jan 19 16:11:50 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: Ic627340df70774eb48031a50e65e095d7e624763

commit 1fbff37957196d496ae5b9a21ae05d153e3210ae Author: jrobson <jrobson@wikimedia.org> Date:  Fri Jan 4 15:01:13 2013 +0100

update empty message (307) style like the attached screenshot take into account language directionality Change-Id: I8a177a43c070a104db2ede82cca4cb4fce6d8019

commit b592fc5d751062a64d2fc3fc45e3a23aeba2ffef Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Wed Jan 16 21:44:56 2013 +0400

Lots of minor fixes Unused variables, type annotations, proper function call signatures Change-Id: Iae6f653faf38c9ee851d3b066412114c127e77f2

commit d080d8a4d3c0a1122e107c9ae042a2eae2c32e07 Author: Juliusz Gonera <jgonera@wikimedia.org> Date:  Fri Jan 18 12:03:19 2013 -0800

(bug 44089) Fix js/css for non-English special pages Change-Id: I8df8c8a257fd1b72b89ddd3ee75eed01d921880c

commit b00aa2520cd3f9939868cbb53979e3ee9c24bf6b Author: Zeljko Filipin <zeljko.filipin@gmail.com> Date:  Tue Jan 8 14:02:20 2013 +0100

Commited files that got lost in patch set 2 of Gerrit commit 42218 https://gerrit.wikimedia.org/r/#/c/42218/ Change-Id: Ic810217b2fa3ae835f346d2429eda77ae50f2fca

commit 6231a1c0e8c285876658464f5c43bb9393803d18 Author: Max Semenik <maxsem.wiki@gmail.com> Date:  Fri Jan 18 03:17:44 2013 +0400

Fix double-escaping Change-Id: If9b70194d5399ca807941b333be4f7a3a2820cc4

commit 66ba9c3c59cc8e70f398fcf81d3679cca1da4b00 Author: Translation updater bot <l10n-bot@translatewiki.net> Date:  Thu Jan 17 21:26:59 2013 +0000

Localisation updates from http://translatewiki.net. Change-Id: Ic30d1a9304c288858bb8fed0cd85753cc0caff17

commit 84457cf4dbae3d0a70353cab2b3064899502adce Author: jrobson <jrobson@wikimedia.org> Date:  Thu Jan 17 12:18:20 2013 -0800

fix diff view js error (regression) the diff page tries to load thumbnails and shouldn't   in process refactor watchlist.js to look like a module Change-Id: Iad1fce511343c16c5017f8ea134efd50a64d7bba

commit 78d91dc93e871f2c8031f66baba1dddce9d4171e Author: jrobson <jrobson@wikimedia.org> Date:  Thu Jan 17 11:34:13 2013 -0800

move reset.css to externals folder Make it clear this file comes from outside the project Change-Id: I7627a4f973b94a6e1d187af2e2656ec8c7ded4f9

commit cdf393d6639a276eb2546df8a0dc9233eb7e52fe Author: jrobson <jrobson@wikimedia.org> Date:  Tue Jan 8 16:54:45 2013 +0000

only close notifications with class locked via button this is important for calls to action which may contain links or   be clickable themselves - only clicking the close button will remove them added styling for toast notification button in this mode (previously   hidden at all times) Change-Id: I8433cc1cf7364ae63a9911d7352d72fa7927daa0

commit a1b3e9ce85d555f05f3b117a6c4ccd959115299b Author: Siebrand Mazeland <s.mazeland@xs4all.nl> Date:  Sun Jan 27 16:56:31 2013 +0100

article -> topic Change-Id: I1efd98fe2f98640659f4c05f087e6ddae4dfb1ee