User talk:Simon Moon/AdSense Extension

From MediaWiki.org

[edit] Add it under the toolbox

how it could be added under the toolbox?

This is not really meant to be used in that location. You should add the code directly to the template in that case. --Simon Moon 00:08, 17 December 2007 (UTC)

[edit] cpachoice problem

Ive tested on two of my Wikis versions 1.11 and 1.93 and both give me problems with referrals:

ad_client = "pub-XXXXXXXXXXX";
ad_width = 180;
ad_height = 150;
ad_format = "180x150_as";
cpa_choice = "CAEQ69entQMaCFRaYALOCkMkKIOWpOYB";

error message is Google AdSense Extension: Fatal error, not enough parameters. array ( )

You have the _ character in the fields. You need to remove those. Like "ad_client" gets to be "adclient" and so on. MediaWiki does not like the _ character in variable names. --Simon Moon 00:08, 17 December 2007 (UTC)

[edit] Security alert

Although you are escaping ", any smart user can still insert random javascript. (I'm thinking about something like ;script=document.createElement(String.fromCharCode(..) + .. String.fromCharCode(..))) -- Bryan (talk|commons) 15:06, 7 November 2008 (UTC)