User talk:Matma Rex

From mediawiki.org
Latest comment: 1 month ago by Diskdance in topic OOjs classes' compatibility with ES6 classes

Witamy na MediaWiki.org!

Witamy! To jest witryna poświęcona dokumentacji oprogramowania MediaWiki, które wspiera wiele stron typu wiki, włączając Wikipedię oraz inne projekty Fundacji Wikimedia.
Prosimy przejrzeć poniższe strony, które mogą być przydatne dla nowicjuszy:

Jeżeli masz jakieś pytania, zadaj je na mojej stronie dyskusji. Mamy nadzieję, że znajdziesz tu wszystkie odpowiedzi na Twoje pytania dotyczące oprogramowania MediaWiki.

Pozdrawiam.--wargo (talk) 18:22, 2 August 2012 (UTC)Reply

Numero dos[edit]

In that mockup, I forgot to unbold the usernames and resplicing it together is annoying. Did it matter? -— Isarra 04:01, 28 March 2013 (UTC)Reply

jsbeautifier[edit]

Hi!

Just in case you did this prettification by hand: there is http://jsbeautifier.org. Helder.wiki 21:01, 8 April 2014 (UTC)

Join the GSoC & OPW IRC meeting[edit]

Hi! The community bonding period is over, and you should have started working on your project. In addition to the strict work, you are required to report frequently, see the details at the GSoC or OPW pages.

The Engineering Community team is organizing a Q&A session for all participants (mentors included) tomorrow Tuesday at #wikimedia-office connect, see Engineering Community Team/Meetings/2014-05-20. See you there!--Qgil (talk) 21:57, 19 May 2014 (UTC)Reply

Question on $wgResourceModuleSkinStyles[edit]

Hi Matma Rex!

I am trying to use $wgResourceModuleSkinStyles, but it does not work as the docs made me think it would.

What is expected to happen when I define a stylesheet through this variable and add some styles in it? E.g. I define

$GLOBALS['wgResourceModuleSkinStyles']['myskin'] = array(
	'mediawiki.ui.input' => 'skinStyles/mediawiki.ui.input.less',
	'remoteSkinPath' => 'MySkin',
	'localBasePath' => __DIR__,
);

skinStyles/mediawiki.ui.input.less only contains the things I want to change:

@import "../variables";

/* mediawiki.ui.input */

/* Overwrite default styles of the mediawiki.ui.input module */
/* Forms: Adjust styling of input boxes, e.g. on [[Special:Search]] */

.mw-ui-input {
	&:focus {
		border-color: #f8f8f8;
		box-shadow: #f8f8f8 0 0 5px ;
	}
}

When I now visit the Special:Search page, the input field also does have these styles applied. But only those. All the other styles (which MediaWiki defines in its resources/src/mediawiki.ui/components/input.less file) are no longer applied. It seems like the complete(!) content of that stylesheet is no longer used. But I do not want to redefine all rules. Instead, I only want to change the few mentioned above.

What is the fix for this? Is this the intended behaviour or am I doing something wrong?

Cheers! --88.130.95.110 01:24, 11 December 2014 (UTC)Reply

Yes, this is the expected behavior - mediawiki.ui.input module is built to allow such overriding. To add to the existing styles instead of replacing them, use:
$GLOBALS['wgResourceModuleSkinStyles']['+myskin'] = array(
Note the "+" character. The doc page mentions it, but briefly - how could this be rephrased better? Matma Rex (talk) 09:23, 11 December 2014 (UTC)Reply
Hi!
Yes, I saw this, but I did not understand it. Thinking about it, I do not want to add something to the module myskin (instead of overwriting stuff in this module), but I want to add to the module mediawiki.ui. Shouldn't I then do something like this:
$GLOBALS['wgResourceModuleSkinStyles']['myskin'] = array(
	// Adding (instead of overwriting) to the file of the mediawiki.ui module
	'+mediawiki.ui.input' => 'skinStyles/mediawiki.ui.input.less',
Or would that be wrong in my situation? (Technically it's working as well...) --88.130.95.110 20:57, 11 December 2014 (UTC)Reply
Hmm, this might actually be correct, and what I quoted earlier might be wrong. Matma Rex (talk) 19:07, 13 December 2014 (UTC)Reply
Thank you, I corrected the documentation here [1] and in the source code [2]. Not sure how could I have gotten this wrong about code I've written myself :) Matma Rex (talk) 19:21, 13 December 2014 (UTC)Reply
Things happen ;-) I have added to the manual page; at least for me it's clear now, how this is supposed to work. :-) Nice Sunday! --88.130.127.99 14:58, 14 December 2014 (UTC)Reply

A barnstar for you![edit]

The Technical Barnstar
Thank you for helping me with git review! Unicodesnowman (talk) 14:57, 21 December 2014 (UTC)Reply

Random acts of CR barnstar[edit]

I hereby award you this random acts of code review barnstar for being among the few most active +2'ers that we know of! Nemo 23:34, 3 February 2015 (UTC)Reply

Page tools/toolbox/whatever[edit]

I went through the pile of tools/links that show up in the toolbox and across the top of the page in vector (+maybe a couple of others) and reorganised them in a way that makes sense logically to me. Any idea what could be done with this in order to actually use such a grouping in skins or whatever? -— Isarra 08:06, 29 May 2015 (UTC)Reply

@Isarra: Hmm, I guess we'd like to treat this as another way to structure the interface, in addition to Vector-like tabs (internally known as content_navigation) and MonoBook-like tabs (content_actions). SkinTemplate.php generates those two:
		$content_navigation = $this->buildContentNavigationUrls();
		$content_actions = $this->buildContentActionUrls( $content_navigation );
		$tpl->setRef( 'content_navigation', $content_navigation );
		$tpl->setRef( 'content_actions', $content_actions );
So I guess we'd need to add another method to build this structure, and another key for this to use it from skins. Matma Rex (talk) 15:23, 22 July 2015 (UTC)Reply

On enclose="div"[edit]

My mistake. It seems I am one MediaWiki version behind.

So how one would wrap lines now?

--Ioannis Protonotarios 15:39, 6 July 2015 (UTC)Reply

@Protnet: Starting with MediaWiki 1.26 (and corresponding version of SyntaxHighlight), preformatted text blocks should all be automatically wrapped. Matma Rex (talk) 15:08, 22 July 2015 (UTC)Reply
Good call! Thanks! --Ioannis Protonotarios 13:44, 23 July 2015 (UTC)Reply

On style="overflow: auto;"[edit]

Hi Matma Rex,

there does not seem to be a replacement for this in the current version of the "Syntaxhighlight GeShi" extension. Will this be a nice feature request?

Cheers --[[kgh]] (talk) 14:15, 16 September 2015 (UTC)Reply

@Kghbln: I don't understand. No replacement is necessary, as code snippets are now automatically wrapped. Matma Rex (talk) 22:04, 17 September 2015 (UTC)Reply
Indeed, the code does continue in the next line automatically. I was more looking for a way do avoid this. Probably a matter of preference since I think this was nicer in display (easier to grasp). I guess I will get used to it. Cheers --[[kgh]] (talk) 22:28, 17 September 2015 (UTC)Reply

Phab[edit]

Sorry for removing the tag, I was editing the page in the same moment and I am not very into phab yet. Could you please fix my edit? thanks! --Lucas (talk) 13:53, 12 May 2016 (UTC)Reply

All right, you did it already. Thanks. --Lucas (talk) 13:59, 12 May 2016 (UTC)Reply
@Lucas: No worries :) Unfortunately Phabricator doesn't do edit conflict detection, eh. Matma Rex (talk) 14:06, 12 May 2016 (UTC)Reply

A barnstar for you![edit]

The Half Barnstar
Thank you for this change, which I hope will significantly improve matters from the perspective of script maintainers. You solve problems with kindness, skill, and collegiality. Whatamidoing (WMF) (talk) 18:56, 30 May 2017 (UTC)Reply

Did you noticed my answer?[edit]

Hello Rex,

I answered you on T208981. Did you recognized it? Regards from --Der Keks (talk) 13:14, 16 December 2018 (UTC)Reply

Hey, I saw your reply, I didn't have time to think about it yet :) Matma Rex (talk) 21:01, 17 December 2018 (UTC)Reply
links Just a little thanks …
for working on the task.
kind greetings,
a Wikipedian
Needed to translate it from dewiki because mediawiki has no template :( --Der Keks (talk) 22:26, 10 January 2019 (UTC)Reply

Searching a project for Visual Diffview[edit]

Hello, I am searching for an project on phab for the visual diff view, (not the VE-Diff view). I have two problems with that beta function:

  1. Weblinks in continuous text are not displayed.
  2. References are marked as changed but they didn't (ref. 7)

Off topic: do you know if it's planned to implement Reference Previews into the visual diff view?

I ask you because I don't know someone who is more up to date on phab and i don't want to make duplicates :)

(Example edit and Screenshot)

Thank you very much! --Der Keks (talk) 16:04, 18 June 2019 (UTC)Reply

@Der Keks: The right project is #VisualEditor-VisualDiffs (the same code is used for visual diffs in the editor and for historical visual diffs). But it's perfectly fine to file a task with no projects if you can't find the right one, someone will usually add a project to it. And there's nothing wrong with duplicates either (sometimes it's even useful to know that many people encounter the same problem).
The thing with autonumbered links is definitely a bug. I don't see anything wrong with the reference though – can you explain?
As for Reference Previews in the visual diff, I have no idea. It might be tricky to do though, because the diff doesn't actually display most of the references (only those that were added/removed and the ones nearby).
Matma Rex (talk) 19:40, 19 June 2019 (UTC)Reply
Thanks for the answer, hmmm... Reference Preview (for that which are displayed) was nice :). If you look into the source-diff you'll see that the reference #7 was not changed. But in the visual view it's marked (green and red). --Der Keks (talk) 19:47, 19 June 2019 (UTC)Reply
@Der Keks: Hmm, well, it's a part of text that was deleted (and added elsewhere)? The text snippet is probably too short for move detection to kick in. Matma Rex (talk) 16:18, 20 June 2019 (UTC)Reply
Yeah I know but it implicates that the reference itself was changed. I can check in the visual diff view that the text was changed but I cannot control if the reference was changed. All what happened was a deleted line break... --Der Keks (talk) 17:15, 20 June 2019 (UTC)Reply

A barnstar for you![edit]

The Technical Barnstar
Thank you very much for the quick debug! -- Roy17 (talk) 08:01, 13 July 2019 (UTC)Reply

Central login[edit]

Hi, before I open a phabtask I wanna ask you what's the problem: I use webauthn as 2. factor. By using this I am limited to login on dewiki, where I set up the key. Usually central login should do the rest but I am not logged in on WikiData and MediaWiki. What can I do? --87.134.34.141 14:10, 19 February 2020 (UTC) (Keks)Reply

Sorry, I don't know. I'm not too familiar with our 2FA systems. Personally I use TOTP and with that, I can use the generated tokens to log into any Wikimedia site. Matma Rex (talk) 20:19, 19 February 2020 (UTC)Reply
I It worked mow! Weired... Yeah I reckon the wehautn-method is bound to the URL. My Browser doesn't accept the dewiki-key on different wikis. --Der Keks (talk) 21:31, 19 February 2020 (UTC)Reply

Patchdemo cleanup[edit]

Hi Bartosz!

Patchdemo is great tool, thank you for making it!
My old demos with the long patch lists are no longer necessary, feel free to delete those, I can't:

  • 35acdd13f1581b64f54b2006f343a27f -- 576109,3, 573035,5 -- heading-typography Vector, MonoBook
  • c7e2ca45d58d8e7f08b0cf51743a8776 -- 576170,4 -- [POC] Make sidebar scrolled, header sticky and more like those in Desktop Improvements Project
  • fb769a9f264acf24f53dcf7d73e8091f -- 576109,2, 573035,5 -- heading-typography Vector, MonoBook
  • 5882894f1c8c2a23e36b3d886745fcc4 -- 576109,2, 573035,5, 570639,17, 570074,19, 572456,6
  • 89f593bd99c77afa85484364621e983e -- 576105,2, 576106,2, 576107,2, 576108,2, 576109,2, 573035,5, 570639,17, 570074,19, 572456,6
  • 511bb2e48ca33cd0861efd6d7db93b61 -- 573035,5, 573052,3, 570639,16, 570074,19, 572456,6

You can confirm ownership from the first patch.

Aron Man.🍂 edits🌾 18:23, 16 March 2020 (UTC)Reply

@Aron Manning: There isn't really any reason to delete them, they don't take up much space. I don't want to manage everyone's demos manually. Maybe at some point I'll set up some automated thing to delete old unused demos. Matma Rex (talk) 21:25, 16 March 2020 (UTC)Reply
Ok. It's all good with the new demos that are assigned to the owner and can be deleted. —Aron Man.🍂 edits🌾 08:51, 17 March 2020 (UTC)Reply
Turns out Ed made a convenient interface for us to delete the old wikis, so I went ahead and did that now. Matma Rex (talk) 18:11, 17 March 2020 (UTC)Reply

Thank you[edit]

Thank you so much for reviewing my patches and explaining how Jenkins works! Nardog (talk) 04:25, 6 October 2020 (UTC)Reply

How we will see unregistered users[edit]

Hi!

You get this message because you are an admin on a Wikimedia wiki.

When someone edits a Wikimedia wiki without being logged in today, we show their IP address. As you may already know, we will not be able to do this in the future. This is a decision by the Wikimedia Foundation Legal department, because norms and regulations for privacy online have changed.

Instead of the IP we will show a masked identity. You as an admin will still be able to access the IP. There will also be a new user right for those who need to see the full IPs of unregistered users to fight vandalism, harassment and spam without being admins. Patrollers will also see part of the IP even without this user right. We are also working on better tools to help.

If you have not seen it before, you can read more on Meta. If you want to make sure you don’t miss technical changes on the Wikimedia wikis, you can subscribe to the weekly technical newsletter.

We have two suggested ways this identity could work. We would appreciate your feedback on which way you think would work best for you and your wiki, now and in the future. You can let us know on the talk page. You can write in your language. The suggestions were posted in October and we will decide after 17 January.

Thank you. /Johan (WMF)

18:17, 4 January 2022 (UTC)

proboje dac strony OOUI na FR , warto dalej ?[edit]

hej ! https://www.mediawiki.org/wiki/Topic:Xkktrmkeplpz95da Forestier mowi ze lepiej skasowac moje tlumaczenie - co robic ? -- Christian 🇫🇷 FR (talk) 20:07, 23 June 2023 (UTC)Reply

Ja nie mam nic przeciwko tłumaczeniu. Odpiszę w tamtej dyskusji. Matma Rex (talk) 20:36, 23 June 2023 (UTC)Reply
dzieki. Christian 🇫🇷 FR (talk) 05:19, 24 June 2023 (UTC)Reply

A barnstar for you![edit]

The Original Barnstar
Thank you so much for reviewing my patches! Nardog (talk) 09:02, 1 October 2023 (UTC)Reply

Gerritbot Phabricator userstyle[edit]

Hi! Would you be willing to edit the userstyle for Gerritbot (thanks for making it!) to give the same treatment to CodeReviewBot? Jon Harald Søby (talk) 15:57, 1 February 2024 (UTC)Reply

@Jon Harald Søby Sure, I gave it a try. Have a look. (The style is rather limited in what it can do to the content of comments, so CodeReviewBot and Gerritbot will look quite different.) Matma Rex (talk) 16:31, 2 February 2024 (UTC)Reply
This is perfect. Thank you very much! 😁 Jon Harald Søby (talk) 18:29, 2 February 2024 (UTC)Reply

OOjs classes' compatibility with ES6 classes[edit]

This is a follow up of phab:T336122#9556358 because this is kind of off-topic.

IMHO, I don't think OOjs classes are fully interoperable with ES6 classes. Here's an example:

class MyDialog extends OO.ui.ProcessDialog { } 
MyDialog.static.name = 'MyDialog'; 
console.log(OO.ui.ProcessDialog.static.name); // => Surprise: "MyDialog"

OO.inheritClass does more things than a class extends do, like setting up prototype chain of the static object and the super property. Consequently, migration to ES6 syntaxes is impossible without a breaking change. I believe the production code has similar problems unless there are some special workarounds. Diskdance (talk) 14:54, 22 February 2024 (UTC)Reply

Hmm, good point, that's not really "fully" compatible. I guess I should say that it can work if you're careful. If we don't get rid of .static, we should probably provide a another helper function like OO.inheritClass() / OO.initClass() to set it up in this scenario. Can you file a task? Matma Rex (talk) 16:33, 22 February 2024 (UTC)Reply
Filed phab:T358416. Diskdance (talk) 02:40, 24 February 2024 (UTC)Reply