Help
Add this page to your book
Show book (0 pages)
Suggest pagesUser:Aaron Schulz/code review
From MediaWiki.org
Code review (core and WMF extensions) (Revisions 36512-36861):
- Major (OK): [36631,36632,36637,36642,36728], 36668 (hard to avoid duplication), [36682,36727], [36758,36760]
- Major (check): 36648 (looks fine), [36664,36752], [36772 - 36844] catTree stuff
- Iffy: 36600 (by ref?), 36608 (???), 36692 (won't this block the same IP several times?, what is the use of $ignoreErrors?, $editor in getBaseRevision() looks bogus)
- Things to look at: 36730, [36796,36797], 36802, 36814
Note: 36685 reverted by committer, OK? (other changes pending anyway)
Still need to look more at CategoryTree stuff and look closer at RC changes. Prolly should go on testwp first.
