HT 0.9 + htEditTabLink = false results in the edit link still be present
We updated to HT 0.9 and tried to use $htEditTabLink = false; but somehow the [edit] link still appears within the HT. We tested HT on MW 1.17 and 1.18 and experienced the same behaviour.
I'm sure it'll be fixed soon, but you can get your version working by adding an if-test in HeaderTabs_body.jq.php. Around line 21, add
$htEditTabLink
to the global declaration list, and around line 224, Change
//! @todo handle __NOEDITTAB__ here (2011-12-12, ofb)
$tabhtml .= '<span class="editsection" id="edittab"> [<a href="" title="'.wfMsg('headertabs-edittab-hint').'">'.wfMsg('headertabs -edittab').'</a>]</span>';
to
//! @todo handle __NOEDITTAB__ here (2011-12-12, ofb)
if ( $htEditTabLink ) {
$tabhtml .= '<span class="editsection" id="edittab"> [<a href="" title="'.wfMsg('headertabs-edittab-hint').'">'.wfMsg('headertabs -edittab').'</a>]</span>';
}
Excellent, it works! Thx.
Thanks people, committed it to Special:Code/MediaWiki/107284
Notice that the patch above is missing adding the variable to the 'global' line. The above patch turns it always-off. If someone can verify that the SVN HEAD version works on their setup, then Yaron maybe we could do a 0.9.1 release?
