Error for /maintenance/updateStats.php - "Notice: Undefined variable: times" + Misc
Hi Aaron, thanks to you and everyone else who worked on this!
1. I have MW 1.18 with the latest version of Flagged revisions. The file to run for the cronjob, updateStats.php is giving an error. Here's what I ran on the Shell access command prompt, with the output:
php /home/USER/public_html/wiki/extensions/FlaggedRevs/maintenance/updateStats.php ValidationStatistics Notice: Undefined variable: times in /home/USER/public_html/wiki/extensions/FlaggedRevs/dataclasses/FlaggedRevsStats.php on line 359 completed in 0.06s
I had some other suggestions or questions:
2. To approve all current pages, I ran "reviewAllPages.php" for the two editors with the highest number of edits and that seemed to empty the "Unreviewed pages" list. Is that the right way to do this?
3. $wgFlaggedRevsLowProfile changes things for visitors. Could there be a variable that can make the visitor or anonymous IP (who is not a reviewer or editor) see nothing different at all from the stable page? That is, if that variable was set as true, they would not see the "eye" icon, or the "pending changes" tab for a page which has not been reviewed and approved yet.
4. When an IP tries to edit, it sees the warning text ('revreview-editnotice' in the i18n file) above the edit box when it tries to edit: "Your changes will be displayed to readers once an authorized user reviews them. (help)". However I noticed that a registered user who is not an editor or reviewer does not see this text. They are shown that notice only after they've made the edit. Is it possible to turn it on for them as well? That way, the pre-edit notice will be shown to everyone whose changes will need to be reviewed.
5. When an IP or a user who is not an editor or reviewer creates a page, that page shows a small "unchecked" box on the right of the page when it is viewed by visitors. Is it possible to have options for:
- Dont show an unreviewed page to visitors and only show them a warning like "this new page is not visible because it has not been reviewed by an authorized user". Is that the solution? -> Extension:FlaggedRevs/Restricting unapproved revisions. I'm afraid that these changes would effect speed or do something else. I hope a build-in option ($wgShowStableVersionOnly) can made where if there's no stable version of a page, the contents are not showed to visitors, and only editors and reviewers would see it. This method can then be applied equally for new and existing pages.
6. For the situation in #5, $wgFlaggedRevsLowProfile should also work for new pages that have not been reviewed yet, like the way it works for unreviewed edits to existing pages. This way visitors will either see small notices (eye icon, "unchecked" box) or a more visible message with a blue background with the complete text "this new page has not been reviewed yet by an authorized user"
I have some coding experience in extensions and can help if needed to do some of the above. thanks.
2. That works. 3. That doesn't seem like a good GUI design, what about pages with pending changes? 4. I'll look into this...it was probably done to reduce clutter or something. 5. You'll have to use the code on that mw.org subpage if you want this kind of functionality I'm afraid. 6. Similiar to (3), though more reasonable. I'll look into that too.
