pywikipedia r8245 - Code Review

Jump to: navigation, search
Repository:pywikipedia
Revision:< r8244‎ | r8245 (on ViewVC)‎ | r8246 >
Date:09:19, 4 June 2010
Author:xqt
Status:old
Tags:
Comment:
enable <references></references>; +fix for old bug introduced in r7544
Modified paths:

Diff [purge]

Index: trunk/pywikipedia/noreferences.py
——@@ -354,6 +354,7 @@
355355 self.site = wikipedia.getSite()
356356 self.refR = re.compile('</ref>', re.IGNORECASE)
357357 self.referencesR = re.compile('<references.*?/>', re.IGNORECASE)
 358+ self.referencesTagR = re.compile('<references>.*?</references>', re.IGNORECASE|re.DOTALL)
358359 try:
359360 self.referencesTemplates = referencesTemplates[wikipedia.getSite().family.name][wikipedia.getSite().lang]
360361 except KeyError:
——@@ -368,7 +369,8 @@
369370 Checks whether or not the page is lacking a references tag.
370371 """
371372 oldTextCleaned = wikipedia.removeDisabledParts(text)
372 - if self.referencesR.search(oldTextCleaned):
 373+ if self.referencesR.search(oldTextCleaned) or \
 374+ self.referencesTagR.search(oldTextCleaned):
373375 if verbose:
374376 wikipedia.output(u'No changes necessary: references tag found.')
375377 return False
——@@ -378,7 +380,7 @@
379381 if verbose:
380382 wikipedia.output(u'No changes necessary: references template found.')
381383 return False
382 - elif not self.refR.search(oldTextCleaned):
 384+ if not self.refR.search(oldTextCleaned):
383385 if verbose:
384386 wikipedia.output(u'No changes necessary: no ref tags found.')
385387 return False

Past revisions this follows-up on

Rev.Commit summaryAuthorDate
r7544check <references /> first, prepairing test for ref-tags in templatesxqt09:36, 26 October 2009

Status & tagging log

  • 12:09, 22 June 2012 Xqt (talk | contribs) changed the status of r8245 [removed: new added: old]
Retrieved from "http://www.mediawiki.org/wiki/Special:Code/pywikipedia/8245"