pywikipedia r7544 - Code Review

Jump to: navigation, search
Repository:pywikipedia
Revision:< r7543‎ | r7544 (on ViewVC)‎ | r7545 >
Date:09:36, 26 October 2009
Author:xqt
Status:old
Tags:
Comment:
check <references /> first, prepairing test for ref-tags in templates
Modified paths:

Diff [purge]

Index: trunk/pywikipedia/noreferences.py
——@@ -329,21 +329,21 @@
330330 Checks whether or not the page is lacking a references tag.
331331 """
332332 oldTextCleaned = wikipedia.removeDisabledParts(text)
333 - if not self.refR.search(oldTextCleaned):
 333+ if self.referencesR.search(oldTextCleaned):
334334 if verbose:
335 - wikipedia.output(u'No changes necessary: no ref tags found.')
 335+ wikipedia.output(u'No changes necessary: references tag found.')
336336 return False
337 - elif self.referencesR.search(oldTextCleaned):
 337+ elif self.referencesTemplates:
 338+ templateR = u'{{(' + u'|'.join(self.referencesTemplates) + ')'
 339+ if re.search(templateR, oldTextCleaned, re.IGNORECASE):
 340+ if verbose:
 341+ wikipedia.output(u'No changes necessary: references template found.')
 342+ return False
 343+ elif not self.refR.search(oldTextCleaned):
338344 if verbose:
339 - wikipedia.output(u'No changes necessary: references tag found.')
 345+ wikipedia.output(u'No changes necessary: no ref tags found.')
340346 return False
341347 else:
342 - if self.referencesTemplates:
343 - templateR = u'{{(' + u'|'.join(self.referencesTemplates) + ')'
344 - if re.search(templateR, oldTextCleaned, re.IGNORECASE):
345 - if verbose:
346 - wikipedia.output(u'No changes necessary: references template found.')
347 - return False
348348 if verbose:
349349 wikipedia.output(u'Found ref without references.')
350350 return True

Follow-up revisions

Rev.Commit summaryAuthorDate
r8245enable <references></references>; +fix for old bug introduced in r7544xqt09:19, 4 June 2010

Status & tagging log

  • 14:40, 12 September 2011 Meno25 (talk | contribs) changed the status of r7544 [removed: resolved added: old]
  • 12:27, 25 August 2010 Xqt (talk | contribs) changed the status of r7544 [removed: new added: resolved]
Retrieved from "http://www.mediawiki.org/wiki/Special:Code/pywikipedia/7544"