Code Review

Jump to: navigation, search
Search revisions in this repo by path
    
First page
First page		 Previous page
Previous page		 Last page
Last page
Show items per page
 Total number of results: 514
Date Commenter Rev. Status Commit summary Note
21:46, 24 May 2012 Khorn (WMF) 1765 ok Adding a sed fix for trailing whitespaces. Added ignore flow handling. See r1... This will work until we remove sed completely.
21:04, 24 May 2012 Jpostlethwaite 1766 ok Adding utm fields to csv. See r1765. The script is fixed in r1769 and in the Gerrit patch for DonationInterface:...
20:32, 24 May 2012 Jpostlethwaite 1766 ok Adding utm fields to csv. See r1765. This is not complete....
20:14, 23 May 2012 Khorn (WMF) 1762 new Setting a dynamically generated variable to prevent notices. See r1761. Where is this used?
18:40, 23 May 2012 Jpostlethwaite 1764 ok Updated error handling. See r1763. This is not really error handling....
18:29, 23 May 2012 Jpostlethwaite 1763 ok Updated parser to handle new log format. Added $customFilterScores handling. I am going to update how the default variables are set on this.
23:02, 17 May 2012 Jpostlethwaite 1758 ok (mingle-fr-2012-436) Fixing nightly fraud log. This patch returns the script to working order....
23:01, 17 May 2012 Jpostlethwaite 1759 new (mingle-fr-2012-436) Adding example logs for testing. See r1758. This patch returns the script to working order....
23:00, 17 May 2012 Jpostlethwaite 1759 new (mingle-fr-2012-436) Adding example logs for testing. See r1758. To use these test files, copy them to another directory, because the script w...
16:30, 2 May 2012 Jpostlethwaite 1570 ok Failed payments should be marked with a failed status. This is done in r1652.
15:38, 2 May 2012 Jpostlethwaite 1635 ok Updating documentation. See r1634. No custom status codes will be added at this time.
01:18, 2 May 2012 Khorn (WMF) 1638 deferred Added setting for recurring_globalcollect_failures_before_cancellation. Added... I'm still not happy with what I'm seeing in recurring_globalcollect_process_e...
00:24, 2 May 2012 Jpostlethwaite 1638 deferred Added setting for recurring_globalcollect_failures_before_cancellation. Added... See follow up revisions for fixes.
00:01, 2 May 2012 Khorn (WMF) 1591 fixme Adding search by order id to module. See r1590. I'm reverting this, as the actual card was taken care of in what sounds like ...
23:27, 1 May 2012 Khorn (WMF) 1715 resolved Added resetResponseErrors() to reset(). Instead of using this, we should probably be using resetResponseParsed(), whi...
23:09, 1 May 2012 Khorn (WMF) 1718 ok Adding code to offline2civicrm that adds checks to a group for review The only thing I can see here that I might possibly change, is returning earl...
00:50, 27 April 2012 Khorn (WMF) 1679 ok Removing calendar input fields from form. The jcalender.tpl is not working pr... Okay. I thought we were just going to make them read-only, but taking them ou...
23:03, 24 April 2012 Jpostlethwaite 1678 ok Revert r1661, r1651, r1650... See the Mingle card for adding to the API for CiviCRM:...
22:30, 24 April 2012 Jpostlethwaite 1662 resolved Implementing get_contribution_status_key(). Changed API call. See r1661. Fixed in r1681.
22:22, 24 April 2012 Jpostlethwaite 1665 resolved Added element for contribution_status_id. Fixed dates to be set as null, if c... Date code has been removed in r1679 and r1680.
22:14, 24 April 2012 Khorn (WMF) 1650 reverted Fixing comments in PseudoConstant. Reverted in r1678
22:14, 24 April 2012 Khorn (WMF) 1651 reverted Added civicrm_api3_contribution_status to API. Reverted in r1678
22:14, 24 April 2012 Khorn (WMF) 1661 reverted Changed API call to specifically use CRM_Contribute_PseudoConstant::contribut... Reverted in r1678
22:05, 24 April 2012 Jpostlethwaite 1641 resolved Added _recurring_globalcollect_update_record_in_progress(). See r1635. This is fixed in r1677.
19:21, 24 April 2012 Khorn (WMF) 1634 ok Adding See r * @todo contribution_status_id: [7] => Thank you mail failed Everything that survived at what is currently head, is OK.
19:16, 24 April 2012 Khorn (WMF) 1637 resolved Updated _recurring_globalcollect_get_failure_retry_date() to properly use `co... All the hard-coded stuff is gone from head at the time of this review. Resolved.
19:13, 24 April 2012 Khorn (WMF) 1638 deferred Added setting for recurring_globalcollect_failures_before_cancellation. Added... Even though this problem crept in before this point (probably r1377?):...
19:13, 24 April 2012 Jpostlethwaite 1636 ok Removing unnecessary WHERE clauses. See r1635. The contribution_status_id will now be reliable to tell if the status has fai...
19:01, 24 April 2012 Khorn (WMF) 1641 resolved Added _recurring_globalcollect_update_record_in_progress(). See r1635. It would probably be a good idea to switch back to the default database right...
18:54, 24 April 2012 Khorn (WMF) 1650 reverted Fixing comments in PseudoConstant. I'm going to let them fix their own typos. :) Reverting.
18:53, 24 April 2012 Khorn (WMF) 1651 reverted Added civicrm_api3_contribution_status to API. This needs to be reverted: The civi people don't want this in this file.
18:52, 24 April 2012 Khorn (WMF) 1661 reverted Changed API call to specifically use CRM_Contribute_PseudoConstant::contribut... This needs to be reverted: The civi people don't want it in this file.
18:51, 24 April 2012 Khorn (WMF) 1662 resolved Implementing get_contribution_status_key(). Changed API call. See r1661. function _recurring_globalcollect_update_record_in_progress() needs to be upd...
18:46, 24 April 2012 Khorn (WMF) 1663 resolved Moved code inside if block. See r1662. Removed in a later commit.
18:43, 24 April 2012 Khorn (WMF) 1665 resolved Added element for contribution_status_id. Fixed dates to be set as null, if c... Once the date-related code is removed (with the hard-coded status values) thi...
18:17, 24 April 2012 Khorn (WMF) 1652 resolved Implementing get_contribution_status() and get_contribution_status_key(). See... Marking as resolved because r1670 removes most of this functionality in favor...
20:46, 20 April 2012 Jpostlethwaite 1651 reverted Added civicrm_api3_contribution_status to API. I think it is necessary to add a new option_group for recurring contributions....
22:21, 19 April 2012 Jpostlethwaite 1651 reverted Added civicrm_api3_contribution_status to API. Fixed in r1661 and r1662.
21:37, 19 April 2012 Jpostlethwaite 1651 reverted Added civicrm_api3_contribution_status to API. By default:...
19:47, 19 April 2012 Pgehres (WMF) 1650 reverted Fixing comments in PseudoConstant. I'll let Katie have the final word on this, but my impression is that every m...
19:43, 19 April 2012 Jpostlethwaite 1634 ok Adding See r * @todo contribution_status_id: [7] => Thank you mail failed I added code to the API to get the contribution status. See r1651.
19:42, 19 April 2012 Jpostlethwaite 1632 resolved Optimizing database queries for _recurring_globalcollect_get_next_sched_contr... Debugging has been removed. See r1654.
15:50, 19 April 2012 Jpostlethwaite 1643 ok $this->setEmbedded(true) should only be called on the edit form and not the p... This fix prevents the WSOD for CiviCRM when trying to view a subscription.
18:40, 18 April 2012 Jpostlethwaite 1632 resolved Optimizing database queries for _recurring_globalcollect_get_next_sched_contr... I will remove the debugging statements after this is all complete....
18:23, 18 April 2012 Pgehres (WMF) 1634 ok Adding See r * @todo contribution_status_id: [7] => Thank you mail failed We really should not be requiring specific files and functions from core Civi...
18:19, 18 April 2012 Pgehres (WMF) 1636 ok Removing unnecessary WHERE clauses. See r1635. Can you elaborate on why these lines are unnecessary?
18:15, 18 April 2012 Pgehres (WMF) 1632 resolved Optimizing database queries for _recurring_globalcollect_get_next_sched_contr... I don't see anything wrong with the query changes, but can we please avoid ad...
17:09, 18 April 2012 Jpostlethwaite 1635 ok Updating documentation. See r1634. I think all of the code has been modified correctly. Will test.
15:58, 18 April 2012 Jpostlethwaite 1635 ok Updating documentation. See r1634. I could get rid of:...
15:46, 18 April 2012 Jpostlethwaite 1635 ok Updating documentation. See r1634. I think I can get rid of:...
First page
First page		 Previous page
Previous page		 Last page
Last page
Search revisions in this repo by path
    
Retrieved from "http://www.mediawiki.org/wiki/Special:Code/Wikimedia/comments"
Personal tools
Namespaces

Variants
Views
Actions
Navigation
Support
Download
Development
Communication
Toolbox