MediaWiki r84228 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r84227‎ | r84228 (on ViewVC)‎ | r84229 >
Date:07:06, 18 March 2011
Author:aaron
Status:ok (Comments)
Tags:
Comment:
* Fixed wfIncrStats calls from r83617 (I assume this wants the # of jobs added)
* Follow up r83494, r74737: allow for proper db rollback of a user renames (addresses code comments added in r74737)
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r844201.17wmf1: MFT r76372, r76377, r83586, r83587, r83817, r83876, r83979, r84118,...catrope21:04, 20 March 2011
r85033MFT more extension revs: r82601, r82654, r82698, r82755, r82756, r82759, r829...demon18:49, 30 March 2011
r85434MFT: r83885, r83891, r83897, r83902, r83903, r83934, r83965, r83979, r83988, ...demon13:38, 5 April 2011

Past revisions this follows-up on

Rev.Commit summaryAuthorDate
r74737* Removed DIY job insertion batching, batchInsert() already handles this (50 ...aaron20:50, 13 October 2010
r83494Remove the limit on edit count, it is unnecessary now that we have job queue ...tstarling01:12, 8 March 2011
r83617* Add a $count argument to wfIncrStats(), to allow it to increase the count b...tstarling00:00, 10 March 2011

Comments

#Comment by Catrope (talk | contribs)   19:49, 20 March 2011

Surely this can be refactored to be nicer, e.g. with a boolean $commit parameter to batchInsert() ?

Looks good otherwise.

#Comment by Aaron Schulz (talk | contribs)   19:52, 20 March 2011

I really considered that at first (but using a string not a bool), but the function would be littered with if ( $commit == "nocommit" ) all over the place and it seemed better to just make a separate function. The duplication is minuscule.

#Comment by ^demon (talk | contribs)   18:50, 30 March 2011

Still needs phase3 merge

Status & tagging log