Code Review

Jump to: navigation, search
Search revisions in this repo by path
    
First page
First page		 Previous page
Previous page		 Last page
Last page
Show items per page
 Total number of results: 30,194
Date Commenter Rev. Status Commit summary Note
00:20, 9 February 2012 Aaron Schulz 110922 resolved Added some simple path validation to resolveContainerPath() in FSFileBackend.... Note that $relStoragePath already has normalized directory separators (only "...
00:17, 9 February 2012 Reedy 110922 resolved Added some simple path validation to resolveContainerPath() in FSFileBackend.... You're missing | from the windows regex. ...
23:23, 8 February 2012 Catrope 110933 ok Followup r98500, fixes flash of unstyled content I was gonna say that you need to add the modules to the ParserOutput object t...
23:13, 8 February 2012 Aaron Schulz 110979 resolved Properly expand the "error storing file" message. Fixes bug 33846 By default wfMessage() parses messages (rather than plaintext). This might be...
23:10, 8 February 2012 Aaron Schulz 110979 resolved Properly expand the "error storing file" message. Fixes bug 33846 Why is the implode still there?
23:08, 8 February 2012 Aaron Schulz 110938 ok enhance filerepo doc structure <pre>This module regroup classes meant for MediaWiki to interacts with</pre>...
22:57, 8 February 2012 IAlex 110836 ok Fixes Bug 34243 - [Regression] Can't navigate from Special:ListUsers/sysop to... That code is in a subclass of Pager, not SpecialPage.
22:11, 8 February 2012 Tim Starling 110909 new * Fix for r96546 etc.: due to a severe performance regression in log lists, r... For the nature of the performance regression, see my comments on r96546. I'm ...
20:41, 8 February 2012 Nikerabbit 110870 ok changes IndexWriter xtor to conform to Lucene 3.0 API In 3.2 even that syntax is deprecated: http://lucene.apache.org/core/old_vers...
20:35, 8 February 2012 Aaron Schulz 110960 ok Bumped $maxContCacheSize to handle container sharding a bit better. However, ... The other two lines are whitespace cleanup.
20:18, 8 February 2012 Catrope 110836 ok Fixes Bug 34243 - [Regression] Can't navigate from Special:ListUsers/sysop to... Are you afraid that getTitle() will produce something like <code>Special:List...
20:06, 8 February 2012 Aaron Schulz 110942 ok fix doc grouping for actions What was wrong with it before? Grouping by base class seemed OK.
20:03, 8 February 2012 Aaron Schulz 110948 ok Fix my stupid mistake in r110750 that resulted in fake "can't delete page" er... Weird, I read that as "equals" when I looked at it...
19:57, 8 February 2012 Aaron Schulz 96546 new Enabled MoveLogFormatter... Yeah, I was fixing other breakage first. I just fixes that problem now.
18:42, 8 February 2012 Nikerabbit 96546 new Enabled MoveLogFormatter... Correct. I have some ideas how to query them at once, but that can probably b...
16:40, 8 February 2012 Hashar 110938 ok enhance filerepo doc structure It works for me. Not sure our good old version does :/ Something to look at ...
16:39, 8 February 2012 Aaron Schulz 110938 ok enhance filerepo doc structure Does @copydoc work for our doxygen? If so, a lot more @see statements could b...
16:17, 8 February 2012 Catrope 110568 ok Fix bug 33768, introduced in r104041: saveChanges() needs to be run even if $... As it should have. I've added comments to this file before saying it should b...
16:15, 8 February 2012 Catrope 110592 new Followup r108184: per CR, blocking loads in debug mode were broken because de... Yeah, it's not the cleanest code I ever wrote, but it's needed because the as...
15:47, 8 February 2012 Liangent 103763 new (bug 31982) Handle fallback languages in LocalisationUpdate. Modified patch b... Done. bug 34272.
15:28, 8 February 2012 Catrope 103763 new (bug 31982) Handle fallback languages in LocalisationUpdate. Modified patch b... This is a bug, yes, but it's not a regression, because fallbacks weren't hand...
15:06, 8 February 2012 MaxSem 110935 ok Sort extension names on those lame Linux file systems:) Yes, I observed unsorted extensions on Labs.
15:04, 8 February 2012 ^demon 110935 ok Sort extension names on those lame Linux file systems:) They are sorted according to the filesystem?
14:58, 8 February 2012 ^demon 109552 new fix Bug 33739 - \text{äöü} doesn't add encoding preamble We should add them if we're going to keep supporting code that none of us can...
14:17, 8 February 2012 ^demon 110909 new * Fix for r96546 etc.: due to a severe performance regression in log lists, r... Well if you're only looking at a single case, I don't see the point of using ...
14:14, 8 February 2012 ^demon 110928 ok align variables / enhance comment s/Virtual/virtual/ -- it's not a proper noun :)
10:42, 8 February 2012 Aaron Schulz 110923 resolved use rtrim() to strip trailing slashes... The change in the foreach loop is broken since rtrim does not work by reference.
09:55, 8 February 2012 Hashar 110923 resolved use rtrim() to strip trailing slashes... That revision made basePath always null. Fixed with r110926
07:03, 8 February 2012 Hashar 110871 ok simplify FileCacheBase::fetchText... binary flag added with r110916.
06:48, 8 February 2012 Siebrand 110909 new * Fix for r96546 etc.: due to a severe performance regression in log lists, r... Can you elaborate on the "severe performance regression"? Also, why only reve...
05:43, 8 February 2012 Tim Starling 96546 new Enabled MoveLogFormatter... If you have memcached enabled, you get less queries: one per row for users wi...
03:49, 8 February 2012 Tim Starling 96546 new Enabled MoveLogFormatter... Disabled the relevant feature in r110909.
03:49, 8 February 2012 Tim Starling 96546 new Enabled MoveLogFormatter... Disabled the relevant feature in
03:47, 8 February 2012 Tim Starling 96546 new Enabled MoveLogFormatter... This broken code is still present, even after r110893. Leaving status as fixm...
01:57, 8 February 2012 Tim Starling 96546 new Enabled MoveLogFormatter... Here is the query log for [[Special:Log/move]] on my test wiki: http://paste....
01:24, 8 February 2012 Tim Starling 110900 ok Revert r110321: introduces an XSS vulnerability because FormatJson::encode() ... Actually there is a difference between \x3c and \u003c: \x3c is not allowed i...
01:17, 8 February 2012 MZMcBride 110907 deferred Fix bug Truncated commit summary?
00:37, 8 February 2012 Krinkle 110900 ok Revert r110321: introduces an XSS vulnerability because FormatJson::encode() ... Aggregating from #mediawiki: http://toolserver.org/~mwbot/logs/%23mediawiki/2......
23:49, 7 February 2012 Krinkle 109678 new Reinstate r109223 per CR + fixes... Fixed by r110716.
23:49, 7 February 2012 Krinkle 110716 ok Please review carefully, I cannot see negative side effects from this patch. ... This is a follow-up to r109678.
23:15, 7 February 2012 Aaron Schulz 110807 new Follow-up r100165:... Do you have commit access?
22:18, 7 February 2012 Bawolff 110883 ok Adding my USERINFO file Welcome to Wikimedia land!
21:26, 7 February 2012 Aaron Schulz 110871 ok simplify FileCacheBase::fetchText... Can you add the 'b' flag to gzopen() for good measure? ("$fh = gzopen( $this-...
20:48, 7 February 2012 Hashar 98405 new HTMLFileCache refactoring:... r110871 implements gzopen() + stream_get_contents()
19:43, 7 February 2012 Aaron Schulz 110836 ok Fixes Bug 34243 - [Regression] Can't navigate from Special:ListUsers/sysop to... I'm pretty sure there is a better way to do this using SpecialPage functions.
19:15, 7 February 2012 Event 108242 deferred http://translatewiki.net/wiki/Thread:Support/Translation_of_SMW_datatypes... It is preferable to use "Størrelse" as standard and "Mål" as alias....
19:07, 7 February 2012 Aaron Schulz 96546 new Enabled MoveLogFormatter... It's mostly there for reference (saw the bug # is on CR).
19:04, 7 February 2012 Nikerabbit 96546 new Enabled MoveLogFormatter... So who should see it? You know I've already seen it.
18:53, 7 February 2012 Aaron Schulz 96546 new Enabled MoveLogFormatter... Should be bug 33167.
18:49, 7 February 2012 Nikerabbit 96546 new Enabled MoveLogFormatter... I don't see how that is related.
First page
First page		 Previous page
Previous page		 Last page
Last page
Search revisions in this repo by path
    
Retrieved from "http://www.mediawiki.org/wiki/Special:Code/MediaWiki/comments"
Personal tools
Namespaces
Variants
Views
Actions
Site
Support
Download
Development
Communication
Toolbox