Code Review
From MediaWiki.org
For MediaWiki (recent comments | status changes | tags | authors | states | release notes)
 First page |
 Previous page |
 Next page |
 Last page |
| Date | Commenter | Revision | Status | Commit summary | Note |
|---|---|---|---|---|---|
| 16:51, 7 November 2009 | Brion VIBBER | 58706 | resolved | W/ the order fix it looks good to me! | |
| 15:51, 7 November 2009 | Bryan | 58706 | resolved | If the index il_from_il_to is forced and only ORDER BY page_id is done, it will still sort by il_to without filesorting, but that will break on databases without implicitOrderBy. | |
| 15:46, 7 November 2009 | Duesentrieb | 58712 | resolved | better pattern in r58714 | |
| 15:34, 7 November 2009 | Bryan | 58706 | resolved | Found out that it filesorts. | |
| 15:31, 7 November 2009 | MaxSem | 58712 | resolved | Possible attack vectors: javascript/**/:alert(document.cookie) vbscript:alert(document.cookie) | |
| 15:27, 7 November 2009 | Siebrand | 58695 | new | The current parser does no i18n for special page URLs that are suffixed with a parameter. Using <nowiki>{{#special:pagename}}</nowiki> fixes that. This is also used in core in several places, and FlaggedRevs, IIRC. See example below. <pre> 'signature-anon' => '[[{{#special:Contributions}}/$1|$2]]', ... | |
| 15:04, 7 November 2009 | Duesentrieb | 58694 | reverted | reverted in r58711 | |
| 14:36, 7 November 2009 | Duesentrieb | 58694 | reverted | not convinced by the spammer argument, but thinking about it, the url needs to be registered as an external link with the parser output, and needs to trigger the spam filter hooks, so it's probably best to use a parser function after all. will revert. | |
| 14:07, 7 November 2009 | Nikerabbit | 58695 | new | If this actually changes something, I think there is a bug. | |
| 10:45, 7 November 2009 | MaxSem | 58694 | reverted | Probably, RDFa support should be implemented as a parser tag? | |
| 10:14, 7 November 2009 | MaxSem | 58694 | reverted | Now imagine a typical spambot that posts something like <a href="http://example.com" style="display:none">. While the href attribute will be ignored, the whole spam addition will still be parsed as HTML and therefore hidden, making detection harder. | |
| 10:00, 7 November 2009 | IAlex | 57459 | new | This fixes bug 10764. | |
| 09:26, 7 November 2009 | Mdale | 58512 | new | right thanks :) r58691 | |
| 17:19, 6 November 2009 | Brion VIBBER | 58659 | resolved | expires looks ok; should use the regular title funcs for title validation | |
| 15:18, 6 November 2009 | ^demon | 58635 | resolved | Also, need to update docs/hooks.txt | |
| 14:57, 6 November 2009 | Brion VIBBER | 58635 | resolved | You can drop the & on the &$this here; it's not an out-param so we don't need to pass-by-reference in PHP 5. (A bunch of reference arguments are still floating around from PHP 4 object semantics, but that's obsolete :D) | |
| 10:37, 6 November 2009 | Bryan | 58633 | fixme | We should probably settle on whether we use restriction or protection. We now have a function getProtectionTypes which basically returns $wgRestrictionTypes. The hook is in Title, so should not be prefixed ProtectionForm. | |
| 20:51, 5 November 2009 | Catrope | 58587 | new | Putting the text "Error: invalid XML" in the page_props table seems like a bad idea to me. Instead, just put an empty string there or something, and check for it in the API module and add the invalid => '' attribute when appropriate. | |
| 19:08, 5 November 2009 | MaxSem | 58364 | fixme | Broke it for SQLite: "aggregate functions are not allowed in the GROUP BY clause" | |
| 17:05, 5 November 2009 | Mormegil | 58512 | new | There is a bug here. You miss a dot on line 309. Instead of $uriParam .= "&urid={$wgStyleVersion}"; there is just $uriParam = "&urid={$wgStyleVersion}"; removing the prepared $uriParam = 'uselang=' . $wgLang->getCode(); from line 277. Altogether, it means everything is in English now. (And the q... | |
| 16:40, 5 November 2009 | Yaron Koren | 58585 | resolved | Oh yeah, I forgot... I changed this in the code now. | |
| 15:51, 5 November 2009 | Catrope | 58585 | resolved | As I said before, I think it's better to validate the XML at parse time rather than in the API module. | |
| 11:57, 5 November 2009 | Catrope | 58575 | reverted | This breaks on PHP 5.2, because late static binding was introduced in PHP 5.3. | |
| 19:36, 4 November 2009 | Sergey Chernyshev | 58458 | new | Yes, it should work fine if that's generic approach. I just hope I don't get a change in the extension by somebody else without backwards compatibility check. | |
| 19:33, 4 November 2009 | Sergey Chernyshev | 58535 | new | Yep, thanks. | |
| 19:17, 4 November 2009 | Catrope | 58556 | new | Does this revision make any functional changes to engine.js? | |
| 15:14, 4 November 2009 | Raymond | 58536 | fixme | Seen at translatewiki after reupload http://translatewiki.net/wiki/File:Wildkatze.jpg PHP Strict Standards: Declaration of UploadFromStash::initialize() should be compatible with that of UploadBase::initialize() in /var/www/w/includes/upload/UploadFromStash.php on line 85 | |
| 14:17, 4 November 2009 | Siebrand | 58532 | new | Assuming this will only work on 1.16 and later, loading messages is no longer necessary. wfLoadExtensionMessages is a no-op in trunk. | |
| 12:56, 4 November 2009 | Bryan | 58536 | fixme | MessagesEn.php commit belongs to r58537. | |
| 09:36, 4 November 2009 | Siebrand | 58458 | new | I haven't tested it either, but Yaron told me it worked on ExternalData. Wouldn't know why it would work there and not here. Thanks. | |
| 05:52, 4 November 2009 | Sergey Chernyshev | 58458 | new | Did this in r58517 - didn't test on 1.16 branch, but tested on older version (e.g. 1.15 for mediawikiwidgets.org) | |
| 02:47, 4 November 2009 | Mdale | 58516 | new | opps .. I just copied and pasted from the inline text ... thx for the fix. | |
| 21:16, 3 November 2009 | Bryan | 55749 | ok | Do other browsers break by sending type=text/xsl? It looks like Mozilla, Opera and Chrome support text/xsl. | |
| 15:46, 3 November 2009 | Juliano | 58477 | fixme | Siebrand, are you sure this is correct? It seems that $aliases was used with the deprecated $wgExtensionAliasesFiles. The documentation in DefaultSettings.php and the code in LocalisationCache::recache() points that the correct name for Mw 1.16a is $specialPageAliases. After this commit, special pa... | |
| 12:37, 3 November 2009 | Catrope | 58449 | ok | Oh wait, that's due to the rebuild. I'm an idiot. | |
| 10:20, 3 November 2009 | Catrope | 58449 | ok | The <code>if(e.button !== 0) return true;</code> statement is not in jquery.wikiEditor.toolbar.js but is in the combined JS. | |
| 06:41, 3 November 2009 | Siebrand | 58458 | new | See r55348 | |
| 22:51, 2 November 2009 | Brion VIBBER | 58448 | resolved | needs updated minified code | |
| 22:45, 2 November 2009 | Brion VIBBER | 58070 | ok | If clicked when there's not a selection, this adds a : at the insertion point, rather than at the beginning where it would be needed to indent. (Eg, if I type some text, then hit "indent") The numbered and bullet list buttons in this case will add a new line with a sample item, which is at least cl... | |
| 22:37, 2 November 2009 | Brion VIBBER | 57836 | resolved | Minor regression: this activates the folding/unfolding on right- and middle-click as well as left-click. Trevor's looking into poking to filter by button so it behaves nicer. | |
| 19:25, 2 November 2009 | Aaron Schulz | 58429 | new | The replacing itself was actually manual | |
| 08:30, 2 November 2009 | Catrope | 58399 | resolved | That wasn't it: you forgot to declare the (rv|le|rc)tag parameters. Fixed in r58419 | |
| 23:48, 1 November 2009 | Gurch | 58399 | resolved | Looks like I mixed up isset() and !is_null(), sorry about that. one of these days I might actually learn PHP :/ | |
| 21:36, 1 November 2009 | Siebrand | 58399 | resolved | PHP Notice: Undefined index: tag in includes/api/ApiQueryRevisions.php on line 152 | |
| 19:48, 1 November 2009 | Catrope | 58399 | resolved | Oh wait, it does. Reverted unintended changes in r58403. | |
| 19:46, 1 November 2009 | Catrope | 58399 | resolved | Are you sure it's caused by this revision? It looks like a preferences and/or cookie bug; this commit doesn't even touch User.php | |
| 18:33, 1 November 2009 | Church of emacs | 58399 | resolved | Gives me the following notice:<br /> <tt>Notice: Undefined index: wikidatabasename_wiki_Options in /path/to/wiki/includes/User.php on line 3631</tt> | |
| 17:42, 30 October 2009 | Juliano | 58354 | deferred | Heh, Ok! I'm going to revert it then. No problem :-) | |
| 17:14, 30 October 2009 | Mr.Z-man | 58079 | fixme | I can add a permission check to Title::isValidMoveOperation, but it will mainly just increase code duplication. For it to be able to provide a different warning with the option to override to users who ''can'' move it, versus a "you can't do this" warning to users who can't, it still needs to do the... | |
| 14:19, 30 October 2009 | Siebrand | 58353 | deferred | No need to take care of that. We try to let 'you guys' develop, and 'us guys' will take care of the L10n related issues. You'll hear from us if you're writing code with bad i18n... ;) |
First page |
Previous page |
Next page |
Last page |
