Code Review

From MediaWiki.org

Jump to: navigation, search
First page
First page
Previous page
Previous page
Last page
Last page
Show items per page
Date Commenter Revision Status Commit summary Note
17:56, 20 November 2009 Werdna 58789 ok * Add API module for GlobalUsage (although, ideally most of this should be done with a pager, and the links, while safe, should really be constructed with the Skin object).
17:56, 20 November 2009 Bryan 58657 ok Changes after review by Andrew: Reviewed by Werdna.
17:56, 20 November 2009 Werdna 58789 ok * Add API module for GlobalUsage Looks OK
17:56, 20 November 2009 Bryan 58693 ok Show globalusage on the imagepage Reviewed by Werdna.
17:56, 20 November 2009 Bryan 58705 ok File forgotten to commit in r58693: Show globalusage on the imagepage Reviewed by Werdna.
17:46, 20 November 2009 Werdna 58778 ok Set default maxlag to 5 seconds Looks fine
17:46, 20 November 2009 Werdna 58763 ok Show the pretty name of the wiki instead of the internal representation. Looks fine.
17:46, 20 November 2009 Werdna 58758 ok * Add globalusage link to the file toc Looks ok
17:43, 20 November 2009 Mormegil 59152 new migrating the toc resizing to use jquery ui resizable And you cannot copy&paste <code>context.modules.$toc</code> into <tt>jquery.wikiEditor.toolbar.js</tt>, you need to use <code>$toolbar</code> there.
17:37, 20 November 2009 Mormegil 59152 new migrating the toc resizing to use jquery ui resizable That “*/” forgotten in wikiEditor.css is redundant [http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/UsabilityInitiative/css/wikiEditor.css?%721=59151&%722=59152]
17:29, 20 November 2009 Trevor Parscal 59276 fixme Initial check in for the SVGZoom tool. Oops - yes, ialex has moved it to the right place.
10:06, 20 November 2009 Catrope 59275 new Initial setup for the highlight module of wikiEditor. <pre> - '<html><head><title>wikiEditor</title></head><body style="margin:0;padding:0;width:100%;height:100%;">' + - '<pre style="margin:0;padding:0;width:100%;height:100%;white-space:pre-wrap;"></pre></body></html>' + '<html><head><title>wikiEditor</title><script>var context = window.parent...
03:01, 20 November 2009 ^demon 59276 fixme Initial check in for the SVGZoom tool. Should be in /trunk/extensions?
18:00, 19 November 2009 Reedy 59258 new bug 19523 prop=info&inprop=watched Not sure if "$this->watched[$row->page_namespace][$row->page_title] = true;" would be better to be "$this->watched[$row->page_namespace][$row->page_title] = '';" or similar?
14:17, 19 November 2009 Catrope 59196 ok userinfo for reedy Test comment to see if reedy's enotif works.
12:25, 19 November 2009 Catrope 59247 fixme LiquidThreads: Add direct descendent selector to CSS rule that was breaking sign... The rule is ignored. This is actually a trick the Vector stylesheets use to apply rules for IE6 only: <pre> /* Rules for IE6 */ foo bar { blah: 0; } /* Non-IE6 browsers will parse this rule and let it override the previous one */ foo > bar { blah: 1; } </pre>
11:47, 19 November 2009 Werdna 59247 fixme LiquidThreads: Add direct descendent selector to CSS rule that was breaking sign... What happens if I do use one in IE6?
11:47, 19 November 2009 Catrope 59247 fixme LiquidThreads: Add direct descendent selector to CSS rule that was breaking sign... Child selectors don't work in IE6.
10:18, 19 November 2009 Catrope 59221 new Add missing messages for the existing idention icon Adam recombined it for you in r59228. For future reference, you can do this by running make in the UsabilityInitiative directory. Also please update the relevant style versions (done in r59238).
08:03, 19 November 2009 Catrope 58974 resolved Fix for r58973: needs parentheses Agreed. However, we decided that using click instead of mousedown was OK, so that's what we did.
01:11, 19 November 2009 Tfinc 59225 new add tracking field to transaction Looks like extra debugging made its way in here.
00:42, 19 November 2009 Tim Starling 58974 resolved Fix for r58973: needs parentheses I think if you have a choice between browser sniffing and totally broken behaviour, you should choose browser sniffing.
22:11, 18 November 2009 Nimish Gautam 59205 ok escaping using addQuotes quoted using dbr instead of manual quotes
21:47, 18 November 2009 Siebrand 59216 new New Extension:GroupsSidebar. More information about this extension in mediawiki.... Has 'descriptionmsg' => 'myextension-desc' but no i18n file and wgExtensionMessagesFiles[]
18:59, 18 November 2009 Catrope 58974 resolved Fix for r58973: needs parentheses Changed back to using click() in r59202
18:55, 18 November 2009 Shuhari 57425 ok * EditToolbar: (bug 21015) Make table and link dialogs also work nicely with the... This revision was reviewed by Werdna at 6:44pm UTC on November 18th before production deployment.
18:50, 18 November 2009 Shuhari 57541 ok Added extra classes for collapsible tabs to use. This revision was reviewed by Werdna at 6:44pm UTC on November 18th before production deployment.
18:49, 18 November 2009 Shuhari 58969 ok Fixing a bug on collapsible tabs where the tabs would get stuck alternating betw... This revision was reviewed by Werdna at 6:44pm UTC on November 18th before production deployment.
18:48, 18 November 2009 Shuhari 59185 ok acaifix: Some IE fixes. This should fix bug 21492, bug 21220, bug 21248 and bug ... This revision was reviewed by Werdna at 6:44pm UTC on November 18th before production deployment.
18:47, 18 November 2009 Shuhari 59191 ok acaifix: Change tactics for handling browsers that don't restore cursor position... This revision was reviewed by Werdna at 6:44pm UTC on November 18th before production deployment.
11:08, 18 November 2009 Catrope 59185 ok acaifix: Some IE fixes. This should fix bug 21492, bug 21220, bug 21248 and bug ... Yes, I had Andrew and Adam test it.
11:08, 18 November 2009 Catrope 58974 resolved Fix for r58973: needs parentheses That's not intended, no, but I don't think it's a big deal, or that we can cleanly solve this without browser sniffing. The problem would go away if we went back to using click(), but we're using mousedown() for a reason. I'll discuss this with Trevor.
11:05, 18 November 2009 Catrope 58953 resolved * UsabilityIntiative: Hopefully fix bug 21342 (e.button != 0 check doesn't work ... Yes, I fixed it in those revs, and I had others test it. I downloaded VirtualBox yesterday and I'm gonna play around with it today so I'll (hopefully) finally have IE to test on. Removing fixme as this has been tested by other people, and you haven't explicitly said it didn't work for you (after r5...
11:01, 18 November 2009 Catrope 58873 fixme * EditToolbar: Make header dropdown whitespace-tolerant Stripping the leading whitespaces doesn't happen for me on the deployment candidate; it could be and probably is a bug with the magic iframe, which was introduced later. The bug this is meant to fix is that when you accidentally select the newline before or after the heading along with the heading ...
04:09, 18 November 2009 Tim Starling 59185 ok acaifix: Some IE fixes. This should fix bug 21492, bug 21220, bug 21248 and bug ... Is it tested?
02:56, 18 November 2009 Tim Starling 59048 fixme add trailing zeroes for MW_TIMESTAMP format I'm disabling this extension on Wikimedia until the correct SQL escaping functions are used.
02:31, 18 November 2009 Tim Starling 59048 fixme add trailing zeroes for MW_TIMESTAMP format This file is wrong in lots of different ways. I'll have to write a full review.
02:22, 18 November 2009 Tim Starling 58974 resolved Fix for r58973: needs parentheses Is it intended that this will cause a middle-button click to be treated the same as a left-button click in FF?
02:21, 18 November 2009 Tim Starling 58972 resolved usability: Merge r58953 (IE fixes) from trunk to acaifix Fixme as per r58953.
01:33, 18 November 2009 Tim Starling 58953 resolved * UsabilityIntiative: Hopefully fix bug 21342 (e.button != 0 check doesn't work ... Plainly broken, I assume you're hoping this was fixed in r58973 and r58974. I assume the bug 21050 component is also untested. Is it too much to ask that you test your changes before commit? Do we need to sponsor you a Windows license or something? Marking as "fixme" pending proper testing.
01:02, 18 November 2009 Tim Starling 58873 fixme * EditToolbar: Make header dropdown whitespace-tolerant It doesn't work for me, in FF 3.5. If I select a heading with spaces at the start of the line, and change it to a different level heading, the spaces at the start of the line disappear, presumably folding into the line break after the &lt;br/&gt;. Note that a heading with spaces preceding is not a...
00:26, 18 November 2009 Tim Starling 58570 reverted adding a styling rule to ensure vector menu h5s aren't f#ed with by the german p... Roan tells me it is to override a rule from [[:de:MediaWiki:Common.css]]. I have now fixed that page, so this change can be reverted.
00:15, 18 November 2009 Tim Starling 58570 reverted adding a styling rule to ensure vector menu h5s aren't f#ed with by the german p... Can you explain this?
22:47, 17 November 2009 Tim Starling 58646 fixme API: (bug 20554) Expose average slave lag (avglag) as well as maxlag. Patch by S... https://bugzilla.wikimedia.org/show_bug.cgi?id=20554#c5
10:46, 17 November 2009 MaxSem 59145 new Fix parse error: syntax error, unexpected $end in extensions/AntiSpoof/equivset.... Whoopsie. Gotta tweak the checker to test only modified files quickly, otherwise it will be too slow to run it at all times, like in this case.
13:46, 16 November 2009 IAlex 59123 reverted Allow $wgMaxCredits to work for database backends with non-magic group by behavi... Reverted in r59131.
13:29, 16 November 2009 IAlex 59123 reverted Allow $wgMaxCredits to work for database backends with non-magic group by behavi... This produces the following warnings (on translatewiki.net): <pre> [16-Nov-2009 13:09:23] PHP Notice: Undefined property: stdClass::$user_password in /var/www/w/includes/User.php on line 972 [16-Nov-2009 13:09:23] PHP Notice: Undefined property: stdClass::$user_newpassword in /var/www/w/includes...
13:26, 16 November 2009 Werdna 58633 fixme Enabling changes for r56828: some refactoring and code cleanup of the protection... Resolution in r58816.
00:34, 16 November 2009 Simetrical 59024 new RDFa/microdata follow-up I meant: ". . . will be an HTML processor . . ."
00:33, 16 November 2009 Simetrical 59024 new RDFa/microdata follow-up Some more thoughts: * I still don't like the script filtering thing. It gives a false sense of security at best, and is WTFish at worst. * If xml:lang="" is used, it's certainly only valid if it matches lang="" on the same attribute. So why not only allow lang="", and just spit out a matching xml...
First page
First page
Previous page
Previous page
Last page
Last page
Views
Toolbox