MediaWiki r99321 - Code Review

Repository:	MediaWiki
Revision:	< r99320‎ \| r99321 (on ViewVC)‎ \| r99322 >
Date:	19:28, 8 October 2011
Author:	hartman
Status:	resolved (Comments)
Tags:
Comment:	Check if there is a prexisting tfoot, before creating a new one. Follow up to r98669, though this was a problem that also could surface without tfoot emulation.
Modified paths:	/trunk/phase3/resources/jquery/jquery.tablesorter.js (modified) (history) (diff)

Diff [purge]

Index: trunk/phase3/resources/jquery/jquery.tablesorter.js
—	—	@@ -596,7 +596,12 @@
597	597	// and put the <tfoot> at the end of the <table>
598	598	var $sortbottoms = $table.find( 'tr.sortbottom' );
599	599	if ( $sortbottoms.length ) {
600		~~- $table.append( $( '<tfoot>' ).append( $sortbottoms ) )~~
	600	+ var $tfoot = $table.find( 'tfoot' );
	601	+ if( $tfoot ) {
	602	+ $tfoot.eq(0).prepend( $sortbottoms );
	603	+ } else {
	604	+ $table.append( $( '<tfoot>' ).append( $sortbottoms ) )
	605	+ }
601	606	}
602	607
603	608	explodeRowspans( $table );

Rev.	Commit summary	Author	Date
r99994	Fix broken test by r99321	krinkle	22:33, 16 October 2011
r101126	1.18wmf1: MFT r98669, r99164, r99321, r99332, r99632, r99897, r99914, r99952,...	catrope	12:09, 28 October 2011
r101202	REL1_18 MFT r98669, r99031, r99321, r99994	reedy	21:14, 28 October 2011

Rev.	Commit summary	Author	Date
r98669	Add tfoot emulation to tablesorter. Fixes part of the complaints in bug 31060	hartman	11:58, 2 October 2011

#Comment by Siebrand (talk | contribs) 01:18, 10 October 2011

#Comment by TheDJ (talk | contribs) 16:32, 22 October 2011

Test fixed by Krinkle.

21:14, 28 October 2011 Reedy (talk | contribs) changed the tags for r99321 [removed: 1.18]
12:37, 28 October 2011 Catrope (talk | contribs) changed the tags for r99321 [removed: 1.18wmf1]
11:12, 28 October 2011 Catrope (talk | contribs) changed the status of r99321 [removed: new added: resolved]
11:12, 28 October 2011 Catrope (talk | contribs) changed the tags for r99321 [added: 1.18,1.18wmf1]
16:34, 22 October 2011 TheDJ (talk | contribs) changed the status of r99321 [removed: fixme added: new]
01:18, 10 October 2011 Siebrand (talk | contribs) changed the status of r99321 [removed: new added: fixme]