MediaWiki r9861 - Code Review

Repository:	MediaWiki
Revision:	< r9860‎ \| r9861 (on ViewVC)‎ \| r9862 >
Date:	07:16, 3 July 2005
Author:	vibber
Status:	old
Tags:
Comment:	really fix that enhanced rc changes link
Modified paths:	/trunk/phase3/includes/ChangesList.php (modified) (history) (diff)

Diff [purge]

Index: trunk/phase3/includes/ChangesList.php
—	—	@@ -122,7 +122,7 @@
123	123	$userlinks = array () ;
124	124	foreach ( $block AS $rcObj ) {
125	125	$oldid = $rcObj->mAttribs['rc_last_oldid'];
126		~~- $newid = $rcObj->mAttribs['rc_this_oldid'];~~
	126	+ $newid = $rcObj->mAttribs['rc_this_oldid'];
127	127	if ( $rcObj->mAttribs['rc_new'] ) {
128	128	$isnew = true ;
129	129	}
—	—	@@ -172,12 +172,13 @@
173	173	$r .= $link ;
174	174
175	175	$curIdEq = 'curid=' . $block[0]->mAttribs['rc_cur_id'];
	176	+ $currentRevision = $block[0]->mAttribs['rc_this_oldid'];
176	177	if ( $block[0]->mAttribs['rc_type'] != RC_LOG ) {
177	178	# Changes
178	179	$r .= ' ('.count($block).' ' ;
179	180	if ( $isnew ) $r .= wfMsg('changes');
180	181	else $r .= $this->skin->makeKnownLinkObj( $block[0]->getTitle() , wfMsg('changes') ,
181		~~- $curIdEq."&diff=$newid&oldid=$oldid" ) ;~~
	182	+ $curIdEq."&diff=$currentRevision&oldid=$oldid" ) ;
182	183	$r .= '; ' ;
183	184
184	185	# History

15:03, 12 September 2011 Meno25 (Talk | contribs) changed the status of r9861 [removed: ok added: old]
14:05, 18 June 2009 ^demon (Talk | contribs) changed the status of r9861 [removed: new added: ok]