MediaWiki r97711 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r97710‎ | r97711 (on ViewVC)‎ | r97712 >
Date:09:41, 21 September 2011
Author:nikerabbit
Status:ok (Comments)
Tags:
Comment:
* (bug 30245) Use the correct way to construct a log page title
Modified paths:

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -95,6 +95,7 @@
9696 * (bug 18424) Special:Prefixindex and Special:Allpages paging links are
9797 really small, and somewhat inconsistent with each other.
9898 * Per page edit-notices now work in namespaces without subpages enabled.
 99+* (bug 30245) Use the correct way to construct a log page title
99100
100101 === API changes in 1.19 ===
101102 * (bug 19838) siprop=interwikimap can now use the interwiki cache.
Index: trunk/phase3/includes/RecentChange.php
@@ -621,7 +621,7 @@
622622 $wgCanonicalServer, $wgScript;
623623
624624 if( $this->mAttribs['rc_type'] == RC_LOG ) {
625 - $titleObj = Title::newFromText( 'Log/' . $this->mAttribs['rc_log_type'], NS_SPECIAL );
 625+ $titleObj = SpecialPage::getTitleFor( 'Log', $this->mAttribs['rc_log_type'] );
626626 } else {
627627 $titleObj =& $this->getTitle();
628628 }
Index: trunk/phase3/includes/ChangesList.php
@@ -511,7 +511,7 @@
512512 if( $rc->mAttribs['rc_type'] == RC_MOVE || $rc->mAttribs['rc_type'] == RC_MOVE_OVER_REDIRECT ) {
513513 // Log entries
514514 } elseif( $rc->mAttribs['rc_log_type'] ) {
515 - $logtitle = Title::newFromText( 'Log/'.$rc->mAttribs['rc_log_type'], NS_SPECIAL );
 515+ $logtitle = SpecialPage::getTitleFor( 'Log', $rc->mAttribs['rc_log_type'] );
516516 $this->insertLog( $s, $logtitle, $rc->mAttribs['rc_log_type'] );
517517 // Log entries (old format) or log targets, and special pages
518518 } elseif( $rc->mAttribs['rc_namespace'] == NS_SPECIAL ) {

Follow-up revisions

Rev.Commit summaryAuthorDate
r111006Revert r88270, r97711 and r110825 out of 1.19reedy01:16, 9 February 2012

Comments

#Comment by Nikerabbit (Talk | contribs)   09:42, 21 September 2011

Forgot to mention in the commit message: Patch provided by Umherirrender.

#Comment by Krinkle (Talk | contribs)   23:16, 21 September 2011
#Comment by Tim Starling (Talk | contribs)   03:47, 25 November 2011

Should be reverted in 1.19 unless maintainers of the bots that use the Wikimedia IRC feed are notified before deployment.

Status & tagging log

Personal tools
Namespaces

Variants
Views
Actions
Navigation
Support
Download
Development
Communication
Toolbox