MediaWiki r96270 - Code Review

Repository:	MediaWiki
Revision:	< r96269‎ \| r96270 (on ViewVC)‎ \| r96271 >
Date:	06:28, 5 September 2011
Author:	hashar
Status:	ok (Comments)
Tags:
Comment:	(bug 26470) add checkered background on files pages
Modified paths:	/trunk/phase3/RELEASE-NOTES-1.19 (modified) (history) (diff) /trunk/phase3/skins/common/shared.css (modified) (history) (diff)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
—	—	@@ -184,6 +184,16 @@
185	185	}
186	186
187	187	/**
	188	+ * Add a checkered background image on hover for file
	189	+ * description pages. (bug 26470)
	190	+ */
	191	+.filehistory a img,
	192	+#file img:hover {
	193	+ /* @embed */
	194	+ background: white url(images/Checker-16x16.png) repeat;
	195	+}
	196	+
	197	+/**
188	198	* rev_deleted stuff
189	199	*/
190	200	li span.deleted,
—	—	@@ -974,4 +984,4 @@
975	985	/* bug 12205 */
976	986	#mw-credits a {
977	987	unicode-bidi: embed;
978		-}
\ No newline at end of file
	988	+}
Index: trunk/phase3/RELEASE-NOTES-1.19
—	—	@@ -53,6 +53,7 @@
54	54	* (bug 16428) Include permalink in printable version
55	55	* (bug 96170) Add array support for space-separated list attributes (like
56	56	'class') in the Html helper class.
	57	+* (bug 26470) Add checkered background image on hover on files pages.
57	58
58	59	=== Bug fixes in 1.19 ===
59	60	* $wgUploadNavigationUrl should be used for file redlinks if

Rev.	Commit summary	Author	Date
r91756	Bug 26470 : Add checkered background image for transparent images on hover	diebuche	20:34, 8 July 2011
r91759	Reverting r91756 per CR and bug 26470	krinkle	21:27, 8 July 2011
r91761	Reverting r91756 per CR and bug 26470	krinkle	21:29, 8 July 2011

#Comment by Krinkle (Talk | contribs) 01:13, 8 September 2011

No checkbox stuff in-article
On the file page the primary thumbnail on top shows transparency when hovering it
The file history section on the bottom shows it by default for comparison.

#Comment by Hashar (Talk | contribs) 06:10, 8 September 2011

Thanks for the review!

01:13, 8 September 2011 Krinkle (Talk | contribs) changed the tags for r96270 [removed: frontend]
01:13, 8 September 2011 Krinkle (Talk | contribs) changed the status of r96270 [removed: new added: ok]
08:38, 5 September 2011 Krinkle (Talk | contribs) changed the tags for r96270 [added: frontend]