MediaWiki r96181 - Code Review

Repository:	MediaWiki
Revision:	< r96180‎ \| r96181 (on ViewVC)‎ \| r96182 >
Date:	13:34, 3 September 2011
Author:	santhosh
Status:	ok
Tags:
Comment:	Fix javascript error. $('input.narayam-scheme')[0] does not give jquery object. Use $('input.narayam-scheme:first') instead.
Modified paths:	/trunk/extensions/Narayam/js/ext.narayam.core.js (modified) (history) (diff)

Diff [purge]

Index: trunk/extensions/Narayam/js/ext.narayam.core.js
—	—	@@ -475,7 +475,8 @@
476	476	that.setScheme( savedScheme );
477	477	$( '#narayam-' + savedScheme ).attr( 'checked', 'checked' );
478	478	} else {
479		~~- $('input.narayam-scheme')[0].attr( 'checked', 'checked' );~~
	479	+ //if no saved input scheme, select the first.
	480	+ $('input.narayam-scheme:first').attr( 'checked', 'checked' );
480	481	}
481	482	var enabledCookie = $.cookie( 'narayam-enabled' );
482	483	if ( enabledCookie == '1' \|\| ( mw.config.get( 'wgNarayamEnabledByDefault' ) && enabledCookie !== '0' ) ) {

14:35, 8 September 2011 Catrope (talk | contribs) changed the status of r96181 [removed: new added: ok]
13:11, 7 September 2011 Catrope (talk | contribs) changed the tags for r96181 [removed: 1.17wmf1]
13:04, 7 September 2011 Catrope (talk | contribs) changed the tags for r96181 [removed: 1.18]
12:48, 7 September 2011 Siebrand (talk | contribs) changed the tags for r96181 [added: 1.17wmf1,1.18]