MediaWiki r9498 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r9497‎ | r9498 (on ViewVC)‎ | r9499 >
Date:07:03, 19 June 2005
Author:vibber
Status:old
Tags:
Comment:
* Changed $wgGroupPermissions to more cut-n-paste-friendly format
* 'developer' group deprecated by default
Modified paths:

Diff [purge]

Index: trunk/phase3/UPGRADE
@@ -46,7 +46,7 @@
4747 key in $wgGroupPermissions. To emulate the old effect of setting:
4848 $wgWhitelistAccount['user'] = 0;
4949 set:
50 - $wgGroupPermissions['*'] = array( 'read' ); // without createaccount
 50+ $wgGroupPermissions['*']['createaccount'] = false;
5151
5252 If $wgWhitelistRead is set, things need to be funked around. This needs work.
5353
Index: trunk/phase3/includes/User.php
@@ -1578,7 +1578,8 @@
15791579 $rights = array();
15801580 foreach( $groups as $group ) {
15811581 if( isset( $wgGroupPermissions[$group] ) ) {
1582 - $rights = array_merge( $rights, $wgGroupPermissions[$group] );
 1582+ $rights = array_merge( $rights,
 1583+ array_keys( array_filter( $wgGroupPermissions[$group] ) ) );
15831584 }
15841585 }
15851586 return $rights;
Index: trunk/phase3/includes/DefaultSettings.php
@@ -679,19 +679,38 @@
680680 * combined with the permissions of all groups that a given user is listed
681681 * in in the user_groups table.
682682 */
683 -$wgGroupPermissions = array(
684 - '*' => array( 'read', 'createaccount' ),
685 - 'user' => array( 'read', 'move' ),
686 -
687 - 'bot' => array( 'bot' ),
688 - 'sysop' => array( 'createaccount', 'patrol', 'protect', 'delete',
689 - 'rollback', 'block', 'editinterface' ),
690 - 'bureaucrat' => array( 'userrights' ),
691 - 'developer' => array( 'siteadmin' ),
692 -);
 683+$wgGroupPermissions = array();
693684
 685+$wgGroupPermissions['*' ]['createaccount'] = true;
 686+$wgGroupPermissions['*' ]['read'] = true;
694687
 688+$wgGroupPermissions['user' ]['move'] = true;
 689+$wgGroupPermissions['user' ]['read'] = true;
695690
 691+$wgGroupPermissions['bot' ]['bot'] = true;
 692+
 693+$wgGroupPermissions['sysop']['block'] = true;
 694+$wgGroupPermissions['sysop']['createaccount'] = true;
 695+$wgGroupPermissions['sysop']['delete'] = true;
 696+$wgGroupPermissions['sysop']['editinterface'] = true;
 697+$wgGroupPermissions['sysop']['import'] = true;
 698+$wgGroupPermissions['sysop']['importraw'] = true;
 699+$wgGroupPermissions['sysop']['patrol'] = true;
 700+$wgGroupPermissions['sysop']['protect'] = true;
 701+$wgGroupPermissions['sysop']['rollback'] = true;
 702+
 703+$wgGroupPermissions['bureaucrat']['userrights'] = true;
 704+
 705+/**
 706+ * The developer group is deprecated, but can be activated if need be
 707+ * to use the 'lockdb' and 'unlockdb' special pages. Those require
 708+ * that a lock file be defined and creatable/removable by the web
 709+ * server.
 710+ */
 711+# $wgGroupPermissions['developer']['siteadmin'] = true;
 712+
 713+
 714+
696715 # Proxy scanner settings
697716 #
698717
Index: trunk/phase3/RELEASE-NOTES
@@ -298,6 +298,8 @@
299299 * (bug 2277) Added Friulian language file
300300 * Less gratuitous munging of content sample in delete summary
301301 * badaccess/badaccesstext to supercede sysop*, developer* messages
 302+* Changed $wgGroupPermissions to more cut-n-paste-friendly format
 303+* 'developer' group deprecated by default
302304
303305
304306 === Caveats ===

Status & tagging log

  • 15:03, 12 September 2011 Meno25 (talk | contribs) changed the status of r9498 [removed: ok added: old]
  • 14:05, 18 June 2009 ^demon (talk | contribs) changed the status of r9498 [removed: new added: ok]