MediaWiki r93233 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r93232‎ | r93233 (on ViewVC)‎ | r93234 >
Date:19:04, 26 July 2011
Author:happy-melon
Status:ok (Comments)
Tags:
Comment:
* Fix double-escaping from r85025
* Allow admins to modify blocks placed (probably accidentally) on themselves *by* themselves, whether or not they have the 'unblockself' permission.
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r94235Followup r85025, r85166, r93233: use strict comparison per CR comment, becaus...catrope10:33, 11 August 2011
r94446MFT to REL1_18:...hashar09:27, 14 August 2011

Past revisions this follows-up on

Rev.Commit summaryAuthorDate
r85025(bug 23408) give admins a warning before letting them block themselves. Also...happy-melon18:00, 30 March 2011

Comments

#Comment by Aaron Schulz (talk | contribs)   17:59, 2 August 2011
$wgUser->blockedBy() === $wgUser->getName()

Could this use ID instead of name?

#Comment by Happy-melon (talk | contribs)   08:03, 3 August 2011

If the available accessors in User weren't so retarded, sure... :P

Status & tagging log