MediaWiki r92529 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r92528‎ | r92529 (on ViewVC)‎ | r92530 >
Date:12:45, 19 July 2011
Author:robin
Status:resolved (Comments)
Tags:
Comment:
* Use interwiki cache (per r92528)
* Use ResourceLoader for css
* Some code clean-up/improvements
This version is only compatible with 1.19 (r92528)
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r92636Use wfMessage() functions, and rewrite/clean-up showForm() using Html and Xml...robin15:29, 20 July 2011
r105761fix copy-paste error in r92529 (oops)robin12:54, 10 December 2011

Past revisions this follows-up on

Rev.Commit summaryAuthorDate
r92528(bug 19838) API does not use interwiki cache....robin12:30, 19 July 2011

Comments

#Comment by Nikerabbit (talk | contribs)   12:43, 20 July 2011

Double escaping:

+Html::element( 'th', null, wfMsgHtml( 'interwiki_local' ) ) .

In canModify(), the newest fashion is to throw Exceptions.

#Comment by SPQRobin (talk | contribs)   15:31, 20 July 2011

Done in r92636 + rewritten to use wfMessage(). I hope escaping is done right :)

Status & tagging log

  • 07:50, 21 September 2011 Nikerabbit (talk | contribs) changed the status of r92529 [removed: new added: resolved]