MediaWiki r92059 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r92058‎ | r92059 (on ViewVC)‎ | r92060 >
Date:13:10, 13 July 2011
Author:purodha
Status:resolved (Comments)
Tags:
Comment:
[bug 29737] "MediaWiki:Qbsettings-directionality" should refer to script, not language.
Modified paths:

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -157,7 +157,9 @@
158158 are disabled for user pages.
159159 * (bug 12205) Bidirectional names in action=credits are split and displayed
160160 incorrectly when wrapped to the next line.
161 -* (bug 120781) Move 'mainpagetext' messages to installer's .i18n file.
 161+* (bug 20781) Move 'mainpagetext' messages to installer's .i18n file.
 162+* (bug 29737) "MediaWiki:Qbsettings-directionality" should refer to script,
 163+ not language.
162164
163165 === API changes in 1.19 ===
164166 * BREAKING CHANGE: action=watch now requires POST and token.
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1731,7 +1731,7 @@
17321732 'qbsettings-fixedright' => 'Fixed right',
17331733 'qbsettings-floatingleft' => 'Floating left',
17341734 'qbsettings-floatingright' => 'Floating right',
1735 -'qbsettings-directionality' => 'Fixed, depending on the directionality of your language',
 1735+'qbsettings-directionality' => 'Fixed, depending on the directionality of your script and your language',
17361736
17371737 # Preferences page
17381738 'preferences' => 'Preferences',

Follow-up revisions

Rev.Commit summaryAuthorDate
r95413Fix fixme on r92059 per SPQRobinreedy18:46, 24 August 2011

Comments

#Comment by SPQRobin (Talk | contribs)   13:42, 13 July 2011

The sentence feels a bit strange now. Maybe make it "depending on the script directionality of your language"?

#Comment by Purodha (Talk | contribs)   16:21, 13 July 2011

No, there may be no script directionality associated with language. Generally, languages may have several (common) scripts having their own directionality each. Examples are mostly Central Asian ones with Latn, Cyrl, or some other being RTL, and Arab being LTR. Not in our current set but upcoming with growing browser support are also scripts running top-to-bottom lines stacked either RTL or LTR, such as some Chinese, Japanese, Mongolian, Korean, etc.

Wording should mention language, because that is what users are aware of selecting (while in fact, they select locales on the code level) and correctly mention script, since directionalities are a direct function of scripts.

While for one-script languages users may be not aware, users of languages having multiple scripts of differing directioalities would be bewildered finding MediaWiki associating a directionality with their language.

I you have a better wording, which is not too long, please go ahead!

#Comment by SPQRobin (Talk | contribs)   17:27, 13 July 2011

I do know what you explained, and how the mediawiki language/scripts work. A language can have multiple scripts, but it's difficult to formulate that in a simple sentence. This setting does not depend on the language at all (but rather on the script), but language is indeed what users are used to selecting in their preferences.

I can't think of a better wording than what I proposed, but "depending on the directionality of your script AND your language" is a bit wrong.

Status & tagging log

  • 18:46, 24 August 2011 Reedy (Talk | contribs) changed the status of r92059 [removed: fixme added: resolved]
  • 15:39, 13 July 2011 Siebrand (Talk | contribs) changed the status of r92059 [removed: new added: fixme]
Personal tools
Namespaces

Variants
Views
Actions
Navigation
Support
Download
Development
Communication
Toolbox