MediaWiki r89892 - Code Review

Repository:	MediaWiki
Revision:	< r89891‎ \| r89892 (on ViewVC)‎ \| r89893 >
Date:	20:27, 11 June 2011
Author:	rotem
Status:	ok (Comments)
Tags:	todo
Comment:	(bug 20044) Misaligned text on file pages (RTL wikis only)
Modified paths:	/trunk/extensions/OggHandler/OggHandler_body.php (modified) (history) (diff)

Diff [purge]

Index: trunk/extensions/OggHandler/OggHandler_body.php
—	—	@@ -448,7 +448,7 @@
449	449	}
450	450
451	451	function setHeaders( $out ) {
452		~~- global $wgOggScriptVersion, $wgCortadoJarFile, $wgServer;~~
	452	+ global $wgOggScriptVersion, $wgCortadoJarFile, $wgServer, $wgContLang;
453	453
454	454	if ( $out->hasHeadItem( 'OggHandlerScript' ) && $out->hasHeadItem( 'OggHandlerInlineScript' ) &&
455	455	$out->hasHeadItem( 'OggHandlerInlineCSS' ) ) {
—	—	@@ -471,6 +471,7 @@
472	472	}
473	473	$encCortadoUrl = Xml::encodeJsVar( $cortadoUrl );
474	474	$encExtPathUrl = Xml::encodeJsVar( $scriptPath );
	475	+ $alignStart = $wgContLang->alignStart();
475	476
476	477	$out->addHeadItem( 'OggHandlerScript' , Html::linkedScript( "{$scriptPath}/OggPlayer.js?$wgOggScriptVersion" ) );
477	478
—	—	@@ -487,7 +488,7 @@
488	489	.ogg-player-options {
489	490	border: solid 1px #ccc;
490	491	padding: 2pt;
491		~~- text-align: left;~~
	492	+ text-align: $alignStart;
492	493	font-size: 10pt;
493	494	}
494	495

Rev.	Commit summary	Author	Date
r92945	Fix r89892 so it uses wgLang when appropriate.	robin	14:50, 23 July 2011

#Comment by Siebrand (Talk | contribs) 23:07, 12 July 2011

Shouldn't this be done with flip/noflip?

#Comment by Catrope (Talk | contribs) 01:45, 13 July 2011

Yes, but the CSS is inside the PHP for some reason. If it's in a ResourceLoader module, CSSJanus will take care of the flipping automatically.

#Comment by Siebrand (Talk | contribs) 09:38, 13 July 2011

Adding "todo" label so someone might some day notice this...

#Comment by Reedy (Talk | contribs) 21:50, 24 August 2011

bug 30556 logged about RL'ifying OggHandler

21:50, 24 August 2011 Reedy (Talk | contribs) changed the status of r89892 [removed: new added: ok]
09:38, 13 July 2011 Siebrand (Talk | contribs) changed the tags for r89892 [added: todo]