MediaWiki r89147 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r89146‎ | r89147 (on ViewVC)‎ | r89148 >
Date:01:45, 30 May 2011
Author:wikinaut
Status:deferred (Comments)
Tags:
Comment:
hook parameters pass by reference
Modified paths:

Diff [purge]

Index: trunk/extensions/UserMerge/UserMerge_body.php
@@ -183,7 +183,7 @@
184184 $log = new LogPage( 'usermerge' );
185185 $log->addEntry( 'deleteuser', $wgUser->getUserPage(), '', array( $olduser_text, $olduserID ) );
186186
187 - wfRunHooks( 'DeleteAccount', array( $objOldUser ) );
 187+ wfRunHooks( 'DeleteAccount', array( &$objOldUser ) );
188188
189189 $users = $dbw->selectField( 'user', 'COUNT(*)', array() );
190190 $admins = $dbw->selectField( 'user_groups', 'COUNT(*)', array( 'ug_group' => 'sysop' ) );
@@ -251,7 +251,7 @@
252252 $log = new LogPage( 'usermerge' );
253253 $log->addEntry( 'mergeuser', $wgUser->getUserPage(), '', array( $olduser_text, $olduserID, $newuser_text, $newuserID ) );
254254
255 - wfRunHooks( 'MergeAccountFromTo', array( $objOldUser, $objNewUser ) );
 255+ wfRunHooks( 'MergeAccountFromTo', array( &$objOldUser, &$objNewUser ) );
256256
257257 return true;
258258 }
Index: trunk/extensions/UserMerge/UserMerge.php
@@ -13,9 +13,9 @@
1414 'path' => __FILE__,
1515 'name' => 'User Merge and Delete',
1616 'url' => 'http://www.mediawiki.org/wiki/Extension:User_Merge_and_Delete',
17 - 'author' => 'Tim Laqua',
 17+ 'author' => 'Tim Laqua, Thomas Gries',
1818 'descriptionmsg' => 'usermerge-desc',
19 - 'version' => '1.6.2'
 19+ 'version' => '1.6.21'
2020 );
2121
2222 $wgAvailableRights[] = 'usermerge';

Follow-up revisions

Rev.Commit summaryAuthorDate
r89151array( author1, author2 )wikinaut06:17, 30 May 2011

Comments

#Comment by ^demon (talk | contribs)   02:41, 30 May 2011

This isn't necessary in PHP5.

#Comment by Nikerabbit (talk | contribs)   06:09, 30 May 2011

Unless he wants to substitute the user object with a new one?

+	'author'         => 'Tim Laqua, Thomas Gries',

Using array() is better.

#Comment by Wikinaut (talk | contribs)   06:12, 30 May 2011

ad i) yes, this was what I want to make possible. ad ii) correction will follow soon - thank you for pointing out.

Status & tagging log

  • 13:16, 30 May 2011 Reedy (talk | contribs) changed the status of r89147 [removed: new added: deferred]