MediaWiki r87092 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:< r87091‎ | r87092 (on ViewVC)‎ | r87093 >
Date:18:23, 28 April 2011
Author:thenub314
Status:resolved (Comments)
Tags:math 
Comment:
The following fixes bug 19547 by allowing left and right single
quotation symbols in the list of allowable characters in a textbox or mbox.
Modified paths:

Diff [purge]

Index: trunk/extensions/Math/math/lexer.mll
——@@ -11,8 +11,8 @@
1212 let delimiter_uf_lt = ['(' ')' '.']
1313 let literal_uf_op = ['+' '-' '*' '=']
1414 let delimiter_uf_op = ['/' '|']
15 -let boxchars = ['0'-'9' 'a'-'z' 'A'-'Z' '+' '-' '*' ',' '=' '(' ')' ':' '/' ';' '?' '.' '!' ' ' '\128'-'\255']
16 -let aboxchars = ['0'-'9' 'a'-'z' 'A'-'Z' '+' '-' '*' ',' '=' '(' ')' ':' '/' ';' '?' '.' '!' ' ']
 15+let boxchars = ['0'-'9' 'a'-'z' 'A'-'Z' '+' '-' '*' ',' '=' '(' ')' ':' '/' ';' '?' '.' '!' '\'' '`' ' ' '\128'-'\255']
 16+let aboxchars = ['0'-'9' 'a'-'z' 'A'-'Z' '+' '-' '*' ',' '=' '(' ')' ':' '/' ';' '?' '.' '\'' '`' '!' ' ']
1717 let latex_function_names = "arccos"| "arcsin" | "arctan" | "arg" | "cos" | "cosh" | "cot" | "coth" | "csc"| "deg" | "det" | "dim" | "exp" | "gcd" | "hom" | "inf" | "ker" | "lg" | "lim" | "liminf" | "limsup" | "ln" | "log" | "max" | "min" | "Pr" | "sec" | "sin" | "sinh" | "sup" | "tan" | "tanh"
1818 let mediawiki_function_names = "arccot" | "arcsec" | "arccsc" | "sgn" | "sen"
1919

Sign-offs

UserFlagDate
Thelema314inspected14:09, 29 August 2011

Follow-up revisions

Rev.Commit summaryAuthorDate
r96990Revert changes to texvc that provide no test cases or examples of what they'r...brion19:00, 13 September 2011
r96993MFT r96990: provisional revert of texvc changes that don't come with any test...brion19:07, 13 September 2011
r97018* (bug 19547): Apostrophe / single quotes in math \text{...}...brion22:24, 13 September 2011

Comments

#Comment by Thelema314 (talk | contribs)   14:09, 29 August 2011

Does what it says.

#Comment by Brion VIBBER (talk | contribs)   19:03, 13 September 2011

Provisionally reverted in r96990 pending test cases.

#Comment by Brion VIBBER (talk | contribs)   21:13, 13 September 2011

Asked a followup on bug 19547 as to whether the single-quote is really the only character that needs to be added here. What characters are legit and what aren't? Is there a handy reference?

#Comment by Brion VIBBER (talk | contribs)   22:25, 13 September 2011

Reapplied as r97018 with a parser test case.

Note that bits that didn't render before may not immediately start rendering when this goes live later this month due to the caching of math output.

I still suspect more chars are allowed that are still broken, but it doesn't hurt to tweak this for now.

Status & tagging log

  • 22:25, 13 September 2011 Brion VIBBER (talk | contribs) changed the status of r87092 [removed: reverted added: resolved]
  • 19:03, 13 September 2011 Brion VIBBER (talk | contribs) changed the status of r87092 [removed: ok added: reverted]
  • 06:44, 26 August 2011 Hashar (talk | contribs) changed the status of r87092 [removed: new added: ok]
  • 23:12, 22 August 2011 Catrope (talk | contribs) changed the tags for r87092 [added: math]
Retrieved from "http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87092"