MediaWiki r86714 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r86713‎ | r86714 (on ViewVC)‎ | r86715 >
Date:16:13, 22 April 2011
Author:nikerabbit
Status:resolved (Comments)
Tags:
Comment:
Allow extensions to customize the search forms. This required some cleanup and refactoring to special:search and search engine.
Should be fully backwards compatible. Lightly tested, but only with MySQL search backend.
Introduces concept of search profiles, which replace long list of namespaces in the url.
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r94737Amend the documention of search profile, fu r86714nikerabbit09:50, 17 August 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   00:22, 15 June 2011

What exactly are the 'profiles' introduced here? Can you describe & document the concept and how it is exposed to the UI and to the search engine implementations?

#Comment by Nikerabbit (talk | contribs)   20:55, 16 June 2011

What would be a good place to add that documentation?

#Comment by Siebrand (talk | contribs)   22:05, 28 July 2011

Brion, please reply

#Comment by Brion VIBBER (talk | contribs)   22:07, 28 July 2011

First -- here in this commit comment would be nice.

Second -- in doc comments on the code would be nice.

Third -- whoever the audience who has to know what they are should be able to find that information. If we don't know what 'search profiles' are, we can't tell whether that's info that only people working on tweaking Special:Search have to worry about, or whether this is a concept that's being introduced to end-users that they'll have to select from and manage.

#Comment by Nikerabbit (talk | contribs)   09:51, 17 August 2011

Is r94737 good enough?

#Comment by SPQRobin (talk | contribs)   01:28, 6 September 2011

Status & tagging log

  • 00:42, 7 September 2011 ^demon (talk | contribs) changed the tags for r86714 [removed: brion,needs-doc]
  • 00:42, 7 September 2011 ^demon (talk | contribs) changed the status of r86714 [removed: new added: resolved]
  • 18:30, 5 September 2011 Catrope (talk | contribs) changed the tags for r86714 [added: brion]
  • 09:51, 17 August 2011 Nikerabbit (talk | contribs) changed the status of r86714 [removed: fixme added: new]
  • 00:22, 15 June 2011 Brion VIBBER (talk | contribs) changed the tags for r86714 [added: needs-doc]
  • 00:22, 15 June 2011 Brion VIBBER (talk | contribs) changed the status of r86714 [removed: new added: fixme]