MediaWiki r8645 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r8644‎ | r8645 (on ViewVC)‎ | r8646 >
Date:20:17, 26 April 2005
Author:gabrielwicke
Status:old
Tags:
Comment:
cache key fix, indentation
Modified paths:

Diff [purge]

Index: trunk/extensions/catfeed/catfeed.php
@@ -120,8 +120,8 @@
121121 return false;
122122 }
123123
124 - $timekey = "$wgDBname:catfeed:timestamp";
125 - $key = "$wgDBname:catfeed:$this->mTitle->getDBKey():$this->mFeedFormat:limit:$limit";
 124+ $timekey = "$wgDBname:catfeed:" . $this->mTitle->getDBKey() . ":timestamp";
 125+ $key = "$wgDBname:catfeed:" . $this->mTitle->getDBKey() . ":$this->mFeedFormat:limit:$limit";
126126
127127 $feedTitle = $this->mTitle->getPrefixedText() . ' - ' . $wgSitename;
128128 $feed = new $wgFeedClasses[$this->mFeedFormat](
@@ -155,15 +155,15 @@
156156 $feed->httpHeaders();
157157 echo $cachedFeed;
158158 } else {
159 - wfDebug( "CatFeed: rendering new feed and caching it\n" );
160 - ob_start();
161 - $this->catDoOutputFeed( $rows, $feed );
162 - $cachedFeed = ob_get_contents();
163 - ob_end_flush();
 159+ wfDebug( "CatFeed: rendering new feed and caching it\n" );
 160+ ob_start();
 161+ $this->catDoOutputFeed( $rows, $feed );
 162+ $cachedFeed = ob_get_contents();
 163+ ob_end_flush();
164164
165 - $expire = 3600 * 24; # One day
166 - $messageMemc->set( $key, $cachedFeed );
167 - $messageMemc->set( $timekey, wfTimestamp( TS_MW ), $expire );
 165+ $expire = 3600 * 24; # One day
 166+ $messageMemc->set( $key, $cachedFeed );
 167+ $messageMemc->set( $timekey, wfTimestamp( TS_MW ), $expire );
168168 }
169169 return true;
170170 }

Status & tagging log

  • 15:03, 12 September 2011 Meno25 (Talk | contribs) changed the status of r8645 [removed: ok added: old]
  • 14:06, 1 July 2009 ^demon (Talk | contribs) changed the status of r8645 [removed: new added: ok]
Personal tools
Namespaces

Variants
Views
Actions
Navigation
Support
Download
Development
Communication
Toolbox