MediaWiki r86131 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r86130‎ | r86131 (on ViewVC)‎ | r86132 >
Date:18:40, 15 April 2011
Author:aaron
Status:ok (Comments)
Tags:
Comment:
* Pass around parser options instead of users and made some parser options consistency fixes
* Moved makeParserOptions to Article.php
* Renamed currentIncludeVersions -> getRevIncludes
* Renamed updatePageCache -> setPageCache
* Moved FlaggedRevs::getCacheKey up
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r89706Reinstate r79122 (fix for bug 14404), reverting r83868. The real bug seem to ...platonides22:28, 7 June 2011

Comments

#Comment by Platonides (talk | contribs)   22:19, 7 June 2011

Why didn't you make makeParserOptions static?

#Comment by Platonides (talk | contribs)   22:22, 7 June 2011

Also, I don't see the need for creating a new method. Seems that just calling getParserOptions() would have worked for you.

#Comment by Aaron Schulz (talk | contribs)   23:29, 7 June 2011

I'd rather dependency inject the User rather than always using $wgUser.

#Comment by Platonides (talk | contribs)   14:06, 8 June 2011

In which case does your $user not match $wgUser?

#Comment by Tim Starling (talk | contribs)   06:39, 2 September 2011

A case where it does not match was introduced in r89124, and another potential use for $user not matching $wgUser was introduced in r89706.

Status & tagging log