MediaWiki r85616 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r85615‎ | r85616 (on ViewVC)‎ | r85617 >
Date:12:07, 7 April 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
For bug 27488: move the startup script, jquery+mediawiki and the mw.config.set() call for configuration variables back to the <head> . Let modules control whether they're loaded in the <head> ('top') or at the bottom of the <body> ('bottom') through the position parameter/property

Also rearranges the loading order a little bit such that only=messages comes before only=scripts, and config comes before everything except startup and jquery+mediawiki
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r85617Fix copypaste fail in r85616catrope13:14, 7 April 2011
r910891.17wmf1: MFT r85616, r85617. This required meticulous conflict resolution du...catrope18:06, 29 June 2011
r108184ResourceLoader: Add an experimental option to move the main module loading qu...catrope23:32, 5 January 2012

Comments

#Comment by Krinkle (talk | contribs)   12:30, 7 April 2011
+	function getBottomScripts( Skin $sk ) {
+		// Only load modules that have marked themselves for loading at the top

"at the top", bottom, right ?

#Comment by Catrope (talk | contribs)   13:15, 7 April 2011

Yeah, copypaste fail. Fixed in r85617.

#Comment by Krinkle (talk | contribs)   07:48, 26 May 2011

Could you look at the TODO you added here ? How urgent / accurate is it towards the current HEAD ?

#Comment by Catrope (talk | contribs)   19:21, 26 May 2011

It's not urgent. Ugly, but low priority.

#Comment by ^demon (talk | contribs)   06:01, 2 July 2011

Removing 1.18 tag, this was before the branch point.

Status & tagging log

  • 06:01, 2 July 2011 ^demon (talk | contribs) changed the tags for r85616 [removed: 1.18]
  • 02:39, 30 June 2011 Reedy (talk | contribs) changed the tags for r85616 [removed: 1.17wmf1 added: 1.18]
  • 21:19, 31 May 2011 Catrope (talk | contribs) changed the tags for r85616 [added: 1.17wmf1]
  • 03:21, 29 May 2011 Krinkle (talk | contribs) changed the status of r85616 [removed: new added: ok]