MediaWiki r83147 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r83146‎ | r83147 (on ViewVC)‎ | r83148 >
Date:15:24, 3 March 2011
Author:tstarling
Status:ok
Tags:
Comment:
* When CACHE_ANYTHING is requested, return the cached instance, don't construct a new object for each use.
* In MemcachedSessions.php, register a shutdown function to shut down the session early, before $wgMemc is destroyed. I'm not sure why my recent changes caused this problem to show up now.
* Use EmptyBagOStuff instead of FakeMemCachedClient in DefaultSettings.php for CACHE_NONE.
Modified paths:

Diff [purge]

Loading diff…

Sign-offs

UserFlagDate
Siebrandtested16:02, 3 March 2011

Follow-up revisions

Rev.Commit summaryAuthorDate
r84727Merged in the ObjectCache refactor and the Ehcache client. MFT r83135, r83136...tstarling03:28, 25 March 2011

Past revisions this follows-up on

Rev.Commit summaryAuthorDate
r83140* Rewrote ObjectCache.php to conform to the modern coding style, and to be le...tstarling09:37, 3 March 2011

Status & tagging log

  • 00:13, 15 June 2011 ^demon (talk | contribs) changed the status of r83147 [removed: new added: ok]