MediaWiki r82530 - Code Review

Repository:	MediaWiki
Revision:	< r82529‎ \| r82530 (on ViewVC)‎ \| r82531 >
Date:	19:27, 20 February 2011
Author:	catrope
Status:	ok
Tags:
Comment:	(bug 27355) Guard against context being null, this happens when wikiEditor disables itself in unsupported browsers and was causing a JS error
Modified paths:	/trunk/phase3/resources/jquery/jquery.textSelection.js (modified) (history) (diff)

Diff [purge]

Index: trunk/phase3/resources/jquery/jquery.textSelection.js
—	—	@@ -386,7 +386,7 @@
387	387	break;
388	388	}
389	389	var context = $(this).data( 'wikiEditor-context' );
390		~~- var hasIframe = context !== undefined && context.$iframe !== undefined;~~
	390	+ var hasIframe = typeof context !== 'undefined' && context && typeof context.$iframe !== 'undefined';
391	391
392	392	// IE selection restore voodoo
393	393	var needSave = false;

Rev.	Commit summary	Author	Date
r82533	1.17wmf1: MFT r78893, r78897, r78909, r82404, r82408, r82409, r82453, r82456,...	catrope	20:13, 20 February 2011
r85354	MFT r82518, r82530, r82538, r82547, r82550, r82565, r82572, r82608, r82696, r...	demon	18:25, 4 April 2011

18:26, 4 April 2011 ^demon (talk | contribs) changed the tags for r82530 [removed: 1.17]
20:10, 20 March 2011 Catrope (talk | contribs) changed the tags for r82530 [removed: trevor]
01:01, 21 February 2011 Krinkle (talk | contribs) changed the status of r82530 [removed: new added: ok]
20:14, 20 February 2011 Catrope (talk | contribs) changed the tags for r82530 [removed: 1.17wmf1]
19:27, 20 February 2011 Catrope (talk | contribs) changed the tags for r82530 [added: 1.17,1.17wmf1,trevor]