MediaWiki r82482 - Code Review

Repository:	MediaWiki
Revision:	< r82481‎ \| r82482 (on ViewVC)‎ \| r82483 >
Date:	20:35, 19 February 2011
Author:	hartman
Status:	ok (Comments)
Tags:
Comment:	All functions of the importer have $title, origTitle, but processTitle() returned $title, origTitle. This caused confusion and a misusage of the processTitle() result. Follow up to r66267. Fixes bug 27486
Modified paths:	/trunk/phase3/includes/Import.php (modified) (history) (diff)

Diff [purge]

Index: trunk/phase3/includes/Import.php
—	—	@@ -662,7 +662,7 @@
663	663	return false;
664	664	}
665	665
666		~~- return array( $origTitle, $title );~~
	666	+ return array( $title, $origTitle );
667	667	}
668	668	}
669	669

Rev.	Commit summary	Author	Date
r82533	1.17wmf1: MFT r78893, r78897, r78909, r82404, r82408, r82409, r82453, r82456,...	catrope	20:13, 20 February 2011
r85211	MFT: r82297, r82307, r82309, r82312, r82315, r82337, r82391, r82392, r82403, ...	demon	21:01, 2 April 2011

Rev.	Commit summary	Author	Date
r66267	Rewrite of XML Dump Processing:...	werdna	13:28, 12 May 2010

#Comment by TheDJ (talk | contribs) 20:37, 19 February 2011

that should be 'returned $origTitle, $title' of course.

21:01, 2 April 2011 ^demon (talk | contribs) changed the tags for r82482 [removed: 1.17]
20:14, 20 February 2011 Catrope (talk | contribs) changed the tags for r82482 [removed: 1.17wmf1]
19:37, 20 February 2011 Catrope (talk | contribs) changed the status of r82482 [removed: new added: ok]
20:36, 19 February 2011 TheDJ (talk | contribs) changed the tags for r82482 [added: 1.17,1.17wmf1]