MediaWiki r82285 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r82284‎ | r82285 (on ViewVC)‎ | r82286 >
Date:19:54, 16 February 2011
Author:happy-melon
Status:resolved (Comments)
Tags:
Comment:
Create a user.groups module in ResourceLoader, which bundles a CSS and JS page for each usergroup the user is a member of (MediaWiki:Sysop.js, MediaWiki:Autoconfirmed.css, etc). Groups '*' and 'user' are not included.
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r82335Per r82285: Add new messages for the default user groups. This way they can b...raymond15:39, 17 February 2011
r86508Follow-up r82285: prefix group css and js pages with "Group-", and fix licens...happy-melon17:29, 20 April 2011
r100239Follow-up r82285: we should not apply case conversion to these names, because...happy-melon17:09, 19 October 2011

Comments

#Comment by Hashar (talk | contribs)   09:15, 23 February 2011

This is a good idea! thanks happy melon :-)

#Comment by Peachey88 (talk | contribs)   10:36, 23 February 2011

What about if someone was say to create a user group called for example Print, that would conflict with Mediawiki:Print.css, We could perhaps prefix the page names with something like [[Mediawiki:Group-<group>]].

#Comment by Reedy (talk | contribs)   10:42, 23 February 2011

Prefixing sounds like a good idea.

This can be said for most possible words, where conflict may be possible (granted, less likely, but possible)


Also, you've added a new code file, and then just listed Roan and Trevor as the author :)

#Comment by Happy-melon (talk | contribs)   10:54, 23 February 2011

I'm really, really bad at copying license headers and getting other random stuff as well; it generally doesn't get very rigorous review... :D I think I copied the class description from Skin.php to an extension once...

#Comment by Krinkle (talk | contribs)   19:42, 7 March 2011

Just for the record:

  • The load of user.groups is added to the same call as user.

Does not take an extra http-request (nice!)

  • Takes advantage of the same split (styles on top – without js-dependancy; scripts at the bottom – close to document ready).
#Comment by Aaron Schulz (talk | contribs)   00:07, 20 April 2011
  • Needs prefixing
  • License on ResourceLoaderUserGroupsModule.php looks wrong

Status & tagging log