MediaWiki r80813 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r80812‎ | r80813 (on ViewVC)‎ | r80814 >
Date:13:09, 23 January 2011
Author:krinkle
Status:ok (Comments)
Tags:
Comment:
Bug 26870 - add width/height param to {{filepath:}}
* In addition to r80381
* Expanded comments in SpecialFilePath a little bit
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r80814update RELEASE-NOTES for r80813 and r80381krinkle13:15, 23 January 2011
r80815Follow-up per r80813 CRkrinkle14:34, 23 January 2011
r852561.17wmf1: MFT r80813, r80815, r83798, r84459, r84729, r84820, r84921, r84985,...catrope14:13, 3 April 2011

Past revisions this follows-up on

Rev.Commit summaryAuthorDate
r80381Add width parameter to Special:Filepath to allow getting the file path of a t...catrope11:20, 15 January 2011

Comments

#Comment by Reedy (talk | contribs)   13:32, 23 January 2011

Minor comment, when you're doing like intval casts/transformations, and doing them potentially twice on the same variable, it's saner to do it to a temp variable :)

#Comment by Krinkle (talk | contribs)   14:34, 23 January 2011

Thanks, I wasn't sure whether to introduce two additional variables or not, but I performance wise the difference is small although a temp variable does sound faster. Done in r80815.

#Comment by Bawolff (talk | contribs)   23:47, 23 January 2011

Might want to consider supporting Special:Filepath (200 wide 300 high) and Special:Filepath (height of 300), to be consistent with how image links work.

#Comment by Bawolff (talk | contribs)   23:49, 23 January 2011

*Sigh* Lets try that again with nowiki ;)

Might want to consider supporting {{Filepath:foo|200x300}} (200 wide 300 high) and {{Filepath:foo|x300}} (height of 300), to be consistent with how image links work.

#Comment by Krinkle (talk | contribs)   17:04, 28 March 2011

See also r80815. Wikipedia is currently using a funny way with {{#titleparts:}} and {{filepath:}} [1]

We might as well deploy this one ? Tagging 1.17wmf1


  1. http://en.wikipedia.org/wiki/Template:Thumbpath

Status & tagging log

  • 14:27, 3 April 2011 Catrope (talk | contribs) changed the tags for r80813 [removed: 1.17wmf1]
  • 13:15, 3 April 2011 Catrope (talk | contribs) changed the status of r80813 [removed: new added: ok]
  • 17:04, 28 March 2011 Krinkle (talk | contribs) changed the tags for r80813 [added: 1.17wmf1]