MediaWiki r76344 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r76343‎ | r76344 (on ViewVC)‎ | r76345 >
Date:21:55, 8 November 2010
Author:vasilievvv
Status:resolved (Comments)
Tags:
Comment:
Title blacklist:
* (bug 22141) Introduce a separate user right for overriding title blacklist on account creations only
* Some minor refactorings
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r817511.17wmf1: Superficially fix fatal caused by r76344catrope15:26, 8 February 2011
r84575Followup r76344, fix another inversed logic...reedy22:30, 22 March 2011
r97794Fix for r76344: you can't access $wgUser during the CentralAuthAutoCreate hoo...tstarling06:10, 22 September 2011

Comments

#Comment by Catrope (talk | contribs)   15:28, 8 February 2011
-	public function userCan( $title, $user, $action ) {
-		if( $user->isAllowed( 'tboverride' ) ) {
-			return true;
-		}
+	public function matches( $title, $action ) {

This causes a fatal because $user is used again in the function ( if( isset( $this->mParams['autoconfirmed'] ) && $user->isAllowed( 'autoconfirmed' ) ) {). Superficially fixed this in 1.17wmf1, but this needs a proper fix.

#Comment by Aaron Schulz (talk | contribs)   05:33, 22 September 2011

$wgUser not used anymore in abortNewAccount().

#Comment by Tim Starling (talk | contribs)   06:00, 22 September 2011

Was the $user parameter to TitleBlacklist::userCannot() meant to be used for something?

Status & tagging log

  • 13:54, 15 June 2011 Reedy (talk | contribs) changed the status of r76344 [removed: new added: resolved]
  • 21:24, 21 April 2011 Happy-melon (talk | contribs) changed the tags for r76344 [removed: 1.17ok]
  • 22:51, 22 March 2011 Reedy (talk | contribs) changed the status of r76344 [removed: fixme added: new]
  • 21:13, 11 February 2011 RobLa-WMF (talk | contribs) changed the tags for r76344 [added: 1.17ok]
  • 15:28, 8 February 2011 Catrope (talk | contribs) changed the status of r76344 [removed: ok added: fixme]
  • 16:20, 31 January 2011 Reedy (talk | contribs) changed the tags for r76344 [removed: sam]
  • 16:20, 31 January 2011 Reedy (talk | contribs) changed the status of r76344 [removed: new added: ok]
  • 03:28, 26 January 2011 MarkAHershberger (talk | contribs) changed the tags for r76344 [added: sam]